[Lldb-commits] [lldb] [lldb-dap] Swapping to not use FLAG_ENUM and just defining typed enums. (PR #133622)

2025-04-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/133622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Make the DAP server resilient against broken pipes (PR #133791)

2025-04-01 Thread John Harrison via lldb-commits
ashgti wrote: Does setting the 3rd param to `false` on https://github.com/llvm/llvm-project/blob/5e2860a8d375ded2d2912894e380fefc8cb1f23a/lldb/tools/lldb-dap/lldb-dap.cpp#L574 change anything for you? https://github.com/llvm/llvm-project/pull/133791

[Lldb-commits] [lldb] [lldb-dap] Protect SetBreakpoint with the API mutex (PR #134030)

2025-04-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Protect the various SetBreakpoint functions with the API mutex. This fixes a race condition between the breakpoint being created and the DAP label getting added. This was causing `TestDAP_breakpoint

[Lldb-commits] [lldb] [lldb-dap] Protect SetBreakpoint with the API mutex (PR #134030)

2025-04-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/134030 Protect the various SetBreakpoint functions with the API mutex. This fixes a race condition between the breakpoint being created and the DAP label getting added. This was causing `TestDAP_breakpointEvents.

[Lldb-commits] [lldb] 28b300d - [lldb] Update ScriptInterpreterLua::LoadScriptingModule

2025-04-01 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-01T22:13:26-07:00 New Revision: 28b300d546948baf4396c3467507dea8b9e34881 URL: https://github.com/llvm/llvm-project/commit/28b300d546948baf4396c3467507dea8b9e34881 DIFF: https://github.com/llvm/llvm-project/commit/28b300d546948baf4396c3467507dea8b9e34881.d

[Lldb-commits] [lldb] [lldb] Hoist UUID generation into the UUID class (PR #133662)

2025-04-01 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/include/lldb/Utility/UUID.h lldb/source/Core/T

[Lldb-commits] [lldb] [lldb] Hoist UUID generation into the UUID class (PR #133662)

2025-04-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/133662 >From f0a4b9bc2f20a812f7f37e5f5a2417dbbb4d45e0 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 30 Mar 2025 16:10:05 -0700 Subject: [PATCH 1/4] [lldb] Hoist UUID generation into the UUID class H

[Lldb-commits] [lldb] [lldb-dap] Creating a common configuration structure for launch and attach requests. (PR #133960)

2025-04-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Neat https://github.com/llvm/llvm-project/pull/133960 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Prefer PointerType::get with LLVMContext over Type (NFC) (PR #133869)

2025-04-01 Thread Mats Jun Larsen via lldb-commits
https://github.com/junlarsen closed https://github.com/llvm/llvm-project/pull/133869 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c8764f0 - Fix handling of auto_continue for stop hooks (#129622)

2025-04-01 Thread via lldb-commits
Author: Julian Lettner Date: 2025-04-01T15:36:35-07:00 New Revision: c8764f0c655b2edb139896ecbb9f5bfd932fbe4b URL: https://github.com/llvm/llvm-project/commit/c8764f0c655b2edb139896ecbb9f5bfd932fbe4b DIFF: https://github.com/llvm/llvm-project/commit/c8764f0c655b2edb139896ecbb9f5bfd932fbe4b.diff

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-04-01 Thread Adrian Prantl via lldb-commits
@@ -88,6 +88,7 @@ class ValueObjectMockProcessTest : public ::testing::Test { var_name, data_extractor); if (llvm::Error error = valobj_sp->Dump(strm, options)) adrian-prantl wrote: The old function s

[Lldb-commits] [lldb] Fix handling of auto_continue for stop hooks (PR #129622)

2025-04-01 Thread Julian Lettner via lldb-commits
https://github.com/yln closed https://github.com/llvm/llvm-project/pull/129622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix handling of auto_continue for stop hooks (PR #129622)

2025-04-01 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/129622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix handling of auto_continue for stop hooks (PR #129622)

2025-04-01 Thread via lldb-commits
@@ -3109,7 +3104,10 @@ bool Target::RunStopHooks() { auto result = cur_hook_sp->HandleStop(exc_ctx, output_sp); switch (result) { case StopHook::StopHookResult::KeepStopped: jimingham wrote: Only KeepStopped. If any thread reports AlreadyCon

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-01 Thread John Harrison via lldb-commits
@@ -19,10 +19,39 @@ #include "lldb/lldb-forward.h" #include "llvm/ADT/StringRef.h" #include "llvm/Support/Error.h" -#include +#include +#include namespace lldb_dap { +class EndOfFileError : public llvm::ErrorInfo { +public: + static char ID; + + EndOfFileError() = def

[Lldb-commits] [lldb] 782e0ce - [lldb] Fix intel trace plugin tests (#133826)

2025-04-01 Thread via lldb-commits
Author: David Peixotto Date: 2025-04-01T12:55:41-07:00 New Revision: 782e0cef762c1346396eb7dd75462f842be350e3 URL: https://github.com/llvm/llvm-project/commit/782e0cef762c1346396eb7dd75462f842be350e3 DIFF: https://github.com/llvm/llvm-project/commit/782e0cef762c1346396eb7dd75462f842be350e3.diff

[Lldb-commits] [lldb] a03fce4 - Update README.md - fixed invalid json in example (#133890)

2025-04-01 Thread via lldb-commits
Author: Doeke Wartena Date: 2025-04-01T08:49:36-07:00 New Revision: a03fce4e200d47b9133897b8f0d4688b30b42689 URL: https://github.com/llvm/llvm-project/commit/a03fce4e200d47b9133897b8f0d4688b30b42689 DIFF: https://github.com/llvm/llvm-project/commit/a03fce4e200d47b9133897b8f0d4688b30b42689.diff

[Lldb-commits] [lldb] 347c5a7 - Add a new affordance that the Python module in a dSYM (#133290)

2025-04-01 Thread via lldb-commits
Author: jimingham Date: 2025-04-01T09:54:06-07:00 New Revision: 347c5a7af5adfe81b79dd77f7f88c626b09e8534 URL: https://github.com/llvm/llvm-project/commit/347c5a7af5adfe81b79dd77f7f88c626b09e8534 DIFF: https://github.com/llvm/llvm-project/commit/347c5a7af5adfe81b79dd77f7f88c626b09e8534.diff LOG

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-01 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130169 >From c183231db80d6c97bdd5e9bd0b21d041189146e8 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 18 Mar 2025 14:05:38 -0700 Subject: [PATCH 01/13] [lldb-dap] Adding support for cancelling a request. Adding

[Lldb-commits] [lldb] [lldb] Include the version in the lldbassert error message (PR #133740)

2025-04-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Include the LLDB version in the lldbassert error message, and prompt users to include it in the bug report. The majority of users that bother filing a bug report just copy past the stack trace and o

[Lldb-commits] [lldb] [lldb-dap] Make the DAP server resilient against broken pipes (PR #133791)

2025-04-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Does setting the 3rd param to `false` on > > https://github.com/llvm/llvm-project/blob/5e2860a8d375ded2d2912894e380fefc8cb1f23a/lldb/tools/lldb-dap/lldb-dap.cpp#L574 > > change anything for you? No, I tried that but I'm still getting the `SIGHUP`. Why do we take ownersh

[Lldb-commits] [lldb] 7581cb6 - [lldb] Remove lldb-server min and max gdbserver port options (#133275)

2025-04-01 Thread via lldb-commits
Author: David Spickett Date: 2025-04-01T10:05:11+01:00 New Revision: 7581cb68f9fbff7a4628da594580d81a803129ee URL: https://github.com/llvm/llvm-project/commit/7581cb68f9fbff7a4628da594580d81a803129ee DIFF: https://github.com/llvm/llvm-project/commit/7581cb68f9fbff7a4628da594580d81a803129ee.diff

[Lldb-commits] [lldb] [LLDB][MIPS] Fix signal SIGBUS number mismatch error on mips target (PR #132688)

2025-04-01 Thread via lldb-commits
https://github.com/yingopq updated https://github.com/llvm/llvm-project/pull/132688 >From 61901c7cd6aa2b53169eae92ef55848589a8c276 Mon Sep 17 00:00:00 2001 From: Ying Huang Date: Mon, 24 Mar 2025 03:44:41 -0400 Subject: [PATCH] [LLDB][MIPS] Fix signal SIGBUS number mismatch error on mips targe