Author: David Spickett Date: 2025-04-01T10:05:11+01:00 New Revision: 7581cb68f9fbff7a4628da594580d81a803129ee
URL: https://github.com/llvm/llvm-project/commit/7581cb68f9fbff7a4628da594580d81a803129ee DIFF: https://github.com/llvm/llvm-project/commit/7581cb68f9fbff7a4628da594580d81a803129ee.diff LOG: [lldb] Remove lldb-server min and max gdbserver port options (#133275) Since lldb 20, these have had no effect: https://releases.llvm.org/20.1.0/docs/ReleaseNotes.html#changes-to-lldb > lldb-server now listens to a single port for gdbserver connections and > provides that port to the connection handler processes. This means that > only 2 ports need to be opened in the firewall (one for the lldb-server > platform, one for gdbserver connections). In addition, due to this work, lldb-server now works on Windows in the server mode. Remove them. Added: Modified: lldb/tools/lldb-server/lldb-platform.cpp llvm/docs/ReleaseNotes.md Removed: ################################################################################ diff --git a/lldb/tools/lldb-server/lldb-platform.cpp b/lldb/tools/lldb-server/lldb-platform.cpp index 51174a0f443c3..23d36ffb4cb66 100644 --- a/lldb/tools/lldb-server/lldb-platform.cpp +++ b/lldb/tools/lldb-server/lldb-platform.cpp @@ -67,8 +67,6 @@ static struct option g_long_options[] = { {"log-channels", required_argument, nullptr, 'c'}, {"listen", required_argument, nullptr, 'L'}, {"gdbserver-port", required_argument, nullptr, 'P'}, - {"min-gdbserver-port", required_argument, nullptr, 'm'}, - {"max-gdbserver-port", required_argument, nullptr, 'M'}, {"socket-file", required_argument, nullptr, 'f'}, {"server", no_argument, &g_server, 1}, {"child-platform-fd", required_argument, nullptr, 2}, diff --git a/llvm/docs/ReleaseNotes.md b/llvm/docs/ReleaseNotes.md index b989f477be6b5..58cf71b947083 100644 --- a/llvm/docs/ReleaseNotes.md +++ b/llvm/docs/ReleaseNotes.md @@ -220,6 +220,9 @@ Changes to LLDB information about the current state of the debugger at the bottom of the terminal. This is on by default and can be configured using the `show-statusline` and `statusline-format` settings. +* The `min-gdbserver-port` and `max-gdbserver-port` options have been removed + from `lldb-server`'s platform mode. Since the changes to `lldb-server`'s port + handling in LLDB 20, these options have had no effect. ### Changes to lldb-dap _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
