[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -0,0 +1,59 @@ +//===-- SBMutexTest.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -0,0 +1,60 @@ +//===-- SBMutex.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Emit progress events in SymbolFileDWARFDebugMap (PR #133211)

@@ -716,6 +718,27 @@ bool SymbolFileDWARFDebugMap::ParseDebugMacros(CompileUnit &comp_unit) { return false; } +void SymbolFileDWARFDebugMap::ForEachSymbolFile( +std::string description, +std::function closure) { + const size_t num_oso_idxs = m_compile_unit_infos.si

[Lldb-commits] [lldb] Reapply LLDB-Telemetry TargetInfo branch (pr/127834) (PR #132043)

oontvoo wrote: All checks ✅ passed so I'm going to merge this https://github.com/llvm/llvm-project/pull/132043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

JDevlieghere wrote: The pre-merge bot is using SWIG 4.0.2 which seems to have trouble with the move-only type. I'm going to build that SWIG and see if I can reproduce this. https://github.com/llvm/llvm-project/pull/131404 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

@@ -0,0 +1,276 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

@@ -0,0 +1,104 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

@@ -0,0 +1,238 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

@@ -0,0 +1,131 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

@@ -0,0 +1,131 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -0,0 +1,48 @@ +//===-- SBMutex.h +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -0,0 +1,48 @@ +//===-- SBMutex.h +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -0,0 +1,59 @@ +//===-- SBMutex.cpp bulbazord wrote: Broken header https://github.com/llvm/llvm-project/pull/133295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -0,0 +1,48 @@ +//===-- SBMutex.h +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -0,0 +1,59 @@ +//===-- SBMutex.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -0,0 +1,48 @@ +//===-- SBMutex.h bulbazord wrote: Header messed up https://github.com/llvm/llvm-project/pull/133295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -1692,6 +1692,22 @@ class Target : public std::enable_shared_from_this, } }; +/// The private implementation backing SBLock. +class APILock { +public: + APILock(std::shared_ptr mutex_sp) + : m_mutex(std::move(mutex_sp)), m_lock(*m_mutex) {} + + void Lock() { m_loc

[Lldb-commits] [lldb] Plugin toggle roadmap (PR #132876)

https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/132876 >From 21ac6ae78d53feba8322e3aca724ecb01ff7c847 Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Thu, 13 Mar 2025 16:13:45 -0700 Subject: [PATCH 1/3] Remove raw access to PluginInstances vector This commit mod

[Lldb-commits] [lldb] [lldb] Improve default statusline colors to work with more color schemes (PR #133315)

https://github.com/adrian-prantl approved this pull request. As the person who suggested this change, I think this is a _great_ idea :-) https://github.com/llvm/llvm-project/pull/133315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/129262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adjust skips on reverse continue tests (PR #133240)

https://github.com/jasonmolenda approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/133240 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2a96bec - [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (#133309)

Author: Jacob Lalonde Date: 2025-03-27T14:20:43-07:00 New Revision: 2a96beca9b502776d5e2a3be2da3f886135b056e URL: https://github.com/llvm/llvm-project/commit/2a96beca9b502776d5e2a3be2da3f886135b056e DIFF: https://github.com/llvm/llvm-project/commit/2a96beca9b502776d5e2a3be2da3f886135b056e.diff

[Lldb-commits] [lldb] [lldb-dap] Migrating DAP 'initialize' to new typed RequestHandler. (PR #133007)

https://github.com/JDevlieghere approved this pull request. Thanks, I'm happy with this! https://github.com/llvm/llvm-project/pull/133007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] 0d4f12e - [lldb-dap] Allow providing debug adapter arguments in the extension (#129262)

Author: Matthew Bastien Date: 2025-03-27T14:09:09-07:00 New Revision: 0d4f12ee0046b83d28dbf3a8aca07a0f27b77786 URL: https://github.com/llvm/llvm-project/commit/0d4f12ee0046b83d28dbf3a8aca07a0f27b77786 DIFF: https://github.com/llvm/llvm-project/commit/0d4f12ee0046b83d28dbf3a8aca07a0f27b77786.dif

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/129262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/133309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve default statusline colors to work with more color schemes (PR #133315)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Use the reverse video [1] font effect (`${ansi.negative}`) as the default for the statusline. Inverting the foreground and background color has a better change as looking reasonably good, compared t

[Lldb-commits] [lldb] [lldb] Improve default statusline colors to work with more color schemes (PR #133315)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/133315 Use the reverse video [1] font effect (`${ansi.negative}`) as the default for the statusline. Inverting the foreground and background color has a better change as looking reasonably good, compared to picki

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

Jlalond wrote: > I am fine with this being always enabled. I will defer to Jonas to make sure > he is So @JDevlieghere and I agreed on adding this to the default listener which is currently the case. But because we only tested DAP after we added the new broadcast bit, this fell through the cr

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

https://github.com/satyajanga approved this pull request. https://github.com/llvm/llvm-project/pull/133309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

https://github.com/clayborg commented: I am fine with this being always enabled. I will defer to Jonas to make sure he is https://github.com/llvm/llvm-project/pull/133309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/133309 >From d55d7e328300134c723cbc7d0f67ac8c1309ebbb Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 27 Mar 2025 13:15:46 -0700 Subject: [PATCH] Configure sbprogress events to be emitted for the CLI --- lldb

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff fbf0276b6a7a7a4508c373cf87fc349569652659 d5840447a35992530963ae910615b1908e2880d2 --e

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/133309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes In the original SBProgress patch, #123837, I didn't ensure the debugger was broadcasting these events to the CLI. This patch addresses that. [Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

2025-03-27 Thread Jacob Lalonde via lldb-commits

https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/133309 In the original SBProgress patch, #123837, I didn't ensure the debugger was broadcasting these events to the CLI. This patch addresses that. https://github.com/user-attachments/assets/5eb93a46-1db6-4d46-a6b7-2b

[Lldb-commits] [lldb] [lldb] Emit progress events in SymbolFileDWARFDebugMap (PR #133211)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/133211 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8244f82 - [lldb] Emit progress events in SymbolFileDWARFDebugMap (#133211)

2025-03-27 Thread via lldb-commits

Author: Jonas Devlieghere Date: 2025-03-27T13:09:38-07:00 New Revision: 8244f8210f2e62f68429a0daf104fd483ada45ab URL: https://github.com/llvm/llvm-project/commit/8244f8210f2e62f68429a0daf104fd483ada45ab DIFF: https://github.com/llvm/llvm-project/commit/8244f8210f2e62f68429a0daf104fd483ada45ab.d

[Lldb-commits] [lldb] 48864a5 - Revert "[lldb] Remove UnwindPlan::Row shared_ptrs (#132370)" (#133299)

2025-03-27 Thread via lldb-commits

Author: Jordan Rupprecht Date: 2025-03-27T14:20:07-05:00 New Revision: 48864a52ef547ac0477271127b510dd9e9798219 URL: https://github.com/llvm/llvm-project/commit/48864a52ef547ac0477271127b510dd9e9798219 DIFF: https://github.com/llvm/llvm-project/commit/48864a52ef547ac0477271127b510dd9e9798219.di

[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs (PR #132370)

2025-03-27 Thread Jordan Rupprecht via lldb-commits

rupprecht wrote: Saw the same thing running tests internally; reverted. https://github.com/llvm/llvm-project/pull/132370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Remove UnwindPlan::Row shared_ptrs (#132370)" (PR #133299)

2025-03-27 Thread Jordan Rupprecht via lldb-commits

https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/133299 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Remove UnwindPlan::Row shared_ptrs (#132370)" (PR #133299)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/133299 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits

@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

2025-03-27 Thread via lldb-commits

jimingham wrote: > Do we want to just do the "command script import" _after_ the target is > created to avoid this? > > Or it would be great to have a way for a python script to add a callback > function to be run after a target is created. So this diff could just do > something like: > > ``

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/131404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits

@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

2025-03-27 Thread via lldb-commits

https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/133290 >From effad9525461611ed47598b53a77ee5aabb0e4cf Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 27 Mar 2025 11:04:26 -0700 Subject: [PATCH 1/2] Add a new affordance that the Python module in a dSYM can be

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/133295 >From 79241d2f5701ab789f7fdbb5bd881c4494cb67eb Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 27 Mar 2025 11:24:50 -0700 Subject: [PATCH 1/2] [lldb] Expose the Target API mutex through the SB A

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

JDevlieghere wrote: Superseded by https://github.com/llvm/llvm-project/pull/133295 https://github.com/llvm/llvm-project/pull/131404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

2025-03-27 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Expose u target API mutex through the SB API. This is motivated by lldb-dap, which is built on top of the SB API and needs a way to execute a series of SB API calls in an atomic manner (see #131242)

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/133295 Expose u target API mutex through the SB API. This is motivated by lldb-dap, which is built on top of the SB API and needs a way to execute a series of SB API calls in an atomic manner (see #131242). We c

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits

@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits

@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits

@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits

@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits

@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits

@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits

https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/131820 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

2025-03-27 Thread via lldb-commits

https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/133290 So the dSYM can be told what target it has been loaded into. When lldb is loading modules, while creating a target, it will run "command script import" on any Python modules in Resources/Python in the dSYM.

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

2025-03-27 Thread via lldb-commits

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 960615954e4cb3150ae4a479fa7f9d0d17035eea...effad9525461611ed47598b53a77ee5aabb0e4cf lldb/

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

2025-03-27 Thread via lldb-commits

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 960615954e4cb3150ae4a479fa7f9d0d17035eea effad9525461611ed47598b53a77ee5aabb0e4cf --e

[Lldb-commits] [lldb] [lldb] Show target.debug-file-search-paths setting from python SBDebugger (PR #131683)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/131683 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

2025-03-27 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes So the dSYM can be told what target it has been loaded into. When lldb is loading modules, while creating a target, it will run "command script import" on any Python modules in Resources/Python in the dSYM. Howeve

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Santhosh Kumar Ellendula via lldb-commits

@@ -112,3 +112,48 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb] Remove raw access to PluginInstances vector (PR #132884)

2025-03-27 Thread David Peixotto via lldb-commits

dmpots wrote: > Alright, let's go with the copy. Unless you think the `enabled` property > might change while we're iterating over the plugins, we should be able to > store it in the PluginInstance. AFAIK, the instance itself is never stored > away. Sounds good. That seems to be the simplest

[Lldb-commits] [lldb] [lldb] Remove raw access to PluginInstances vector (PR #132884)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

JDevlieghere wrote: Alright, let's go with the copy. Unless you think the `enabled` property might change while we're iterating over the plugins, we should be able to store it in the PluginInstance. AFAIK, the instance itself is never stored away. https://github.com/llvm/llvm-project/pull/132

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-03-27 Thread Dmitry Vasilyev via lldb-commits

slydiman wrote: @labath The repro above shows that CPlusPlusLanguage::GetHardcodedSummaries() causes to link TypeSystemClang and other dependencies. But --print-gc-sections and `llvm-objdump --all-headers --demangle lldb-server` shows that GetHardcodedSummaries is missing in the final binary

[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs (PR #132370)

2025-03-27 Thread Michael Buch via lldb-commits

Michael137 wrote: Still double checking but i think this may have broken a couple of macOS x86_64 tests: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/10909/ ``` TestTsanMultiple.test_dsym/a.out") runCmd: env TSAN_OPTIONS=abort_on_error=0 output: runCmd: run warning: li

[Lldb-commits] [lldb] [lldb] Make GetRowForFunctionOffset compatible with discontinuous functions (PR #133250)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/133250 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-03-27 Thread via lldb-commits

earnol wrote: Could you please look into https://github.com/llvm/llvm-project/issues/133144? It looks like to be caused by your change. https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread John Harrison via lldb-commits

@@ -112,3 +112,48 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Santhosh Kumar Ellendula via lldb-commits

@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][Target] Clear selected frame index after a StopInfo::PerformAction (PR #133078)

2025-03-27 Thread via lldb-commits

@@ -936,3 +936,7 @@ size_t StackFrameList::GetStatus(Stream &strm, uint32_t first_frame, strm.IndentLess(); return num_frames_displayed; } + +void StackFrameList::ClearSelectedFrameIndex() { jimingham wrote: lldb really only should have an opinion about t

[Lldb-commits] [lldb] [lldb] Emit progress events in SymbolFileDWARFDebugMap (PR #133211)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/133211 >From ed2905d3abc064476627863c9b9f1266fb6c5a55 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 26 Mar 2025 22:49:39 -0700 Subject: [PATCH 1/2] [lldb] Emit progress events in SymbolFileDWARFDebug

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere approved this pull request. LGTM™ assuming the answer to my inline question is "no". https://github.com/llvm/llvm-project/pull/133247 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb] Emit progress events in SymbolFileDWARFDebugMap (PR #133211)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/133211 >From ed2905d3abc064476627863c9b9f1266fb6c5a55 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 26 Mar 2025 22:49:39 -0700 Subject: [PATCH 1/3] [lldb] Emit progress events in SymbolFileDWARFDebug

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-03-27 Thread via lldb-commits

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/112555 >From a9d02c8b0c22138d9337bf33883f7e6c937bd655 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Mon, 14 Oct 2024 14:14:30 + Subject: [PATCH 1/2] [lldb] add --platform-available-ports option to the dotest.

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-03-27 Thread via lldb-commits

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/112555 >From a9d02c8b0c22138d9337bf33883f7e6c937bd655 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Mon, 14 Oct 2024 14:14:30 + Subject: [PATCH 1/2] [lldb] add --platform-available-ports option to the dotest.

[Lldb-commits] [lldb] [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (PR #132128)

2025-03-27 Thread Jason Molenda via lldb-commits

@@ -1594,6 +1594,10 @@ static uint64_t bits(uint64_t value, uint32_t msbit, uint32_t lsbit) { m_sent_interrupt_signo); } } else { + // We've requested that the process stop anew; if we had recorded this + // requested stop as being

[Lldb-commits] [lldb] [llvm] [lldb] Remove lldb-server min and max gdbserver port options (PR #133275)

2025-03-27 Thread David Spickett via lldb-commits

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/133275 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-03-27 Thread via lldb-commits

@@ -185,6 +185,9 @@ def setUpServerLogging(self, is_llgs): ] def get_next_port(self): +available_ports = self.getPlatformAvailablePorts() +if available_ports: dlav-sc wrote: addressed https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-03-27 Thread via lldb-commits

@@ -292,6 +292,13 @@ def create_parser(): metavar="platform-working-dir", help="The directory to use on the remote platform.", ) +group.add_argument( +"--platform-available-ports", +dest="lldb_platform_available_ports", +type=lamb

[Lldb-commits] [lldb] [lldb][Target] Clear selected frame index after a StopInfo::PerformAction (PR #133078)

2025-03-27 Thread via lldb-commits

@@ -936,3 +936,7 @@ size_t StackFrameList::GetStatus(Stream &strm, uint32_t first_frame, strm.IndentLess(); return num_frames_displayed; } + +void StackFrameList::ClearSelectedFrameIndex() { jimingham wrote: I'm not sure what we'd do if two parts of lldb

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/129728 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() { return sb_target; } +void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) { + LLDB_INSTRUMENT_VA(this); + // Disable client-telemetry for SWIG. + // This prevent arbitrary python client

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-03-27 Thread via lldb-commits

dlav-sc wrote: > I don't know what else it was going to do :) Yeah, me too, so I've decided to retain the old behavior if `--platform-available-ports` isn’t specified. > Do you need a CMake variable for this too? I wonder how you are getting the > argument to dotest. I don't think I really n

[Lldb-commits] [lldb] [lldb] Remove raw access to PluginInstances vector (PR #132884)

2025-03-27 Thread David Peixotto via lldb-commits

dmpots wrote: > > We did consider this approach. There are some drawbacks beyond the > > performance issue, but the tradeoff may be worth it. > > If we define the method like: `std::vector > > GetEnabledInstances()` then we are returning copies of the PluginInstance. > > Anything that modifies

[Lldb-commits] [lldb] [llvm] [lldb] Remove lldb-server min and max gdbserver port options (PR #133275)

2025-03-27 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Since lldb 20, these have had no effect: https://releases.llvm.org/20.1.0/docs/ReleaseNotes.html#changes-to-lldb > lldb-server now listens to a single port for gdbserver connections and > provides that

[Lldb-commits] [lldb] 17aca79 - [lldb] Teach FuncUnwinders about discontinuous functions (#133072)

2025-03-27 Thread via lldb-commits

Author: Pavel Labath Date: 2025-03-27T12:51:20+01:00 New Revision: 17aca79d98d92510d131c4766a040b02adf6c4b8 URL: https://github.com/llvm/llvm-project/commit/17aca79d98d92510d131c4766a040b02adf6c4b8 DIFF: https://github.com/llvm/llvm-project/commit/17aca79d98d92510d131c4766a040b02adf6c4b8.diff

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-03-27 Thread via lldb-commits

https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/112555 >From a9d02c8b0c22138d9337bf33883f7e6c937bd655 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Mon, 14 Oct 2024 14:14:30 + Subject: [PATCH 1/2] [lldb] add --platform-available-ports option to the dotest.

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/133247 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating DAP 'initialize' to new typed RequestHandler. (PR #133007)

2025-03-27 Thread John Harrison via lldb-commits

@@ -54,6 +54,79 @@ bool fromJSON(const llvm::json::Value &, DisconnectArguments &, /// body field is required. using DisconnectResponse = VoidResponse; +/// Arguments for `initialize` request. +struct InitializeRequestArguments { + /// The ID of the debug adapter. + std::st

[Lldb-commits] [lldb] [lldb] Adjust skips on reverse continue tests (PR #133240)

2025-03-27 Thread Jonas Devlieghere via lldb-commits

https://github.com/JDevlieghere approved this pull request. LGTM, we discussed this yesterday with @rocallahan https://github.com/llvm/llvm-project/pull/133240 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFExpression::Delegate to break dependencies and reduce lldb-server size (PR #131645)

2025-03-27 Thread Pavel Labath via lldb-commits

https://github.com/labath commented: I actually very much like this result. It'd be nice to (try) get rid of the `GetAddressByteSize` method, as I outlined before, but that's better done separately. Just a couple of small changes/improvements inline. https://github.com/llvm/llvm-project/pull/1

  1   2   >