https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/130026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mpark edited https://github.com/llvm/llvm-project/pull/129982
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-03-07T07:09:18Z
New Revision: 39a4da20d88d797824f0e7be0f732ccaf0c7eee4
URL:
https://github.com/llvm/llvm-project/commit/39a4da20d88d797824f0e7be0f732ccaf0c7eee4
DIFF:
https://github.com/llvm/llvm-project/commit/39a4da20d88d797824f0e7be0f732ccaf0c7eee4.diff
LOG:
https://github.com/JDevlieghere commented:
Could you also update `docs/use/symbolfilejson.rst`? Doesn't need to be in this
PR.
https://github.com/llvm/llvm-project/pull/129916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
@@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined {
export class LLDBDapConfigurationProvider
implements vscode.DebugConfigurationProvider
{
+ resolveDebugConfiguration(
+_folder: vscode.WorkspaceFolder | undefined,
+debugConfiguration: vsc
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/129916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -693,7 +690,14 @@ bool fromJSON(const llvm::json::Value &value,
o.map("address", section.address) && o.map("size", section.size) &&
o.map("read", section.read) && o.map("write", section.write) &&
o.map("execute", section.execute) &&
- o.map
@@ -0,0 +1,146 @@
+//===-- Transport.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/130026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,146 @@
+//===-- Transport.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/JDevlieghere commented:
I left some small comments but but overall I really like this approach.
https://github.com/llvm/llvm-project/pull/130026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -219,65 +220,27 @@ void DAP::StopEventHandlers() {
}
}
-// Send the JSON in "json_str" to the "out" stream. Correctly send the
-// "Content-Length:" field followed by the length, followed by the raw
-// JSON bytes.
-void DAP::SendJSON(const std::string &json_str) {
- out
@@ -0,0 +1,146 @@
+//===-- Transport.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -838,19 +775,16 @@ llvm::Error DAP::Loop() {
StopEventHandlers();
});
while (!disconnecting) {
-llvm::json::Object object;
-lldb_dap::PacketStatus status = GetNextObject(object);
-
-if (status == lldb_dap::PacketStatus::EndOfFile) {
- break;
-}
-
jasonmolenda wrote:
FTR on the CI bot my API test did not make correctly. I reverted the PR,
rewrote the makefiles for the API test, relanded.
https://github.com/llvm/llvm-project/pull/129967
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib`
running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/60/builds/21306
Here is the relevant piece of th
SuibianP wrote:
Hi @ashgti, pinging just in case GitHub had its notification fall through the
cracks again :)
I have left several possibly debatable review chains open for your kind
attention, and would appreciate instructions on next steps.
https://github.com/llvm/llvm-project/pull/121269
__
https://github.com/SuibianP updated
https://github.com/llvm/llvm-project/pull/121269
>From 0b7cc855990aad5d4b9b9beb2726e4b0ac5a3755 Mon Sep 17 00:00:00 2001
From: Jialun Hu
Date: Mon, 24 Feb 2025 22:10:17 +0800
Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows
Currently, the name
https://github.com/matthewbastien edited
https://github.com/llvm/llvm-project/pull/128943
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,48 @@
+import * as path from "path";
+import { BaseProcessTree, ProcessTreeParser } from "../base-process-tree";
+
+export class WindowsProcessTree extends BaseProcessTree {
+ protected override getCommand(): string {
+return "PowerShell";
+ }
+
+ protected overr
@@ -0,0 +1,56 @@
+//===-- Transport.h
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/129605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
LGTM
Should maybe file an ER on the lldb issues to plumb this (and the other
SymbolContext specifications) through the expression command so some ambitious
person could see and do that.
https://github.com/llvm/llvm-project/pull/129733
_
Author: Jacob Lalonde
Date: 2025-03-06T18:57:54-08:00
New Revision: 5b1c281fca01373c95d9ddf59bdb59e9ae2ae4ff
URL:
https://github.com/llvm/llvm-project/commit/5b1c281fca01373c95d9ddf59bdb59e9ae2ae4ff
DIFF:
https://github.com/llvm/llvm-project/commit/5b1c281fca01373c95d9ddf59bdb59e9ae2ae4ff.diff
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/129605
>From 6c8f3ee0b033917213c802ddd978c63f8947616b Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 3 Mar 2025 15:12:29 -0800
Subject: [PATCH 1/2] Drop markdown backticks for codeblock
---
lldb/bindings/int
@@ -0,0 +1,16 @@
+import { ChildProcessWithoutNullStreams, spawn } from "child_process";
+import { LinuxProcessTree } from "./linux-process-tree";
+
+function fill(prefix: string, suffix: string, length: number): string {
matthewbastien wrote:
Thanks! I didn't kn
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129354
>From 5a992aff351a93ff820d15ace3ebc2bea59dd5fc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Fri, 28 Feb 2025 23:03:35 -0500
Subject: [PATCH 01/23] [LLDB][Telemetry]Defind telemetry::CommandInfo and
collect te
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129354
>From 5a992aff351a93ff820d15ace3ebc2bea59dd5fc Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Fri, 28 Feb 2025 23:03:35 -0500
Subject: [PATCH 01/22] [LLDB][Telemetry]Defind telemetry::CommandInfo and
collect te
@@ -66,6 +80,52 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct CommandInfo : public LLDBBaseTelemetryInfo {
+ /// If the command is/can be associated with a target
Author: Jason Molenda
Date: 2025-03-06T17:19:43-08:00
New Revision: 82af9888dbbcd248ec4d41968c53135e12e13454
URL:
https://github.com/llvm/llvm-project/commit/82af9888dbbcd248ec4d41968c53135e12e13454
DIFF:
https://github.com/llvm/llvm-project/commit/82af9888dbbcd248ec4d41968c53135e12e13454.diff
Author: Jason Molenda
Date: 2025-03-06T17:19:43-08:00
New Revision: cec36e279cb871dd011e105e0c9d3edccd0dcad9
URL:
https://github.com/llvm/llvm-project/commit/cec36e279cb871dd011e105e0c9d3edccd0dcad9
DIFF:
https://github.com/llvm/llvm-project/commit/cec36e279cb871dd011e105e0c9d3edccd0dcad9.diff
@@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined {
export class LLDBDapConfigurationProvider
implements vscode.DebugConfigurationProvider
{
+ resolveDebugConfiguration(
+_folder: vscode.WorkspaceFolder | undefined,
+debugConfiguration: vsc
Author: Adrian Prantl
Date: 2025-03-06T17:15:49-08:00
New Revision: ca0850f916a75a16264798fe7b7be08fdb892c97
URL:
https://github.com/llvm/llvm-project/commit/ca0850f916a75a16264798fe7b7be08fdb892c97
DIFF:
https://github.com/llvm/llvm-project/commit/ca0850f916a75a16264798fe7b7be08fdb892c97.diff
Author: Jason Molenda
Date: 2025-03-06T17:03:16-08:00
New Revision: 00fdc5297e2ac325eeaa08e1bc8ebe3b8b5f7977
URL:
https://github.com/llvm/llvm-project/commit/00fdc5297e2ac325eeaa08e1bc8ebe3b8b5f7977
DIFF:
https://github.com/llvm/llvm-project/commit/00fdc5297e2ac325eeaa08e1bc8ebe3b8b5f7977.diff
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/128943
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,48 @@
+import * as path from "path";
+import { BaseProcessTree, ProcessTreeParser } from "../base-process-tree";
+
+export class WindowsProcessTree extends BaseProcessTree {
+ protected override getCommand(): string {
+return "PowerShell";
+ }
+
+ protected overr
@@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined {
export class LLDBDapConfigurationProvider
implements vscode.DebugConfigurationProvider
{
+ resolveDebugConfiguration(
+_folder: vscode.WorkspaceFolder | undefined,
+debugConfiguration: vsc
vogelsgesang wrote:
> Is there a way we can use the LLDB platform layer to pick processes?
See discussion further up in the thread ([first
comment](https://github.com/llvm/llvm-project/pull/128943#issuecomment-2686308012)
and follow-up messages). It seems the [final
blocker](https://github.co
https://github.com/mpark converted_to_draft
https://github.com/llvm/llvm-project/pull/129982
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -65,6 +65,19 @@ This will attach to a process `a.out` whose process ID is
123:
}
```
+You can also use the variable substituion `${command:PickProcess}` to select a
+process at the start of the debug session instead of setting the pid manually:
+
+```javascript
+{
+ "type
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/130209
where it can overflow a 2GB offset by just a little bit by applying a heuristic.
rdar://145888306
>From a6caecd1e1bae614579783ac1952e999eae5959d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 6
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 01/16] add a process picker for attaching by PID
---
l
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/129967
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> LGTM. I think you could simplify the test even further by using C++ but on
> the other hand the C tests compile a little faster.
yeah I was going to rewrite it into slightly nicer C but then I realized there
was more value in doing it exactly the same as the other test t
https://github.com/JDevlieghere approved this pull request.
LGTM. I think you could simplify the test even further by using C++ but on the
other hand the C tests compile a little faster.
```
std::ofstream pid_file;
pid_file.open (pid_file_path);
pid_file << getpid();
pid_file.close();
```
htt
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -67,7 +67,7 @@ static Status ReadExpected(IOObjectSP &descriptor,
llvm::StringRef expected) {
if (status.Fail())
return status;
if (expected != result) {
-return Status::FromErrorStringWithFormatv("expected %s, got %s", expected,
+return Status::FromErrorStr
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 01/14] add a process picker for attaching by PID
---
l
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 01/15] add a process picker for attaching by PID
---
l
@@ -27,9 +28,14 @@ export class LinuxProcessTree extends BaseProcessTree {
return;
}
+ const command = line.slice(commandOffset, argumentsOffset).trim();
+ if (command === "-") {
vogelsgesang wrote:
when would command be `-`? Please ad
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,7 +38,7 @@ Expected OutputRedirector::GetWriteFileDescriptor() {
return m_fd;
}
-Error OutputRedirector::RedirectTo(std::FILE *file_override,
+Error OutputRedirector::RedirectTo(std::FILE *fileOverride,
JDevlieghere wrote:
Yeah no worries. Thanks for
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/129605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -65,6 +65,18 @@ This will attach to a process `a.out` whose process ID is
123:
}
```
+You can also use the variable substituion `${command:pickProcess}` to select a
+process at the start of the debug session instead of setting the pid manually:
+
+```javascript
+{
+ "type
@@ -0,0 +1,152 @@
+//===-- Transport.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -65,6 +65,18 @@ This will attach to a process `a.out` whose process ID is
123:
}
```
+You can also use the variable substituion `${command:pickProcess}` to select a
matthewbastien wrote:
Fixed.
https://github.com/llvm/llvm-project/pull/128943
___
@@ -0,0 +1,19 @@
+C_SOURCES := main.c
+LD_EXTRAS = -Wl,-rpath "-Wl,$(shell pwd)" -L. -lno-nlists -lhas-nlists
+
+.PHONY: build-libno-nlists build-libhas-nlists
+all: build-libno-nlists build-libhas-nlists a.out
+
+include Makefile.rules
+
+build-libno-nlists: no-nlists.c no-nlist-
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
Attached are some images of docstrings I'm cleaning up (I also made the mess
:P).
SBSaveCore formatting breaks on the newline
SBProgress has quote blocks instead of just a code block
![imag
Jlalond wrote:
@clayborg These are those docstring cleanups I pinged you about
https://github.com/llvm/llvm-project/pull/129605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 01/13] add a process picker for attaching by PID
---
l
@@ -27,9 +28,14 @@ export class LinuxProcessTree extends BaseProcessTree {
return;
}
+ const command = line.slice(commandOffset, argumentsOffset).trim();
+ if (command === "-") {
matthewbastien wrote:
Added the comment. When `ps` doesn
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/128943
>From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Wed, 26 Feb 2025 11:18:21 -0500
Subject: [PATCH 01/12] add a process picker for attaching by PID
---
l
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/130202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
I adopted the synchronization scheme that we do in other attach tests -- the
python provides a filename that the inferior should create with its pid, we
launch it and wait until that file exists (indicating that the inferior is done
setting up) and then the python tests exe
@@ -0,0 +1,52 @@
+import * as path from "path";
+import { BaseProcessTree, ProcessTreeParser } from "../base-process-tree";
+import { ChildProcessWithoutNullStreams, spawn } from "child_process";
+
+export class WindowsProcessTree extends BaseProcessTree {
+ protected override sp
@@ -38,7 +38,7 @@ Expected OutputRedirector::GetWriteFileDescriptor() {
return m_fd;
}
-Error OutputRedirector::RedirectTo(std::FILE *file_override,
+Error OutputRedirector::RedirectTo(std::FILE *fileOverride,
ashgti wrote:
Sorry for the churn, I saw I brok
https://github.com/vogelsgesang approved this pull request.
LGTM
Side note: Please don't amend your commits, but rather push multiple separate
commits into your PR. That way, I can see the diff compared to the version
which I previously reviewed
https://github.com/llvm/llvm-project/pull/13002
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/130202
Updating the naming and adding documentation to better follow the style guide.
>From a0e065631c5cd071ccf371aa647dd206a99b4054 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 7 Mar 2025 00:13:53 +0100
Sub
@@ -348,6 +351,71 @@ llvm::json::Value toJSON(const ExitedEventBody &);
// MARK: Requests
+// "CancelRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+// "description": "The `cancel` request is used by the client in two
+//
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/130202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1526,7 +1526,8 @@ static void addStatistic(lldb::SBTarget &target,
llvm::json::Object &event) {
const char *key = keys.GetStringAtIndex(i);
FilterAndGetValueForKey(statistics, key, stats_body);
}
- event.try_emplace("statistics", std::move(stats_body));
+ llvm:
@@ -857,29 +819,112 @@ lldb::SBError DAP::Disconnect(bool terminateDebuggee) {
return error;
}
+template
+static std::optional getArgumentsIfRequest(const protocol::Message &pm,
+ llvm::StringLiteral command) {
+ auto *const req
@@ -0,0 +1,56 @@
+//===-- SourceRequestHandler.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -256,7 +257,27 @@ void DAP::SendJSON(const llvm::json::Value &json) {
}
return;
}
- auto status = transport.Write(log, M);
+ Send(M);
+}
+
+void DAP::Send(const protocol::Message &M) {
+ lldb_private::Status status;
+ // If the debugger was interrupted while ha
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/129967
>From 6e258eb09b13776fc393a161225438baa92e5f87 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 5 Mar 2025 17:27:20 -0800
Subject: [PATCH 1/7] [lldb][Mach-O] Don't read symbol table of specially
mar
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
Instead of having two discrete InputStream and OutputStream helpers, this
merges the two into a unifed 'Transport' handler.
This handler is responsible for reading the DAP message headers, parsing the
result
@@ -0,0 +1,152 @@
+//===-- Transport.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,56 @@
+//===-- Transport.h
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -722,40 +683,9 @@ void DAP::SetTarget(const lldb::SBTarget target) {
}
}
-PacketStatus DAP::GetNextObject(llvm::json::Object &object) {
- std::string json = ReadJSON();
- if (json.empty())
-return PacketStatus::EndOfFile;
-
- llvm::StringRef json_sref(json);
- llv
@@ -237,65 +238,25 @@ void DAP::StopEventHandlers() {
}
}
-// Send the JSON in "json_str" to the "out" stream. Correctly send the
-// "Content-Length:" field followed by the length, followed by the raw
-// JSON bytes.
-void DAP::SendJSON(const std::string &json_str) {
- out
@@ -1526,7 +1526,8 @@ static void addStatistic(lldb::SBTarget &target,
llvm::json::Object &event) {
const char *key = keys.GetStringAtIndex(i);
FilterAndGetValueForKey(statistics, key, stats_body);
}
- event.try_emplace("statistics", std::move(stats_body));
+ llvm:
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/130026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130026
>From a9ae73407acad86c49099f4c7eba914e639f0850 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 6 Mar 2025 10:18:36 +0100
Subject: [PATCH] [lldb-dap] Refactoring IOStream into Transport handler.
Instead o
@@ -0,0 +1,81 @@
+"""
+Test that we read don't read the nlist symbols for a specially marked dylib
+when read from memory.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from time import sle
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/130186
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -65,6 +65,18 @@ This will attach to a process `a.out` whose process ID is
123:
}
```
+You can also use the variable substituion `${command:pickProcess}` to select a
+process at the start of the debug session instead of setting the pid manually:
+
+```javascript
+{
+ "type
@@ -65,6 +65,18 @@ This will attach to a process `a.out` whose process ID is
123:
}
```
+You can also use the variable substituion `${command:pickProcess}` to select a
vogelsgesang wrote:
```suggestion
You can also use the variable substitution `${command:pi
@@ -38,7 +38,7 @@ Expected OutputRedirector::GetWriteFileDescriptor() {
return m_fd;
}
-Error OutputRedirector::RedirectTo(std::FILE *file_override,
+Error OutputRedirector::RedirectTo(std::FILE *fileOverride,
JDevlieghere wrote:
But now this doesn't confor
https://github.com/dmpots closed
https://github.com/llvm/llvm-project/pull/129817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/129967
>From 6e258eb09b13776fc393a161225438baa92e5f87 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 5 Mar 2025 17:27:20 -0800
Subject: [PATCH 1/6] [lldb][Mach-O] Don't read symbol table of specially
mar
@@ -146,6 +146,9 @@
"windows": {
"program": "./bin/lldb-dap.exe"
},
+"variables": {
+ "PickProcess": "lldb-dap.pickProcess"
matthewbastien wrote:
Done.
https://github.com/llvm/llvm-project/pull/128943
___
Author: John Harrison
Date: 2025-03-06T14:15:30-08:00
New Revision: e4157218584bd7f02a3345a4473c9e5937f068e8
URL:
https://github.com/llvm/llvm-project/commit/e4157218584bd7f02a3345a4473c9e5937f068e8
DIFF:
https://github.com/llvm/llvm-project/commit/e4157218584bd7f02a3345a4473c9e5937f068e8.diff
@@ -57,235 +68,288 @@ class RequestHandler {
DAP &dap;
};
-class AttachRequestHandler : public RequestHandler {
-public:
- using RequestHandler::RequestHandler;
+/// Base class for handling DAP requests. Handlers should declare their
+/// arguments and response body types l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/130186.diff
1 Files Affected:
- (modified) lldb/tools/lldb-dap/OutputRedirector.cpp (+3-3)
``diff
diff --git a/lldb/tools/lldb-dap/Output
ashgti wrote:
I didn't realize the suggestion only updated the variable name in the
parameter, sorry!
https://github.com/llvm/llvm-project/pull/130186
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/130186
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/130186
None
>From ab48e2c1ee83ed9068f080d2f072f4fb957e1bb7 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 6 Mar 2025 23:06:20 +0100
Subject: [PATCH] [lldb-dap] Correct the variable name from a half finished
m
1 - 100 of 176 matches
Mail list logo
