[Lldb-commits] [lldb] [lldb] Use Lambda to simplify repeptitive code in DynamicLoaderDarwin (NFC) (PR #126175)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/126175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 99099cd - [lldb] Use Lambda to simplify repeptitive code in DynamicLoaderDarwin (NFC) (#126175)

2025-02-06 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-02-06T20:39:30-08:00 New Revision: 99099cd63516bd87665a5199547f6daa9f8d6ce3 URL: https://github.com/llvm/llvm-project/commit/99099cd63516bd87665a5199547f6daa9f8d6ce3 DIFF: https://github.com/llvm/llvm-project/commit/99099cd63516bd87665a5199547f6daa9f8d6ce3.d

[Lldb-commits] [lldb] [lldb] Use Lambda to simplify repeptitive code in DynamicLoaderDarwin (NFC) (PR #126175)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Yeah that is better, thanks, I should have done it myself. https://github.com/llvm/llvm-project/pull/126175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [lldb] Use Lambda to simplify repeptitive code in DynamicLoaderDarwin (NFC) (PR #126175)

2025-02-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes I suggested using a lambda in #126171 but I think @jasonmolenda missed it. --- Full diff: https://github.com/llvm/llvm-project/pull/126175.diff 1 Files Affected: - (modified) lldb/source/Plugins

[Lldb-commits] [lldb] [lldb] Use Lambda to simplify repeptitive code in DynamicLoaderDarwin (NFC) (PR #126175)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/126175 I suggested using a lambda in #126171 but I think @jasonmolenda missed it. >From 11e390143d7097b7d99383b18bc96b08d7502838 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 6 Feb 2025 20:24:05 -08

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-02-06 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 16 "test-check-lldb-unit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/1717 Here is the relevant piece o

[Lldb-commits] [lldb] 003a2bf - [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (#126171)

2025-02-06 Thread via lldb-commits
Author: Jason Molenda Date: 2025-02-06T19:11:23-08:00 New Revision: 003a2bf95415afef74d2c3d4a44c3f2ad1fe582d URL: https://github.com/llvm/llvm-project/commit/003a2bf95415afef74d2c3d4a44c3f2ad1fe582d DIFF: https://github.com/llvm/llvm-project/commit/003a2bf95415afef74d2c3d4a44c3f2ad1fe582d.diff

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-02-06 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/11097 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BREAK, WATCH} (PR #126020)

2025-02-06 Thread via lldb-commits
github-actions[bot] wrote: @seehearfeel Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/126171 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BREAK, WATCH} (PR #126020)

2025-02-06 Thread Lu Weining via lldb-commits
https://github.com/SixWeining closed https://github.com/llvm/llvm-project/pull/126020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 50ae1c7 - [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BREAK, WATCH} (#126020)

2025-02-06 Thread via lldb-commits
Author: Tiezhu Yang Date: 2025-02-07T11:18:40+08:00 New Revision: 50ae1c7bf40ba50aaf3132fa869eda8f06648155 URL: https://github.com/llvm/llvm-project/commit/50ae1c7bf40ba50aaf3132fa869eda8f06648155 DIFF: https://github.com/llvm/llvm-project/commit/50ae1c7bf40ba50aaf3132fa869eda8f06648155.diff L

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BREAK, WATCH} (PR #126020)

2025-02-06 Thread Tiezhu Yang via lldb-commits
seehearfeel wrote: By now, the format of pr and patch seem no problems, but my email setting of GitHub is not correct, I will update the comment once it is OK, please wait some time before merging it, thank you. https://github.com/llvm/llvm-project/pull/126020 __

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/126171 >From af2fa2e17ceb527dd9a2b8c5d7e72da374b4512b Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 6 Feb 2025 18:48:02 -0800 Subject: [PATCH 1/2] [lldb][Darwin] Change DynamicLoaderDarwin to default to

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BREAK, WATCH} (PR #126020)

2025-02-06 Thread Tiezhu Yang via lldb-commits
https://github.com/seehearfeel edited https://github.com/llvm/llvm-project/pull/126020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove old skipIfOutOfTreeDebugserver's (PR #126144)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Thanks! https://github.com/llvm/llvm-project/pull/126144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-02-06 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/125143 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0cbc498 - [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (#125143)

2025-02-06 Thread via lldb-commits
Author: Augusto Noronha Date: 2025-02-06T19:04:01-08:00 New Revision: 0cbc4983adcdbbd85ccb38b2dfbfe5985367b1b2 URL: https://github.com/llvm/llvm-project/commit/0cbc4983adcdbbd85ccb38b2dfbfe5985367b1b2 DIFF: https://github.com/llvm/llvm-project/commit/0cbc4983adcdbbd85ccb38b2dfbfe5985367b1b2.dif

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-02-06 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/125143 >From 937fdeab0b8526bd4b0e951f939a74ae01b1020c Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 30 Jan 2025 16:33:09 -0800 Subject: [PATCH] [lldb] Make ValueObjectDynamicValue::UpdateValue() point t

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/126171 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
@@ -1208,35 +1208,44 @@ DynamicLoaderDarwin::GetThreadLocalData(const lldb::ModuleSP module_sp, bool DynamicLoaderDarwin::UseDYLDSPI(Process *process) { Log *log = GetLog(LLDBLog::DynamicLoader); - bool use_new_spi_interface = false; + bool use_new_spi_interface = true;

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/126171 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I originally removed the old DynamicLoader plugin except for corefiles. But it seemed unnecessary to break lldb from working on old macOS for no reason. I should probably remove the iOS/watchOS/tvOS cases, it's years outside Xcode's supported OS versions. https://github.

[Lldb-commits] [lldb] d8e0b13 - [lldb][NFC] Small comment fix in Process.h

2025-02-06 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-02-06T18:54:30-08:00 New Revision: d8e0b130bd7b2dd168642a82056b8eca21c49f9f URL: https://github.com/llvm/llvm-project/commit/d8e0b130bd7b2dd168642a82056b8eca21c49f9f DIFF: https://github.com/llvm/llvm-project/commit/d8e0b130bd7b2dd168642a82056b8eca21c49f9f.diff

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes In Sep 2016 and newer Darwin releases, debugserver uses libdyld SPI to gather information about the binaries loaded in a process. Before Sep 2016, lldb would inspect the dyld internal data structures d

[Lldb-commits] [lldb] [lldb][Darwin] Change DynamicLoaderDarwin to default to new SPI (PR #126171)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/126171 In Sep 2016 and newer Darwin releases, debugserver uses libdyld SPI to gather information about the binaries loaded in a process. Before Sep 2016, lldb would inspect the dyld internal data structures dire

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BREAK, WATCH} (PR #126020)

2025-02-06 Thread Tiezhu Yang via lldb-commits
https://github.com/seehearfeel updated https://github.com/llvm/llvm-project/pull/126020 >From 7adde90f84cd43fe47c30a094a483b68fafe9bef Mon Sep 17 00:00:00 2001 From: Tiezhu Yang Date: Thu, 23 Jan 2025 15:30:20 +0800 Subject: [PATCH] [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BRE

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BREAK, WATCH} (PR #126020)

2025-02-06 Thread Lu Weining via lldb-commits
https://github.com/SixWeining approved this pull request. https://github.com/llvm/llvm-project/pull/126020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b800293 - [lldb] Add missing return statements in ThreadMemory (#126128)

2025-02-06 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-02-06T15:59:43-08:00 New Revision: b8002933e92f89600521be420376ec111ad367f1 URL: https://github.com/llvm/llvm-project/commit/b8002933e92f89600521be420376ec111ad367f1 DIFF: https://github.com/llvm/llvm-project/commit/b8002933e92f89600521be420376ec111

[Lldb-commits] [lldb] [lldb] Add missing return statements in ThreadMemory (PR #126128)

2025-02-06 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/126128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 163ccfa - [lldb][NFC] whitespace reflow

2025-02-06 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-02-06T15:04:29-08:00 New Revision: 163ccfac33201948eb430db6fac38d265958cfaa URL: https://github.com/llvm/llvm-project/commit/163ccfac33201948eb430db6fac38d265958cfaa DIFF: https://github.com/llvm/llvm-project/commit/163ccfac33201948eb430db6fac38d265958cfaa.diff

[Lldb-commits] [lldb] [lldb][NFC] Remove old skipIfOutOfTreeDebugserver's (PR #126144)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/126144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8b65411 - [lldb][NFC] Remove old skipIfOutOfTreeDebugserver's (#126144)

2025-02-06 Thread via lldb-commits
Author: Jason Molenda Date: 2025-02-06T14:50:09-08:00 New Revision: 8b65411b006cbe302dea7d00ff79abddd1403061 URL: https://github.com/llvm/llvm-project/commit/8b65411b006cbe302dea7d00ff79abddd1403061 DIFF: https://github.com/llvm/llvm-project/commit/8b65411b006cbe302dea7d00ff79abddd1403061.diff

[Lldb-commits] [lldb] [lldb][NFC] Remove old skipIfOutOfTreeDebugserver's (PR #126144)

2025-02-06 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: The Xcode installed on the macOS CI bots was updated to Xcode 16.2 a few weeks ago, so we've got a pretty recent debugserver being used on them now. https://github.com/llvm/llvm-project/pull/126144 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] [lldb][NFC] Remove old skipIfOutOfTreeDebugserver's (PR #126144)

2025-02-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes When a test depends on a new debugserver feature/fix, the API test must be marked @skipIfOutOfTreeDebugserver because the macOS CI bots test using the latest Xcode release debugserver. But over time al

[Lldb-commits] [lldb] [lldb] Add missing return statements in ThreadMemory (PR #126128)

2025-02-06 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Yeah, that was clearly wrong. Thanks for adding the test. https://github.com/llvm/llvm-project/pull/126128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb][NFC] Remove old skipIfOutOfTreeDebugserver's (PR #126144)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/126144 When a test depends on a new debugserver feature/fix, the API test must be marked @skipIfOutOfTreeDebugserver because the macOS CI bots test using the latest Xcode release debugserver. But over time all o

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap port listening mode to allow multiple connections. (PR #116392)

2025-02-06 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/116392 >From 88a8522f1b29b2ff392974322acdb722b7e00b70 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 28 Jan 2025 12:39:38 -0800 Subject: [PATCH 1/4] [lldb-dap] Refactoring lldb-dap port listening mode to allow

[Lldb-commits] [lldb] [lldb] Add missing return statements in ThreadMemory (PR #126128)

2025-02-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes These prevented ThreadMemory from correctly returning the Name/Queue/Info of the backing thread. Note about testing: this test only finds regressions if the system sets a name or queue f

[Lldb-commits] [lldb] [lldb] Add missing return statements in ThreadMemory (PR #126128)

2025-02-06 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/126128 These prevented ThreadMemory from correctly returning the Name/Queue/Info of the backing thread. Note about testing: this test only finds regressions if the system sets a name or queue for the backing t

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
@@ -257,8 +257,8 @@ enum StopReason { }; /// Command Return Status Types. -enum ReturnStatus { - eReturnStatusInvalid, +enum ReturnStatus : int { + eReturnStatusInvalid = 0, oontvoo wrote: done - removed the `:int` and `=0` https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/119716 >From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 26 Dec 2024 20:50:40 -0500 Subject: [PATCH 01/14] Implement LLDB Telemetry (Part 1) This contains only the conc

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-02-06 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/125143 >From e8124c1949a1957befd58a045c0e36f4f6e09274 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 30 Jan 2025 16:33:09 -0800 Subject: [PATCH] [lldb] Make ValueObjectDynamicValue::UpdateValue() point t

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-02-06 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/125143 >From ceb193ba178a3ec71824f8137ea648d70a5b0a79 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 30 Jan 2025 16:33:09 -0800 Subject: [PATCH] [lldb] Make ValueObjectDynamicValue::UpdateValue() point t

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo deleted https://github.com/llvm/llvm-project/pull/119716 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] Reland: [clang] fix P3310 overload resolution flag propagation (PR #125791)

2025-02-06 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: > > > > > Actually, @mizvekov, can we make the > > > > > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext > > > > > &C, Kind DK)` constructor default initialize the `StrictPackMatch` > > > > > member to false? In that case users of `CreateDeserialize

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-02-06 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Thanks for making that work! LGTM https://github.com/llvm/llvm-project/pull/125143 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [clang] [lldb] Reland: [clang] fix P3310 overload resolution flag propagation (PR #125791)

2025-02-06 Thread Michael Buch via lldb-commits
Michael137 wrote: > > > > Actually, @mizvekov, can we make the > > > > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext > > > > &C, Kind DK)` constructor default initialize the `StrictPackMatch` > > > > member to false? In that case users of `CreateDeserialized` wou

[Lldb-commits] [clang] [lldb] Reland: [clang] fix P3310 overload resolution flag propagation (PR #125791)

2025-02-06 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: > > > Actually, @mizvekov, can we make the > > > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext > > > &C, Kind DK)` constructor default initialize the `StrictPackMatch` > > > member to false? In that case users of `CreateDeserialized` wouldn't need

[Lldb-commits] [clang] [lldb] Reland: [clang] fix P3310 overload resolution flag propagation (PR #125791)

2025-02-06 Thread Michael Buch via lldb-commits
Michael137 wrote: > > Actually, @mizvekov, can we make the > > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext > > &C, Kind DK)` constructor default initialize the `StrictPackMatch` member > > to false? In that case users of `CreateDeserialized` wouldn't need to wo

[Lldb-commits] [clang] [lldb] Reland: [clang] fix P3310 overload resolution flag propagation (PR #125791)

2025-02-06 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: > Actually, @mizvekov, can we make the > `ClassTemplateSpecializationDecl::ClassTemplateSpecializationDecl(ASTContext > &C, Kind DK)` constructor default initialize the `StrictPackMatch` member to > false? In that case users of `CreateDeserialized` wouldn't need to worry > abo

[Lldb-commits] [lldb] c4d75b1 - [lldb][DWARFASTParser][NFC] Fix doxygen comment

2025-02-06 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-02-06T19:12:26Z New Revision: c4d75b1e9b9c22577032ba68b7560481027b4b8a URL: https://github.com/llvm/llvm-project/commit/c4d75b1e9b9c22577032ba68b7560481027b4b8a DIFF: https://github.com/llvm/llvm-project/commit/c4d75b1e9b9c22577032ba68b7560481027b4b8a.diff LOG:

[Lldb-commits] [lldb] [lldb][TypeSystem] Ensure that ParmVarDecls have the correct DeclContext (PR #124279)

2025-02-06 Thread Michael Buch via lldb-commits
@@ -3205,6 +3199,8 @@ void DWARFASTParserClang::ParseChildParameters( break; } } + + assert(function_param_names.size() == function_param_names.size()); Michael137 wrote: hah good catch! yea that's meant to say: ``` assert(function_param_types.siz

[Lldb-commits] [lldb] [lldb][TypeSystem] Ensure that ParmVarDecls have the correct DeclContext (PR #124279)

2025-02-06 Thread via lldb-commits
@@ -3205,6 +3199,8 @@ void DWARFASTParserClang::ParseChildParameters( break; } } + + assert(function_param_names.size() == function_param_names.size()); klensy wrote: This looks like typo? Comparing with self. https://github.com/llvm/llvm-project

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
@@ -257,8 +257,8 @@ enum StopReason { }; /// Command Return Status Types. -enum ReturnStatus { - eReturnStatusInvalid, +enum ReturnStatus : int { + eReturnStatusInvalid = 0, oontvoo wrote: done https://github.com/llvm/llvm-project/pull/119716 _

[Lldb-commits] [clang] [lldb] Reland: [clang] fix P3310 overload resolution flag propagation (PR #125791)

2025-02-06 Thread Michael Buch via lldb-commits
Michael137 wrote: Actually, @mizvekov, can we make `ClassTemplatePartialSpecializationDecl(ASTContext&)` default initialize the `StrictPackMatch` member to false? In that case users of `CreateDeserialized` wouldn't need to worry about it being potentially uninitialized? Otherwise we'll have t

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/119716 >From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 26 Dec 2024 20:50:40 -0500 Subject: [PATCH 01/11] Implement LLDB Telemetry (Part 1) This contains only the conc

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/119716 >From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 26 Dec 2024 20:50:40 -0500 Subject: [PATCH 01/10] Implement LLDB Telemetry (Part 1) This contains only the conc

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/119716 >From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 26 Dec 2024 20:50:40 -0500 Subject: [PATCH 1/9] Implement LLDB Telemetry (Part 1) This contains only the concre

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/119716 >From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 26 Dec 2024 20:50:40 -0500 Subject: [PATCH 1/8] Implement LLDB Telemetry (Part 1) This contains only the concre

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
@@ -17,6 +17,15 @@ if (LLDB_ENABLE_CURSES) endif() # TODO: Add property `NO_PLUGIN_DEPENDENCIES` to lldbCore +set(LLDB_CORE_SRCS + +) + oontvoo wrote: done https://github.com/llvm/llvm-project/pull/119716 ___ lldb-

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,93 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,93 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,93 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: I left a bunch of nits but the core looks good. https://github.com/llvm/llvm-project/pull/119716 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,93 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,93 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/119716 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,93 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,93 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,93 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
@@ -0,0 +1,100 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][NFC] Add documentation for SBFrame::GetRegisters (PR #125969)

2025-02-06 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/125969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 18bd118 - [lldb][NFC] Add documentation for SBFrame::GetRegisters (#125969)

2025-02-06 Thread via lldb-commits
Author: Jason Molenda Date: 2025-02-06T09:19:22-08:00 New Revision: 18bd11889386a653edb1ef5eb501c6af0094478f URL: https://github.com/llvm/llvm-project/commit/18bd11889386a653edb1ef5eb501c6af0094478f DIFF: https://github.com/llvm/llvm-project/commit/18bd11889386a653edb1ef5eb501c6af0094478f.diff

[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread Adrian Prantl via lldb-commits
@@ -262,8 +262,10 @@ OptionArgParser::DoToAddress(const ExecutionContext *exe_ctx, llvm::StringRef s, // 3: The symbol/reg name if there is an offset // 4: +/- // 5: The offset value. + // clang-format off static RegularExpression g_symbol_plus_offset_regex( - "

[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/126053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
@@ -0,0 +1,93 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,81 @@ +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/119716 >From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 26 Dec 2024 20:50:40 -0500 Subject: [PATCH 1/7] Implement LLDB Telemetry (Part 1) This contains only the concre

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/119716 >From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 26 Dec 2024 20:50:40 -0500 Subject: [PATCH 1/6] Implement LLDB Telemetry (Part 1) This contains only the concre

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,100 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,81 @@ +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Pavel Labath via lldb-commits
@@ -17,6 +17,15 @@ if (LLDB_ENABLE_CURSES) endif() # TODO: Add property `NO_PLUGIN_DEPENDENCIES` to lldbCore +set(LLDB_CORE_SRCS + +) + labath wrote: unused? https://github.com/llvm/llvm-project/pull/119716 ___ lld

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Pavel Labath via lldb-commits
@@ -257,8 +257,8 @@ enum StopReason { }; /// Command Return Status Types. -enum ReturnStatus { - eReturnStatusInvalid, +enum ReturnStatus : int { + eReturnStatusInvalid = 0, labath wrote: In that case, I'd suggest working around that locally (by casting the

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/119716 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I think this looks okay so far. @JDevlieghere, do you have anything to add? The interesting part will be wiring this up with initialization and all the call sites (which is now complicated by the fact that this code is conditionally compiled. Before you ge

[Lldb-commits] [lldb] [lldb][telemetry] Implement LLDB Telemetry (part 1) (PR #119716)

2025-02-06 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,93 @@ +//===-- Telemetry.h --*- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][AIX] Added PlatformAIX plugin (PR #121273)

2025-02-06 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/121273 >From 16107a423e30cc339b7529db35a75c3c26924146 Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Sat, 28 Dec 2024 13:19:21 -0600 Subject: [PATCH 1/4] Introducing PlatformAIX from PlatformLinux ---

[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,12 @@ +# RUN: %clang_host -g -O0 %S/Inputs/main.c -o %t.out +# RUN: %lldb -b -o 'breakpoint set -a "main+26"' \ labath wrote: Nested quotes don't work (or maybe work differently) on windows. Better put this into a command file (i.e., this file, since

[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/126053 >From 659a383f00011ecbf88163d15719eff9661742a7 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 6 Feb 2025 11:44:50 + Subject: [PATCH 1/4] [lldb][Breakpoint] Allow whitespace in breakpoint address

[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread Michael Buch via lldb-commits
@@ -0,0 +1,3 @@ +# RUN: %clang_host -g -O0 %S/Inputs/main.c -o %t.out +# RUN: %lldb -b -o 'breakpoint set -a "main +26"' %t.out | FileCheck %s --check-prefix CHECK Michael137 wrote: Done, will put them all in one lldb invocation https://github.com/llvm/llv

[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/126053 >From 659a383f00011ecbf88163d15719eff9661742a7 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 6 Feb 2025 11:44:50 + Subject: [PATCH 1/3] [lldb][Breakpoint] Allow whitespace in breakpoint address

[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/126053 >From 659a383f00011ecbf88163d15719eff9661742a7 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 6 Feb 2025 11:44:50 + Subject: [PATCH 1/2] [lldb][Breakpoint] Allow whitespace in breakpoint address

[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread David Spickett via lldb-commits
@@ -0,0 +1,3 @@ +# RUN: %clang_host -g -O0 %S/Inputs/main.c -o %t.out +# RUN: %lldb -b -o 'breakpoint set -a "main +26"' %t.out | FileCheck %s --check-prefix CHECK DavidSpickett wrote: You should test a few versions in case the whitespace was ever made mand

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BREAK, WATCH} (PR #126020)

2025-02-06 Thread via lldb-commits
seehearfeel wrote: > I see that the basics of this were added 2 years ago - > [torvalds/linux@1a69f7a](https://github.com/torvalds/linux/commit/1a69f7a161a78aead07cd4b811d796950e892fa4). > > So I assume the build error here is not that NT_LOONGARCH_HW_BREAK is not > defined, it's that user_wat

[Lldb-commits] [lldb] [LLDB][LoongArch] Fix build errors about NT_LOONGARCH_HW_{BREAK, WATCH} (PR #126020)

2025-02-06 Thread via lldb-commits
https://github.com/seehearfeel edited https://github.com/llvm/llvm-project/pull/126020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/126053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Setting a breakpoint on ` + ` used to work until `2c76e88e9eb284d17cf409851fb01f1d583bb22a`, where this regex was reworked. Now we only accept `+ `. This patch fixes the re

[Lldb-commits] [lldb] [lldb][Breakpoint] Allow whitespace in breakpoint address expression (PR #126053)

2025-02-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/126053 Setting a breakpoint on ` + ` used to work until `2c76e88e9eb284d17cf409851fb01f1d583bb22a`, where this regex was reworked. Now we only accept `+ `. This patch fixes the regression by adding yet another `[[

[Lldb-commits] [lldb] [llvm] [NFC][DebugInfo] Make some block-start-position methods return iterators (PR #124287)

2025-02-06 Thread Stephen Tozer via lldb-commits
SLTozer wrote: The approach sounds reasonable enough to me that it's probably best to open a PR and continue discussion there - the C API is a bit of a special case, so it might warrant bringing in people who know more about it (and actually consume it) if a change is necessary, but I suspect

  1   2   >