seehearfeel wrote:
> I see that the basics of this were added 2 years ago -
> [torvalds/linux@1a69f7a](https://github.com/torvalds/linux/commit/1a69f7a161a78aead07cd4b811d796950e892fa4).
>
> So I assume the build error here is not that NT_LOONGARCH_HW_BREAK is not
> defined, it's that user_watch_state got redefined?
Actually, as the commit message said, it is because
NT_LOONGARCH_HW_{BREAK,WATCH} are not defined in the system header.
>
> Please explain all this in the PR _description_. GitHub does not use the
> contents of the commit messages for the final commit. Link to kernel commits
> as well, that will be easier than writing out the same justifications again.
>
> Also include something in the title so it's like "Fix build errors with
> user_watch_v2". If you need to find this commit again, that will help you a
> lot.
>
> I'd like to know what your intent is with supporting older kernels, if at
> all. Given that this new structure is not the same size as the other one, or
> is it? A `pad` was added but perhaps that just made the existing compiler
> padding explicit?
>
> (I don't care if you do support older kernels or not, but let's get the
> intent documented)
This PR only has one patch now, the PR title is same with the patch title.
There will be another patch to do what you said once this PR is merged.
https://github.com/llvm/llvm-project/pull/126020
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
