[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-15 Thread Chuanqi Xu via lldb-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/123152 >From 3b3a9575f47c786db93fc0524d019fad5ef7cd61 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 16 Jan 2025 11:30:30 +0800 Subject: [PATCH] [AST] Add OriginalDC argument to ExternalASTSource::FindExterna

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chuanqi Xu (ChuanqiXu9) Changes Part for relanding https://github.com/llvm/llvm-project/pull/122887. I split this to test where the performance regession comes from if modules are not used. --- Full diff: https://github.com/llvm/llvm-pro

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chuanqi Xu (ChuanqiXu9) Changes Part for relanding https://github.com/llvm/llvm-project/pull/122887. I split this to test where the performance regession comes from if modules are not used. --- Full diff: https://github.com/llvm/llvm-proj

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Chuanqi Xu (ChuanqiXu9) Changes Part for relanding https://github.com/llvm/llvm-project/pull/122887. I split this to test where the performance regession comes from if modules are not used. --- Full diff: https://github.com/llvm/

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-15 Thread Chuanqi Xu via lldb-commits
ChuanqiXu9 wrote: @nikic hi, could you test if this patch may trigger the compilation time regression? https://github.com/llvm/llvm-project/pull/123152 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [clang] [lldb] [AST] Add OriginalDC argument to ExternalASTSource::FindExternalVisibleDeclsByName (PR #123152)

2025-01-15 Thread Chuanqi Xu via lldb-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/123152 Part for relanding https://github.com/llvm/llvm-project/pull/122887. I split this to test where the performance regession comes from if modules are not used. >From 15e0af0c7a7f93a2f4fce6c996ef50726770a4ea M

[Lldb-commits] [lldb] 731db2a - Revert "[C++20] [Modules] Support module level lookup (#122887)"

2025-01-15 Thread Chuanqi Xu via lldb-commits
Author: Chuanqi Xu Date: 2025-01-16T10:23:11+08:00 New Revision: 731db2a03e096fe42196f0ae6531179b998b0bf8 URL: https://github.com/llvm/llvm-project/commit/731db2a03e096fe42196f0ae6531179b998b0bf8 DIFF: https://github.com/llvm/llvm-project/commit/731db2a03e096fe42196f0ae6531179b998b0bf8.diff LO

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-15 Thread Chuanqi Xu via lldb-commits
ChuanqiXu9 wrote: > Looks like this change has some compile-time impact even if modules are not > used: > https://llvm-compile-time-tracker.com/compare.php?from=edc02351dd11cc4a39b7c541b26b71c6f36c8e55&to=7201cae106260aeb3e97d5291ff30f05076a&stat=instructions:u > It seems to add about 0.5%

[Lldb-commits] [lldb] [LLDB][NFC] Calculate the region size of an in memory image if size isn't specified (PR #123148)

2025-01-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes This patch cleans up some code and allows users to not have to specify a size and now get a more realistic value when reading modules from memory. This patch is in preparation for starting to have the dynami

[Lldb-commits] [lldb] [LLDB][NFC] Calculate the region size of an in memory image if size isn't specified (PR #123148)

2025-01-15 Thread Greg Clayton via lldb-commits
https://github.com/clayborg created https://github.com/llvm/llvm-project/pull/123148 This patch cleans up some code and allows users to not have to specify a size and now get a more realistic value when reading modules from memory. This patch is in preparation for starting to have the dynamic

[Lldb-commits] [lldb] [lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar (PR #123107)

2025-01-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Either returning true or false is perfectly fine. The only argument I can come up for returning true is that now all call sites need to replicate this check as to not call this function with a size of 0. https://github.com/llvm/llvm-

[Lldb-commits] [lldb] [LLDB] Add draft docstrings for SBSaveCoreOptions (PR #123132)

2025-01-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: I left a few suggestions in terms of wordsmithing. https://github.com/llvm/llvm-project/pull/123132 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [LLDB] Add draft docstrings for SBSaveCoreOptions (PR #123132)

2025-01-15 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,72 @@ +%feature("docstring", +"A container for options to use when saving a core file. + +SBSaveCoreOptions includes API's to specify the memory regions and threads to include +when generating a core file. These options are not exclusive the existing SaveCoreStyle opt

[Lldb-commits] [lldb] [LLDB] Add draft docstrings for SBSaveCoreOptions (PR #123132)

2025-01-15 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,72 @@ +%feature("docstring", +"A container for options to use when saving a core file. + +SBSaveCoreOptions includes API's to specify the memory regions and threads to include +when generating a core file. These options are not exclusive the existing SaveCoreStyle opt

[Lldb-commits] [lldb] [LLDB] Add draft docstrings for SBSaveCoreOptions (PR #123132)

2025-01-15 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,72 @@ +%feature("docstring", +"A container for options to use when saving a core file. JDevlieghere wrote: ```suggestion "A container to specify how to save a core file. ``` https://github.com/llvm/llvm-project/pull/123132

[Lldb-commits] [lldb] [LLDB] Add draft docstrings for SBSaveCoreOptions (PR #123132)

2025-01-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/123132 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix std::unordered_* synthetic children when typedefs are used. (PR #123125)

2025-01-15 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/123125 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b7722fb - [lldb] Fix std::unordered_* synthetic children when typedefs are used. (#123125)

2025-01-15 Thread via lldb-commits
Author: Greg Clayton Date: 2025-01-15T16:30:45-08:00 New Revision: b7722fbcab4d769be54ae3001f311b2955ef6134 URL: https://github.com/llvm/llvm-project/commit/b7722fbcab4d769be54ae3001f311b2955ef6134 DIFF: https://github.com/llvm/llvm-project/commit/b7722fbcab4d769be54ae3001f311b2955ef6134.diff

[Lldb-commits] [lldb] [lldb] Add OS plugin property for reporting all threads (PR #123145)

2025-01-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes Currently, an LLDB target option controls whether plugins report all threads. However, it seems natural for this knowledge could come from the plugin itself. To support this, this commits

[Lldb-commits] [lldb] [lldb] Add OS plugin property for reporting all threads (PR #123145)

2025-01-15 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/123145 Currently, an LLDB target option controls whether plugins report all threads. However, it seems natural for this knowledge could come from the plugin itself. To support this, this commits adds a virtual

[Lldb-commits] [lldb] [lldb] Fix std::unordered_* synthetic children when typedefs are used. (PR #123125)

2025-01-15 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. https://github.com/llvm/llvm-project/pull/123125 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3241d91 - [lldb] Recognize embedded Swift mangling in Mangled::GetManglingScheme

2025-01-15 Thread Augusto Noronha via lldb-commits
Author: Augusto Noronha Date: 2025-01-15T15:19:30-08:00 New Revision: 3241d915b1b8257fd6234461b04e4775fc7ed9fb URL: https://github.com/llvm/llvm-project/commit/3241d915b1b8257fd6234461b04e4775fc7ed9fb DIFF: https://github.com/llvm/llvm-project/commit/3241d915b1b8257fd6234461b04e4775fc7ed9fb.dif

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-15 Thread Alexander Richardson via lldb-commits
arichardson wrote: Sanitizer build has been fixed but I know this will also break the Fuchsia build bots if we reland it (see https://github.com/llvm/llvm-project/pull/115379#issuecomment-2469268557) - not sure if there is any plan to update those builders to use installed toolchains for the

[Lldb-commits] [lldb] [lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar (PR #123107)

2025-01-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/123107 >From f83e29d9b6fc747584485bae3f519dcd34a5bb0b Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 15 Jan 2025 10:42:35 -0800 Subject: [PATCH 1/2] [lldb] Handle a byte size of zero in CompilerType:

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/123089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-15 Thread Michael Buch via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [lldb] Fix std::unordered_* synthetic children when typedefs are used. (PR #123125)

2025-01-15 Thread Greg Clayton via lldb-commits
https://github.com/clayborg created https://github.com/llvm/llvm-project/pull/123125 There was a bug in both the GNU and libc++ library synthetic child providers when a typedef was used in the type of the variable. Previous code was looking at the top level typename to try and determine if std

[Lldb-commits] [lldb] [LLDB] Add draft docstrings for SBSaveCoreOptions (PR #123132)

2025-01-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes SBSaveCoreOptions has been around for awhile now, so I decided to draft up some Docstrings describing the functionality better. Some of my wording sounded a bit clunky due the optionality of each method call

[Lldb-commits] [lldb] [LLDB] Add draft docstrings for SBSaveCoreOptions (PR #123132)

2025-01-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/123132 SBSaveCoreOptions has been around for awhile now, so I decided to draft up some Docstrings describing the functionality better. Some of my wording sounded a bit clunky due the optionality of each method call so

[Lldb-commits] [lldb] [lldb] Fix std::unordered_* synthetic children when typedefs are used. (PR #123125)

2025-01-15 Thread Greg Clayton via lldb-commits
clayborg wrote: Going to give others time to give feedback before merging. https://github.com/llvm/llvm-project/pull/123125 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix std::unordered_* synthetic children when typedefs are used. (PR #123125)

2025-01-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. Great to see a quick follow up on this. I left a comment, but I think we should still include some test cases not behind a typedef, and then include your test changes as well to cover all the bases. https://github.com/llvm/llvm-project/pul

[Lldb-commits] [lldb] [lldb] Fix std::unordered_* synthetic children when typedefs are used. (PR #123125)

2025-01-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/123125 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix std::unordered_* synthetic children when typedefs are used. (PR #123125)

2025-01-15 Thread Jacob Lalonde via lldb-commits
@@ -18,15 +18,19 @@ int main() { char buffer[sizeof(std::unordered_map)] = {0}; std::unordered_map &corrupt_map = *(std::unordered_map *)buffer; - std::unordered_map map; // Set break point at this line. + // Make a typedef to ensure functionality when typedefs are used

[Lldb-commits] [lldb] [lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar (PR #123107)

2025-01-15 Thread Jacob Lalonde via lldb-commits
@@ -1105,7 +1105,7 @@ bool CompilerType::GetValueAsScalar(const lldb_private::DataExtractor &data, return false; std::optional byte_size = GetByteSize(exe_scope); -if (!byte_size) +if (!byte_size || *byte_size == 0) Jlalond wrote: Nit: I wo

[Lldb-commits] [lldb] [lldb] Fix std::unordered_* synthetic children when typedefs are used. (PR #123125)

2025-01-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Greg Clayton (clayborg) Changes There was a bug in both the GNU and libc++ library synthetic child providers when a typedef was used in the type of the variable. Previous code was looking at the top level typename to try and determine if s

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
cmtice wrote: I think I have addressed all the review comments and this is ready for another review. Thanks! https://github.com/llvm/llvm-project/pull/120971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] [lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar (PR #123107)

2025-01-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. https://github.com/llvm/llvm-project/pull/123107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,191 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,191 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-15 Thread via lldb-commits
jimingham wrote: Done. https://github.com/llvm/llvm-project/pull/120817 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-15 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/120817 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d594d4c - Refactor `ThreadList::WillResume()` to prepare to support reverse execution (#120817)

2025-01-15 Thread via lldb-commits
Author: Robert O'Callahan Date: 2025-01-15T13:18:25-08:00 New Revision: d594d4cef7d0ba15370435aac362fe44224c1bab URL: https://github.com/llvm/llvm-project/commit/d594d4cef7d0ba15370435aac362fe44224c1bab DIFF: https://github.com/llvm/llvm-project/commit/d594d4cef7d0ba15370435aac362fe44224c1bab.d

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,191 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,191 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,26 @@ +int +main(int argc, char **argv) +{ + int a = 1; + int b = 2; + + char c = -3; + unsigned short s = 4; + + return 0; // Set a breakpoint here +} + +/* cmtice wrote: Removed. https://github.com/llvm/llvm-project/pull/120971

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,191 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,191 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,166 @@ +//===-- DILLexer.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,117 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-15 Thread Nikita Popov via lldb-commits
nikic wrote: Looks like this change has some compile-time impact even if modules are not used: https://llvm-compile-time-tracker.com/compare.php?from=edc02351dd11cc4a39b7c541b26b71c6f36c8e55&to=7201cae106260aeb3e97d5291ff30f05076a&stat=instructions:u It seems to add about 0.5% to C++ compi

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,228 @@ +//===-- DILAST.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -511,22 +513,58 @@ ValueObjectSP StackFrame::GetValueForVariableExpressionPath( VariableSP &var_sp, Status &error) { ExecutionContext exe_ctx; CalculateExecutionContext(exe_ctx); + bool use_DIL = exe_ctx.GetTargetRef().GetUseDIL(&exe_ctx); + if (use_DIL)

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -511,22 +513,58 @@ ValueObjectSP StackFrame::GetValueForVariableExpressionPath( VariableSP &var_sp, Status &error) { ExecutionContext exe_ctx; CalculateExecutionContext(exe_ctx); + bool use_DIL = exe_ctx.GetTargetRef().GetUseDIL(&exe_ctx); + if (use_DIL)

[Lldb-commits] [lldb] [lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar (PR #123107)

2025-01-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes A bit or byte size of 0 is not a bug. It can legitimately (and frequently) happen in Swift and C, just not in C++. However, it doesn't make sense to read a scalar of zero bytes. Currently, when thi

[Lldb-commits] [lldb] [lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar (PR #123107)

2025-01-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/123107 A bit or byte size of 0 is not a bug. It can legitimately (and frequently) happen in Swift and C, just not in C++. However, it doesn't make sense to read a scalar of zero bytes. Currently, when this happe

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-15 Thread Alexander Richardson via lldb-commits
arichardson wrote: > > > https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh > > > > > > It looks like > > https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh >

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-15 Thread Vitaly Buka via lldb-commits
vitalybuka wrote: > > https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh > > It looks like > https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh > tries to run

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,161 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -511,22 +513,58 @@ ValueObjectSP StackFrame::GetValueForVariableExpressionPath( VariableSP &var_sp, Status &error) { ExecutionContext exe_ctx; CalculateExecutionContext(exe_ctx); + bool use_DIL = exe_ctx.GetTargetRef().GetUseDIL(&exe_ctx); + if (use_DIL)

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,62 @@ +//===-- DILEval.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,161 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-15 Thread Alexander Richardson via lldb-commits
arichardson wrote: > https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh It looks like https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh tries to run `ninja c

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,161 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,161 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-15 Thread via lldb-commits
jimingham wrote: LGTM modulo the couple little niggles. Thanks for the extra testing! https://github.com/llvm/llvm-project/pull/123046 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-15 Thread Vitaly Buka via lldb-commits
vitalybuka wrote: > IIUC, the build that encountered issues in this patch ([in the comment > above](https://github.com/llvm/llvm-project/pull/115380#issuecomment-2590801533)) > is a flavour of (2), right? That seems surprising to me though since we also > use the same flags when configuring li

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-15 Thread Alexander Richardson via lldb-commits
arichardson wrote: > IIUC, the build that encountered issues in this patch ([in the comment > above](https://github.com/llvm/llvm-project/pull/115380#issuecomment-2590801533)) > is a flavour of (2), right? That seems surprising to me though since we also > use the same flags when configuring l

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,134 @@ +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class StepUntilTestCase(TestBase): jimingham wrote: Do you need to rename this? It's the same as the test cla

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-15 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: Great, thanks! Hopefully someone can merge this? https://github.com/llvm/llvm-project/pull/120817 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-15 Thread Louis Dionne via lldb-commits
ldionne wrote: IIUC, the build that encountered issues in this patch ([in the comment above](https://github.com/llvm/llvm-project/pull/115380#issuecomment-2590801533)) is a flavour of (2), right? That seems surprising to me though since we also use the same flags when configuring libc++: http

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-15 Thread via lldb-commits
@@ -859,7 +859,9 @@ SBError SBThread::StepOverUntil(lldb::SBFrame &sb_frame, addr_t step_addr = sc.line_entry.range.GetBaseAddress().GetLoadAddress(target); if (step_addr != LLDB_INVALID_ADDRESS) { -if (fun_range.ContainsLoadAddress(step_addr, targ

[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)

2025-01-15 Thread via lldb-commits
https://github.com/jimingham approved this pull request. That looks better. The one functional change - not telling a bunch of threads to set themselves up for running when we know they aren't going to get to run - is better behavior, and I can't see how it would cause problems. https://githu

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,161 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-15 Thread via lldb-commits
@@ -0,0 +1,161 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/123089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-15 Thread Michael Buch via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-15 Thread Michael Buch via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [LLDB] Make the thread list for SBSaveCoreOptions iterable (PR #122541)

2025-01-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/122541 >From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 10 Jan 2025 14:26:10 -0800 Subject: [PATCH 1/8] Make the thread list for SBSaveCoreOptions iterable --- ll

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-15 Thread Pavel Labath via lldb-commits
@@ -377,7 +377,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const DWARFDIE &die) { break; case DW_AT_object_pointer: - object_pointer = form_value.Reference(); + // GetAttributes follows DW_AT_specification. + // DW_TAG_subprogram defini

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Michael Buch via lldb-commits
@@ -401,12 +399,28 @@ static CompilerContext GetContextEntry(DWARFDIE die) { return ctx(CompilerContextKind::Typedef); case DW_TAG_base_type: return ctx(CompilerContextKind::Builtin); + case DW_TAG_class_type: + case DW_TAG_structure_type: + case DW_TAG_union_type:

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes In https://github.com/llvm/llvm-project/pull/122742 we will start attaching DW_AT_object_pointer to method declarations (in addition to definitions). Currently when LLDB parses a `DW_TAG_subprogram` defini

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/123089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/123089 In https://github.com/llvm/llvm-project/pull/122742 we will start attaching DW_AT_object_pointer to method declarations (in addition to definitions). Currently when LLDB parses a `DW_TAG_subprogram` definiti

[Lldb-commits] [lldb] [WIP][RFC][lldb] faster indexing (PR #122128)

2025-01-15 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/122128 >From f6aee6ad61745e20079d7d56a643dc61a49132b8 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 8 Jan 2025 15:27:30 + Subject: [PATCH] faster indexing --- .../Plugins/SymbolFile/DWARF/DWARFUnit.h

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Pavel Labath via lldb-commits
@@ -401,12 +399,28 @@ static CompilerContext GetContextEntry(DWARFDIE die) { return ctx(CompilerContextKind::Typedef); case DW_TAG_base_type: return ctx(CompilerContextKind::Builtin); + case DW_TAG_class_type: + case DW_TAG_structure_type: + case DW_TAG_union_type:

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Michael Buch via lldb-commits
@@ -401,12 +399,28 @@ static CompilerContext GetContextEntry(DWARFDIE die) { return ctx(CompilerContextKind::Typedef); case DW_TAG_base_type: return ctx(CompilerContextKind::Builtin); + case DW_TAG_class_type: + case DW_TAG_structure_type: + case DW_TAG_union_type:

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Pavel Labath via lldb-commits
@@ -401,12 +399,28 @@ static CompilerContext GetContextEntry(DWARFDIE die) { return ctx(CompilerContextKind::Typedef); case DW_TAG_base_type: return ctx(CompilerContextKind::Builtin); + case DW_TAG_class_type: + case DW_TAG_structure_type: + case DW_TAG_union_type:

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/123054 >From 1aff68c333c9a12a4b67cca717eba6d96d4afb5a Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 20 Nov 2024 14:37:37 +0100 Subject: [PATCH 1/3] [lldb] Fix lookup of types in anonymous namespaces with -gsim

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Pavel Labath via lldb-commits
@@ -376,7 +378,8 @@ lldb_private::Type *DWARFDIE::ResolveTypeUID(const DWARFDIE &die) const { return nullptr; } -static CompilerContext GetContextEntry(DWARFDIE die) { +static CompilerContext GetContextEntry(DWARFDIE die, + bool complet

[Lldb-commits] [lldb] 3986cff - [lldb] Add OpenBSD signals (#123005)

2025-01-15 Thread via lldb-commits
Author: Brad Smith Date: 2025-01-15T11:03:33-05:00 New Revision: 3986cffe81128061b774c06d0ba42ff7340f2d76 URL: https://github.com/llvm/llvm-project/commit/3986cffe81128061b774c06d0ba42ff7340f2d76 DIFF: https://github.com/llvm/llvm-project/commit/3986cffe81128061b774c06d0ba42ff7340f2d76.diff LO

[Lldb-commits] [lldb] [lldb] Add OpenBSD signals (PR #123005)

2025-01-15 Thread Brad Smith via lldb-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/123005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/123054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/123054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/123054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/123054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Michael Buch via lldb-commits
@@ -5,6 +5,13 @@ struct Outer { struct Inner {}; }; +namespace NS { +namespace { +template struct Struct {}; +} // namespace +} // namespace NS + int main() { Outer::Inner oi; + NS::Struct ns_struct; Michael137 wrote: Just for test completeness, could

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Michael Buch via lldb-commits
@@ -401,12 +399,28 @@ static CompilerContext GetContextEntry(DWARFDIE die) { return ctx(CompilerContextKind::Typedef); case DW_TAG_base_type: return ctx(CompilerContextKind::Builtin); + case DW_TAG_class_type: + case DW_TAG_structure_type: + case DW_TAG_union_type:

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Michael Buch via lldb-commits
@@ -376,7 +378,8 @@ lldb_private::Type *DWARFDIE::ResolveTypeUID(const DWARFDIE &die) const { return nullptr; } -static CompilerContext GetContextEntry(DWARFDIE die) { +static CompilerContext GetContextEntry(DWARFDIE die, + bool complet

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/123054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix lookup of types in anonymous namespaces with -gsimple-template-names (PR #123054)

2025-01-15 Thread Pavel Labath via lldb-commits
@@ -2740,18 +2738,11 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query, TypeResults &results) { // Copy our match's context and update the basename we are looking for // so we can use this only to compare the context correctly. m_index->GetTypesWithQu

  1   2   >