[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-08-02 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: tbh my first reaction to this "no instruction stepping feature in hardware" is -- in addition to tracking the Thread::GetTemporaryResumeState(), if I tracked the pc that the thread was at when it resumed, I could tell if it has advanced (so someone has instruction stepped T

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior (PR #96260)

2024-08-02 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I had to work on some other things the past couple of weeks but got back to this for a bit this afternoon. Wanted to add a quick update of where things are. There were five debuginfo dexter tests that failed on ubuntu and dwarf5. I can reproduce these (or at least four

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/101770 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 34766d0 - [LLDB][SBSaveCore] Fix bug where default values are not propagated. (#101770)

2024-08-02 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-08-02T18:38:05-07:00 New Revision: 34766d0d488ba2fbefa80dcd0cc8720a0e753448 URL: https://github.com/llvm/llvm-project/commit/34766d0d488ba2fbefa80dcd0cc8720a0e753448 DIFF: https://github.com/llvm/llvm-project/commit/34766d0d488ba2fbefa80dcd0cc8720a0e753448.diff

[Lldb-commits] [lldb] [WIP] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/101778 >From 3d7c2b87ec73a48de30e1c5387a7f0d8d817b0f4 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 2 Aug 2024 23:38:18 +0100 Subject: [PATCH 1/2] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemMo

[Lldb-commits] [lldb] [WIP] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/101778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/101778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/101778 This patch addresses an issue that will arise with future SDKs. The ClangExpressionParser currently unconditionally sets `-fbuiltin-headers-in-system-modules` when evaluating expressions with the `target.im

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-02 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/101770 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/101770 >From 11f8323bb40a537161c76b89d564c9ae96888d01 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 2 Aug 2024 15:44:17 -0700 Subject: [PATCH 1/4] Create copies in both minidump and mach-o so we can set a de

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/101770 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/101770 >From 11f8323bb40a537161c76b89d564c9ae96888d01 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 2 Aug 2024 15:44:17 -0700 Subject: [PATCH 1/4] Create copies in both minidump and mach-o so we can set a de

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/101770 >From 11f8323bb40a537161c76b89d564c9ae96888d01 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 2 Aug 2024 15:44:17 -0700 Subject: [PATCH 1/4] Create copies in both minidump and mach-o so we can set a de

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-02 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Might actually be nice to make the SaveCoreOptions non const. Why? Because clients could see what the settings were set to if a plug-in modifies or overrides certain settings. https://github.com/llvm/llvm-project/pull/101770 __

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1ae837ab34424a0b81bcc9a4fabc89e36cd57235 9d105b25b2e0721d68db8dca60cb155d233d0933 --e

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 1ae837ab34424a0b81bcc9a4fabc89e36cd57235...9d105b25b2e0721d68db8dca60cb155d233d0933 lldb/

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes In #100443, Mach-o and Minidump now only call process API's that take a `SaveCoreOption` as the container for the style and information if a thread should be included in the core or not. This introduced a bu

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/101770 In #100443, Mach-o and Minidump now only call process API's that take a `SaveCoreOption` as the container for the style and information if a thread should be included in the core or not. This introduced a bug w

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @Michael137 Has Green Dragon been down for awhile? I did break this test, but it looks like it was about [a month ago](https://github.com/llvm/llvm-project/commit/47d80ec1802d70082c8fd32b4396c98db2c4dba2#diff-96c5fb7a96b37c4401faaef482eaf8d4e1ecd38d49a1ff8eb96d361b0dfa24b9R6442).

[Lldb-commits] [clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-08-02 Thread Justin Bogner via lldb-commits
https://github.com/bogner approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/97362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/101669 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 12e3a06 - [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (#101669)

2024-08-02 Thread via lldb-commits
Author: Michael Buch Date: 2024-08-02T22:27:40+01:00 New Revision: 12e3a06cb7615fbd91031420f3dec2a85d7877d6 URL: https://github.com/llvm/llvm-project/commit/12e3a06cb7615fbd91031420f3dec2a85d7877d6 DIFF: https://github.com/llvm/llvm-project/commit/12e3a06cb7615fbd91031420f3dec2a85d7877d6.diff

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @Michael137 ack, I'll make a fix https://github.com/llvm/llvm-project/pull/100443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Michael Buch via lldb-commits
Michael137 wrote: Looks like this broke the macOS buildbots: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/8988/execution/node/97/log/ ``` FAIL: LLDB (/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/lldb-build/bin/clang-arm64) :: test_lc_note_dsym (TestSkinnyCore

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/100443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3e4af61 - [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (#100443)

2024-08-02 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-08-02T13:35:05-07:00 New Revision: 3e4af616334eae532f308605b89ff158dd195180 URL: https://github.com/llvm/llvm-project/commit/3e4af616334eae532f308605b89ff158dd195180 DIFF: https://github.com/llvm/llvm-project/commit/3e4af616334eae532f308605b89ff158dd195180.diff

[Lldb-commits] [lldb] [lldb/test] Add test for the `scripting template list` command (PR #101726)

2024-08-02 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,42 @@ +# REQUIRES: python +# RUN: %lldb -s %s -o exit | FileCheck %s + +scripting template list +# CHECK:Available scripted extension templates: + +# CHECK: Name: OperatingSystemPythonInterface +# CHECK-NEXT: Language: Python +# CHECK-NEXT: Description: Mock thread s

[Lldb-commits] [lldb] [lldb] Don't crash when attaching to pid and no binaries found (PR #100287)

2024-08-02 Thread Rose Silicon via lldb-commits
RSilicon wrote: Should this be backported to 19.x? https://github.com/llvm/llvm-project/pull/100287 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 01/14] Implemplement a thread list that is currently unused for

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/101669 >From a4518719a09ef2910209663c62544dc5797f2df7 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 2 Aug 2024 13:48:18 +0100 Subject: [PATCH 1/5] [lldb][ClangExpressionParser][NFC] Factor LangOptions logi

[Lldb-commits] [lldb] ObjectFileJSON and Section changes to support section.address field i… (PR #101062)

2024-08-02 Thread Ilhan Raja via lldb-commits
YungRaj wrote: > > > I was hoping to fix everything in one Pull Request so that it at least > > > becomes usable once this merges. > > > > > > The LLVM project generally > > [prefers](https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity) > > smaller patches as they're eas

[Lldb-commits] [lldb] 737c387 - [lldb/test] Add test for the `scripting template list` command (#101726)

2024-08-02 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-08-02T11:20:39-07:00 New Revision: 737c387f8be15cf3d6004d3f58a3ce5763f7f9e8 URL: https://github.com/llvm/llvm-project/commit/737c387f8be15cf3d6004d3f58a3ce5763f7f9e8 DIFF: https://github.com/llvm/llvm-project/commit/737c387f8be15cf3d6004d3f58a3ce5763f7f9e8.

[Lldb-commits] [lldb] [lldb/test] Add test for the `scripting template list` command (PR #101726)

2024-08-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/101726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. Do the variable rename and all good https://github.com/llvm/llvm-project/pull/100443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/100443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Greg Clayton via lldb-commits
@@ -32,13 +33,25 @@ class SaveCoreOptions { void SetOutputFile(lldb_private::FileSpec file); const std::optional GetOutputFile() const; + Status SetProcess(lldb::ProcessSP process_sp); + + Status AddThread(lldb::ThreadSP thread_sp); + bool RemoveThread(lldb::ThreadSP th

[Lldb-commits] [lldb] [lldb/test] Add test for the `scripting template list` command (PR #101726)

2024-08-02 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,42 @@ +# REQUIRES: python +# RUN: %lldb -s %s -o exit | FileCheck %s + +scripting template list +# CHECK:Available scripted extension templates: + +# CHECK: Name: OperatingSystemPythonInterface +# CHECK-NEXT: Language: Python +# CHECK-NEXT: Description: Mock thread s

[Lldb-commits] [lldb] [lldb/test] Add test for the `scripting template list` command (PR #101726)

2024-08-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/101726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (PR #101697)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/101697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5c1d768 - [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (#101697)

2024-08-02 Thread via lldb-commits
Author: Michael Buch Date: 2024-08-02T19:13:41+01:00 New Revision: 5c1d7689738d144613e7915c0b6ec850dd5c3956 URL: https://github.com/llvm/llvm-project/commit/5c1d7689738d144613e7915c0b6ec850dd5c3956 DIFF: https://github.com/llvm/llvm-project/commit/5c1d7689738d144613e7915c0b6ec850dd5c3956.diff

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 01/13] Implemplement a thread list that is currently unused for

[Lldb-commits] [lldb] 1fcddc0 - [lldb] Fix a warning

2024-08-02 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2024-08-02T11:10:21-07:00 New Revision: 1fcddc0dfa1b371bc0b278438d5f47cf8d03b511 URL: https://github.com/llvm/llvm-project/commit/1fcddc0dfa1b371bc0b278438d5f47cf8d03b511 DIFF: https://github.com/llvm/llvm-project/commit/1fcddc0dfa1b371bc0b278438d5f47cf8d03b511.diff L

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Jacob Lalonde via lldb-commits
@@ -9,6 +9,8 @@ #include "lldb/API/SBSaveCoreOptions.h" #include "lldb/API/SBError.h" #include "lldb/API/SBFileSpec.h" +#include "lldb/API/SBProcess.h" +#include "lldb/API/SBThread.h" Jlalond wrote: Followed up offline, Greg was correct and it was proper to mo

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 01/12] Implemplement a thread list that is currently unused for

[Lldb-commits] [lldb] [lldb/test] Add test for the `scripting template list` command (PR #101726)

2024-08-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/101726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/test] Add test for the `scripting template list` command (PR #101726)

2024-08-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/101726 >From 3c3ed4f115a38ea4aed4901724caa5da2512a754 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Fri, 2 Aug 2024 11:05:43 -0700 Subject: [PATCH] [lldb/test] Add test for the `scripting template list`

[Lldb-commits] [lldb] [lldb/test] Add test for the `scripting template list` command (PR #101726)

2024-08-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/101726 >From d7242816f18d7b71013f60dfdbb0ddfa0af77e04 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Fri, 2 Aug 2024 11:04:07 -0700 Subject: [PATCH] [lldb/test] Add test for the `scripting template list`

[Lldb-commits] [lldb] [lldb/test] Add test for the `scripting template list` command (PR #101726)

2024-08-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch adds a shell test to verify the output of the `scripting template list` command. --- Full diff: https://github.com/llvm/llvm-project/pull/101726.diff 1 Files Affected: - (added) lldb/

[Lldb-commits] [lldb] [lldb/test] Add test for the `scripting template list` command (PR #101726)

2024-08-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/101726 This patch adds a shell test to verify the output of the `scripting template list` command. >From 52c63b228e903e1a4850f8cc172c9a7c929f7e40 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Fri, 2 Au

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/101669 >From a4518719a09ef2910209663c62544dc5797f2df7 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 2 Aug 2024 13:48:18 +0100 Subject: [PATCH 1/4] [lldb][ClangExpressionParser][NFC] Factor LangOptions logi

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

2024-08-02 Thread Jacob Lalonde via lldb-commits
@@ -9,6 +9,8 @@ #include "lldb/API/SBSaveCoreOptions.h" #include "lldb/API/SBError.h" #include "lldb/API/SBFileSpec.h" +#include "lldb/API/SBProcess.h" +#include "lldb/API/SBThread.h" Jlalond wrote: They're actually not right now, all the SB classes are forwar

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor out TargetOpts logic out of ClangExpressionParser (PR #101681)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/101681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d6cbcf9 - [lldb][ClangExpressionParser][NFC] Factor out TargetOpts logic out of ClangExpressionParser (#101681)

2024-08-02 Thread via lldb-commits
Author: Michael Buch Date: 2024-08-02T18:13:35+01:00 New Revision: d6cbcf93b227befaad00957a56acd63c837c26ff URL: https://github.com/llvm/llvm-project/commit/d6cbcf93b227befaad00957a56acd63c837c26ff DIFF: https://github.com/llvm/llvm-project/commit/d6cbcf93b227befaad00957a56acd63c837c26ff.diff

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (PR #101697)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/101697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (PR #101697)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/101697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (PR #101697)

2024-08-02 Thread Michael Buch via lldb-commits
@@ -465,18 +465,24 @@ ClangExpressionParser::ClangExpressionParser( // A value of 0 means no limit for both LLDB and Clang. m_compiler->getDiagnostics().setErrorLimit(target_sp->GetExprErrorLimit()); - auto target_info = TargetInfo::CreateTargetInfo( - m_compiler->ge

[Lldb-commits] [lldb] c6ce324 - [lldb] Eliminate more Targer* in favor of Target& in CommandObjects (NFC)

2024-08-02 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-08-02T09:53:34-07:00 New Revision: c6ce324fa7fb2438b945fa1205b2a23138327e83 URL: https://github.com/llvm/llvm-project/commit/c6ce324fa7fb2438b945fa1205b2a23138327e83 DIFF: https://github.com/llvm/llvm-project/commit/c6ce324fa7fb2438b945fa1205b2a23138327e83.d

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (PR #101697)

2024-08-02 Thread Adrian Prantl via lldb-commits
@@ -465,18 +465,24 @@ ClangExpressionParser::ClangExpressionParser( // A value of 0 means no limit for both LLDB and Clang. m_compiler->getDiagnostics().setErrorLimit(target_sp->GetExprErrorLimit()); - auto target_info = TargetInfo::CreateTargetInfo( - m_compiler->ge

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (PR #101697)

2024-08-02 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/101697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/101669 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Michael Buch via lldb-commits
@@ -615,6 +484,147 @@ ClangExpressionParser::ClangExpressionParser( // 'fopen'). Those libc functions are already correctly handled by LLDB, and // additionally enabling them as expandable builtins is breaking Clang. lang_opts.NoBuiltin = true; +} + +static void SetupImpo

[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (PR #101672)

2024-08-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/101672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9d07f43 - Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (#101672)

2024-08-02 Thread via lldb-commits
Author: David Spickett Date: 2024-08-02T08:55:26-07:00 New Revision: 9d07f43676f03460d913aabd503ae8154cabdda1 URL: https://github.com/llvm/llvm-project/commit/9d07f43676f03460d913aabd503ae8154cabdda1 DIFF: https://github.com/llvm/llvm-project/commit/9d07f43676f03460d913aabd503ae8154cabdda1.diff

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/101669 >From a4518719a09ef2910209663c62544dc5797f2df7 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 2 Aug 2024 13:48:18 +0100 Subject: [PATCH 1/4] [lldb][ClangExpressionParser][NFC] Factor LangOptions logi

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (PR #101697)

2024-08-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes `CreateTargetInfo` can return a `nullptr` in a couple cases. So we should log that and let the user know something is wrong (hence the `lldbassert`). I didn't actually run into this. Just stumbled upon it

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (PR #101697)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/101697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (PR #101697)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/101697 `CreateTargetInfo` can return a `nullptr` in a couple cases. So we should log that and let the user know something is wrong (hence the `lldbassert`). >From 6dd59090c0098c18d38629fa1030122b0edffa88 Mon Sep 17

[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (PR #101672)

2024-08-02 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: Sounds good, I'll merge it and add the test. If the bot fails for whatever reason, I'll revert it. Thanks! https://github.com/llvm/llvm-project/pull/101672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (PR #101672)

2024-08-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: I'm not going to merge this myself as I'm finishing for the week, but you can if you want to get that test added sooner. https://github.com/llvm/llvm-project/pull/101672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Adrian Prantl via lldb-commits
@@ -615,6 +484,147 @@ ClangExpressionParser::ClangExpressionParser( // 'fopen'). Those libc functions are already correctly handled by LLDB, and // additionally enabling them as expandable builtins is breaking Clang. lang_opts.NoBuiltin = true; +} + +static void SetupImpo

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/101669 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -351,136 +352,32 @@ static void SetupDefaultClangDiagnostics(CompilerInstance &compiler) { } } -//===--===// -// Implementation of ClangExpressionParser -//===

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/101669 >From a4518719a09ef2910209663c62544dc5797f2df7 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 2 Aug 2024 13:48:18 +0100 Subject: [PATCH 1/3] [lldb][ClangExpressionParser][NFC] Factor LangOptions logi

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor out TargetOpts logic out of ClangExpressionParser (PR #101681)

2024-08-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Same motivation as https://github.com/llvm/llvm-project/pull/101669. We plan to eventually use the Clang driver to initialize the `CompilerInstance`. This should make refactorings of this code more straigh

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor out TargetOpts logic out of ClangExpressionParser (PR #101681)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/101681 Same motivation as https://github.com/llvm/llvm-project/pull/101669. We plan to eventually use the Clang driver to initialize the `CompilerInstance`. This should make refactorings of this code more straightf

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/101669 >From a4518719a09ef2910209663c62544dc5797f2df7 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 2 Aug 2024 13:48:18 +0100 Subject: [PATCH 1/2] [lldb][ClangExpressionParser][NFC] Factor LangOptions logi

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Michael Buch via lldb-commits
@@ -551,42 +448,14 @@ ClangExpressionParser::ClangExpressionParser( if (expr.DesiredResultType() == Expression::eResultTypeId) lang_opts.DebuggerCastResultToId = true; - lang_opts.CharIsSigned = ArchSpec(m_compiler->getTargetOpts().Triple.c_str()) -

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/101669 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (PR #101672)

2024-08-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: I tried making lldb-pthon.h the literal first include of the file but this doesn't work. When it gets to SWIGPythonBridge.h the redefinition happens again, no idea why, I'd think NO_PID_T would still be defined. https://github.com/llvm/llvm-project/pull/101672

[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (PR #101672)

2024-08-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This reverts commit 9effefbae8d96006a4dd29bb9ab8532fd408559d. With the include order in ScriptedProcessPythonInterface.cpp fixed (though I cannot explain exactly why it works) and removes the /H flag

[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (PR #101672)

2024-08-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/101672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows build issue (PR #101672)

2024-08-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/101672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb] Reland 2402b3213c2f with `/H` to debug the windows bui… (PR #101672)

2024-08-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/101672 …ld issue" This reverts commit 9effefbae8d96006a4dd29bb9ab8532fd408559d. With the include order in ScriptedProcessPythonInterface.cpp fixed (though I cannot explain exactly why it works) and removes the

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes We plan to eventually use the Clang driver to initialize the `CompilerInstance`. This should make refactorings of this code more straightforward. --- Full diff: https://github.com/llvm/llvm-project/pull/10

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

2024-08-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/101669 We plan to eventually use the Clang driver to initialize the `CompilerInstance`. This should make refactorings of this code more straightforward. >From a4518719a09ef2910209663c62544dc5797f2df7 Mon Sep 17 00:

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-08-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: What did you intend with `/H`? If anything it would be https://learn.microsoft.com/en-us/cpp/build/reference/h-restrict-length-of-external-names?view=msvc-170 but clang-cl doesn't support this one. (yes, the bot uses clang-cl, we really should change the name) https://git

[Lldb-commits] [lldb] 3c3851f - [lldb][test][x86_64][win] Split assertion in TestBreakpointConditions (#100487)

2024-08-02 Thread via lldb-commits
Author: Kendal Harland Date: 2024-08-02T10:03:39+01:00 New Revision: 3c3851f3ed837aaae7df76e9a4cbb866dbfee3ac URL: https://github.com/llvm/llvm-project/commit/3c3851f3ed837aaae7df76e9a4cbb866dbfee3ac DIFF: https://github.com/llvm/llvm-project/commit/3c3851f3ed837aaae7df76e9a4cbb866dbfee3ac.diff

[Lldb-commits] [lldb] [lldb][test][x86_64][win] Split assertion in TestBreakpointConditions (PR #100487)

2024-08-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/100487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][x86_64][win] Split assertion in TestBreakpointConditions (PR #100487)

2024-08-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/100487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits