@@ -255,6 +256,8 @@ class LLDB_API SBThread {
lldb::ExecutionContextRefSP m_opaque_sp;
+ lldb::ThreadSP get_sp() const;
clayborg wrote:
Rename to GetSP to match what is in SBProcess. I saw code below that calls
these accessors in lldb/source/API/SBSaveCo
@@ -46,8 +48,83 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) {
+ Status error;
+ if (!process_sp) {
+ClearProcessSpecificData();
+m_process_sp.reset();
+return error;
+ }
+
+ if (
@@ -10,6 +10,7 @@
#define LLDB_API_SBSAVECOREOPTIONS_H
#include "lldb/API/SBDefines.h"
+#include "lldb/API/SBThread.h"
clayborg wrote:
probably should include SBProcess.h here as well since we are using it.
https://github.com/llvm/llvm-project/pull/100443
__
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/100443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -9,6 +9,8 @@
#include "lldb/API/SBSaveCoreOptions.h"
#include "lldb/API/SBError.h"
#include "lldb/API/SBFileSpec.h"
+#include "lldb/API/SBProcess.h"
+#include "lldb/API/SBThread.h"
clayborg wrote:
remove these, they are in the `SBSaveCoreOptions.h` header f
https://github.com/clayborg commented:
Code looks fine to me now. I will let Pavel give the final OK as I don't know
much about the YAML layering in LLVM.
https://github.com/llvm/llvm-project/pull/101272
___
lldb-commits mailing list
lldb-commits@list
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/101237
>From f0cd3ef613b2da145b14a3d79d6810cc19e9b198 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 30 Jul 2024 13:37:44 -0700
Subject: [PATCH 1/4] Impove ObjectFileELF's .dynamic parsing and usage.
This pat
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/101130
>From 55b1ac1fbad89ebc50038738c1e09045e9884be8 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 29 Jul 2024 22:37:43 -0700
Subject: [PATCH 1/4] [lldb] Change Module to have a concrete UnwindTable,
u
https://github.com/dzhidzhoev approved this pull request.
https://github.com/llvm/llvm-project/pull/100487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/101365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/101237
>From f0cd3ef613b2da145b14a3d79d6810cc19e9b198 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Tue, 30 Jul 2024 13:37:44 -0700
Subject: [PATCH 1/3] Impove ObjectFileELF's .dynamic parsing and usage.
This pat
@@ -384,6 +392,9 @@ class ObjectFileELF : public lldb_private::ObjectFile {
/// ELF dependent module dump routine.
void DumpDependentModules(lldb_private::Stream *s);
+ /// ELF dump the .dynamic section
+ void DumpELFDynamic(lldb_private::Stream *s);
cla
@@ -0,0 +1,58 @@
+// REQUIRES: system-linux, native
clayborg wrote:
Adding support for memory ELF files is my primary concern with this patch as
you know. Testing that in memory ELF files work as well as they can and that we
can find the DT_DEBUG is the primary
@@ -3704,3 +3790,83 @@ ObjectFileELF::MapFileDataWritable(const FileSpec &file,
uint64_t Size,
return FileSystem::Instance().CreateWritableDataBuffer(file.GetPath(), Size,
Offset);
}
+
+std::optional ObjectFileELF::Get
@@ -3664,7 +3730,27 @@ llvm::ArrayRef
ObjectFileELF::ProgramHeaders() {
}
DataExtractor ObjectFileELF::GetSegmentData(const ELFProgramHeader &H) {
- return DataExtractor(m_data, H.p_offset, H.p_filesz);
+ // Try and read the program header from our cached m_data which can c
https://github.com/JDevlieghere approved this pull request.
LGTM if @medismailben is happy!
https://github.com/llvm/llvm-project/pull/101365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
@@ -2570,6 +2570,18 @@ void PruneThreadPlans();
/// information related to the process.
virtual StructuredData::DictionarySP GetMetadata() { return nullptr; }
+ /// Fetch extended crash information held by the process. This will never be
+ /// an empty shared pointe
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/101365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/101272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kendalharland wrote:
Hi @JDevlieghere, friendly reminder to PTAL when you can.
https://github.com/llvm/llvm-project/pull/100487
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/101383
>From 9c5005d9f28bf1419250a3b3d0d2f5e2ab34b58d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 31 Jul 2024 22:02:53 +0400
Subject: [PATCH] [lldb] Added Pipe::WriteWithTimeout()
Fixed few bugs in Pipe
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101272
>From 78ab13e3da15832117a7e2f8f85090a63482ca41 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 30 Jul 2024 11:04:45 -0700
Subject: [PATCH 1/8] Squash 64b-memory-regions-minidump and take only
llvm-chang
https://github.com/damyanp approved this pull request.
https://github.com/llvm/llvm-project/pull/97362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I don't know, it never occurred to me to do so before now. @omjavaid mentioned
it so maybe he knows something about it.
https://github.com/llvm/llvm-project/pull/100710
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
DavidSpickett wrote:
Looks good to me. @labath should give this another look as the biggest skeptic
here :)
And @JDevlieghere who was also tagged earlier (start with the RFC though
https://discourse.llvm.org/t/rfc-lldb-support-remote-run-of-shell-tests/80072).
https://github.com/llvm/llvm-pro
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/101383
>From f88510ee4ae348b62550d785d3efaa4a4a7ee050 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 31 Jul 2024 22:02:53 +0400
Subject: [PATCH] [lldb] Added Pipe::WriteWithTimeout()
Fixed few bugs in Pipe
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/95986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -244,6 +244,7 @@ llvm_canonicalize_cmake_booleans(
LLVM_ENABLE_ZLIB
LLVM_ENABLE_SHARED_LIBS
LLDB_HAS_LIBCXX
+ LLDB_SHELL_TESTS_DISABLE_REMOTE
DavidSpickett wrote:
It would be good to declare this and the other new options in CMake with
docstrings so
Michael137 wrote:
> Yeah, won't work with link.exe, so I've just disabled it. Nothing more for
> you to do here.
Awesome, thanks for the fix!
Out of curiosity, what's stopping us from using `lld` on Windows?
https://github.com/llvm/llvm-project/pull/100710
@@ -4,16 +4,16 @@
target create -l "ls" /bin/ls
target list
-# CHECK: * target #0 (ls): /bin/ls
+# CHECK: * target #0 (ls): [[LS_PATH:.*]]
dzhidzhoev wrote:
Sorry, I was wrong here.
`target create` command accepts remote path. But `target list` prints full p
slydiman wrote:
@labath
Note I have updated PipeTest.OpenAsReader. The behavior of the creating named
pipe is different on Windows and Posix.
PipePosix calls mkfifo() and does not open the pipe. But PipeWindows really
creates the pipe, which is already opened for read and write. Currently lldb
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/101383
>From 459303737e728a2cda683eb73f46763661126efa Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 31 Jul 2024 22:02:53 +0400
Subject: [PATCH] [lldb] Added Pipe::WriteWithTimeout()
Fixed few bugs in Pipe
dzhidzhoev wrote:
> Though another way of thinking about it might be, I have a custom compiler
> setup but only intend to do host testing. This variable lets me tell the test
> runner not to assume I'm going to do any remote testing?
Yes, considering only Shell tests. By default, host testing
DavidSpickett wrote:
Ok, that seems reasonable. I'm still in a mode of thinking where a given build
is all remote or all native. `LLDB_SHELL_TESTS_DISABLE_REMOTE` allows you to
reuse all the settings you went to the trouble to set up, but on the host not
the remote.
Though another way of thin
@@ -22,6 +25,60 @@ def _disallow(config, execName):
config.substitutions.append((" {0} ".format(execName),
warning.format(execName)))
+def get_lldb_args(config, suffix=""):
+lldb_args = []
+if "remote-linux" in config.available_features:
+lldb_args += [
+
dzhidzhoev wrote:
> Ok I see what `LLDB_SHELL_TESTS_DISABLE_REMOTE` does but I don't get why.
> Perhaps you can show how a developer would:
>
> * Hit the problem that this option addresses
> * Apply the option
> * What problems it would solve and what that final build looks like
> * What the va
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From b747d2cf8d648e0dadda4adaaf2e0ef41d4ebd34 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH 1/5] [lldb][test] Support remote run of Shell tests
1.
DavidSpickett wrote:
> If you have a recent build of lldb on windows (with python enabled), could
> you run the scripting template list command and paste the output here.
As of 229a16590a3cd65da77bb868498d3eed63bf6263:
```
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build>.\bin\lldb.exe
(lld
DavidSpickett wrote:
Yeah, won't work with link.exe, so I've just disabled it. Nothing more for you
to do here.
https://github.com/llvm/llvm-project/pull/100710
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
Author: David Spickett
Date: 2024-08-01T12:59:49Z
New Revision: 229a16590a3cd65da77bb868498d3eed63bf6263
URL:
https://github.com/llvm/llvm-project/commit/229a16590a3cd65da77bb868498d3eed63bf6263
DIFF:
https://github.com/llvm/llvm-project/commit/229a16590a3cd65da77bb868498d3eed63bf6263.diff
LOG
DavidSpickett wrote:
I'm going to look into this now.
https://github.com/llvm/llvm-project/pull/100710
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/100670
>From 7fb5b2ee53f3125dc2b93cb6fba28b35c70b70e1 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 25 Jul 2024 00:34:34 +0400
Subject: [PATCH 1/2] [lldb] Multithreading lldb-server works on Windows now;
medismailben wrote:
Hey @DavidSpickett! Thanks for the help! I don't have a system to try this on
and it only fails on windows :/
> Actually I'm looking at old results, the latest build makes it to tests
> https://lab.llvm.org/buildbot/#/builders/141/builds/1285 (which fail for
> reasons unre
DavidSpickett wrote:
Ok I see what `LLDB_SHELL_TESTS_DISABLE_REMOTE` does but I don't get why.
Perhaps you can show how a developer would:
* Hit the problem that this option addresses
* Apply the option
* What problems it would solve and what that final build looks like
* What the value of the r
@@ -22,6 +25,60 @@ def _disallow(config, execName):
config.substitutions.append((" {0} ".format(execName),
warning.format(execName)))
+def get_lldb_args(config, suffix=""):
+lldb_args = []
+if "remote-linux" in config.available_features:
+lldb_args += [
+
@@ -22,6 +25,60 @@ def _disallow(config, execName):
config.substitutions.append((" {0} ".format(execName),
warning.format(execName)))
+def get_lldb_args(config, suffix=""):
+lldb_args = []
+if "remote-linux" in config.available_features:
+lldb_args += [
+
@@ -2,6 +2,8 @@
# RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands false'
-s %S/Inputs/EchoCommandsTest.in | FileCheck
%S/Inputs/EchoCommandsNoComments.out
# RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false'
-s %S/Inputs/EchoCommand
@@ -2,6 +2,8 @@
# RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands false'
-s %S/Inputs/EchoCommandsTest.in | FileCheck
%S/Inputs/EchoCommandsNoComments.out
# RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false'
-s %S/Inputs/EchoCommand
DavidSpickett wrote:
Thanks for your efforts @kendalharland. If you think any of these details are
worth documenting (https://lldb.llvm.org/index.html), please do so. The page
sources are in `lldb/docs`.
https://github.com/llvm/llvm-project/pull/100477
_
DavidSpickett wrote:
Actually I'm looking at old results, the latest build makes it to tests
https://lab.llvm.org/buildbot/#/builders/141/builds/1285 (which fail for
reasons unrelated to this patch).
https://github.com/llvm/llvm-project/pull/97273
__
DavidSpickett wrote:
I thought I saw that fixed once already, but perhaps that was just a full
revert.
We (Linaro) can test a patch for you if it's fiddly to verify, we just need to
know the general idea of it.
https://github.com/llvm/llvm-project/pull/97273
__
https://github.com/DimitryAndric closed
https://github.com/llvm/llvm-project/pull/101403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dimitry Andric
Date: 2024-08-01T09:28:29+02:00
New Revision: 7088a5ed880f29129ec844c66068e8cb61ca98bf
URL:
https://github.com/llvm/llvm-project/commit/7088a5ed880f29129ec844c66068e8cb61ca98bf
DIFF:
https://github.com/llvm/llvm-project/commit/7088a5ed880f29129ec844c66068e8cb61ca98bf.diff
https://github.com/YungRaj edited
https://github.com/llvm/llvm-project/pull/101062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
54 matches
Mail list logo
