medismailben wrote:

Hey @DavidSpickett! Thanks for the help! I don't have a system to try this on 
and it only fails on windows :/

> Actually I'm looking at old results, the latest build makes it to tests 
> https://lab.llvm.org/buildbot/#/builders/141/builds/1285 (which fail for 
> reasons unrelated to this patch).

My patch has already been reverted in 9effefbae8d96006a4dd29bb9ab8532fd408559d 
and the failure you're talking about was introduced in #100710. I believe 
@Michael137 is trying to fix it.

If you have a recent build of lldb on windows (with python enabled), could you 
run the `scripting template list` command and paste the output here.

I've split this patch in smaller chunks (bccff3baeff8, ecf125eaf0b1, 
995f643f5aa7) and they've all landed without any build failure on windows 
except for 2402b3213c2f. I've noticed however that the cmake configure phase 
would produce some warnings on the bot regarding the files related to my 
changes, about the fact that they'd exceed `CMAKE_OBJECT_PATH_MAX` limit (250 
on windows apparently).

You can see it happening here : 
https://lab.llvm.org/buildbot/#/builders/141/builds/1222

```
CMake Warning in 
C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/llvm-project/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedProcessPythonInterface/CMakeLists.txt:
  The object file directory
    
C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedProcessPythonInterface/CMakeFiles/lldbPluginScriptInterpreterPythonScriptedProcessPythonInterface.dir/./
  has 227 characters.  The maximum full path to an object file is 250
  characters (see CMAKE_OBJECT_PATH_MAX).  Object file
    ScriptedProcessPythonInterface.cpp.obj
  cannot be safely placed under this directory.  The build may not work
  correctly.
```

Also, if you could re-apply e72cdae47b4e263ea97b2bdd75cf44c1510cf3be and attach 
your build log here, that would be very helpful, and hopefully help us narrow 
down the ambiguous typedef issue. 

If I'm not able to make it work on windows, I'll unfortunately have to compile 
it out of lldb for that platform, since I don't have access to a machine to 
investigate the issue further.

Thank you in advance!

https://github.com/llvm/llvm-project/pull/97273
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to