@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName &objc_method, const DWARFDIE &die,
+CompilerType clang_type, const
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -110,6 +108,9 @@ bool
StopInfoMachException::DeterminePtrauthFailure(ExecutionContext &exe_ctx) {
strm.Printf("Note: Possible pointer authentication failure detected.\n");
};
+ ABISP abi_sp = process.GetABI();
+ assert(abi_sp && "Missing ABI info");
---
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/95015
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
LGTM to avoid the UB, I wouldn't block this because of a complex existential
question.
In general though, I don't really see the point in being able to convert a
`ConstString` into a `std::string`? The whole point is that it uniques the
@@ -110,6 +108,9 @@ bool
StopInfoMachException::DeterminePtrauthFailure(ExecutionContext &exe_ctx) {
strm.Printf("Note: Possible pointer authentication failure detected.\n");
};
+ ABISP abi_sp = process.GetABI();
+ assert(abi_sp && "Missing ABI info");
---
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/95181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2024-06-11T16:41:31-07:00
New Revision: 3d86eebdf84f1c1a8ef57706c1182836176a1780
URL:
https://github.com/llvm/llvm-project/commit/3d86eebdf84f1c1a8ef57706c1182836176a1780
DIFF:
https://github.com/llvm/llvm-project/commit/3d86eebdf84f1c1a8ef57706c1182836176a1780.d
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/95181
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
…andOverrideCallback (#94518)"
This reverts commit 7cff05ada05e87408966d56b4c1675033187ff5c. The API test that
was added erroneously imports a module that isn't needed and wouldn't be found
which
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/95181
…andOverrideCallback (#94518)"
This reverts commit 7cff05ada05e87408966d56b4c1675033187ff5c. The API test that
was added erroneously imports a module that isn't needed and wouldn't be found
which causes a
Author: Miro Bucko
Date: 2024-06-12T06:21:17+07:00
New Revision: 11a4d43f4a8ed02694de4d39b5591ff2b1c31803
URL:
https://github.com/llvm/llvm-project/commit/11a4d43f4a8ed02694de4d39b5591ff2b1c31803
DIFF:
https://github.com/llvm/llvm-project/commit/11a4d43f4a8ed02694de4d39b5591ff2b1c31803.diff
LO
https://github.com/mbucko closed https://github.com/llvm/llvm-project/pull/94494
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> This PR rate limits things. Might be worth trying this out here to see if it
> helps:
>
> #75769
Will try this out, though I haven't found any major performance issues as a
result of the progress events added here. Maybe for different workloads this
could get more noticea
Author: Chelsea Cassanova
Date: 2024-06-11T15:27:10-07:00
New Revision: 7cff05ada05e87408966d56b4c1675033187ff5c
URL:
https://github.com/llvm/llvm-project/commit/7cff05ada05e87408966d56b4c1675033187ff5c
DIFF:
https://github.com/llvm/llvm-project/commit/7cff05ada05e87408966d56b4c1675033187ff5c.d
@@ -1758,6 +1759,11 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
}
if (attrs.is_forward_declaration) {
+Progress progress(llvm::formatv(
+"Parsing forward declaration {0}: {1}",
Michael137 wrote:
done
https://github
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/91452
>From d9d0e0de9d57cefc8be78efa5ba9254127c68521 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 8 May 2024 10:47:54 +0100
Subject: [PATCH 1/2] [lldb][DWARFASTParserClang] Report progress when parsing
ty
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/94518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2024-06-11T15:20:35-07:00
New Revision: 6fb6eba9304b63e86ebf039edcb9a0b32e4b39e7
URL:
https://github.com/llvm/llvm-project/commit/6fb6eba9304b63e86ebf039edcb9a0b32e4b39e7
DIFF:
https://github.com/llvm/llvm-project/commit/6fb6eba9304b63e86ebf039edcb9a0b32e4b39e7.d
@@ -1758,6 +1759,11 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
}
if (attrs.is_forward_declaration) {
+Progress progress(llvm::formatv(
+"Parsing forward declaration {0}: {1}",
adrian-prantl wrote:
It should either
clayborg wrote:
This PR rate limits things. Might be worth trying this out here to see if it
helps:
https://github.com/llvm/llvm-project/pull/75769
https://github.com/llvm/llvm-project/pull/91452
___
lldb-commits mailing list
lldb-commits@lists.llvm.
Michael137 wrote:
Decided to go with something much simpler. Currently just reporting progress in
`ParseStructureLikeDIE`, when we search for the definition DIE. Should reduce
the number of broadcasts to some extent, and once
https://github.com/llvm/llvm-project/pull/92328 lands again, it woul
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/94518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/91452
>From d9d0e0de9d57cefc8be78efa5ba9254127c68521 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 8 May 2024 10:47:54 +0100
Subject: [PATCH] [lldb][DWARFASTParserClang] Report progress when parsing
types
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/94518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
@bulbazord raised a good question: do we need this API at all?
>From a brief glance it looks like we're mainly using it for the `operator
>std::string()` conversion operator? Apart from that, there are a couple of
>other callers which probably could just use one of the C-stri
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/95175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch prevents passing a `nullptr` to the `std::string` constructor in
`GetString`. This prevents UB arising from calling `GetString` on a
default-constructed `ConstString`.
---
Full diff: https://gi
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/95175
This patch prevents passing a `nullptr` to the `std::string` constructor in
`GetString`. This prevents UB arising from calling `GetString` on a
default-constructed `ConstString`.
>From adacdee08b3d4f13be
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/95078
>From 75d1bc01ca42e327594cceba753bec483228efbd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 10 Jun 2024 17:46:31 +0100
Subject: [PATCH 1/6] [lldb][DWARFASTParser][NFC] Factor out CXX/ObjC method
spe
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/94846
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Greg Clayton
Date: 2024-06-11T13:58:26-07:00
New Revision: a118f5f398bf099ec76ebf889234ebbc58b28f0c
URL:
https://github.com/llvm/llvm-project/commit/a118f5f398bf099ec76ebf889234ebbc58b28f0c
DIFF:
https://github.com/llvm/llvm-project/commit/a118f5f398bf099ec76ebf889234ebbc58b28f0c.diff
Author: Dave Lee
Date: 2024-06-11T13:14:59-07:00
New Revision: 982b4b6f4d5ddf04ed5e85aea7074c9b26f29673
URL:
https://github.com/llvm/llvm-project/commit/982b4b6f4d5ddf04ed5e85aea7074c9b26f29673
DIFF:
https://github.com/llvm/llvm-project/commit/982b4b6f4d5ddf04ed5e85aea7074c9b26f29673.diff
LOG:
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/95146
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
We clearly parse that as a Thread Index later on, so the definition here is
wrong. Thread Index is also the right choice, having to type out the ID would
be annoying.
https://github.com/llvm/llvm-project/pull/95146
_
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/87740
>From c364215cef4d383bf5cb51bf61d442a5bc9fbfe9 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Sat, 30 Mar 2024 10:50:34 -0700
Subject: [PATCH 1/9] Add support for using foreign type units in .debug_names.
Th
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/95015
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -110,6 +108,9 @@ bool
StopInfoMachException::DeterminePtrauthFailure(ExecutionContext &exe_ctx) {
strm.Printf("Note: Possible pointer authentication failure detected.\n");
};
+ ABISP abi_sp = process.GetABI();
+ assert(abi_sp && "Missing ABI info");
---
Author: Pavel Labath
Date: 2024-06-11T19:49:10+02:00
New Revision: 56f668c12b1a26e103aafe5ac37930b1895c938b
URL:
https://github.com/llvm/llvm-project/commit/56f668c12b1a26e103aafe5ac37930b1895c938b
DIFF:
https://github.com/llvm/llvm-project/commit/56f668c12b1a26e103aafe5ac37930b1895c938b.diff
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/95127
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
LGTM.
https://github.com/llvm/llvm-project/pull/94744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/95127
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/91544
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/95146
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/95146
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/95146.diff
1 Files Affected:
- (modified) lldb/source/Commands/CommandObjectThread.cpp (+1-1)
``diff
diff --git a/lldb/source/Commands/Co
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/95146
None
>From 1f4d61ed4e0ab42d5e5ac0937c0af0572f0f8f10 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Mon, 10 Jun 2024 10:46:08 -0700
Subject: [PATCH] [lldb] Fix declaration of thread argument in
CommandObjectT
@@ -86,4 +89,22 @@ TEST_F(HostTest, GetProcessInfo) {
ProcessInstanceInfo::timespec next_user_time = Info.GetUserTime();
ASSERT_TRUE(user_time.tv_sec <= next_user_time.tv_sec ||
user_time.tv_usec <= next_user_time.tv_usec);
+
+ struct rlimit rlim;
+ EXPECT_E
https://github.com/feg208 updated
https://github.com/llvm/llvm-project/pull/91544
>From a162f04d6d9f6c879398e4a6883f026bbfbd1e8f Mon Sep 17 00:00:00 2001
From: Fred Grim
Date: Wed, 8 May 2024 15:36:16 -0700
Subject: [PATCH] [lldb] Adds additional fields to ProcessInfo
To implement SaveCore for
Author: Felipe de Azevedo Piovezan
Date: 2024-06-11T09:28:10-07:00
New Revision: 2e007b89c65eeb33baf1b40103284d8937700cf0
URL:
https://github.com/llvm/llvm-project/commit/2e007b89c65eeb33baf1b40103284d8937700cf0
DIFF:
https://github.com/llvm/llvm-project/commit/2e007b89c65eeb33baf1b40103284d893
https://github.com/Michael137 approved this pull request.
Nice, can confirm they're unused on the apple fork too
https://github.com/llvm/llvm-project/pull/95127
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/95078
>From 75d1bc01ca42e327594cceba753bec483228efbd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 10 Jun 2024 17:46:31 +0100
Subject: [PATCH 1/6] [lldb][DWARFASTParser][NFC] Factor out CXX/ObjC method
spe
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/95078
>From 75d1bc01ca42e327594cceba753bec483228efbd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 10 Jun 2024 17:46:31 +0100
Subject: [PATCH 1/5] [lldb][DWARFASTParser][NFC] Factor out CXX/ObjC method
spe
@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName &objc_method, const DWARFDIE &die,
+CompilerType clang_type, const
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName &objc_method, const DWARFDIE &die,
+CompilerType clang_type, const
@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName &objc_method, const DWARFDIE &die,
+CompilerType clang_type, const
@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName &objc_method, const DWARFDIE &die,
+CompilerType clang_type, const
https://github.com/felipepiovezan approved this pull request.
It's say something that, even after this refactor, the methods are still pretty
big. But this is still a win
https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
ll
@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName &objc_method, const DWARFDIE &die,
+CompilerType clang_type, const
@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName &objc_method, const DWARFDIE &die,
+CompilerType clang_type, const
Michael137 wrote:
> * when you say "slower", what exactly does that mean. How much slow down are
> we talking about?
> * the "increased number of DWARF searches", is that due to clang asking for
> definitions of types more eagerly? If yes, do you have some examples of where
> are these extra d
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
`GetDeclContextDIEs` and `DIEDeclContextsMatch` are unused (possibly since we
added support for simplified template names, but I haven't checked).
`GetDeclContextDIEs` is also very similar (but subtly differen
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/95127
`GetDeclContextDIEs` and `DIEDeclContextsMatch` are unused (possibly since we
added support for simplified template names, but I haven't checked).
`GetDeclContextDIEs` is also very similar (but subtly different)
DavidSpickett wrote:
https://github.com/llvm/llvm-project/pull/85058 is the FreeBSD change, it'll
get rebased onto this later.
https://github.com/llvm/llvm-project/pull/95125
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Currently the logic is generate field information for all registers in
LinuxArm64RegisterFlags and then as we walk the existing register info, only
those that are in that existing info will get the ne
https://github.com/DavidSpickett ready_for_review
https://github.com/llvm/llvm-project/pull/95125
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/95125
Currently the logic is generate field information for all registers in
LinuxArm64RegisterFlags and then as we walk the existing register info, only
those that are in that existing info will get the new fie
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/94744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-06-11T16:17:25+02:00
New Revision: c0e1ad779f8b7b0073b89ecdd44c3b9c4a72e494
URL:
https://github.com/llvm/llvm-project/commit/c0e1ad779f8b7b0073b89ecdd44c3b9c4a72e494
DIFF:
https://github.com/llvm/llvm-project/commit/c0e1ad779f8b7b0073b89ecdd44c3b9c4a72e494.diff
@@ -657,6 +657,42 @@ std::optional
DWARFDebugNames::Entry::getLocalTUOffset() const {
return NameIdx->getLocalTUOffset(*Index);
}
+std::optional
+DWARFDebugNames::Entry::getForeignTUTypeSignature() const {
+ std::optional Index = getLocalTUIndex();
+ const uint32_t NumLoc
labath wrote:
Thank you for working on this. I'm very interested in the results of this
effort, as it appears I may end up dabbling into these parts of lldb in the
near future. For now just a couple of quick questions (with hopefully not too
long answers).
- when you say "slower", what exactl
walter-erquinigo wrote:
I'll review this today or tomorrow. Thanks for all the activity!
https://github.com/llvm/llvm-project/pull/91570
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 97cfe549c9a9ec3880c984bd4d2ddbbd92dcb9a0
2d90c9f4bf29f7de7db3df115d505db4b674649c --
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
97cfe549c9a9ec3880c984bd4d2ddbbd92dcb9a0...2d90c9f4bf29f7de7db3df115d505db4b674649c
lldb/
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/95078
>From 75d1bc01ca42e327594cceba753bec483228efbd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 10 Jun 2024 17:46:31 +0100
Subject: [PATCH 1/4] [lldb][DWARFASTParser][NFC] Factor out CXX/ObjC method
spe
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/95078
>From 75d1bc01ca42e327594cceba753bec483228efbd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 10 Jun 2024 17:46:31 +0100
Subject: [PATCH 1/3] [lldb][DWARFASTParser][NFC] Factor out CXX/ObjC method
spe
@@ -975,6 +975,226 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::HandleObjCMethod(
+ObjCLanguage::MethodName const &objc_method, DWARFDIE const &die,
+CompilerType clang_type, Parse
@@ -975,6 +975,226 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::HandleObjCMethod(
+ObjCLanguage::MethodName const &objc_method, DWARFDIE const &die,
+CompilerType clang_type, Parse
@@ -975,6 +975,226 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::HandleObjCMethod(
+ObjCLanguage::MethodName const &objc_method, DWARFDIE const &die,
+CompilerType clang_type, Parse
@@ -370,6 +371,20 @@ class DWARFASTParserClang : public
lldb_private::plugin::dwarf::DWARFASTParser {
ParsedDWARFTypeAttributes &attrs);
lldb::TypeSP ParseSubroutine(const lldb_private::plugin::dwarf::DWARFDIE
&die,
co
@@ -975,6 +975,226 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::HandleObjCMethod(
+ObjCLanguage::MethodName const &objc_method, DWARFDIE const &die,
+CompilerType clang_type, Parse
@@ -975,6 +975,226 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::HandleObjCMethod(
+ObjCLanguage::MethodName const &objc_method, DWARFDIE const &die,
labath wrote:
I b
@@ -370,6 +371,20 @@ class DWARFASTParserClang : public
lldb_private::plugin::dwarf::DWARFASTParser {
ParsedDWARFTypeAttributes &attrs);
lldb::TypeSP ParseSubroutine(const lldb_private::plugin::dwarf::DWARFDIE
&die,
co
https://github.com/labath commented:
I can't say if this is the right split, but I think we should try something, as
this function is long overdue for an overhaul.
https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
lldb-comm
@@ -975,6 +975,226 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes &attrs) {
return clang::CC_C;
}
+bool DWARFASTParserClang::HandleObjCMethod(
+ObjCLanguage::MethodName const &objc_method, DWARFDIE const &die,
+CompilerType clang_type, Parse
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
Thanks.
https://github.com/llvm/llvm-project/pull/94846
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,69 @@
+"""
+Test the SBModule and SBTarget type lookup APIs to find multiple types.
+"""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TypeFindFirstTestCase(TestBase):
+def test_find_first_type(self):
+
https://github.com/labath approved this pull request.
My concerns have been addressed (*), so I'm removing my request for changes. It
looks like the only way to do that is to Approve the PR, but I'd suggest
getting another approval from a lldb-dap owner as well.
(*) There is still the question
@@ -672,9 +672,14 @@ void request_attach(const llvm::json::Object &request) {
lldb::SBError error;
FillResponse(request, response);
lldb::SBAttachInfo attach_info;
+ const int invalid_port = 0;
auto arguments = request.getObject("arguments");
const lldb::pid_t pid
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/91570
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,202 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbplatformutil
+import lldb
@@ -370,6 +371,20 @@ class DWARFASTParserClang : public
lldb_private::plugin::dwarf::DWARFASTParser {
ParsedDWARFTypeAttributes &attrs);
lldb::TypeSP ParseSubroutine(const lldb_private::plugin::dwarf::DWARFDIE
&die,
co
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Shivam Gupta
Date: 2024-06-11T12:52:32+05:30
New Revision: baad1b85b93c0b5ce0341668259ae21911bed8b1
URL:
https://github.com/llvm/llvm-project/commit/baad1b85b93c0b5ce0341668259ae21911bed8b1
DIFF:
https://github.com/llvm/llvm-project/commit/baad1b85b93c0b5ce0341668259ae21911bed8b1.diff
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94852
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 104 matches
Mail list logo
