Author: Pavel Labath
Date: 2024-05-03T06:30:49Z
New Revision: f8fedfb6802173372ec923f99f31d4af810fbcb0
URL:
https://github.com/llvm/llvm-project/commit/f8fedfb6802173372ec923f99f31d4af810fbcb0
DIFF:
https://github.com/llvm/llvm-project/commit/f8fedfb6802173372ec923f99f31d4af810fbcb0.diff
LOG:
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/90622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,183 @@
+import os
+import shutil
+import tempfile
+
+import lldb
+from lldbsuite.test.decorators import *
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.lldbtest import *
+
+
+"""
+Test support for the DebugInfoD network symbol acquisition protocol.
+T
@@ -0,0 +1,183 @@
+import os
+import shutil
+import tempfile
+
+import lldb
+from lldbsuite.test.decorators import *
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.lldbtest import *
+
+
+"""
+Test support for the DebugInfoD network symbol acquisition protocol.
+T
@@ -44,6 +44,10 @@ lldb_build_intel_pt = '@LLDB_BUILD_INTEL_PT@'
if lldb_build_intel_pt == '1':
config.enabled_plugins.append('intel-pt')
+llvm_enable_curl = '@LLVM_ENABLE_CURL@'
labath wrote:
Emulating the curses dependency approach would probably be mor
labath wrote:
f8fedfb6802173372ec923f99f31d4af810fbcb0 ought to fix
`TestSharedLibStrippedSymbols.py`. The rest might be due to the test being too
strict with what it expects of a UUID.
https://github.com/llvm/llvm-project/pull/90622
___
lldb-commits
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/89868
>From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Tue, 23 Apr 2024 18:10:21 -0700
Subject: [PATCH 01/14] Allow multiple destroy callbacks in
`SBDebugger::SetDestroyCall
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -743,9 +743,24 @@ DebuggerSP
Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
}
void Debugger::HandleDestroyCallback() {
- if (m_destroy_callback) {
-m_destroy_callback(GetID(), m_destroy_callback_baton);
-m_destroy_callback = nullptr;
+ std::lock_g
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -731,8 +747,11 @@ class Debugger : public
std::enable_shared_from_this,
lldb::TargetSP m_dummy_target_sp;
Diagnostics::CallbackID m_diagnostics_callback_id;
- lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr;
- void *m_destroy_callback_baton = nullp
@@ -62,12 +62,15 @@ typedef void *thread_arg_t; // Host thread
argument type
typedef void *thread_result_t; // Host thread result type
typedef void *(*thread_func_t)(void *); // Host thread function type
typedef int pipe_t; // Host pipe
@@ -321,9 +321,26 @@ class LLDB_API SBDebugger {
void SetLoggingCallback(lldb::LogOutputCallback log_callback, void *baton);
+ /// DEPRECATED: We used to only support one Destroy callback. Now that we
+ /// support Add and Remove, you should only remove Destroy callbacks
@@ -290,6 +290,36 @@ class StructuredData {
void GetDescription(lldb_private::Stream &s) const override;
+/// Creates an Array of substrings by splitting a string around the
+/// occurrences of a separator character.
+///
+/// Note:
+/// * This is almo
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/90703
>From 0fd67e2de7e702ce6f7353845454ea7ff9f980d6 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Tue, 30 Apr 2024 21:35:49 -0700
Subject: [PATCH 01/10] Add SBCommandInterpreter::GetTranscript()
---
lldb/include/lld
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/90703
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -766,6 +768,12 @@ class CommandInterpreter : public Broadcaster,
CommandUsageMap m_command_usages;
StreamString m_transcript_stream;
+
+ /// Contains a list of handled commands, output and error. Each element in
+ /// the list is a dictionary with three keys: "command
@@ -366,10 +396,10 @@ class StructuredData {
class String : public Object {
public:
String() : Object(lldb::eStructuredDataTypeString) {}
-explicit String(llvm::StringRef S)
-: Object(lldb::eStructuredDataTypeString), m_value(S) {}
+explicit String(llvm:
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/90930
None
>From b72df8cf2a047ed731913609b58bdb4a3601e111 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Thu, 2 May 2024 18:12:04 -0700
Subject: [PATCH] Single thread timeout feature
---
lldb/include/lldb/Ta
https://github.com/Awfa updated https://github.com/llvm/llvm-project/pull/88845
>From 3d75f42b5f61ea126001919491aa09ebd15ba9f8 Mon Sep 17 00:00:00 2001
From: Anthony Ha
Date: Mon, 15 Apr 2024 19:36:34 +
Subject: [PATCH 1/3] [lldb] Have lldb-server assign ports to children in
platform mode
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Anthony Ha (Awfa)
Changes
# Overview
In my previous PR: https://github.com/llvm/llvm-project/pull/88812, @JDevlieghere suggested to match return types of the various calculate md5
functions.
This PR achieves that by changing the various ca
https://github.com/Awfa created https://github.com/llvm/llvm-project/pull/90921
# Overview
In my previous PR: https://github.com/llvm/llvm-project/pull/88812,
@JDevlieghere suggested to match return types of the various calculate md5
functions.
This PR achieves that by changing the various cal
@@ -87,8 +87,15 @@ class Host {
StartMonitoringChildProcess(const MonitorChildProcessCallback &callback,
lldb::pid_t pid);
+ /// System log level.
+ enum SystemLogLevel {
+eSystemLogInfo,
+eSystemLogWarning,
JDevlieghe
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
We have 3 different enums all expressing severity (info, warning, error).
Remove all uses with a new Severity enum in lldb-enumerations.h.
---
Patch is 52.97 KiB, truncated to 20.00 KiB below, full
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/90917
We have 3 different enums all expressing severity (info, warning, error).
Remove all uses with a new Severity enum in lldb-enumerations.h.
>From 23b16ba8418f03dd11190798ccddf218cbfaf3f1 Mon Sep 17 00:00:00
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/90913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM with comment
https://github.com/llvm/llvm-project/pull/90913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1512,7 +1512,22 @@ void
Debugger::ReportDiagnosticImpl(DiagnosticEventData::Type type,
std::string message,
std::optional debugger_id,
std::once_flag *once) {
+ aut
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/90913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -87,8 +87,15 @@ class Host {
StartMonitoringChildProcess(const MonitorChildProcessCallback &callback,
lldb::pid_t pid);
+ /// System log level.
+ enum SystemLogLevel {
+eSystemLogInfo,
+eSystemLogWarning,
adrian-pra
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Always emit diagnostic events to the system log so that they end up in the
sysdiagnose on Darwin.
---
Full diff: https://github.com/llvm/llvm-project/pull/90913.diff
1 Files Affected:
- (modified
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/90913
Always emit diagnostic events to the system log so that they end up in the
sysdiagnose on Darwin.
>From 458913020dd443c0ca92caa63cf8477035f8c5cc Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu,
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/90904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-05-02T16:07:11-07:00
New Revision: a7e9e3eb8b44bc3a6f14f0af71e555e2cac6ef41
URL:
https://github.com/llvm/llvm-project/commit/a7e9e3eb8b44bc3a6f14f0af71e555e2cac6ef41
DIFF:
https://github.com/llvm/llvm-project/commit/a7e9e3eb8b44bc3a6f14f0af71e555e2cac6ef41.d
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/90657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/90808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-05-02T15:52:24-07:00
New Revision: 2d15855adf6afac3f4171a24fd18b65a32eedf78
URL:
https://github.com/llvm/llvm-project/commit/2d15855adf6afac3f4171a24fd18b65a32eedf78
DIFF:
https://github.com/llvm/llvm-project/commit/2d15855adf6afac3f4171a24fd18b65a32eedf78.diff
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/90808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/90904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-05-02T15:20:17-07:00
New Revision: 954d00e87cdd77d0e9e367be52e62340467bd779
URL:
https://github.com/llvm/llvm-project/commit/954d00e87cdd77d0e9e367be52e62340467bd779
DIFF:
https://github.com/llvm/llvm-project/commit/954d00e87cdd77d0e9e367be52e62340467bd779.diff
@@ -169,25 +173,28 @@ kern_return_t DNBArchMachARM64::GetGPRState(bool force) {
(thread_state_t)&m_state.context.gpr, &count);
if (DNBLogEnabledForAny(LOG_THREAD)) {
uint64_t *x = &m_state.context.gpr.__x[0];
+
+#if defined(DEBUGSERVER_IS_ARM64E)
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/90808
>From 8145e9faaa52209f9800d473fb75f7cfbd2a1185 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 1 May 2024 18:06:50 -0700
Subject: [PATCH 1/2] [lldb] [debugserver] address preprocessor warning, extra
Prabhuk wrote:
I am starting to see test failures in our toolchain builders after this patch:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8749027826743254513/overview
https://github.com/llvm/llvm-project/pull/90622
__
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/90904
>From 1109b65209d49046e029b780bf484a810c1bd42e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 2 May 2024 13:20:16 -0700
Subject: [PATCH] [lldb] Add a log level to Host::SystemLog
Add the abilit
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/90297
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -91,15 +91,37 @@ using namespace lldb_private;
#if !defined(__APPLE__)
#if !defined(_WIN32)
#include
-void Host::SystemLog(llvm::StringRef message) {
+void Host::SystemLog(SystemLogLevel log_level, llvm::StringRef message) {
static llvm::once_flag g_openlog_once;
llvm
https://github.com/medismailben deleted
https://github.com/llvm/llvm-project/pull/90904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -91,15 +91,37 @@ using namespace lldb_private;
#if !defined(__APPLE__)
#if !defined(_WIN32)
#include
-void Host::SystemLog(llvm::StringRef message) {
+void Host::SystemLog(SystemLogLevel log_level, llvm::StringRef message) {
static llvm::once_flag g_openlog_once;
llvm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Add the ability to specify a log level to Host::SystemLog.
---
Full diff: https://github.com/llvm/llvm-project/pull/90904.diff
3 Files Affected:
- (modified) lldb/include/lldb/Host/Host.h (+8-1)
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/90904
Add the ability to specify a log level to Host::SystemLog.
>From a7b4d7bd7374d0b41cb82fe8c97315006bf7d212 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 2 May 2024 13:20:16 -0700
Subject: [PATC
@@ -321,9 +321,26 @@ class LLDB_API SBDebugger {
void SetLoggingCallback(lldb::LogOutputCallback log_callback, void *baton);
+ /// DEPRECATED: We used to only support one Destroy callback. Now that we
+ /// support Add and Remove, you should only remove Destroy callbacks
https://github.com/walter-erquinigo approved this pull request.
makes sense to me
https://github.com/llvm/llvm-project/pull/87649
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -321,9 +321,26 @@ class LLDB_API SBDebugger {
void SetLoggingCallback(lldb::LogOutputCallback log_callback, void *baton);
+ /// DEPRECATED: We used to only support one Destroy callback. Now that we
+ /// support Add and Remove, you should only remove Destroy callbacks
https://github.com/clayborg requested changes to this pull request.
I agree with all comments here. I like being able to add and remove destroy
callbacks. See my inline comments for changing `AddDestroyCallback` and
`RemoveDestroyCallback`.
https://github.com/llvm/llvm-project/pull/89868
_
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -44,6 +44,10 @@ lldb_build_intel_pt = '@LLDB_BUILD_INTEL_PT@'
if lldb_build_intel_pt == '1':
config.enabled_plugins.append('intel-pt')
+llvm_enable_curl = '@LLVM_ENABLE_CURL@'
kevinfrei wrote:
I validated that this works correctly (had the same work).
@@ -44,6 +44,10 @@ lldb_build_intel_pt = '@LLDB_BUILD_INTEL_PT@'
if lldb_build_intel_pt == '1':
config.enabled_plugins.append('intel-pt')
+llvm_enable_curl = '@LLVM_ENABLE_CURL@'
nico wrote:
Is this correct? Won't this expand to 'NO' which is truthy when
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when printi
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when printi
@@ -13,11 +13,42 @@
#include
#include
+#include "llvm/ADT/StringSet.h"
+
namespace lldb_private {
class StreamString;
class Log;
+class FieldEnum {
+public:
+ struct Enumerator {
+uint64_t m_value;
+// Short name for the value. Shown in tables and when printi
@@ -366,10 +396,10 @@ class StructuredData {
class String : public Object {
public:
String() : Object(lldb::eStructuredDataTypeString) {}
-explicit String(llvm::StringRef S)
-: Object(lldb::eStructuredDataTypeString), m_value(S) {}
+explicit String(llvm:
@@ -290,6 +290,36 @@ class StructuredData {
void GetDescription(lldb_private::Stream &s) const override;
+/// Creates an Array of substrings by splitting a string around the
+/// occurrences of a separator character.
+///
+/// Note:
+/// * This is almo
@@ -318,6 +318,12 @@ class SBCommandInterpreter {
SBStructuredData GetStatistics();
+ /// Returns a list of handled commands, output and error. Each element in
+ /// the list is a dictionary with three keys: "command" (string), "output"
+ /// (list of strings) and option
@@ -766,6 +768,12 @@ class CommandInterpreter : public Broadcaster,
CommandUsageMap m_command_usages;
StreamString m_transcript_stream;
+
+ /// Contains a list of handled commands, output and error. Each element in
+ /// the list is a dictionary with three keys: "command
Author: Zequan Wu
Date: 2024-05-02T14:22:03-04:00
New Revision: ee63f287e013ab3424372034d4d5a95512ab5b6b
URL:
https://github.com/llvm/llvm-project/commit/ee63f287e013ab3424372034d4d5a95512ab5b6b
DIFF:
https://github.com/llvm/llvm-project/commit/ee63f287e013ab3424372034d4d5a95512ab5b6b.diff
LOG
@@ -1631,13 +1631,19 @@ bool SymbolFileDWARF::CompleteType(CompilerType
&compiler_type) {
return true;
}
- DWARFDIE dwarf_die = GetDIE(die_it->getSecond());
+ DWARFDIE dwarf_die = FindDefinitionDIE(GetDIE(die_it->getSecond()));
if (dwarf_die) {
// Once we star
@@ -1654,6 +1660,99 @@ bool SymbolFileDWARF::CompleteType(CompilerType
&compiler_type) {
return false;
}
+DWARFDIE SymbolFileDWARF::FindDefinitionDIE(const DWARFDIE &die) {
+ auto def_die_it = GetDeclarationDIEToDefinitionDIE().find(die.GetDIE());
+ if (def_die_it != GetD
@@ -533,9 +540,16 @@ class SymbolFileDWARF : public SymbolFileCommon {
NameToOffsetMap m_function_scope_qualified_name_map;
std::unique_ptr m_ranges;
UniqueDWARFASTTypeMap m_unique_ast_type_map;
+ // A map from DIE to lldb_private::Type. For record type, the key might be
@@ -731,8 +747,11 @@ class Debugger : public
std::enable_shared_from_this,
lldb::TargetSP m_dummy_target_sp;
Diagnostics::CallbackID m_diagnostics_callback_id;
- lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr;
- void *m_destroy_callback_baton = nullp
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/90663
>From 4e83099b593e66f12dc21be5fbac5279e03e Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 30 Apr 2024 16:23:11 -0400
Subject: [PATCH 1/3] [lldb][DWARF] Delay struct/class/union definition DIE
searching
@@ -169,25 +173,28 @@ kern_return_t DNBArchMachARM64::GetGPRState(bool force) {
(thread_state_t)&m_state.context.gpr, &count);
if (DNBLogEnabledForAny(LOG_THREAD)) {
uint64_t *x = &m_state.context.gpr.__x[0];
+
+#if defined(DEBUGSERVER_IS_ARM64E)
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/90622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kevin Frei
Date: 2024-05-02T11:02:17-07:00
New Revision: 2d4acb086541577ac6ab3a140b9ceb9659ce7094
URL:
https://github.com/llvm/llvm-project/commit/2d4acb086541577ac6ab3a140b9ceb9659ce7094
DIFF:
https://github.com/llvm/llvm-project/commit/2d4acb086541577ac6ab3a140b9ceb9659ce7094.diff
LO
https://github.com/walter-erquinigo approved this pull request.
lgtm.
It would be nice if new UI features could be added in the typescript code of
lldb-dap, so that all users benefit from them.
https://github.com/llvm/llvm-project/pull/90799
___
lldb-
@@ -1690,11 +1690,28 @@ void SBDebugger::SetDestroyCallback(
lldb::SBDebuggerDestroyCallback destroy_callback, void *baton) {
LLDB_INSTRUMENT_VA(this, destroy_callback, baton);
if (m_opaque_sp) {
-return m_opaque_sp->SetDestroyCallback(
-destroy_callback, ba
@@ -1690,11 +1690,28 @@ void SBDebugger::SetDestroyCallback(
lldb::SBDebuggerDestroyCallback destroy_callback, void *baton) {
LLDB_INSTRUMENT_VA(this, destroy_callback, baton);
if (m_opaque_sp) {
-return m_opaque_sp->SetDestroyCallback(
-destroy_callback, ba
@@ -743,9 +743,24 @@ DebuggerSP
Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
}
void Debugger::HandleDestroyCallback() {
- if (m_destroy_callback) {
-m_destroy_callback(GetID(), m_destroy_callback_baton);
-m_destroy_callback = nullptr;
+ std::lock_g
@@ -731,8 +747,11 @@ class Debugger : public
std::enable_shared_from_this,
lldb::TargetSP m_dummy_target_sp;
Diagnostics::CallbackID m_diagnostics_callback_id;
- lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr;
- void *m_destroy_callback_baton = nullp
@@ -62,12 +62,15 @@ typedef void *thread_arg_t; // Host thread
argument type
typedef void *thread_result_t; // Host thread result type
typedef void *(*thread_func_t)(void *); // Host thread function type
typedef int pipe_t; // Host pipe
@@ -731,8 +747,11 @@ class Debugger : public
std::enable_shared_from_this,
lldb::TargetSP m_dummy_target_sp;
Diagnostics::CallbackID m_diagnostics_callback_id;
- lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr;
- void *m_destroy_callback_baton = nullp
@@ -321,9 +321,26 @@ class LLDB_API SBDebugger {
void SetLoggingCallback(lldb::LogOutputCallback log_callback, void *baton);
+ /// DEPRECATED: We used to only support one Destroy callback. Now that we
+ /// support Add and Remove, you should only remove Destroy callbacks
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1654,6 +1660,99 @@ bool SymbolFileDWARF::CompleteType(CompilerType
&compiler_type) {
return false;
}
+DWARFDIE SymbolFileDWARF::FindDefinitionDIE(const DWARFDIE &die) {
+ auto def_die_it = GetDeclarationDIEToDefinitionDIE().find(die.GetDIE());
+ if (def_die_it != GetD
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/84026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-05-02T16:55:42+01:00
New Revision: fbaba780f6b131e7674259861fce915b1a94f78e
URL:
https://github.com/llvm/llvm-project/commit/fbaba780f6b131e7674259861fce915b1a94f78e
DIFF:
https://github.com/llvm/llvm-project/commit/fbaba780f6b131e7674259861fce915b1a94f78e.diff
labath wrote:
> So no need to change the structure of this PR, but do correct me if any of my
> assumptions are incorrect there.
The `DynamicLoaderPOSIXDYLD` is only used on ELF systems anyway (we might as
well rename it do `DynamicLoaderELF`), so this actually lines up fairly well.
https://g
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/84026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1654,6 +1660,99 @@ bool SymbolFileDWARF::CompleteType(CompilerType
&compiler_type) {
return false;
}
+DWARFDIE SymbolFileDWARF::FindDefinitionDIE(const DWARFDIE &die) {
+ auto def_die_it = GetDeclarationDIEToDefinitionDIE().find(die.GetDIE());
+ if (def_die_it != GetD
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/84026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/90703
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1654,6 +1660,99 @@ bool SymbolFileDWARF::CompleteType(CompilerType
&compiler_type) {
return false;
}
+DWARFDIE SymbolFileDWARF::FindDefinitionDIE(const DWARFDIE &die) {
+ auto def_die_it = GetDeclarationDIEToDefinitionDIE().find(die.GetDIE());
+ if (def_die_it != GetD
royitaqi wrote:
Hi @JDevlieghere , @jimingham , @bulbazord ,
Gentle ping for a re-review.
Thanks,
Roy
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davemgreen wrote:
> This is already split into 18 commits, I don't think there's any reason to
> split it into 18 PRs, since comments on one of them likely apply to the
> others.
I disagree. This is going to be awkward for a lot of users of llvm and contains
at least some details I don't agre
ostannard wrote:
@davemgreen This is already split into 18 commits, I don't think there's any
reason to split it into 18 PRs, since comments on one of them likely apply to
the others.
@tmatheson-arm I don't know if there's any more specific precedent for changing
target feature names, but I t
1 - 100 of 134 matches
Mail list logo
