=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
taalhaataahir0102 wrote:
Hi @reviewers. Did you got the chance to look at the code and is there any
feedback 🙂
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-co
@@ -1165,37 +1208,59 @@ class CommandObjectThreadSelect : public
CommandObjectParsed {
nullptr);
}
+ Options *GetOptions() override { return &m_option_group; }
+
protected:
void DoExecute(Args &command, CommandReturnObject &result) override {
Process *proc
https://github.com/mdko edited https://github.com/llvm/llvm-project/pull/73596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1117,6 +1117,11 @@ let Command = "thread plan list" in {
Desc<"Display thread plans for unreported threads">;
}
+let Command = "thread select" in {
+ def thread_select_thread_id : Option<"thread-id", "t">, Group<2>,
+Arg<"ThreadID">, Desc<"Provide a thread ID inst
brad0 wrote:
It would be nice to get this in so Flang is buildable.
https://github.com/llvm/llvm-project/pull/73254
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/73067
>From 22bfc5878f1f96b3138a03eea4dc856948185c89 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 21 Nov 2023 17:28:30 -0800
Subject: [PATCH 1/2] [lldb][test] Apply @expectedFailureAll/@skipIf early for
@@ -436,8 +482,8 @@ class CompilerType {
ExecutionContextScope *exe_scope);
/// Dump to stdout.
- void DumpTypeDescription(lldb::DescriptionLevel level =
- lldb::eDescriptionLevelFull) const;
hawkinsw wrote:
I
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/73028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jordan Rupprecht
Date: 2023-11-28T23:36:05-06:00
New Revision: 3d7e6db12072c26c7ad42c2c473d1dc321725db4
URL:
https://github.com/llvm/llvm-project/commit/3d7e6db12072c26c7ad42c2c473d1dc321725db4
DIFF:
https://github.com/llvm/llvm-project/commit/3d7e6db12072c26c7ad42c2c473d1dc321725db4.di
@@ -436,8 +482,8 @@ class CompilerType {
ExecutionContextScope *exe_scope);
/// Dump to stdout.
- void DumpTypeDescription(lldb::DescriptionLevel level =
- lldb::eDescriptionLevelFull) const;
cmtice wrote:
Per
@@ -1117,6 +1117,11 @@ let Command = "thread plan list" in {
Desc<"Display thread plans for unreported threads">;
}
+let Command = "thread select" in {
+ def thread_select_thread_id : Option<"thread-id", "t">, Group<2>,
+Arg<"ThreadID">, Desc<"Provide a thread ID inst
@@ -1165,37 +1208,59 @@ class CommandObjectThreadSelect : public
CommandObjectParsed {
nullptr);
}
+ Options *GetOptions() override { return &m_option_group; }
+
protected:
void DoExecute(Args &command, CommandReturnObject &result) override {
Process *proc
@@ -1239,11 +1242,12 @@ class CommandObjectThreadSelect : public
CommandObjectParsed {
new_thread =
process->GetThreadList().FindThreadByIndexID(index_id).get();
if (new_thread == nullptr) {
result.AppendErrorWithFormat("Invalid thread #%s.\n",
---
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/73596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
Great changes, just a few inline comments.
https://github.com/llvm/llvm-project/pull/73596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
A previous patch to llvm allowed the DWARFUnitIndex class to handle
.debug_info.dwo and .debug_types.dwo sections to go over 4GB by checking for
this case and fixing up the DWARFUnitIndex. LLDB's DWARF parse
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/73736
A previous patch to llvm allowed the DWARFUnitIndex class to handle
.debug_info.dwo and .debug_types.dwo sections to go over 4GB by checking for
this case and fixing up the DWARFUnitIndex. LLDB's DWARF parser t
mdko wrote:
[Latest
changes](https://github.com/llvm/llvm-project/pull/73596/commits/34045b9b2e04e01fed142ad2d7f4503e69646c9f)
implement reviewer suggestions:
* `thread_id` option is now `thread-id`
* This option takes a value rather than causing original argument to be
interpreted differentl
https://github.com/mdko updated https://github.com/llvm/llvm-project/pull/73596
>From 97a6e23c85457a14c91c5800fa03bb872e6f1fa6 Mon Sep 17 00:00:00 2001
From: Michael Christensen
Date: Mon, 27 Nov 2023 12:49:24 -0800
Subject: [PATCH 1/3] Add option to pass thread ID to thread select command
---
https://github.com/mdko updated https://github.com/llvm/llvm-project/pull/73596
>From 97a6e23c85457a14c91c5800fa03bb872e6f1fa6 Mon Sep 17 00:00:00 2001
From: Michael Christensen
Date: Mon, 27 Nov 2023 12:49:24 -0800
Subject: [PATCH 1/2] Add option to pass thread ID to thread select command
---
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/73707
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-11-28T17:04:19-08:00
New Revision: 4eb421192479dbecae2621b868e55aaf6d945b02
URL:
https://github.com/llvm/llvm-project/commit/4eb421192479dbecae2621b868e55aaf6d945b02
DIFF:
https://github.com/llvm/llvm-project/commit/4eb421192479dbecae2621b868e55aaf6d945b02.diff
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/17] [libc++] Implement ranges::contains
Differential Revision
philnik777 wrote:
I've reopened the old one for you. Let's keep the discussion in one place.
https://github.com/llvm/llvm-project/pull/70258
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/17] [libc++] Implement ranges::contains
Differential Revision:
https://github.com/philnik777 reopened
https://github.com/llvm/llvm-project/pull/65148
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/70258
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1117,6 +1117,11 @@ let Command = "thread plan list" in {
Desc<"Display thread plans for unreported threads">;
}
+let Command = "thread select" in {
+ def thread_thread_id : Option<"thread_id", "t">,
jimingham wrote:
I don't know about the underlying
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/73707
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
In https://github.com/llvm/llvm-project/pull/73626 we started attaching
`DW_AT_const_value`s on a static data-member's declaration again. In DWARFv5,
those static members are represented with a `DW_TAG_var
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/73707
In https://github.com/llvm/llvm-project/pull/73626 we started attaching
`DW_AT_const_value`s on a static data-member's declaration again. In DWARFv5,
those static members are represented with a `DW_TAG_variab
@@ -37,19 +37,29 @@ llvm::DenseSet
DebugNamesDWARFIndex::GetUnits(const DebugNames &debug_names) {
llvm::DenseSet result;
for (const DebugNames::NameIndex &ni : debug_names) {
-for (uint32_t cu = 0; cu < ni.getCUCount(); ++cu)
+const uint32_t num_cus = ni.getCUCount
clayborg wrote:
> What happens when Linker tombstones the tu local entry to -1, or will that be
> in a separate patch after LLD changes land?
Actually this patch will work for tombstoned units already. I will make an
inline comment and tag you with details.
https://github.com/llvm/llvm-projec
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/72952
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Greg Clayton
Date: 2023-11-28T13:56:45-08:00
New Revision: 3661eb150e6d4e1e06adb8a62c4b45b056f3c8be
URL:
https://github.com/llvm/llvm-project/commit/3661eb150e6d4e1e06adb8a62c4b45b056f3c8be
DIFF:
https://github.com/llvm/llvm-project/commit/3661eb150e6d4e1e06adb8a62c4b45b056f3c8be.diff
clayborg wrote:
> What happens when Linker tombstones the tu local entry to -1, or will that be
> in a separate patch after LLD changes land?
I can will do another PR for that once it lands.
https://github.com/llvm/llvm-project/pull/72952
___
lldb-co
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/73596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1117,6 +1117,11 @@ let Command = "thread plan list" in {
Desc<"Display thread plans for unreported threads">;
}
+let Command = "thread select" in {
+ def thread_thread_id : Option<"thread_id", "t">,
clayborg wrote:
Also wondering if there is only one
@@ -1117,6 +1117,11 @@ let Command = "thread plan list" in {
Desc<"Display thread plans for unreported threads">;
}
+let Command = "thread select" in {
+ def thread_thread_id : Option<"thread_id", "t">,
clayborg wrote:
Change the long option name to be "
https://github.com/clayborg requested changes to this pull request.
Rename long option and change it so the option requires a value, and make the
code use the option value instead of command argument overloading.
https://github.com/llvm/llvm-project/pull/73596
__
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/73596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ZequanWu wrote:
Ping.
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/73028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/73605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2023-11-28T10:45:02-08:00
New Revision: c846f8ba104f18053ce666de7e2da0a82deb45cd
URL:
https://github.com/llvm/llvm-project/commit/c846f8ba104f18053ce666de7e2da0a82deb45cd
DIFF:
https://github.com/llvm/llvm-project/commit/c846f8ba104f18053ce666de7e2da0a82deb45cd.d
jimingham wrote:
lldb doesn't have a notion of arguments actually being the value of a default
option. I'm not sure I like that idea, it seems like it could quickly become
confusing.
lldb does have the notion of "groups of options" that work together for a given
command. You can specify `
mdko wrote:
@jimingham So it seems that when `-t ` is supplied, the user shouldn't be
able to specify a thread index as well, e.g. the following is disallowed:
```
thread select -t 216051 1
```
Would it make sense then for `thread select` to take two possible mutually
exclusive options (`-t `)
ZijunZhaoCCK wrote:
> Gentle ping. There's outstanding feedback to address on this review.
> @ZijunZhaoCCK if you don't think you'll have time to pursue this PR anymore,
> it's all good but please let us know so we can assign it to someone else!
Sorry for the late reply! I can’t make it a prio
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/66963
>From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001
From: Zijun Zhao
Date: Wed, 13 Sep 2023 14:26:01 -0700
Subject: [PATCH 1/6] [libc++] Implement ranges::contains_subrange
---
libcxx/i
cor3ntin wrote:
> So it's not so much that it's not actually true in the implementation
> details, it's that it's not actually true by specification either.
+1. I really do not want `-E` to start not expanding, or transforming
directives.
I do not see a difference between a large embed and a l
@@ -0,0 +1,31 @@
+//===- SPIRVToLLVMIRTranslation.cpp - Translate SPIRV to LLVM IR
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/silee2 updated
https://github.com/llvm/llvm-project/pull/71430
>From c76403cf8629b8f7d8a5b7a3ee5da2881713a7f8 Mon Sep 17 00:00:00 2001
From: "Lee, Sang Ik"
Date: Mon, 6 Nov 2023 18:47:23 +
Subject: [PATCH 1/5] [MLIR] Enable GPU Dialect to SYCL runtime integration
GPU Dia
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/73605
>From 8c29a2034a57174ec68f8c1f1a2c5c66a7988762 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 27 Nov 2023 15:42:13 -0800
Subject: [PATCH 1/2] [lldb][progress] Always report progress upon Progre
https://github.com/bulbazord approved this pull request.
Awesome!
https://github.com/llvm/llvm-project/pull/73028
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ayermolo wrote:
What happens when Linker tombstones the tu local entry to -1, or will that be
in a separate patch after LLD changes land?
https://github.com/llvm/llvm-project/pull/72952
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
AaronBallman wrote:
> I guess I'd consider the "mental model" here to be that (notionally) `#embed`
> is preprocessed by expanding to `#embed_base64`, which is handled by the
> compiler proper, not the preprocessor. Yes, that's not entirely true in the
> implementation, but it seems like a rea
https://github.com/Benjins updated
https://github.com/llvm/llvm-project/pull/73592
>From de348ecdbf9d3c299eb4fe302ed2c224df7cde6b Mon Sep 17 00:00:00 2001
From: Benji Smith <6193112+benj...@users.noreply.github.com>
Date: Mon, 27 Nov 2023 18:15:22 -0500
Subject: [PATCH] [C API] Add support for s
Michael137 wrote:
LGTM, I don't expect this to change with any of the other outstanding bugs, so
seems fine to merge now
https://github.com/llvm/llvm-project/pull/73307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/73307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Haojian Wu
Date: 2023-11-28T12:27:55+01:00
New Revision: 439b16e2b369a0e3d482597b2c6597ce187e65f9
URL:
https://github.com/llvm/llvm-project/commit/439b16e2b369a0e3d482597b2c6597ce187e65f9
DIFF:
https://github.com/llvm/llvm-project/commit/439b16e2b369a0e3d482597b2c6597ce187e65f9.diff
LO
hokein wrote:
@Michael137, I'm merging this patch now. I'm happy to address any post comments.
https://github.com/llvm/llvm-project/pull/73307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
DavidSpickett wrote:
I've reverted this due to failures on Linaro's Linux bots.
https://github.com/llvm/llvm-project/pull/68845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-11-28T09:15:51Z
New Revision: 1459c627f0bc1a4938b5b6a7f4c2bdc1f3ec6a2c
URL:
https://github.com/llvm/llvm-project/commit/1459c627f0bc1a4938b5b6a7f4c2bdc1f3ec6a2c
DIFF:
https://github.com/llvm/llvm-project/commit/1459c627f0bc1a4938b5b6a7f4c2bdc1f3ec6a2c.diff
LOG
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/73307
>From 5fb8fd532fe767feb2d361f9552ff31ea7770663 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 24 Nov 2023 10:46:03 +0100
Subject: [PATCH 1/3] [LLDB] Respect the DW_AT_alignment attribute.
Part of fixes for
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/73307
>From 5fb8fd532fe767feb2d361f9552ff31ea7770663 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 24 Nov 2023 10:46:03 +0100
Subject: [PATCH 1/3] [LLDB] Respect the DW_AT_alignment attribute.
Part of fixes for #7
Endilll wrote:
> The human-readability of a big list of integers is not better than embedded
> base64 -- and actually, seems more of a pain to decode.
I agree that the entirety of the data is not too comprehensible, but I can
imagine users being interested in the first and last N bytes when th
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/73307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1926,12 +1930,13 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
// TypeSystemClang is always in C++ mode, but some compilers such as
// GCC and Clang give empty structs a size of 0 in C mode (in contrast to
// the size of 1 for emp
https://github.com/hokein commented:
Thanks for the review.
https://github.com/llvm/llvm-project/pull/73307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/73307
>From 5fb8fd532fe767feb2d361f9552ff31ea7770663 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 24 Nov 2023 10:46:03 +0100
Subject: [PATCH 1/2] [LLDB] Respect the DW_AT_alignment attribute.
Part of fixes for
70 matches
Mail list logo
