[Lldb-commits] [PATCH] D157361: [lldb] FIx data race in ThreadedCommunication

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, augusto2112. Herald added a project: All. JDevlieghere requested review of this revision. TSan reports the following race: Write of size 8 at 0x000107707ee8 by main thread: #0 lldb_private::ThreadedCommunication::S

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere abandoned this revision. JDevlieghere added a comment. Abandoning this in favor of D157347 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157159/new/ https://reviews.llvm.org/D157159 ___ lldb-com

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

JDevlieghere updated this revision to Diff 548056. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 Files: lldb/include/lldb/Host/File.h lldb/source/Host/common/File.cpp Index: lldb/source/Host/common/File.cpp ===

[Lldb-commits] [lldb] caa5167 - Revert "[lldb] Fix data race in ConnectionFileDescriptor"

Author: Jonas Devlieghere Date: 2023-08-07T19:11:11-07:00 New Revision: caa5167769b5d8a0165e6c1cb7c919e864346db2 URL: https://github.com/llvm/llvm-project/commit/caa5167769b5d8a0165e6c1cb7c919e864346db2 DIFF: https://github.com/llvm/llvm-project/commit/caa5167769b5d8a0165e6c1cb7c919e864346db2.d

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in ConnectionFileDescriptor

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bdbe7bd7f15: [lldb] Fix data race in ConnectionFileDescriptor (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] 0bdbe7b - [lldb] Fix data race in ConnectionFileDescriptor

Author: Jonas Devlieghere Date: 2023-08-07T18:37:52-07:00 New Revision: 0bdbe7bd7f1589817495a60cc8422df49575b17b URL: https://github.com/llvm/llvm-project/commit/0bdbe7bd7f1589817495a60cc8422df49575b17b DIFF: https://github.com/llvm/llvm-project/commit/0bdbe7bd7f1589817495a60cc8422df49575b17b.d

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

jasonmolenda updated this revision to Diff 548015. jasonmolenda added a comment. Update patch to send these error messages to the ErrorStream not OutputStream. Also change LocateSymbolFileMacOSX.cpp so the full command that was used to find the binary is included in the error message, to make i

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

jasonmolenda added inline comments. Comment at: lldb/source/Core/DynamicLoader.cpp:241-243 +Stream &s = target.GetDebugger().GetOutputStream(); +s.Printf("Tried DBGShellCommands cmd, got error: %s\n", + error.AsCString()); JDevlieg

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

jasonmolenda updated this revision to Diff 548009. jasonmolenda added a comment. fix typeo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157160/new/ https://reviews.llvm.org/D157160 Files: lldb/source/Core/DynamicLoader.cpp lldb/source/Plugins

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

JDevlieghere added inline comments. Comment at: lldb/source/Core/DynamicLoader.cpp:241-243 +Stream &s = target.GetDebugger().GetOutputStream(); +s.Printf("Tried DBGShellCommands cmd, got error: %s\n", + error.AsCString()); Shouldn'

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

jasonmolenda updated this revision to Diff 548001. jasonmolenda added a comment. Change calls to Log::Printf to use LLDB_LOGF(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157160/new/ https://reviews.llvm.org/D157160 Files: lldb/source/Core/D

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in ConnectionFileDescriptor

bulbazord accepted this revision. bulbazord added a comment. Makes sense to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in ConnectionFileDescriptor

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] 300c5aa - [lldb] Remove unused Socket::PreDisconnect (NFC)

Author: Jonas Devlieghere Date: 2023-08-07T15:50:06-07:00 New Revision: 300c5aaa0a2ae3b5bb7d14d4f11d93e4ea2666c1 URL: https://github.com/llvm/llvm-project/commit/300c5aaa0a2ae3b5bb7d14d4f11d93e4ea2666c1 DIFF: https://github.com/llvm/llvm-project/commit/300c5aaa0a2ae3b5bb7d14d4f11d93e4ea2666c1.d

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in ConnectionFileDescriptor

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, augusto2112. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. TSan reports the following data race: Write of size 4 at 0x000109e0b160 by thread T2 (

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

This revision was automatically updated to reflect the committed changes. Closed by commit rG57cbd26a68ab: Flag for LoadBinaryWithUUIDAndAddress, to create memory image or not (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D157167?vs=547866&id=547978#toc Reposito

[Lldb-commits] [lldb] 57cbd26 - Flag for LoadBinaryWithUUIDAndAddress, to create memory image or not

Author: Jason Molenda Date: 2023-08-07T15:19:45-07:00 New Revision: 57cbd26a68ab61631f5f4272d3c90df2eb0ce4f6 URL: https://github.com/llvm/llvm-project/commit/57cbd26a68ab61631f5f4272d3c90df2eb0ce4f6 DIFF: https://github.com/llvm/llvm-project/commit/57cbd26a68ab61631f5f4272d3c90df2eb0ce4f6.diff

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

bulbazord accepted this revision. bulbazord added a comment. LGTM Comment at: lldb/source/Core/Communication.cpp:115-118 +total_written += +WriteUnlocked(static_cast(src) + total_written, + src_len - total_written, status, error_ptr); while (

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157167/new/ https://reviews.llvm.org/D157167 ___

[Lldb-commits] [PATCH] D157168: [lldb] [mach-o corefiles] If we have LC_NOTE metadata and can't find a binary, don't fall back to an exhaustive scan

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.h:89 void CreateMemoryRegions(); - void LoadBinariesViaMetadata(); + bool LoadBinariesViaMetadata(); void LoadBinariesViaExhaustiveSearch(); bulbazord wr

[Lldb-commits] [PATCH] D157152: [lldb] Make TSan errors fatal when running the test suite

This revision was automatically updated to reflect the committed changes. Closed by commit rG17226c976e04: [lldb] Make TSan errors fatal when running the test suite (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [lldb] 17226c9 - [lldb] Make TSan errors fatal when running the test suite

Author: Jonas Devlieghere Date: 2023-08-07T13:20:38-07:00 New Revision: 17226c976e04856b10e2da34e93c89596660f882 URL: https://github.com/llvm/llvm-project/commit/17226c976e04856b10e2da34e93c89596660f882 DIFF: https://github.com/llvm/llvm-project/commit/17226c976e04856b10e2da34e93c89596660f882.d

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman added a comment. In D151683#4566907 , @eaeltsin wrote: > Hi, > > Is it a known issue, that clang doesn't compile `void foo(char *argv[] > [[maybe_unused]]) {}` ? The error is `error: 'maybe_unused' attribute cannot > be applied to types`.

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

eaeltsin added a comment. Hi, Is it a known issue, that clang doesn't compile `void foo(char *argv[] [[maybe_unused]]) {}` ? https://godbolt.org/z/r9E81cWxh - clang fails, but gcc doesn't. It looks like there is a lot of oss code of the form `void foo(char *argv[] ATTRIBUTE_UNUSED)`, where `A

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

jasonmolenda updated this revision to Diff 547866. jasonmolenda added a comment. Fix my `script print`'s to just `print`, I can't repo a buffering problem that I thought I had seen in the past. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157167/n

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

jasonmolenda added inline comments. Comment at: lldb/test/API/macosx/lc-note/multiple-binary-corefile/TestMultipleBinaryCorefile.py:38-39 ) +if self.TraceOn(): +self.runCmd("script print('Creating corefile with command %s')" % cmd) call(cmd

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

jasonmolenda updated this revision to Diff 547864. jasonmolenda added a comment. Incorporate Jonas' feedback about the naming of the new DynamicLoader method argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157167/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

jasonmolenda added inline comments. Comment at: lldb/include/lldb/Target/DynamicLoader.h:267 /// + /// \param[in] allow_use_memory_image_last_resort + /// If no better binary image can be found, allow reading the binary JDevlieghere wrote: > Nit: seems l

[Lldb-commits] [PATCH] D157152: [lldb] Make TSan errors fatal when running the test suite

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157152/new/ https://reviews.llvm.org/D157152 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D157168: [lldb] [mach-o corefiles] If we have LC_NOTE metadata and can't find a binary, don't fall back to an exhaustive scan

bulbazord added a comment. Patch looks good to me, one small suggestion about naming. Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.h:89 void CreateMemoryRegions(); - void LoadBinariesViaMetadata(); + bool LoadBinariesViaMetadata(); void LoadBinaries

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

bulbazord added a comment. I don't have any objections other than the questions Jonas has asked. LGTM otherwise Comment at: lldb/test/API/macosx/lc-note/multiple-binary-corefile/TestMultipleBinaryCorefile.py:38-39 ) +if self.TraceOn(): +self.runCm

[Lldb-commits] [lldb] aa27848 - [lldb] Fix typo in comments and in test

Author: Eymen Ünay Date: 2023-08-07T12:56:55Z New Revision: aa2784876a245f10811f65eb748c43574c17a173 URL: https://github.com/llvm/llvm-project/commit/aa2784876a245f10811f65eb748c43574c17a173 DIFF: https://github.com/llvm/llvm-project/commit/aa2784876a245f10811f65eb748c43574c17a173.diff LOG: [l

[Lldb-commits] [PATCH] D157214: [lldb] Fix typo in comments and in test

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa2784876a24: [lldb] Fix typo in comments and in test (authored by Eymay, committed by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157214/n

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D157214: [lldb] Fix typo in comments and in test

Eymay added a comment. Thanks @DavidSpickett. Can you land this patch for me? Please use “Eymen Ünay eymenu...@outlook.com" to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157214/new/ https://reviews.llvm.org/D157214 _

[Lldb-commits] [lldb] 91a0e83 - [lldb] Make IR interpreter timeout test more loose

Author: David Spickett Date: 2023-08-07T09:42:26Z New Revision: 91a0e832d42abc2890d4f8871a14003de6a9919e URL: https://github.com/llvm/llvm-project/commit/91a0e832d42abc2890d4f8871a14003de6a9919e DIFF: https://github.com/llvm/llvm-project/commit/91a0e832d42abc2890d4f8871a14003de6a9919e.diff LOG

[Lldb-commits] [PATCH] D157214: [lldb] Fix typo in comments and in test

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157214/new/ https://reviews.llvm.org/D157214