bulbazord added a comment.
I don't have any objections other than the questions Jonas has asked. LGTM
otherwise
================
Comment at:
lldb/test/API/macosx/lc-note/multiple-binary-corefile/TestMultipleBinaryCorefile.py:38-39
)
+ if self.TraceOn():
+ self.runCmd("script print('Creating corefile with command %s')" %
cmd)
call(cmd, shell=True)
----------------
JDevlieghere wrote:
> Out of curiosity what's the point of doing `self.runCmd("script print ...` vs
> printing the same thing directly? Does this run in another context or
> something? Do we save the command output somewhere?
I'm also curious. Printing directly is probably less expensive than running a
print command through the lldb python script interpreter.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157167/new/
https://reviews.llvm.org/D157167
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
