[Lldb-commits] [PATCH] D151615: [lldb] Change GetChildMemberWithName to take a StringRef, not ConstString

2023-05-28 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. In D151615#4378441 , @kastiglione wrote: > Do you have something in mind? I figured the test suite was enough. Do you > mean stress for perf, or for ensuring this change has no behavior regressions? I meant stress test for pe

[Lldb-commits] [PATCH] D151615: [lldb] Change GetChildMemberWithName to take a StringRef, not ConstString

2023-05-28 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a comment. In D151615#4378130 , @bulbazord wrote: > It may or may not have a measurable impact on performance, but my bet is that > it doesn't make it worse. yes the reason I wanted this change is for ergonomics, I was annoyed that it