kastiglione added a comment. In D151615#4378130 <https://reviews.llvm.org/D151615#4378130>, @bulbazord wrote:
> It may or may not have a measurable impact on performance, but my bet is that > it doesn't make it worse. yes the reason I wanted this change is for ergonomics, I was annoyed that it required a `ConstString` when internally it needs only a null terminated string. Eliminating these `ConstString`s won't have perf savings, but it won't have a perf cost either. > I suppose you could stress test the C++ formatters if you really wanted to > know though. Either way, thank you for doing this work! Do you have something in mind? I figured the test suite was enough. Do you mean stress for perf, or for ensuring this change has no behavior regressions? > We should probably change `CompilerType::GetIndexOfChildMemberWithName` to > take a `StringRef` instead of a `const char *` as a follow-up. I made the same observation. I figured this change was big enough and was also a single semantic change, so I didn't scope it out any further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151615/new/ https://reviews.llvm.org/D151615 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
