[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in shadow mode to event listeners

mib updated this revision to Diff 515960. mib added a comment. fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148397/new/ https://reviews.llvm.org/D148397 Files: lldb/include/lldb/API/SBAttachInfo.h lldb/include/lldb/API/SBLaunchInfo.h lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in shadow mode to event listeners

mib updated this revision to Diff 515959. mib added a comment. More renaming and reformat CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148397/new/ https://reviews.llvm.org/D148397 Files: lldb/include/lldb/API/SBAttachInfo.h lldb/include/lldb/API/SBLaunchInfo.h lldb/include/lldb/

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in shadow mode to event listeners

mib updated this revision to Diff 515956. mib marked an inline comment as done. mib retitled this revision from "[lldb/Utility] Add opt-in passthrough mode to event listeners" to "[lldb/Utility] Add opt-in shadow mode to event listeners". mib edited the summary of this revision. mib added a commen

[Lldb-commits] [PATCH] D148940: [Demangle] remove unused params of microsoftDemangle

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2709fcb0a5b: [Demangle] remove unused params of microsoftDemangle (authored by nickdesaulniers). Herald added a subscriber: JDevlieghere. Repositor

[Lldb-commits] [lldb] c2709fc - [Demangle] remove unused params of microsoftDemangle

Author: Nick Desaulniers Date: 2023-04-21T15:37:00-07:00 New Revision: c2709fcb0a5b32e42a35661fab4d5744e11d04c0 URL: https://github.com/llvm/llvm-project/commit/c2709fcb0a5b32e42a35661fab4d5744e11d04c0 DIFF: https://github.com/llvm/llvm-project/commit/c2709fcb0a5b32e42a35661fab4d5744e11d04c0.di

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I don't have an issue here then. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148395/new/ https://reviews.llvm.org/D148395

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

bulbazord added inline comments. Comment at: lldb/include/lldb/Target/Process.h:122 m_async(false) { ProcessInfo::operator=(launch_info); SetProcessPluginName(launch_info.GetProcessPluginName()); bulbazord wrote: > mib wrote: > > Because we mov

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

bulbazord added inline comments. Comment at: lldb/include/lldb/Target/Process.h:122 m_async(false) { ProcessInfo::operator=(launch_info); SetProcessPluginName(launch_info.GetProcessPluginName()); mib wrote: > Because we moved `m_listener_sp` an

[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

bulbazord added inline comments. Comment at: lldb/source/Target/PathMappingList.cpp:72 void PathMappingList::Append(const PathMappingList &rhs, bool notify) { + std::scoped_lock locks(m_mutex, rhs.m_mutex); ++m_mod_id; nickdesaulniers wrote: > ``` > /android

[Lldb-commits] [PATCH] D148940: [Demangle] remove unused params of microsoftDemangle

nickdesaulniers updated this revision to Diff 515935. nickdesaulniers added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - fix lldb, test building lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148940/new/ h

[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

nickdesaulniers added inline comments. Comment at: lldb/source/Target/PathMappingList.cpp:51 if (this != &rhs) { +std::scoped_lock locks(m_mutex, rhs.m_mutex); m_pairs = rhs.m_pairs; ``` [412/1011] Building CXX object tools/lldb/sourc...CMakeFiles/ll

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

This revision was automatically updated to reflect the committed changes. Closed by commit rG076341d1088b: Make sure SelectMostRelevantFrame happens only when returning to the user. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] 076341d - Make sure SelectMostRelevantFrame happens only when returning to the user.

Author: Jim Ingham Date: 2023-04-21T14:21:25-07:00 New Revision: 076341d1088b0b3e0140178760dc45ac5162cd65 URL: https://github.com/llvm/llvm-project/commit/076341d1088b0b3e0140178760dc45ac5162cd65 DIFF: https://github.com/llvm/llvm-project/commit/076341d1088b0b3e0140178760dc45ac5162cd65.diff LO

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148863/new/ https://reviews.llvm.org/D148863 ___

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

jingham updated this revision to Diff 515908. jingham added a comment. Adopted the "enum SelectMostRelevant" as Jonas suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148863/new/ https://reviews.llvm.org/D148863 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

mib updated this revision to Diff 515902. mib marked 2 inline comments as done. mib added a comment. Re-format python code with `black` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148548/new/ https://reviews.llvm.org/D148548 Files: lldb/bindings/interface/SBTargetExtensions.i lld

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib updated this revision to Diff 515899. mib marked 2 inline comments as done. mib added a comment. Re-format python code with `black` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 Files: lldb/test/API/functionalities/interactive_scripted

[Lldb-commits] [lldb] d9bc7f7 - TestSTL was marked as skipped unconditionally in 2018, undo

Author: Jason Molenda Date: 2023-04-21T13:17:43-07:00 New Revision: d9bc7f7844e803ea622f29e7367c8ba6dccde442 URL: https://github.com/llvm/llvm-project/commit/d9bc7f7844e803ea622f29e7367c8ba6dccde442 DIFF: https://github.com/llvm/llvm-project/commit/d9bc7f7844e803ea622f29e7367c8ba6dccde442.diff

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

JDevlieghere added inline comments. Comment at: lldb/test/API/functionalities/interactive_scripted_process/interactive_scripted_process.py:9 + +import os,json,struct,signal +import time bulbazord wrote: > mib wrote: > > bulbazord wrote: > > > nit: import these a

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

jingham added a comment. In D148863#4288186 , @mib wrote: > It's unfortunate that we're not able to determine easily if the stop is > public or not, so I guess this is the best we could do for now. > > We could however greatly reduce the amount of change

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

mib added inline comments. Comment at: lldb/include/lldb/Target/Thread.h:433 + // call it internally. + uint32_t GetSelectedFrameIndex(bool select_most_relevant) { +return GetStackFrameList() ditto Comment at: lldb/include/lldb/Target/Thr

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

mib added inline comments. Comment at: lldb/include/lldb/Target/StackFrameList.h:56 + /// pass false here. + uint32_t GetSelectedFrameIndex(bool select_most_relevant_frame); I'd suggested making `select_most_relevant_frame = false` by default. Repository:

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

mib added a comment. It's unfortunate that we're not able to determine easily if the stop is public or not, so I guess this is the best we could do for now. We could however greatly reduce the amount of changes in the patch by having `select_most_relevant` default to `false` (or the `true` eith

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

mib added a comment. In D148395#4287673 , @bulbazord wrote: > In D148395#4285017 , @mib wrote: > >> In D148395#4270508 , @bulbazord >> wrote: >> >>> Creating a ProcessAtt

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

manojgupta added a comment. Are there any objecttions? This patch is only making a consistent use of pre-existing and already in-use APIs/struct defintions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148752/new/ https://reviews.llvm.org/D148752

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

jgorbe added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147831/new/ https://reviews.llvm.org/D147831 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D148846: [lldb] Let Mangled decide whether a name is mangled or not

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGc1d55d26d373: [lldb] Let Mangled decide whether a name is mangled or not (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] c1d55d2 - [lldb] Let Mangled decide whether a name is mangled or not

Author: Jonas Devlieghere Date: 2023-04-21T10:23:24-07:00 New Revision: c1d55d26d373e8804aba92f7d0f07de353ea93c9 URL: https://github.com/llvm/llvm-project/commit/c1d55d26d373e8804aba92f7d0f07de353ea93c9 DIFF: https://github.com/llvm/llvm-project/commit/c1d55d26d373e8804aba92f7d0f07de353ea93c9.d

[Lldb-commits] [PATCH] D148846: [lldb] Let Mangled decide whether a name is mangled or not

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/test/API/macosx/format/TestFunctionNameWithoutArgs.py:1 +import os +import lldb aprantl wrote: > why? I assume the question is rhetoric, but on the off-chance it's

[Lldb-commits] [PATCH] D148863: Make sure SelectMostRelevantFrame happens only when returning to the user

jingham added a comment. In D148863#4285797 , @JDevlieghere wrote: > I looked at all the call sites and they all seemed reasonable in terms of > doing work on behalf of the user or not and selecting the most relevant frame > respectively. My only conce

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

bulbazord added a comment. Looks good to me. Might want to let @jingham or @JDevlieghere give it a look-over though. Comment at: lldb/test/API/functionalities/interactive_scripted_process/interactive_scripted_process.py:9 + +import os,json,struct,signal +import time -

[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. one nit but otherwise LGTM. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:124 + if (!CheckStructuredDataObject(LLVM_PRET

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

bulbazord added a comment. In D148395#4285017 , @mib wrote: > In D148395#4270508 , @bulbazord > wrote: > >> Creating a ProcessAttachInfo from a ProcessLaunchInfo with this change means >> they'll have different

[Lldb-commits] [PATCH] D148846: [lldb] Let Mangled decide whether a name is mangled or not

aprantl added inline comments. Comment at: lldb/test/API/macosx/format/TestFunctionNameWithoutArgs.py:7 + + +class TestFunctionNameWithoutArgs(TestBase): I guess this is a no debug info test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148846/new/ ht

[Lldb-commits] [PATCH] D148846: [lldb] Let Mangled decide whether a name is mangled or not

aprantl added inline comments. Comment at: lldb/test/API/macosx/format/TestFunctionNameWithoutArgs.py:1 +import os +import lldb why? Comment at: lldb/test/API/macosx/format/main.c:2 +#include +#include + why? CHANGES SINCE

[Lldb-commits] [PATCH] D148846: [lldb] Let Mangled decide whether a name is mangled or not

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. It seems like we can quickly and unambiguously decide whether a name is mangled or not by looking at the first characters so that seems fine to me. Does Mangled try all Language plugins to d

[Lldb-commits] [PATCH] D148823: Make diagnostics API safer to use

This revision was automatically updated to reflect the committed changes. Closed by commit rG737820e6d6e2: Make diagnostics API safer to use (authored by aprantl). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [lldb] 737820e - Make diagnostics API safer to use

Author: Adrian Prantl Date: 2023-04-21T08:21:56-07:00 New Revision: 737820e6d6e2df50f2ddf522a0db9ffb794ff749 URL: https://github.com/llvm/llvm-project/commit/737820e6d6e2df50f2ddf522a0db9ffb794ff749 DIFF: https://github.com/llvm/llvm-project/commit/737820e6d6e2df50f2ddf522a0db9ffb794ff749.diff

[Lldb-commits] [lldb] 70d8c01 - [lldb] Update QEMU git URL in setup.sh

Author: David Spickett Date: 2023-04-21T14:31:39Z New Revision: 70d8c01e45741ca70f1da16f1ad61112d90b6474 URL: https://github.com/llvm/llvm-project/commit/70d8c01e45741ca70f1da16f1ad61112d90b6474 DIFF: https://github.com/llvm/llvm-project/commit/70d8c01e45741ca70f1da16f1ad61112d90b6474.diff LOG

[Lldb-commits] [lldb] c9083be - [LLDB] Don't print register fields when asked for a specific format

Author: David Spickett Date: 2023-04-21T11:47:05Z New Revision: c9083bea168699b4078b27ce88fd35562751f46f URL: https://github.com/llvm/llvm-project/commit/c9083bea168699b4078b27ce88fd35562751f46f DIFF: https://github.com/llvm/llvm-project/commit/c9083bea168699b4078b27ce88fd35562751f46f.diff LOG

[Lldb-commits] [PATCH] D148790: [LLDB] Don't print register fields when asked for a specific format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9083bea1686: [LLDB] Don't print register fields when asked for a specific format (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D148790: [LLDB] Don't print register fields when asked for a specific format

DavidSpickett updated this revision to Diff 515669. DavidSpickett added a comment. dispayed -> displayed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148790/new/ https://reviews.llvm.org/D148790 Files: lldb/source/Commands/CommandObjectRegister