[Lldb-commits] [lldb] abddb83 - [lldb] Fix type of --apply-fixits (NFC)

Author: Dave Lee Date: 2023-03-23T22:49:29-07:00 New Revision: abddb8359895a2040a3439850f5c8c9c61123947 URL: https://github.com/llvm/llvm-project/commit/abddb8359895a2040a3439850f5c8c9c61123947 DIFF: https://github.com/llvm/llvm-project/commit/abddb8359895a2040a3439850f5c8c9c61123947.diff LOG:

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

kastiglione added a comment. @jgorbe thank you for letting me know! It's not intended that the names of child values are not printed. I have a fix ready for review here D146783 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham, jgorbe. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When printing a value, allow the root value's name to be elid

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

jgorbe added a comment. By the way, I just bisected another problem to this commit: I'm seeing in some cases that prettyprinted values with synthetic children don't show child names when using `dwim-print`. So print used to show: (lldb) p c (MyClass) $0 = MyClass object with children: {

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' # symbol + offset

[Lldb-commits] [PATCH] D146779: Fix handling of backticks in CommandObjectParsed commands

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:1754-1760 +if (error.Success()) { + command.erase(start_backtick, end_backtick - start_ba

[Lldb-commits] [PATCH] D146779: Fix handling of backticks in CommandObjectParsed commands

jingham created this revision. jingham added reviewers: JDevlieghere, bulbazord, kastiglione. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A while back I reworked the way that backticks are handled to

[Lldb-commits] [PATCH] D146152: Add __lldb_init_module_with_target for use when sourcing modules for a target

bulbazord added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:1031-1048 + // First call the target initializer: + if (target) { +python_function_name_string += ".__lldb_init_module_with_target"; +python_function_name = python_function_name_string

[Lldb-commits] [lldb] ccc2f36 - Android.rules: remove mips* rules

Author: Fangrui Song Date: 2023-03-23T15:58:43-07:00 New Revision: ccc2f362db352df8991f493d8a05bdf99eaeea4b URL: https://github.com/llvm/llvm-project/commit/ccc2f362db352df8991f493d8a05bdf99eaeea4b DIFF: https://github.com/llvm/llvm-project/commit/ccc2f362db352df8991f493d8a05bdf99eaeea4b.diff

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:540 +image = self.get_used_image(image_id) frame_offset = int(json_frame['imageOffset']) bulbazord wrote: > is `image` not the same as `json_image` from a few lines

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

int3 added a comment. I'm trying to add similar support to lld-macho, hence the question :) Comment at: lld/COFF/LTO.cpp:183 + [&](size_t task, const Twine &moduleName) { +buf[task].first = moduleName.str(); return std::make_unique( Any re

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:540 +image = self.get_used_image(image_id) frame_offset = int(json_frame['imageOffset']) is `image` not the same as `json_image` from a few lines above this?

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' # symbol + offset

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:552-557 +self.symbol_data[image_uuid]["symbols"].append({ +"name": json_frame['symbol'], +"type": "code", +"size": 0, +

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib created this revision. mib added reviewers: JDevlieghere, kastiglione, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. Sometimes, crash reports come with inlined symbols. These provide the exact

[Lldb-commits] [lldb] 088da8a - [lldb][NFC] makeArrayRef -> ArrayRef

Author: Arthur Eubanks Date: 2023-03-23T14:05:06-07:00 New Revision: 088da8a0e57a461f3be4b554f28c4419418c097c URL: https://github.com/llvm/llvm-project/commit/088da8a0e57a461f3be4b554f28c4419418c097c DIFF: https://github.com/llvm/llvm-project/commit/088da8a0e57a461f3be4b554f28c4419418c097c.diff

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

This revision was automatically updated to reflect the committed changes. Closed by commit rGd557384b43d3: [LLDB] Fix for D139955 Summary: (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D14

[Lldb-commits] [lldb] d557384 - [LLDB] Fix for D139955 Summary:

Author: Alexander Yermolovich Date: 2023-03-23T14:03:42-07:00 New Revision: d557384b43d32700ed09b08564a4f7823061d999 URL: https://github.com/llvm/llvm-project/commit/d557384b43d32700ed09b08564a4f7823061d999 DIFF: https://github.com/llvm/llvm-project/commit/d557384b43d32700ed09b08564a4f7823061d9

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507855. ayermolo added a comment. fixed up refs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D146659 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp l

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo added a comment. In D146659#4217557 , @clayborg wrote: > Must be relocations causing the stuff to not match up to the llvm-dwarfdump > output. Looked through llvm-dwarfdump code. Yep. since relocation exists, it just returns an addend which is

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. Is there any more feedback on this patch? After all, this adds test coverage for existing functionality (with the new GNUstep runtime plugin from D146154 that is ready to land). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [lldb] 0c5cee7 - [lldb-server] Use Platform plugin corresponding to the host

Author: Alex Langford Date: 2023-03-23T12:59:25-07:00 New Revision: 0c5cee779929f840f4f286c5894a01f583ee7b4a URL: https://github.com/llvm/llvm-project/commit/0c5cee779929f840f4f286c5894a01f583ee7b4a DIFF: https://github.com/llvm/llvm-project/commit/0c5cee779929f840f4f286c5894a01f583ee7b4a.diff

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c5cee779929: [lldb-server] Use Platform plugin corresponding to the host (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146668/new/

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Must be relocations causing the stuff to not match up to the llvm-dwarfdump output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

jgorbe added a comment. > Are you using persistent results? If not, how much effort is it to either 1) > change the tools/code that examine the output to not look for $\d+, or 2) use > a custom print/p alias? Honest question. I'm not using them myself, and it's not much effort to fix the proble

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s:11 +# CHECK: 0x006e: adding range [0x-0x001f) +# CHECK-SAME: which has a base that is less than the function's low PC 0x0021. +# CHE

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 added inline comments. Comment at: lldb/include/lldb/Target/Target.h:253 + bool GetEnableTrampolineSupport() const; + JDevlieghere wrote: > What does trampoline "support" mean? Could this be named something more > descriptive? From the description

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 updated this revision to Diff 507841. augusto2112 marked 14 inline comments as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146679/new/ https://reviews.llvm.org/D146679 Files: ll

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

kastiglione added a comment. > Oh, so in the cases where `dwim-print` delegates to frame variable you can't > then refer to that result in another `dwim-print` command/other place where > you'd like to reference a previously printed value? If the variable is in scope, you can use the variable.

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

dblaikie added a comment. > The rationale is: dwim-print doesn't always use expression evaluation, it > prefers to use frame variable where possible. In the future it could be > expanded, for example to print register as well. Because dwim-print doesn't > always use expression, there isn't alwa

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

clayborg added a comment. FYI: This might be because we are using a .o file and relocations are being applied internally!? Comment at: lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s:11 +# CHECK: 0x006e: adding range [0x-0x001f) +# CH

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

clayborg added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s:11 +# CHECK: 0x006e: adding range [0x-0x001f) +# CHECK-SAME: which has a base that is less than the function's low PC 0x0021. +# CHE

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2640 if (!D || !D->isCompleteDefinition()) -return FwdDecl; +return {FwdDecl, nullptr}; aprantl wrote: > I'm curious if this works if we encounter a forward declaration,

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507812. ayermolo added a comment. updated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D146659 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp ll

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

clayborg added a comment. Fix the error message to check for the exact error message and this is good to go. Comment at: lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s:10 + +# CHECK: which has a base that is less than the function's low PC + might

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

aprantl added a comment. > breaks basically anything that examines debugger output I'd be curious to learn about some example you have in mind here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145609/new/ https://reviews.llvm.org/D145609 __

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

kastiglione added a comment. > Also `--persistent-result on` can't be passed to print, it only works for me > if I run specifically `dwim-print`. Is that intended? The intension is that for users who want persistent results enabled can do so by customizing their `p` or `print` alias, like so:

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

jgorbe added a comment. What was the rationale for this change? It changes the output format of a common command (given that `print` is now an alias for `dwim-print`) and it breaks basically anything that examines debugger output. Also `--persistent-result on` can't be passed to `print`, it onl

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:664 + llvm::StringRef m_trampoline_target; + I'd like to see a doxygen comment (1) explaining what the trampoline target is (i.e. according to the summary the mangled name of

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

This revision was automatically updated to reflect the committed changes. Closed by commit rGc640a146c4ca: [lldb] Explicitly set libcxx paths when USE_SYSTEM_STDLIB is provided (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146

[Lldb-commits] [lldb] c640a14 - [lldb] Explicitly set libcxx paths when USE_SYSTEM_STDLIB is provided

Author: Felipe de Azevedo Piovezan Date: 2023-03-23T11:53:13-04:00 New Revision: c640a146c4caa3cca559e308e2e7ecc78c45140d URL: https://github.com/llvm/llvm-project/commit/c640a146c4caa3cca559e308e2e7ecc78c45140d DIFF: https://github.com/llvm/llvm-project/commit/c640a146c4caa3cca559e308e2e7ecc78

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

fdeazeve updated this revision to Diff 507757. fdeazeve added a comment. Fix typo in error msg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146714/new/ https://reviews.llvm.org/D146714 Files: lldb/packages/Python/lldbsuite/test/make/Makefile.ru

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

fdeazeve updated this revision to Diff 507756. fdeazeve added a comment. Improve error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146714/new/ https://reviews.llvm.org/D146714 Files: lldb/packages/Python/lldbsuite/test/make/Makefile.ru

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:434 +ifeq "$(SDKROOT)" "" + $(error "SDKROOT should have been set") +endif Repository: r

[Lldb-commits] [lldb] 5193c4a - [lldb][AArch64] Fix run-qemu.sh when only MTE is enabled.

Author: David Spickett Date: 2023-03-23T13:48:44Z New Revision: 5193c4a8b38c3e61c862d5badf1cace7c26324f7 URL: https://github.com/llvm/llvm-project/commit/5193c4a8b38c3e61c862d5badf1cace7c26324f7 DIFF: https://github.com/llvm/llvm-project/commit/5193c4a8b38c3e61c862d5badf1cace7c26324f7.diff LOG

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

fdeazeve updated this revision to Diff 507711. fdeazeve added a comment. Fix typos in commit message. Add hard error in case SDKROOT is not set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146714/new/ https://reviews.llvm.org/D146714 Files: ll

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

Michael137 added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:434 +CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem $(SDKROOT)/usr/include/c++/v1 +LDFLAGS += -L$(SDKROOT)/usr/lib -Wl,-rpath,$(SDKROOT)/usr/lib -lc++ +end

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

fdeazeve added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:434 +CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem $(SDKROOT)/usr/include/c++/v1 +LDFLAGS += -L$(SDKROOT)/usr/lib -Wl,-rpath,$(SDKROOT)/usr/lib -lc++ +endif

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

Michael137 added a comment. Typo in commit message and description: `USE_SYSTEM_LIBCXX` should be `USE_SYSTEM_STDLIB` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146714/new/ https://reviews.llvm.org/D146714 _

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

Michael137 added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:434 +CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem $(SDKROOT)/usr/include/c++/v1 +LDFLAGS += -L$(SDKROOT)/usr/lib -Wl,-rpath,$(SDKROOT)/usr/lib -lc++ +end

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. Makes sense to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146714/new/ https://reviews.llvm.org/D146714 _

[Lldb-commits] [PATCH] D146714: [lldb] Explicitly set libcxx paths when USE_SYSTEM_LIBCXX is provided

fdeazeve created this revision. Herald added a subscriber: mikhail.ramalho. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For tests marked as "USE_SYSTEM_LIBCXX", the expectation is that the system's

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added a comment. > So the better solution may be along the lines of a register formatting plugin > that depends on TypeSystemClang. Based on discussion here and on another patch, I'm going to try Adrian's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

DavidSpickett added a comment. > I suppose it just depends on what you're trying to do, which I realize may > not be the most helpful advice but I hope that with enough examples it > becomes at least a little more clear how things in lldb are currently done... No it makes sense, I think I have

Re: [Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

> But the command interpreter doesn't "depend" on these plugin commands, it just vends them. Right, I'm conflating depending on as in linking to or specifically asking for a certain plugin, vs. making use of the information that category of plugins could provide if they are present. Commands don't