clayborg added a comment.

Fix the error message to check for the exact error message and this is good to 
go.



================
Comment at: lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s:10
+
+# CHECK: which has a base that is less than the function's low PC
+
----------------
might be good to verify that the correct DIE offset of the block ID is. in the 
error message. If this code hadn't assert'ed we still might have gotten a 
string output, but we need to verify the data is correct. If you run it 
manually once you can see the exact error message we will need to check for.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146659/new/

https://reviews.llvm.org/D146659

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to