[Lldb-commits] [PATCH] D142067: Remove the "help" subcommand - its undocumented, undiscoverable and doesn't work....

jingham created this revision. jingham added reviewers: JDevlieghere, jasonmolenda. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For some reason (lost in the mists of time) CommandObjectMultiword will

[Lldb-commits] [PATCH] D142059: [lldb/Plugins] Add ScriptedProcess::GetCapabilities affordance (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142059/new/ https://reviews.llvm.org/D142059 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D142059: [lldb/Plugins] Add ScriptedProcess::GetCapabilities affordance (NFC)

mib updated this revision to Diff 490301. mib added a comment. Add python docstring CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142059/new/ https://reviews.llvm.org/D142059 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/include/lldb/Interpreter/ScriptedProc

[Lldb-commits] [PATCH] D142059: [lldb/Plugins] Add ScriptedProcess::GetCapabilities affordance (NFC)

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new method to the Scripted Process interface, GetCapabilities. T

[Lldb-commits] [PATCH] D141972: Delay loading of qProcessInfo-informed binaries until later in the Process setup

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb223b7f01f7: Do qProcessInfo-hint binary loading later in Process setup (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141972/new

[Lldb-commits] [lldb] db223b7 - Do qProcessInfo-hint binary loading later in Process setup

Author: Jason Molenda Date: 2023-01-18T12:33:05-08:00 New Revision: db223b7f01f70cbd8459d0db9b20dfe9a3b099a7 URL: https://github.com/llvm/llvm-project/commit/db223b7f01f70cbd8459d0db9b20dfe9a3b099a7 DIFF: https://github.com/llvm/llvm-project/commit/db223b7f01f70cbd8459d0db9b20dfe9a3b099a7.diff

[Lldb-commits] [PATCH] D142052: [lldb] Implement SymbolFile::CopyType

augusto2112 created this revision. augusto2112 added a reviewer: clayborg. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SymbolFiles should be the only point of creation of Types to ensure that the

[Lldb-commits] [PATCH] D141972: Delay loading of qProcessInfo-informed binaries until later in the Process setup

jasonmolenda updated this revision to Diff 490258. jasonmolenda added a comment. Thanks for the feedback Jonas, updated patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141972/new/ https://reviews.llvm.org/D141972 Files: lldb/source/Plugins/

[Lldb-commits] [PATCH] D141972: Delay loading of qProcessInfo-informed binaries until later in the Process setup

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:998 + DynamicLoader::LoadBinaryWithUUIDAndAddress( + this, llvm::String

[Lldb-commits] [PATCH] D141972: Delay loading of qProcessInfo-informed binaries until later in the Process setup

jasonmolenda updated this revision to Diff 490232. jasonmolenda added a comment. Add a comment about the intentional placement of binary loading/load address setting in DidLaunchOrAttach to address Jim's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D142034: [lldb][Language] List supported languages in expr error text

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4a0b9fab4dc: [lldb][Language] List supported languages in expr error text (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142034/new

[Lldb-commits] [lldb] b4a0b9f - [lldb][Language] List supported languages in expr error text

Author: Michael Buch Date: 2023-01-18T18:18:52Z New Revision: b4a0b9fab4dcb7b808612b49604709c2aeadf9f8 URL: https://github.com/llvm/llvm-project/commit/b4a0b9fab4dcb7b808612b49604709c2aeadf9f8 DIFF: https://github.com/llvm/llvm-project/commit/b4a0b9fab4dcb7b808612b49604709c2aeadf9f8.diff LOG:

[Lldb-commits] [PATCH] D142034: [lldb][Language] List supported languages in expr error text

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Nice. IIUC, this will query every already registered plugin, so it should also work without modification for e.g., LLDB with Swift support. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D142034: [lldb][Language] List supported languages in expr error text

Michael137 updated this revision to Diff 490203. Michael137 added a comment. - Language name pair can be `const &` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142034/new/ https://reviews.llvm.org/D142034 Files: lldb/include/lldb/Target/Languag

[Lldb-commits] [PATCH] D142034: [lldb][Language] List supported languages in expr error text

Michael137 updated this revision to Diff 490199. Michael137 added a comment. - Use `GetLanguagesSupportingTypeSystemsForExpressions` instead of `GetSupportedLanguages` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142034/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D142034: [lldb][Language] List supported languages in expr error text

Michael137 created this revision. Michael137 added reviewers: jingham, aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before: (lldb) expr --language abc -- 1 + 1 error: unknown language

[Lldb-commits] [PATCH] D142007: [NFC] Fix "form/from" typos

pfusik added a comment. In D142007#4062211 , @ldionne wrote: > LGTM, thanks! I don't think you need to wait for other owners to approve > before landing this, this is pretty clearly an improvement. I have no commit access, could you please commit this f

[Lldb-commits] [PATCH] D142007: [NFC] Fix "form/from" typos

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM, thanks! I don't think you need to wait for other owners to approve before landing this, this is pretty clearly an improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D142007: [NFC] Fix "form/from" typos

pfusik created this revision. Herald added subscribers: Moerafaat, zero9178, steakhal, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, martong, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rridd

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan updated this revision to Diff 490077. cimacmillan edited the summary of this revision. cimacmillan added a comment. Add handling for const and register cases. Setting watchpoint on SBValue rather than the address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:493 if (!loaded_images_sp->ForEach(reload_image)) return ScriptedInterface::ErrorWithMessage( I'm just thinking about this but I don't see any reason not to