JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
LGMT ================ Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:998 + DynamicLoader::LoadBinaryWithUUIDAndAddress( + this, llvm::StringRef(), standalone_uuid, standalone_value, + standalone_value_is_offset, force_symbol_search, notify); ---------------- I know you just moved this code, but I don't think I've ever seen anyone write `llvm::StringRef()` instead of `""`. ================ Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1007-1008 + // and we are only given the addresses of the binaries. + // Not intended for use with userland debugging when we + // a DynamicLoader plugin that knows how to find the loaded + // binaries and will track updates as binaries are added. ---------------- I think the word "use" is missing at the end of line 1007. ================ Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1019-1020 + // binary that may determine the DynamicLoader and + // Platform to be used in this Process/Target in the + // process of loading it. + if (GetTarget() ---------------- I suspect you meant to replace "in this Process/Target" with "in the process of loading it"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141972/new/ https://reviews.llvm.org/D141972 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
