[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 marked 2 inline comments as done. mark2185 added a comment. Did I just overwrite the initial commit with a new one, instead of just creating a diff based on the two comments? I'm terribly sorry, should I just squash my two commits and run `arc diff --update=D136465` again? Repository

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 updated this revision to Diff 470381. mark2185 added a comment. Remove {} for single line if statements per LLVM coding guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136465/new/ https://reviews.llvm.org/D136465 Files: lldb/so

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 added a comment. In D136465#3880809 , @clayborg wrote: > Is there any way to test this? Through the test suite? I couldn't find //any// `android platform` related tests, and this would require `adb` to be running in the background, so I'm not

[Lldb-commits] [PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470348. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td clang/include/clang

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

seehearfeel updated this revision to Diff 470345. seehearfeel edited the summary of this revision. seehearfeel set the repository for this revision to rG LLVM Github Monorepo. seehearfeel added a comment. Remove GPRegSet and FPRegSet definitions which are not used in this commit. Use git clang-for

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

wallace updated this revision to Diff 470343. wallace added a comment. address issues and comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136557/new/ https://reviews.llvm.org/D136557 Files: lldb/include/lldb/Core/PluginManager.h lldb/so

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

SixWeining added a comment. Build is OK on my local LoongArch machine with 229 failed tests and 2 timed out tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136578/new/ https://reviews.llvm.org/D136578 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:123 /// of a DenseMap because DenseMap can't understand enums. -std::unordered_map events_counts; -size_t total_count = 0; +std::unordered_map events_counts; +uint64

[Lldb-commits] [PATCH] D136557: [trace][intel pt] Simple detection of infinite decoding loops

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. looks good overall, mainly some questions and a few nits Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:123 /// of a DenseMap because DenseMa

[Lldb-commits] [PATCH] D136650: Add a check for TypeSystem use-after-free problems

aprantl created this revision. aprantl added reviewers: kastiglione, jingham, labath. Herald added a project: All. aprantl requested review of this revision. When a process gets restarted TypeSystem objects associated with it may get deleted, and any CompilerType objects holding on to a reference

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1551 +} +if (!all_template_names.empty()) { + all_template_names.append(">"); labath wrote: > When can this be empty? Should we still include the

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 470321. aeubanks marked 3 inline comments as done. aeubanks added a comment. address comments rebasing to ToT, TestCPPBreakpointsLocations.py is failing when using -gsimple-template-names. still working on that Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D136207: [lldb] Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd00c4db747e: Fix breakpoint setting so it always works when there is a line entry in a… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] dd00c4d - Fix breakpoint setting so it always works when there is a line entry in a compile unit's line table.

Author: Greg Clayton Date: 2022-10-24T16:28:39-07:00 New Revision: dd00c4db747e27f53a5621a8b9c50711f00894ef URL: https://github.com/llvm/llvm-project/commit/dd00c4db747e27f53a5621a8b9c50711f00894ef DIFF: https://github.com/llvm/llvm-project/commit/dd00c4db747e27f53a5621a8b9c50711f00894ef.diff

[Lldb-commits] [PATCH] D136648: [lldb] Emit diagnostic events in the diagnostic dump

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, kastiglione. Herald added a project: All. JDevlieghere requested review of this revision. Emit diagnostic events (errors and warnings) in the diagnostic dump. This patch also adds an "information" diagnostic event

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

clayborg added a comment. Is there any way to test this? Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:95-97 + if (gdbstub_port) { +local_port = std::stoi(gdbstub_port); + } remove {} for single line if statements pe

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

hawkinsw reopened this revision. hawkinsw added a comment. This revision is now accepted and ready to land. I updated this revision with the following change and I *think* that things are happy again: diff --git a/lldb/source/Core/ValueObject.cpp b/lldb/source/Core/ValueObject.cpp index 226

[Lldb-commits] [PATCH] D136620: Change how debugserver clears auth bits from pc/fp/sp/lr with thread_get_state on Darwin

jasonmolenda updated this revision to Diff 470298. jasonmolenda added a comment. Update patch to address Jonas' comments -- using a std::call_once to initialize the number of addressing bits, and making the return clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectDiagnostics.cpp:84 +if (!directory) { + result.AppendError(llvm::toString(directory.takeError())); + result.SetStatus(eReturnStatusFailed); clayborg wrote: > Do we wan

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

JDevlieghere updated this revision to Diff 470283. JDevlieghere marked 8 inline comments as done. JDevlieghere added a comment. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135622/new/ https://reviews.llvm.org/D135622 Files: lldb/include/lldb/Utility/Dia

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a comment. Thanks. Since this is not urgent, I'll let it wait for others to chime in a while more. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

dblaikie added a comment. In D136011#3870677 , @labath wrote: > In D136011#3866854 , @aeubanks > wrote: > >> In D136011#3862150 , @labath wrote: >> >>> >> >> Maybe looki

[Lldb-commits] [lldb] 7590776 - [lldb] Skip TestFullLtoStepping in older clangs

Author: Augusto Noronha Date: 2022-10-24T12:12:36-07:00 New Revision: 7590776b852f28ba8d569e17d989060f33d0e7a3 URL: https://github.com/llvm/llvm-project/commit/7590776b852f28ba8d569e17d989060f33d0e7a3 DIFF: https://github.com/llvm/llvm-project/commit/7590776b852f28ba8d569e17d989060f33d0e7a3.dif

[Lldb-commits] [lldb] 5b17eb1 - [lldb] Fix stale diagnostic event comments (NFC)

Author: Jonas Devlieghere Date: 2022-10-24T11:14:52-07:00 New Revision: 5b17eb1c1e152a6d7dbcb94d7613bc2a7ea0b92b URL: https://github.com/llvm/llvm-project/commit/5b17eb1c1e152a6d7dbcb94d7613bc2a7ea0b92b DIFF: https://github.com/llvm/llvm-project/commit/5b17eb1c1e152a6d7dbcb94d7613bc2a7ea0b92b.d

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny updated this revision to Diff 470225. mgorny edited the summary of this revision. mgorny added a comment. Herald added a project: LLVM. Use a shared policy file via `include()` instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 Fi

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

zequanwu added a comment. In D136209#3878821 , @labath wrote: > So if I understand correctly, when we deserialize incorrectly, this causes us > to misclassify some function parameters (arguments) as local variables. Is > that correct? If yes, then that

[Lldb-commits] [PATCH] D136620: Change how debugserver clears auth bits from pc/fp/sp/lr with thread_get_state on Darwin

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/DNB.cpp:1830-1837 + static bool g_tried_addressing_bits_syscall = false; + if (g_tried_addressing_bits_syscall == false) { +size_t len = sizeof(uint32_t); +if (::sysctlbyname("machdep.virtual_

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. pretty good! I just left cosmetic requests Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:285-312 + if (event.has_tsc) { +if (m_tsc

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added inline comments. Comment at: clang/CMakeLists.txt:6 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) + # Please keep policies in sync with llvm/CMakeLists.txt. + if(POLICY CMP0114) nickdesaulniers wrote: > Seems error prone. Does cmake have

[Lldb-commits] [PATCH] D136620: Change how debugserver clears auth bits from pc/fp/sp/lr with thread_get_state on Darwin

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. When debugserver thre

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

nickdesaulniers added inline comments. Comment at: clang/CMakeLists.txt:6 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) + # Please keep policies in sync with llvm/CMakeLists.txt. + if(POLICY CMP0114) Seems error prone. Does cmake have an include syste

[Lldb-commits] [PATCH] D136600: [lldb-tests] Force use of system stdlib for Objective-C test

This revision was automatically updated to reflect the committed changes. Closed by commit rGc413df064e85: [lldb-tests] Force use of system stdlib for Objective-C test (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136600/new/

[Lldb-commits] [lldb] c413df0 - [lldb-tests] Force use of system stdlib for Objective-C test

Author: Felipe de Azevedo Piovezan Date: 2022-10-24T12:39:48-04:00 New Revision: c413df064e85623003ae624835177d19a23fffe9 URL: https://github.com/llvm/llvm-project/commit/c413df064e85623003ae624835177d19a23fffe9 DIFF: https://github.com/llvm/llvm-project/commit/c413df064e85623003ae624835177d19a

[Lldb-commits] [PATCH] D136608: [lldb-tests] Remove libstdc++ requirement from test

This revision was automatically updated to reflect the committed changes. Closed by commit rG73200d155a58: [lldb-tests] Remove libstdc++ requirement from test (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136608/new/ https://

[Lldb-commits] [lldb] 73200d1 - [lldb-tests] Remove libstdc++ requirement from test

Author: Felipe de Azevedo Piovezan Date: 2022-10-24T16:27:10Z New Revision: 73200d155a5882f5bda918596abdc143c991cf0f URL: https://github.com/llvm/llvm-project/commit/73200d155a5882f5bda918596abdc143c991cf0f DIFF: https://github.com/llvm/llvm-project/commit/73200d155a5882f5bda918596abdc143c991cf

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

JDevlieghere abandoned this revision. JDevlieghere added a comment. Seems like the consensus is that we prefer a dedicated API rather than using the existing logging infrastructure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135621/new/ https://reviews.llvm.org/D135621

[Lldb-commits] [PATCH] D136610: [trace][intelpt] Fix multi CPU decoding TSC assertion error

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Occasionally the assertion that enforces increasing TSC values in `DecodedTh

[Lldb-commits] [PATCH] D136608: [lldb-tests] Remove libstdc++ requirement from test

fdeazeve updated this revision to Diff 470165. fdeazeve added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136608/new/ https://reviews.llvm.org/D136608 Files: lldb/test/API/functionalities/data-formatter/data-formatter-skip-

[Lldb-commits] [PATCH] D136608: [lldb-tests] Remove libstdc++ requirement from test

fdeazeve created this revision. fdeazeve added a reviewer: Michael137. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This requirement dates back to ten years ago and the test seems to work nowadays wi

[Lldb-commits] [PATCH] D136600: [lldb-tests] Force use of system stdlib for Objective-C test

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136600/new/ https://reviews.llvm.org/D136600 ___

[Lldb-commits] [PATCH] D136600: [lldb-tests] Force use of system stdlib for Objective-C test

fdeazeve updated this revision to Diff 470146. fdeazeve added a comment. Herald added a subscriber: JDevlieghere. Edit commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136600/new/ https://reviews.llvm.org/D136600 Files: lldb/test/API

[Lldb-commits] [PATCH] D136600: [lldb-tests] Force use of system stdlib for Objective-C test

fdeazeve created this revision. fdeazeve added a reviewer: aprantl. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The test TestObjCDirectMethods loads the Objective C runtime, which doesn't work well

[Lldb-commits] [PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

erichkeane accepted this revision. erichkeane added a comment. A couple of nits, otherwise I don't have to see this again. Comment at: clang/include/clang/AST/TemplateName.h:158 + // When true the substitution will be finalized (subst node won't be placed). + bool getFinal()

[Lldb-commits] [PATCH] D136551: [lldb] Include gtest in standalone build only if LLDB_INCLUDE_TESTS

mgorny added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136551/new/ https://reviews.llvm.org/D136551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D136551: [lldb] Include gtest in standalone build only if LLDB_INCLUDE_TESTS

This revision was automatically updated to reflect the committed changes. Closed by commit rG52f39853abd4: [lldb] Include gtest in standalone build only if LLDB_INCLUDE_TESTS (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D136551?vs=469980&

[Lldb-commits] [lldb] 52f3985 - [lldb] Include gtest in standalone build only if LLDB_INCLUDE_TESTS

Author: Michał Górny Date: 2022-10-24T15:51:43+02:00 New Revision: 52f39853abd46495a6d636c4b035e1b92cf4b833 URL: https://github.com/llvm/llvm-project/commit/52f39853abd46495a6d636c4b035e1b92cf4b833 DIFF: https://github.com/llvm/llvm-project/commit/52f39853abd46495a6d636c4b035e1b92cf4b833.diff

[Lldb-commits] [PATCH] D136551: [lldb] Include gtest in standalone build only if LLDB_INCLUDE_TESTS

labath added inline comments. Comment at: lldb/CMakeLists.txt:20 +option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests." ${LLVM_INCLUDE_TESTS}) + mgorny wrote: > labath wrote: > > mgorny wrote: > > > To be honest, I don't exactly like movi

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 requested review of this revision. kasper81 added a comment. @MaskRay could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 ___

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

seehearfeel added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.h:24 + +class NativeRegisterContextLinux_loongarch64 : public NativeRegisterContextLinux { +public: SixWeining wrote: > Pls limit the columns

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny updated this revision to Diff 470108. mgorny retitled this revision from "[lld] Copy cmake_policy() to silence CMake warnings in standalone builds" to "Harmonize cmake_policy() across standalone builds of all projects". mgorny edited the summary of this revision. mgorny added reviewers: me

[Lldb-commits] [PATCH] D136462: [LLDB] Add color to output text when searching for symbols

DavidSpickett added a comment. And if it helps to refactor in parent patches to make this change easier, go for it. Maybe you add generic colouring support to something, then the last patch hooks it up to the symbol lookup, something along those lines. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D136462: [LLDB] Add color to output text when searching for symbols

DavidSpickett added a comment. I agree that this change names - print - restore names is going to cause problems. Pavel is right that this should happen in some dump function somewhere. But, assuming what you've got works to an extent, you should add some testing first. That will allow you to

[Lldb-commits] [PATCH] D136552: [lldb] Add LLVM include dirs prior to gtest target in standalone build

This revision was automatically updated to reflect the committed changes. Closed by commit rGd15239388cca: [lldb] Add LLVM include dirs prior to gtest target in standalone build (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d152393 - [lldb] Add LLVM include dirs prior to gtest target in standalone build

Author: Michał Górny Date: 2022-10-24T12:18:14+02:00 New Revision: d15239388cca8a5031119b4660e456c26ca5f379 URL: https://github.com/llvm/llvm-project/commit/d15239388cca8a5031119b4660e456c26ca5f379 DIFF: https://github.com/llvm/llvm-project/commit/d15239388cca8a5031119b4660e456c26ca5f379.diff

[Lldb-commits] [PATCH] D136551: [lldb] Include gtest in standalone build only if LLDB_INCLUDE_TESTS

mgorny added inline comments. Comment at: lldb/CMakeLists.txt:20 +option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests." ${LLVM_INCLUDE_TESTS}) + labath wrote: > mgorny wrote: > > To be honest, I don't exactly like moving this `option`. Th

[Lldb-commits] [lldb] 8d06ef5 - [LLDB] Check that RegisterInfo and ContextInfo are trivial

Author: David Spickett Date: 2022-10-24T10:16:29Z New Revision: 8d06ef5658187bf6a3eda61a5ec3627c1ff33fb8 URL: https://github.com/llvm/llvm-project/commit/8d06ef5658187bf6a3eda61a5ec3627c1ff33fb8 DIFF: https://github.com/llvm/llvm-project/commit/8d06ef5658187bf6a3eda61a5ec3627c1ff33fb8.diff LOG

[Lldb-commits] [PATCH] D136584: [LLDB] Check that RegisterInfo and ContextInfo are trivial

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d06ef565818: [LLDB] Check that RegisterInfo and ContextInfo are trivial (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136584/ne

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

DavidSpickett added a comment. > What's more, AFAIK, @seehearfeel (yangtie...@loongson.cn) is the LoongArch > port maintainer of gdb. > Regarding the public buildbot, I'm trying to set it up and maybe we can see > it in one or two weeks. Great! CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

labath added a comment. So if I understand correctly, when we deserialize incorrectly, this causes us to misclassify some function parameters (arguments) as local variables. Is that correct? If yes, then that is something that can be checked. Even if the misclassified variables behave perfectly

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

seehearfeel added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_loongarch64.h:26 +public: + enum { GPRegSet = 0, FPRegSet }; + tschuett wrote: > Firstly, I prefer `ènum class`. Second, it is unused? Now, GPRegSet and FPRegSe

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

SixWeining added a comment. In D136578#3878744 , @DavidSpickett wrote: > Always good to see another architecture in lldb. > > A few points up front. > > Changes like this are fine and we can review them, but can only be landed > once we see that they'll

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

seehearfeel marked an inline comment as done. seehearfeel added a comment. In D136578#3878476 , @xen0n wrote: > Hi, I've edited the summary and patch title for you. It's generally not > necessary to add //that// much "politeness" when most of it is obvio

[Lldb-commits] [PATCH] D135621: [lldb] Add an always-on log channel

labath added a comment. In D135621#3875218 , @JDevlieghere wrote: > In D135621#3850248 , @clayborg > wrote: > >> I am also questioning if the these even belong in the LLDB logging stuff? >> Seems like it would

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

tschuett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_loongarch64.cpp:43 +uint32_t RegisterInfoPOSIX_loongarch64::GetRegisterCount() const { + return 0; +} Stupid question: why is the register count 0? =

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

DavidSpickett added a comment. Always good to see another architecture in lldb. A few points up front. Changes like this are fine and we can review them, but can only be landed once we see that they'll be built on. So please stack changes so that we can see what is upcoming. https://llvm.org/d

[Lldb-commits] [PATCH] D136462: [LLDB] Add color to output text when searching for symbols

labath added a comment. This is definitely not a good way to implement this functionality. There's no telling who else might be accessing the symbols while their names are being changed. The colouration should be implemented inside the dumping function, without modifying the state of the debug

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 added a comment. In D136465#3878640 , @DavidSpickett wrote: > Ok, so this change means that the randomisation still happens, unless you > override it with these environment variables? This seems like a good way to > do it. Exactly, this is co

[Lldb-commits] [PATCH] D136584: [LLDB] Check that RegisterInfo and ContextInfo are trivial

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. RegisterInfo is often initialised with a memcpy, and ContextInfo does not run destructors for anything within it

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

DavidSpickett added a comment. Ok, so this change means that the randomisation still happens, unless you override it with these environment variables? This seems like a good way to do it. Where do these env vars need to be set? On the local machine, on the lldb-server machine, on the device?

[Lldb-commits] [PATCH] D136551: [lldb] Include gtest in standalone build only if LLDB_INCLUDE_TESTS

labath added inline comments. Comment at: lldb/CMakeLists.txt:20 +option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests." ${LLVM_INCLUDE_TESTS}) + mgorny wrote: > To be honest, I don't exactly like moving this `option`. The alternative I >

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 added a comment. In D136465#3878581 , @DavidSpickett wrote: > Does this account for the situation where you spawn many gdbserver from the > platform and therefore need more ports? Does it even need to? (just guessing > that that could have bee

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

DavidSpickett added a comment. I don't have the expertise to review, but have one question. Does this account for the situation where you spawn many gdbserver from the platform and therefore need more ports? Does it even need to? (just guessing that that could have been the reason for selecting

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

xen0n added a comment. Hi, I've edited the summary and patch title for you. It's generally not necessary to add //that// much "politeness" when most of it is obvious from context (e.g. the fact that you're new face here, that there's obviously no LoongArch support in LLDB, and most of the metho