xen0n added a comment.

Hi, I've edited the summary and patch title for you. It's generally not 
necessary to add //that// much "politeness" when most of it is obvious from 
context (e.g. the fact that you're new face here, that there's obviously no 
LoongArch support in LLDB, and most of the methods being stubs). It didn't help 
that much of the text was in Chinglish either.

As for the changes, they look reasonable to me, but as I haven't tested it out 
myself yet (and unable to, due to it being stub-only), I'll not give the 
approval myself this time. Thanks for your contribution and welcome!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136578/new/

https://reviews.llvm.org/D136578

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to