[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere added a comment. In D133906#3791153 , @jingham wrote: > This patch makes me a little sad because it breaks the "Jump to Definition" > chain in Xcode (and I bet it does in other IDE's that support this.) You > used to be able to do "Jump to

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

mib added a comment. In D133858#3790013 , @jingham wrote: > Resetting the hit counts on rerun is a more useful behavior, so this is all > fine. But the Target is the one that does all the breakpoint management, so > I think the resetting should go thro

[Lldb-commits] [PATCH] D133910: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer.

jgorbe created this revision. jgorbe added reviewers: labath, jingham. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. `FormatterContainerPair` is (as its name indicates) a very thin wrapper over two form

[Lldb-commits] [PATCH] D133908: Add auto deduce source map setting

jingham added a comment. We also inject a source-map behind the scenes when a dSYM has path mapping keys as described in: https://lldb.llvm.org/use/symbols.html It would be good to make sure that the auto-detect source maps and that feature get along nicely both when the dSYM source map points

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

mib accepted this revision. mib added a comment. In D133906#3791153 , @jingham wrote: > This patch makes me a little sad because it breaks the "Jump to Definition" > chain in Xcode (and I bet it does in other IDE's that support this.) You > used to be

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

mib added a comment. In D133906#3791153 , @jingham wrote: > This patch makes me a little sad because it breaks the "Jump to Definition" > chain in Xcode (and I bet it does in other IDE's that support this.) You > used to be able to do "Jump to Definiti

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460270. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files: lldb/include/lldb/Breakpoint/BreakpointResolve

[Lldb-commits] [PATCH] D133908: Add auto deduce source map setting

yinghuitan created this revision. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new "target.auto-deduce-source-map" setting. If enabled, this setting may auto deduce a sourc

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

jingham added a comment. This patch makes me a little sad because it breaks the "Jump to Definition" chain Xcode (and I bet it does in other IDE's that support this.) You used to be able to do "Jump to Definition" on ProcessSP, then jump to definition on the class name in the shared pointer de

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan added a comment. @clayborg , it is my intention to make `target.auto-deduce-source-map` boolean flag ultimately working for both relative paths and two full paths (two full paths are really important for off build host debugging, e.g. dump or production debugging). In this patch, I f

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Definitely better than the previous contents! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133906/new/ https://reviews.llvm.org/D133906 ___

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere created this revision. JDevlieghere added reviewers: mib, aprantl, labath. Herald added a project: All. JDevlieghere requested review of this revision. Generate lldb-forward with .def file. The benefit is that we don't have to keep the list of classes, and typedefs in sync. https:/

[Lldb-commits] [lldb] f3d0bda - Revert "Revert "Be more careful to maintain quoting information when parsing commands.""

Author: Jim Ingham Date: 2022-09-14T14:49:51-07:00 New Revision: f3d0bda5344e8429121cb50aba5502c1b399e5cd URL: https://github.com/llvm/llvm-project/commit/f3d0bda5344e8429121cb50aba5502c1b399e5cd DIFF: https://github.com/llvm/llvm-project/commit/f3d0bda5344e8429121cb50aba5502c1b399e5cd.diff LO

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460220. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a1c81e32739: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

fdeazeve updated this revision to Diff 460176. fdeazeve added a comment. Also applied Jim's comment to the LocationList class, as this involves a single lock, instead of one lock per location. If this is wrong, please let me know and I'll revert. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. The main question for me here is if "target.auto-deduce-source-map" should be a boolean or an enum. This path, if I read it correctly, will only auto deduce source maps if the de

[Lldb-commits] [PATCH] D133876: [lldb][tests][NFC] Move C++ gmodules tests into new gmodules/ subdirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b44c9af8efd: [lldb][tests] Move C++ gmodules tests into new gmodules/ subdirectory (authored by Michael137). Changed prior to commit: https://reviews.llvm.org/D133876?vs=460143&id=460169#toc Repositor

[Lldb-commits] [lldb] 3b44c9a - [lldb][tests] Move C++ gmodules tests into new gmodules/ subdirectory

Author: Michael Buch Date: 2022-09-14T14:45:35-04:00 New Revision: 3b44c9af8efd95aba7b4f351e5175ebf02e7b396 URL: https://github.com/llvm/llvm-project/commit/3b44c9af8efd95aba7b4f351e5175ebf02e7b396 DIFF: https://github.com/llvm/llvm-project/commit/3b44c9af8efd95aba7b4f351e5175ebf02e7b396.diff

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

fdeazeve added inline comments. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:334 + for (size_t i = 0; i < GetNumLocations(); ++i) +GetLocationAtIndex(i)->ResetHitCount(); +} @jingham actually, should I apply the same idea to BreakpointLocationList? Re

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

fdeazeve added a comment. In D133858#3790013 , @jingham wrote: > Resetting the hit counts on rerun is a more useful behavior, so this is all > fine. But the Target is the one that does all the breakpoint management, so > I think the resetting should go

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

fdeazeve updated this revision to Diff 460165. fdeazeve added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133858/new/ https://reviews.llvm.org/D133858 Files: lldb/include/lldb/Breakpoint/Breakpoint.h lldb

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu updated this revision to Diff 460152. zequanwu added a comment. Move the logic into `MSVCUndecoratedNameParser`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133446/new/ https://reviews.llvm.org/D133446 Files: lldb/source/Plugins/Langu

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu added a comment. In D133446#3788956 , @labath wrote: > In D133446#3787362 , @zequanwu > wrote: > >> In D133446#3786561 , @labath wrote: >> >>> In D133446#3780961

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

aprantl added a comment. In D130062#3789858 , @kpdev42 wrote: > In D130062#3789671 , @aprantl wrote: > >> Out of curiosity — did you get an email notification from the bot? > > Hi, yes, I will add a priority to th

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Resetting the hit counts on rerun is a more useful behavior, so this is all fine. But the Target is the one that does all the breakpoint management, so I think the resetting shoul

[Lldb-commits] [PATCH] D133876: [lldb][tests] Move C++ gmodules tests into new gmodules/ subdirectory

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is in preparation for adding more gmodules tests. Repository: rG LLVM G

[Lldb-commits] [lldb] da45904 - Revert "[lldb][DWARF5] Enable macro evaluation"

Author: Stella Stamenova Date: 2022-09-14T09:30:49-07:00 New Revision: da459043f8c5d4187c798cc13a48bc7f7c1bd81a URL: https://github.com/llvm/llvm-project/commit/da459043f8c5d4187c798cc13a48bc7f7c1bd81a DIFF: https://github.com/llvm/llvm-project/commit/da459043f8c5d4187c798cc13a48bc7f7c1bd81a.di

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

kpdev42 added a comment. In D130062#3789671 , @aprantl wrote: > Out of curiosity — did you get an email notification from the bot? Hi, yes, I will add a priority to these notifications to react faster, sorry Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

fdeazeve added inline comments. Comment at: lldb/source/Target/Process.cpp:2763-2766 +static void ResetHitCounts(Process &Proc) { + for (const auto &BP : Proc.GetTarget().GetBreakpointList().Breakpoints()) +BP->ResetHitCount(); +} JDevlieghere wrote: > Can t

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

JDevlieghere added inline comments. Comment at: lldb/source/Target/Process.cpp:2763-2766 +static void ResetHitCounts(Process &Proc) { + for (const auto &BP : Proc.GetTarget().GetBreakpointList().Breakpoints()) +BP->ResetHitCount(); +} Can this be a private m

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

aprantl added a comment. Out of curiosity — did you get an email notification from the bot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130062/new/ https://reviews.llvm.org/D130062 ___ lldb-commits mai

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

aprantl added a comment. This test fails to compile on Darwin https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46816/testReport/junit/lldb-api/commands_expression_macros/TestMacros_py/ https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46811/ Can you please add a @skipIfDarwin de

[Lldb-commits] [lldb] 154db06 - [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 1

Author: John Ericson Date: 2022-09-14T10:58:47-04:00 New Revision: 154db06ce0d6c80ec900718b764e56ff90d360a0 URL: https://github.com/llvm/llvm-project/commit/154db06ce0d6c80ec900718b764e56ff90d360a0 DIFF: https://github.com/llvm/llvm-project/commit/154db06ce0d6c80ec900718b764e56ff90d360a0.diff

[Lldb-commits] [PATCH] D133828: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 1

This revision was automatically updated to reflect the committed changes. Closed by commit rG154db06ce0d6: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

fdeazeve added inline comments. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:332 +void Breakpoint::ResetHitCount() { + m_hit_counter.Reset(); + for (size_t i = 0; i < GetNumLocations(); ++i) fdeazeve wrote: > By the way, I don' think this counter is ever i

[Lldb-commits] [PATCH] D133790: Fix heap-use-after-free when clearing DIEs in fission compile units.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f3def30ca86: Fix heap-use-after-free when clearing DIEs in fission compile units. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133

[Lldb-commits] [lldb] 1f3def3 - Fix heap-use-after-free when clearing DIEs in fission compile units.

Author: Jordan Rupprecht Date: 2022-09-14T06:52:47-07:00 New Revision: 1f3def30ca86a35a173cb1fe10e3e73d2a0d0f6f URL: https://github.com/llvm/llvm-project/commit/1f3def30ca86a35a173cb1fe10e3e73d2a0d0f6f DIFF: https://github.com/llvm/llvm-project/commit/1f3def30ca86a35a173cb1fe10e3e73d2a0d0f6f.di

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

fdeazeve added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:332 +void Breakpoint::ResetHitCount() { + m_hit_counter.Reset(); + for (size_t i = 0; i < GetNumLocations(); ++i) By the way, I don' think

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A common debugging pattern is to set a breakpoint that only stops after a number of hits is recorded. The current implemen

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460036. mizvekov marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariab

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

labath added a comment. In D133446#3787362 , @zequanwu wrote: > In D133446#3786561 , @labath wrote: > >> In D133446#3780961 , @zequanwu >> wrote: >> >>> In D133446#377960

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

labath added a comment. Yeah, we can enable them. I've done that now in d079bf33 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132954/new/ https://reviews.llvm.org/D132954 __

[Lldb-commits] [lldb] d079bf3 - [lldb] Enable (un-xfail) some dwarf tests for arm

Author: Pavel Labath Date: 2022-09-14T11:35:16+02:00 New Revision: d079bf33decf25a40a219d7ea47d84ecdb61b5e6 URL: https://github.com/llvm/llvm-project/commit/d079bf33decf25a40a219d7ea47d84ecdb61b5e6 DIFF: https://github.com/llvm/llvm-project/commit/d079bf33decf25a40a219d7ea47d84ecdb61b5e6.diff

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

sebastian-ne accepted this revision. sebastian-ne added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D130062: [lldb][DWARF5] Enable macro evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0fb69d17b4d: [lldb][DWARF5] Enable macro evaluation (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130062/new/ https://reviews.llvm.o

[Lldb-commits] [lldb] a0fb69d - [lldb][DWARF5] Enable macro evaluation

Author: Pavel Kosov Date: 2022-09-14T11:32:07+03:00 New Revision: a0fb69d17b4d7501a85554010727837340e7b52f URL: https://github.com/llvm/llvm-project/commit/a0fb69d17b4d7501a85554010727837340e7b52f DIFF: https://github.com/llvm/llvm-project/commit/a0fb69d17b4d7501a85554010727837340e7b52f.diff L