[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu updated this revision to Diff 457752. zequanwu added a comment. Herald added a subscriber: JDevlieghere. Fix comment in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133243/new/ https://reviews.llvm.org/D133243 Files: lldb/so

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu created this revision. zequanwu added reviewers: rnk, labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `PdbAstBuilder::GetParentDeclContextForSymbol` finds the public symbol that has sam

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe added a comment. This is the first step towards something like this big diff: https://reviews.llvm.org/differential/diff/457740/. It's a pretty simple patch, but I would like some feedback about whether you think it's going in the right direction or I should do something else instead. H

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

aprantl added a comment. In D133069#3768088 , @rsmith wrote: > Hi, the newly-added test, `TestDynamicLoaderDarwin.py`, fails under asan: > https://gist.github.com/zygoloid/bf7b21f03d7db966e456b6c365c4635d Thanks! Should be fixed in commit 603d5a8d632

[Lldb-commits] [lldb] 603d5a8 - Fix out-of-bounds memory access in test

Author: Adrian Prantl Date: 2022-09-02T18:14:23-07:00 New Revision: 603d5a8d632164038a869c200818c4cc238bb85a URL: https://github.com/llvm/llvm-project/commit/603d5a8d632164038a869c200818c4cc238bb85a DIFF: https://github.com/llvm/llvm-project/commit/603d5a8d632164038a869c200818c4cc238bb85a.diff

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. Modify `SBTypeNameSpecifier` and `lldb_private::TypeMatcher` so they have an enum val

[Lldb-commits] [lldb] f021cb5 - [NFC] Remove duplicate code in SBTypeCategory

Author: Jorge Gorbe Moya Date: 2022-09-02T16:04:04-07:00 New Revision: f021cb57ce786f7d5a6c921a19bbcf56709b6ce0 URL: https://github.com/llvm/llvm-project/commit/f021cb57ce786f7d5a6c921a19bbcf56709b6ce0 DIFF: https://github.com/llvm/llvm-project/commit/f021cb57ce786f7d5a6c921a19bbcf56709b6ce0.di

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

rsmith added a comment. Hi, the newly-added test, `TestDynamicLoaderDarwin.py`, fails under asan: https://gist.github.com/zygoloid/bf7b21f03d7db966e456b6c365c4635d Please can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133069/ne

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

rsmith added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:74 + if (name.consume_front("std::")) +name.consume_front("__1::"); + return name.consume_front(type) && name.startswith("<"); This is not right -- libc+

[Lldb-commits] [PATCH] D133230: [NFCI] Remove duplicate code in SBTypeCategory

jgorbe created this revision. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. TypeCategoryImpl has its own implementation of these, so it makes no sense to have the same logic inlined in SBTypeCategory.

[Lldb-commits] [PATCH] D133181: [test] Remove problematic thread from MainLoopTest to fix flakiness

This revision was automatically updated to reflect the committed changes. Closed by commit rG945bdb167ff5: [test] Remove problematic thread from MainLoopTest to fix flakiness (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1331

[Lldb-commits] [lldb] 945bdb1 - [test] Remove problematic thread from MainLoopTest to fix flakiness

Author: Jordan Rupprecht Date: 2022-09-02T10:30:56-07:00 New Revision: 945bdb167ff5d73559780acc2391dabb816ce9e1 URL: https://github.com/llvm/llvm-project/commit/945bdb167ff5d73559780acc2391dabb816ce9e1 DIFF: https://github.com/llvm/llvm-project/commit/945bdb167ff5d73559780acc2391dabb816ce9e1.di

[Lldb-commits] [PATCH] D133181: [test] Remove problematic thread from MainLoopTest to fix flakiness

rupprecht added a comment. In D133181#3767072 , @labath wrote: > It might be a good idea to also change the `kill(getpid(), sig);` statements > into `raise(sig)` (a.k.a. `pthread_kill(pthread_self(), sig)`), so that > they're sent to a specific thread,

[Lldb-commits] [PATCH] D133181: [test] Remove problematic thread from MainLoopTest to fix flakiness

rupprecht updated this revision to Diff 457631. rupprecht added a comment. - Use pthread_kill to only kill the current thread Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133181/new/ https://reviews.llvm.org/D133181 Files: lldb/unittests/Host/M

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2ec18ee043f: [lldb] From unordered_map synthetic provider, return std::pair children (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] a2ec18e - [lldb] From unordered_map synthetic provider, return std::pair children

Author: Dave Lee Date: 2022-09-02T08:53:46-07:00 New Revision: a2ec18ee043f7c8caa0e9e329721182b9f1a5dcd URL: https://github.com/llvm/llvm-project/commit/a2ec18ee043f7c8caa0e9e329721182b9f1a5dcd DIFF: https://github.com/llvm/llvm-project/commit/a2ec18ee043f7c8caa0e9e329721182b9f1a5dcd.diff LOG:

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary added a comment. @labath it doesn't look like the relocations are applied during `lldb-test object-file --contents`: from obj2yaml for rel.c described in summary (with added spacing for readabilty): [...] - Name:.debug_info Type:SHT_PROGBITS Add

[Lldb-commits] [PATCH] D133181: [test] Ensure MainLoop has time to start listening for signals.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. It might be a good idea to also change the `kill(getpid(), sig);` statements into `raise(sig)` (a.k.a. `pthread_kill(pthread_self(), sig)`), so that they're sent to a specific thread, instead

[Lldb-commits] [PATCH] D133181: [test] Ensure MainLoop has time to start listening for signals.

rupprecht marked 2 inline comments as done. rupprecht added a comment. In D133181#3766319 , @labath wrote: >> AFAICT kill is entirely asynchronous > > This is not exactly true. POSIX describes this situation quite well (emphasis > mine): > >> If the valu

[Lldb-commits] [PATCH] D133181: [test] Ensure MainLoop has time to start listening for signals.

rupprecht updated this revision to Diff 457598. rupprecht added a comment. - Remove async call to avoid deadlock instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133181/new/ https://reviews.llvm.org/D133181 Files: lldb/unittests/Host/MainLo

[Lldb-commits] [PATCH] D133181: [test] Ensure MainLoop has time to start listening for signals.

labath added a comment. > AFAICT kill is entirely asynchronous This is not exactly true. POSIX describes this situation quite well (emphasis mine): > If the value of pid causes sig to be generated for the sending process, and > if sig is not blocked for the calling thread and if no other threa