labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
It might be a good idea to also change the `kill(getpid(), sig);` statements into `raise(sig)` (a.k.a. `pthread_kill(pthread_self(), sig)`), so that they're sent to a specific thread, instead of the whole process. It would also be possible to implement the MainLoop class in such a way that it responds to signals received by other threads as well, although one can ask himself which behavior is more natural. For the use case we're currently using this (catching SIGCHLDs) it wouldn't make a difference though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133181/new/ https://reviews.llvm.org/D133181 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
