[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. In D113650#3136407 , @aprantl wrote: > This seems to have broken the green dragon incremental bot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/ Crosscompiling LLDB with Python requires manually s

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

aprantl added a comment. This seems to have broken the green dragon incremental bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 _

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu planned changes to this revision. zequanwu added a comment. I realized that the test case here is incorrect, because the output of `lldb-test symbols dump-ast ...` shows `void virtual_method()` twice. The `void virtual_method()` without `virtual` is created by the new code. Because `ll

[Lldb-commits] [lldb] dd5505a - Revert "Make it possible for lldb to launch a remote binary with no local file."

Author: Jim Ingham Date: 2021-11-16T16:46:21-08:00 New Revision: dd5505a8f2c75a903ec944b6e46aed2042610673 URL: https://github.com/llvm/llvm-project/commit/dd5505a8f2c75a903ec944b6e46aed2042610673 DIFF: https://github.com/llvm/llvm-project/commit/dd5505a8f2c75a903ec944b6e46aed2042610673.diff LO

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

This revision was automatically updated to reflect the committed changes. Closed by commit rGb715b79d54d5: Make it possible for lldb to launch a remote binary with no local file. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [lldb] b715b79 - Make it possible for lldb to launch a remote binary with no local file.

Author: Jim Ingham Date: 2021-11-16T16:06:07-08:00 New Revision: b715b79d54d5ca2d4e8c91089b8f6a9389d9dc48 URL: https://github.com/llvm/llvm-project/commit/b715b79d54d5ca2d4e8c91089b8f6a9389d9dc48 DIFF: https://github.com/llvm/llvm-project/commit/b715b79d54d5ca2d4e8c91089b8f6a9389d9dc48.diff LO

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGae389b2450bd: [lldb] use EXT_SUFFIX for python extension (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112972/new/ https://rev

[Lldb-commits] [lldb] ae389b2 - [lldb] use EXT_SUFFIX for python extension

Author: Lawrence D'Anna Date: 2021-11-16T14:32:26-08:00 New Revision: ae389b2450bd604a3f3bbe5b09b333b2d99801dd URL: https://github.com/llvm/llvm-project/commit/ae389b2450bd604a3f3bbe5b09b333b2d99801dd DIFF: https://github.com/llvm/llvm-project/commit/ae389b2450bd604a3f3bbe5b09b333b2d99801dd.dif

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c2cf3a314d9: [lldb] fix -print-script-interpreter-info on windows (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ h

[Lldb-commits] [lldb] 4c2cf3a - [lldb] fix -print-script-interpreter-info on windows

Author: Lawrence D'Anna Date: 2021-11-16T13:50:20-08:00 New Revision: 4c2cf3a314d9131b1b288e7c8ab0c75ac1b2be1d URL: https://github.com/llvm/llvm-project/commit/4c2cf3a314d9131b1b288e7c8ab0c75ac1b2be1d DIFF: https://github.com/llvm/llvm-project/commit/4c2cf3a314d9131b1b288e7c8ab0c75ac1b2be1d.dif

[Lldb-commits] [PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

ZarkoCA created this revision. ZarkoCA added reviewers: klimek, akyrtzi, quinnp. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added subscribers: lldb-commits, cfe-commits. Herald added a project: LLDB. Rename function to more inclusive name. Repository: rG

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1217-1218 +std::vector +Platform::CreateArchList(llvm::Triple::OSType os, + llvm::ArrayRef archs) { + std::vector list; labath wrote: > JDevlieghere wrote: >

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM if the Windows bot is happy :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 ___

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112972/new/ https://reviews.llvm.org/D112972 ___

[Lldb-commits] [PATCH] D113965: [NFC] Refactor symbol table parsing.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113965/new/ https://reviews.llvm.org/D113965 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] 4c484f1 - [llvm] Add a SFINAE template parameter to DenseMapInfo

Author: River Riddle Date: 2021-11-16T18:54:14Z New Revision: 4c484f11d355e4293f7b245a9330f0a1e89630ac URL: https://github.com/llvm/llvm-project/commit/4c484f11d355e4293f7b245a9330f0a1e89630ac DIFF: https://github.com/llvm/llvm-project/commit/4c484f11d355e4293f7b245a9330f0a1e89630ac.diff LOG:

Re: [Lldb-commits] [PATCH] D113098: [lldb] (Partially) enable formatting of utf strings before the program is started

Something seems to have happened to reviews.llvm.org. I can sort of see patches, but the interface isn't responding, and I can't actually make comments there, so we'll try this way instead. Your changes look good, the "ReasonableSizeForReading" reasonable. About the "force_live_memory" thing.

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan added a comment. When I mocked the num_children to return 4, formatter works for any structure with size <= 4. here is the example: std::deque d; d.push_front(7); d.push_front(5); d.push_front(13); d.push_front(25); (std::deque >) $0 = size=4 { [0] = 25 [1] =

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan added inline comments. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:60 + +def num_children_impl(self): +# logger = lldb.formatters.Logger.Logger() This method does not currently work. I simply tried to calculate the size from

[Lldb-commits] [lldb] db5b960 - fix decorator

Author: Adrian Prantl Date: 2021-11-16T09:17:47-08:00 New Revision: db5b960e2dd5b2c2eac1973345d162245efc1f39 URL: https://github.com/llvm/llvm-project/commit/db5b960e2dd5b2c2eac1973345d162245efc1f39 DIFF: https://github.com/llvm/llvm-project/commit/db5b960e2dd5b2c2eac1973345d162245efc1f39.diff

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114008 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plug

[Lldb-commits] [lldb] 948b36d - Skip tests on older versions of clang

Author: Adrian Prantl Date: 2021-11-16T09:09:56-08:00 New Revision: 948b36d2582c9cde913e434bd22814f01e85bdd6 URL: https://github.com/llvm/llvm-project/commit/948b36d2582c9cde913e434bd22814f01e85bdd6 DIFF: https://github.com/llvm/llvm-project/commit/948b36d2582c9cde913e434bd22814f01e85bdd6.diff

[Lldb-commits] [lldb] 6424dc2 - Increase gdbremote timeout.

Author: Adrian Prantl Date: 2021-11-16T09:09:55-08:00 New Revision: 6424dc21bf6b73645ef98a35417e0591b2a95939 URL: https://github.com/llvm/llvm-project/commit/6424dc21bf6b73645ef98a35417e0591b2a95939 DIFF: https://github.com/llvm/llvm-project/commit/6424dc21bf6b73645ef98a35417e0591b2a95939.diff

[Lldb-commits] [lldb] 6e78cfb - typo

Author: Adrian Prantl Date: 2021-11-16T09:09:55-08:00 New Revision: 6e78cfb28ab545b7367306d43f88f29202c0ae12 URL: https://github.com/llvm/llvm-project/commit/6e78cfb28ab545b7367306d43f88f29202c0ae12 DIFF: https://github.com/llvm/llvm-project/commit/6e78cfb28ab545b7367306d43f88f29202c0ae12.diff

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1026 +/*mangled_name=*/nullptr, func_ct, lldb::AccessType::eAccessPublic, +/*is_virtual=*/false, /*is_static=*/false, +/*is_inline=*/false, /*is_explicit=*

[Lldb-commits] [PATCH] D113487: [lldb] Refactor Platform::ResolveExecutable

This revision was automatically updated to reflect the committed changes. Closed by commit rG098c01c132c8: [lldb] Refactor Platform::ResolveExecutable (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113487/new/ https://reviews.ll

[Lldb-commits] [lldb] 098c01c - [lldb] Refactor Platform::ResolveExecutable

Author: Pavel Labath Date: 2021-11-16T12:52:51+01:00 New Revision: 098c01c132c8d14f08b847793afa045af5bb4522 URL: https://github.com/llvm/llvm-project/commit/098c01c132c8d14f08b847793afa045af5bb4522 DIFF: https://github.com/llvm/llvm-project/commit/098c01c132c8d14f08b847793afa045af5bb4522.diff

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG669e57ebd1a7: [lldb] Simplify specifying of platform supported architectures (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 669e57e - [lldb] Simplify specifying of platform supported architectures

Author: Pavel Labath Date: 2021-11-16T11:43:48+01:00 New Revision: 669e57ebd1a7137aba7aab47d9d4dd67e1b0b9a0 URL: https://github.com/llvm/llvm-project/commit/669e57ebd1a7137aba7aab47d9d4dd67e1b0b9a0 DIFF: https://github.com/llvm/llvm-project/commit/669e57ebd1a7137aba7aab47d9d4dd67e1b0b9a0.diff

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/source/Target/Platform.cpp:1217-1218 +std::vector +Platform::CreateArchList(llvm::Triple::OSType os, + llvm::ArrayRef archs) { + std::vector list; JDe

[Lldb-commits] [PATCH] D113893: [lldb/test] Move gdb client utils into the packages tree

This revision was automatically updated to reflect the committed changes. Closed by commit rG33c0f93f6c10: [lldb/test] Move gdb client utils into the packages tree (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113893/new/ https

[Lldb-commits] [lldb] 33c0f93 - [lldb/test] Move gdb client utils into the packages tree

Author: Pavel Labath Date: 2021-11-16T11:35:56+01:00 New Revision: 33c0f93f6c10acff885fe11b9897943313cd5c26 URL: https://github.com/llvm/llvm-project/commit/33c0f93f6c10acff885fe11b9897943313cd5c26 DIFF: https://github.com/llvm/llvm-project/commit/33c0f93f6c10acff885fe11b9897943313cd5c26.diff

[Lldb-commits] [PATCH] D113098: [lldb] (Partially) enable formatting of utf strings before the program is started

labath updated this revision to Diff 387543. labath marked 4 inline comments as done. labath added a comment. New version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113098/new/ https://reviews.llvm.org/D113098 Files: lldb/include/lldb/DataFo

[Lldb-commits] [PATCH] D113098: [lldb] (Partially) enable formatting of utf strings before the program is started

labath marked 7 inline comments as done. labath added a comment. Thanks for the review. Comment at: lldb/include/lldb/Target/Target.h:1028 + /// + /// This function will read a cache page at a time until a NULL string + /// terminator is found. It will stop reading if an ali

[Lldb-commits] [PATCH] D113965: [NFC] Refactor symbol table parsing.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is a good cleanup independently of the caching feature. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:344 + /// The symbol table to populate. + virtual void Pa

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

labath added a comment. In D113789#3133205 , @clayborg wrote: > In D113789#3130741 , @labath wrote: > >> Maybe it's good for starting a discussion, but I am surprised that we would >> need to cache symtab informa