labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
This is a good cleanup independently of the caching feature. ================ Comment at: lldb/include/lldb/Symbol/ObjectFile.h:344 + /// The symbol table to populate. + virtual void ParseSymtab(Symtab &symtab) = 0; ---------------- I guess this should be protected, as people shouldn't be calling it directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113965/new/ https://reviews.llvm.org/D113965 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
