[Lldb-commits] [lldb] b1bb1d4 - [lldb] Skip tests for target var without a proc on both arm64 & arm64e

Author: Jonas Devlieghere Date: 2021-10-25T20:45:38-07:00 New Revision: b1bb1d4c46889c4cae2b6586b50c3397584fa064 URL: https://github.com/llvm/llvm-project/commit/b1bb1d4c46889c4cae2b6586b50c3397584fa064 DIFF: https://github.com/llvm/llvm-project/commit/b1bb1d4c46889c4cae2b6586b50c3397584fa064.d

[Lldb-commits] [PATCH] D112310: [lldb/DWARF] Don't create lldb_private::Functions for gc'ed DW_TAG_subprograms

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:866 + // discontiguous) + AddressRange func_range; + lldb::addr_t lowest_func_addr = ranges.GetMinRangeBase(0); You declare `func_range` here but don't use it ti

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. In D112439#3084948 , @wallace wrote: > Is it possible to add a test for that? In any case, this makes sense to me In D112439#3085304 , @clayborg wrote: > Adding a test would be g

[Lldb-commits] [PATCH] D112501: Add new key/value pairs to the module statistics for "statistics dump".

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. looks good Comment at: lldb/include/lldb/Symbol/SymbolFile.h:309 + /// this call should add the size of all sections that contain debug + /// information. Symbols the sym

[Lldb-commits] [PATCH] D112501: Add new key/value pairs to the module statistics for "statistics dump".

clayborg updated this revision to Diff 382160. clayborg added a comment. Added newlines to files that needed them at the end of the file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112501/new/ https://reviews.llvm.org/D112501 Files: lldb/incl

[Lldb-commits] [PATCH] D112501: Add new key/value pairs to the module statistics for "statistics dump".

clayborg updated this revision to Diff 382159. clayborg added a comment. Fix headerdoc that mentioned llvm::None. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112501/new/ https://reviews.llvm.org/D112501 Files: lldb/include/lldb/Core/Section.h

[Lldb-commits] [PATCH] D112501: Add new key/value pairs to the module statistics for "statistics dump".

clayborg added a comment. New output looks like: (lldb) statistics dump { "modules": [ { "debugInfoByteSize": 876, "debugInfoIndexTime": 0, "debugInfoParseTime": 0.000118668002, "identifier": 5224745544, "path": "/Users/gclayton/Docume

[Lldb-commits] [PATCH] D112501: Add new key/value pairs to the module statistics for "statistics dump".

clayborg created this revision. clayborg added reviewers: JDevlieghere, wallace, aadsm, labath, jingham. Herald added a subscriber: arphaman. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The new key/value pairs that are added to

[Lldb-commits] [PATCH] D112497: [lldb] Configure CMake policy CMP0116 for standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG65dae8b2f20c: [lldb] Configure CMake policy CMP0116 for standalone builds (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112497/new

[Lldb-commits] [lldb] 65dae8b - [lldb] Configure CMake policy CMP0116 for standalone builds

Author: Dave Lee Date: 2021-10-25T16:29:36-07:00 New Revision: 65dae8b2f20c32632e48922456a305504f4e6fbe URL: https://github.com/llvm/llvm-project/commit/65dae8b2f20c32632e48922456a305504f4e6fbe DIFF: https://github.com/llvm/llvm-project/commit/65dae8b2f20c32632e48922456a305504f4e6fbe.diff LOG:

[Lldb-commits] [PATCH] D112497: [lldb] Configure CMake policy CMP0116 for standalone builds

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112497/new/ https://reviews.llvm.org/D112497 ___

[Lldb-commits] [PATCH] D112497: [lldb] Configure CMake policy CMP0116 for standalone builds

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Using CMake >=3.20 results in many warnings about this new policy.

[Lldb-commits] [PATCH] D112495: [lldb] [Host/ConnectionFileDescriptor] Refactor to improve code reuse

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. Refactor ConnectionFileDescriptor to improve code reuse for different types of sockets. Unify method naming. While at it, remove some (now-)dead code from Socke

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

wallace added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/bitset/TestDataFormatterGenericBitset.py:32-35 for i in range(size): child = var.GetChildAtIndex(i) self.assertEqual(child.GetVal

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. almost there! Comment at: lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp:20 -class BitsetFrontEnd : public SyntheticChildrenFrontEnd { +// This class

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

clayborg added a comment. Adding a test would be great for this. Please add one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc571988e9d57: Add modules stats into the "statistics dump" command. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112279/new/ https:

[Lldb-commits] [lldb] c571988 - Add modules stats into the "statistics dump" command.

Author: Greg Clayton Date: 2021-10-25T11:50:02-07:00 New Revision: c571988e9d576f78c00e45fc730f68953c45ea3a URL: https://github.com/llvm/llvm-project/commit/c571988e9d576f78c00e45fc730f68953c45ea3a DIFF: https://github.com/llvm/llvm-project/commit/c571988e9d576f78c00e45fc730f68953c45ea3a.diff

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

clayborg added a comment. In D112279#3084758 , @JDevlieghere wrote: > Can we use the UUID as the module identifier (at least in the JSON)? Other > than that, this LGTM. Some binaries don't have UUID values and I didn't want to use a UUID when it was t

[Lldb-commits] [PATCH] D112471: [LLDB] Fix Cpsr size for WoA64 target

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112471/new/ https://reviews.llvm.org/D112471 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

danilashtefan updated this revision to Diff 382066. danilashtefan added a comment. I have corrected everything according to the previous comments. Wallace will kindly help me to format the code, since I have the following formatter error Stack dump: 0.Program arguments: clang-format -lines=1

[Lldb-commits] [PATCH] D111498: [lldb] [DynamicRegisterInfo] Remove AddRegister() and make Finalize() protected

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd258fd4e2c: [lldb] [DynamicRegisterInfo] Remove AddRegister() and make Finalize() protected (authored by mgorny). Herald added a project: LLDB. Ch

[Lldb-commits] [PATCH] D111491: [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack

This revision was automatically updated to reflect the committed changes. Closed by commit rG26c584f4f1a3: [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] 1bd258f - [lldb] [DynamicRegisterInfo] Remove AddRegister() and make Finalize() protected

Author: Michał Górny Date: 2021-10-25T20:05:30+02:00 New Revision: 1bd258fd4e2c94d35cdda07b4ca64a2de8d4a047 URL: https://github.com/llvm/llvm-project/commit/1bd258fd4e2c94d35cdda07b4ca64a2de8d4a047 DIFF: https://github.com/llvm/llvm-project/commit/1bd258fd4e2c94d35cdda07b4ca64a2de8d4a047.diff

[Lldb-commits] [lldb] 26c584f - [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack

Author: Michał Górny Date: 2021-10-25T20:05:29+02:00 New Revision: 26c584f4f1a3359bcb31b357ec020e7b8038c10c URL: https://github.com/llvm/llvm-project/commit/26c584f4f1a3359bcb31b357ec020e7b8038c10c DIFF: https://github.com/llvm/llvm-project/commit/26c584f4f1a3359bcb31b357ec020e7b8038c10c.diff

[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

mgorny added inline comments. Comment at: lldb/source/Host/posix/HostInfoPosix.cpp:44 + + ::memset(&un, 0, sizeof(utsname)); + I'm somewhat surprised that you need to do that. I wonder if there was a real reason why it's done or just someone being overly carefu

[Lldb-commits] [PATCH] D111491: [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack

mgorny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111491/new/ https://reviews.llvm.org/D111491 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D112167: [lldb/Plugins] Refactor ScriptedThread register context creation

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:105 + lldb::RegisterContextSP reg_ctx_sp; + Status error; + I

[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/include/lldb/Host/posix/HostInfoPosix.h:25 static bool GetHostname(std::string &s); + static llvm::Optional GetOSKernelDescription(); mgorny wrote: > Ok, I must be missi

[Lldb-commits] [PATCH] D112471: [LLDB] Fix Cpsr size for WoA64 target

omjavaid created this revision. omjavaid added reviewers: mstorsjo, DavidSpickett. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. CPSR on Arm64 is 4 bytes in size but windows on Arm implementation is trying to read/write 8 bytes against a byte register causi

[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

labath updated this revision to Diff 382048. labath added a comment. add missing implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112457/new/ https://reviews.llvm.org/D112457 Files: lldb/include/lldb/Host/freebsd/HostInfoFreeBSD.h

[Lldb-commits] [PATCH] D111491: [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Sorry for the delay in looking at this one. Yes, we usually put a new debugserver on devices every year, and we don't need to support devices this old any more, this is fine to re

[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

dblaikie added a comment. In D112340#3084953 , @teemperor wrote: > Not actually sure when/how Green Dragon is mailing external people, > but usually someone just watches the build bot and emails/comments on > commits that are breaking the buildbot. Green

Re: [Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

Not actually sure when/how Green Dragon is mailing external people, but usually someone just watches the build bot and emails/comments on commits that are breaking the buildbot. Green Dragon is more of a monte carlo simulation than a real build bot so I wouldn't be surprised if it doesn't send auto

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Is it possible to add a test for that? In any case, this makes sense to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://r

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. LGTM, but I would wait for one more approve. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111899/new/ https://reviews.llvm.org/D111899

[Lldb-commits] [PATCH] D112340: [lldb/Formatters] Remove space from vector type string summaries (NFCI)

dblaikie added a comment. In D112340#3081540 , @teemperor wrote: > In D112340#3081532 , @dblaikie > wrote: > >> Sorry I missed this - are these tested anywhere/should I have been able to >> discover if these nee

[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

mgorny added inline comments. Comment at: lldb/include/lldb/Host/posix/HostInfoPosix.h:25 static bool GetHostname(std::string &s); + static llvm::Optional GetOSKernelDescription(); Ok, I must be missing something but I don't see the implementation of this i

[Lldb-commits] [lldb] 974c2f5 - [lldb] Modernize and expand TestCppBitfields

Author: Raphael Isemann Date: 2021-10-25T18:19:26+02:00 New Revision: 974c2f5e22112659549a54ff95ee310a1aac469d URL: https://github.com/llvm/llvm-project/commit/974c2f5e22112659549a54ff95ee310a1aac469d DIFF: https://github.com/llvm/llvm-project/commit/974c2f5e22112659549a54ff95ee310a1aac469d.dif

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

JDevlieghere accepted this revision. JDevlieghere added a comment. Can we use the UUID as the module identifier (at least in the JSON)? Other than that, this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112279/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112457/new/ https://reviews.llvm.org/D112457 ___

[Lldb-commits] [lldb] a53978c - [lldb] Remove a trailing \0 from the result of HostInfoMacOSX::GetOSBuildString

Author: Pavel Labath Date: 2021-10-25T17:33:06+02:00 New Revision: a53978c95c46a8bef563058fa35a688f8cbaaf88 URL: https://github.com/llvm/llvm-project/commit/a53978c95c46a8bef563058fa35a688f8cbaaf88 DIFF: https://github.com/llvm/llvm-project/commit/a53978c95c46a8bef563058fa35a688f8cbaaf88.diff

[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

labath created this revision. labath added reviewers: mgorny, teemperor. Herald added a subscriber: emaste. labath requested review of this revision. Herald added a project: LLDB. Replace bool+by-ref argument with llvm::Optional, and move the common implementation into HostInfoPOSIX. Based on my (

[Lldb-commits] [PATCH] D112442: [lldb] [Host/ConnectionFileDescriptor] Do not use non-blocking mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d63b90b59a6: [lldb] [Host/ConnectionFileDescriptor] Do not use non-blocking mode (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [lldb] 9d63b90 - [lldb] [Host/ConnectionFileDescriptor] Do not use non-blocking mode

Author: Michał Górny Date: 2021-10-25T16:24:00+02:00 New Revision: 9d63b90b59a6283531199e29038954db9ae23d74 URL: https://github.com/llvm/llvm-project/commit/9d63b90b59a6283531199e29038954db9ae23d74 DIFF: https://github.com/llvm/llvm-project/commit/9d63b90b59a6283531199e29038954db9ae23d74.diff

[Lldb-commits] [PATCH] D112169: [lldb] [Communication] Add a WriteAll() method that resumes writing

mgorny updated this revision to Diff 381980. mgorny added a comment. `sleep()` is no longer necessary now that we're operating in blocking mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112169/new/ https://reviews.llvm.org/D112169 Files: lldb/include/lldb/Core/Communication.h

[Lldb-commits] [lldb] 40e4ac3 - [lldb] Modernize Platform::GetOSBuildString

Author: Pavel Labath Date: 2021-10-25T15:58:58+02:00 New Revision: 40e4ac3e5b3548aa77367da37aba52f2556b855e URL: https://github.com/llvm/llvm-project/commit/40e4ac3e5b3548aa77367da37aba52f2556b855e DIFF: https://github.com/llvm/llvm-project/commit/40e4ac3e5b3548aa77367da37aba52f2556b855e.diff

[Lldb-commits] [PATCH] D112442: [lldb] [Host/ConnectionFileDescriptor] Do not use non-blocking mode

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. All read should be going through the select(2) in ConnectionFileDescriptor::BytesAvaliable, which effectively erases (non-)blocking mode differences in reading. And we do want to perform write

[Lldb-commits] [PATCH] D112442: [lldb] [Host/ConnectionFileDescriptor] Do not use non-blocking mode

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, teemperor. mgorny requested review of this revision. Disable non-blocking mode that's enabled only for file:// and serial:// protocols. We do not seem to have a really good reason for it, and it only complicates ha

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 created this revision. xujuntwt95329 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The key stored in the source map is a normalized path string with host's path style, so it is also necessary to normalize the file path durin

[Lldb-commits] [lldb] 025f6ca - [lldb] Modernize TestBitfields

Author: Raphael Isemann Date: 2021-10-25T13:11:39+02:00 New Revision: 025f6ca7c469b6412b58b69fab17092548d5f6c1 URL: https://github.com/llvm/llvm-project/commit/025f6ca7c469b6412b58b69fab17092548d5f6c1 DIFF: https://github.com/llvm/llvm-project/commit/025f6ca7c469b6412b58b69fab17092548d5f6c1.dif

[Lldb-commits] [lldb] a24b2b6 - [lldb] Also print index of child when ValueCheck fails

Author: Raphael Isemann Date: 2021-10-25T13:03:56+02:00 New Revision: a24b2b6aa06a001a98328acf624a5a8b1ab4139a URL: https://github.com/llvm/llvm-project/commit/a24b2b6aa06a001a98328acf624a5a8b1ab4139a DIFF: https://github.com/llvm/llvm-project/commit/a24b2b6aa06a001a98328acf624a5a8b1ab4139a.dif

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor

mgorny updated this revision to Diff 381918. mgorny added a comment. Remove error handling from URI mapping to make the code simpler. In the end, the only possible error here was '--reverse-connect without valid host:port' and we can just treat that as UNIX connect for symmetry with non-reverse

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor

mgorny updated this revision to Diff 381916. mgorny added a comment. Remove error handling from socket name getters. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111964/new/ https://reviews.llvm.org/D111964 Files: lldb/include/lldb/Host/posix/ConnectionFileDescriptorPosix.h lldb/s

[Lldb-commits] [lldb] 309fccd - [lldb][NFC] Use llvm::Optional to refer to Optional

Author: Raphael Isemann Date: 2021-10-25T11:37:15+02:00 New Revision: 309fccdac936c49d0771878b3f4dd345a5e1c5d8 URL: https://github.com/llvm/llvm-project/commit/309fccdac936c49d0771878b3f4dd345a5e1c5d8 DIFF: https://github.com/llvm/llvm-project/commit/309fccdac936c49d0771878b3f4dd345a5e1c5d8.dif

[Lldb-commits] [lldb] 1397c56 - Fix windows build for 6fa1b4ff4

Author: Pavel Labath Date: 2021-10-25T11:12:39+02:00 New Revision: 1397c56d7ae844033d8ba9b7dee2b1b30a6b37c0 URL: https://github.com/llvm/llvm-project/commit/1397c56d7ae844033d8ba9b7dee2b1b30a6b37c0 DIFF: https://github.com/llvm/llvm-project/commit/1397c56d7ae844033d8ba9b7dee2b1b30a6b37c0.diff

[Lldb-commits] [PATCH] D112314: [lldb] [Utility/UriParser] Return results as 'struct URI'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e5a4147e524: [lldb] [Utility/UriParser] Return results as 'struct URI' (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Gi

[Lldb-commits] [lldb] 0e5a414 - [lldb] [Utility/UriParser] Return results as 'struct URI'

Author: Michał Górny Date: 2021-10-25T10:58:21+02:00 New Revision: 0e5a4147e52470516af8c3c6644dca007a6ec4be URL: https://github.com/llvm/llvm-project/commit/0e5a4147e52470516af8c3c6644dca007a6ec4be DIFF: https://github.com/llvm/llvm-project/commit/0e5a4147e52470516af8c3c6644dca007a6ec4be.diff

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor

mgorny added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:647 + uint16_t port = listening_socket.get()->GetLocalPortNumber(); + socket_id_callback(port != 0 ? std::to_string(port) : ""); labath wrote: > mgorny wrote: >

[Lldb-commits] [PATCH] D112365: [lldb] Support serial port parity checking

This revision was automatically updated to reflect the committed changes. Closed by commit rG21bb808eb486: [lldb] Support serial port parity checking (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [lldb] 21bb808 - [lldb] Support serial port parity checking

Author: Michał Górny Date: 2021-10-25T10:51:46+02:00 New Revision: 21bb808eb4867b35b08fa962c7c25e812fcc8836 URL: https://github.com/llvm/llvm-project/commit/21bb808eb4867b35b08fa962c7c25e812fcc8836 DIFF: https://github.com/llvm/llvm-project/commit/21bb808eb4867b35b08fa962c7c25e812fcc8836.diff

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor

labath added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:583-610 +ConnectionStatus ConnectionFileDescriptor::UnixAbstractSocketAccept( +llvm::StringRef socket_name, +std::function socket_id_callback, +Status *error_ptr) { + S

[Lldb-commits] [PATCH] D112310: [lldb/DWARF] Don't create lldb_private::Functions for gc'ed DW_TAG_subprograms

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1055f091908: [lldb/DWARF] Don't create lldb_private::Functions for gc'ed DW_TAG_subprograms (authored by labath). Repository: rG LLVM Github Mono

[Lldb-commits] [lldb] 6fa1b4f - Remove ConstString from DynamicLoader, JITLoader and Instruction plugin names

Author: Pavel Labath Date: 2021-10-25T10:32:35+02:00 New Revision: 6fa1b4ff4b05b9b9a432f7310802255c160c8f4f URL: https://github.com/llvm/llvm-project/commit/6fa1b4ff4b05b9b9a432f7310802255c160c8f4f DIFF: https://github.com/llvm/llvm-project/commit/6fa1b4ff4b05b9b9a432f7310802255c160c8f4f.diff

[Lldb-commits] [lldb] c1055f0 - [lldb/DWARF] Don't create lldb_private::Functions for gc'ed DW_TAG_subprograms

Author: Pavel Labath Date: 2021-10-25T10:32:35+02:00 New Revision: c1055f09190856ae58c9a075b4103d77623228ee URL: https://github.com/llvm/llvm-project/commit/c1055f09190856ae58c9a075b4103d77623228ee DIFF: https://github.com/llvm/llvm-project/commit/c1055f09190856ae58c9a075b4103d77623228ee.diff

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor

mgorny updated this revision to Diff 381876. mgorny marked an inline comment as done. mgorny added a comment. Move to gdb-remote. Update per requests. I've also added a `typedef` for the callback and optimized the URI parsing a bit to hopefully involve less temporary strings. CHANGES SINCE LAS

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:583-610 +ConnectionStatus ConnectionFileDescriptor::UnixAbstractSocketAccept( +llvm::StringRef socket_name, +std::function socket_id

[Lldb-commits] [PATCH] D112169: [lldb] [Communication] Add a WriteAll() method that resumes writing

labath added a comment. In D112169#3083380 , @mgorny wrote: > I'm not against that. However, unless I'm mistaken — even with blocking I/O, > we need to account for the `write()` being interrupted in the middle of > operation and returning less than `src

[Lldb-commits] [PATCH] D112314: [lldb] [Utility/UriParser] Return results as 'struct URI'

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112314/new/ https://reviews.llvm.org/D112314 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D112169: [lldb] [Communication] Add a WriteAll() method that resumes writing

mgorny added a comment. I'm not against that. However, unless I'm mistaken — even with blocking I/O, we need to account for the `write()` being interrupted in the middle of operation and returning less than `src_len`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112169/new/ https://r

[Lldb-commits] [PATCH] D112357: [lldb] [Host] Move port predicate-related logic to gdb-remote

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is pure goodness. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112357/new/ https://reviews.llvm.org/D112357 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D112169: [lldb] [Communication] Add a WriteAll() method that resumes writing

labath added a comment. I think it would be worth at least spending a bit of time to understand the reason for using non-blocking i/o here. Given that all Reads should go through the select(2) in ConnectionFileDescriptor::BytesAvailable, it's possible we could avoid it altogether. CHANGES SIN

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath added a comment. In D112212#3083194 , @teemperor wrote: > Given that `shlex.join` is only used for making the diagnostics copy-pastable > into the terminal, we could probably get away by just making it use the > normal string conversion of list o

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor

labath added a comment. I like this. For lack of a better place, I'd place the `LLGSArgToURL` function into `GDBRemoteCommunicationServerLLGS.h`. That is the ~highest level file that can still be unit tested. Comment at: lldb/include/lldb/Host/posix/ConnectionFileDescriptorPo