wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land.
looks good ================ Comment at: lldb/include/lldb/Symbol/SymbolFile.h:309 + /// this call should add the size of all sections that contain debug + /// information. Symbols the symbol tables are not considered debug + /// information for this call to make it easy and quick for this number to be ---------------- `Symbols the symbol tables` -> fix that :) ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:1463-1464 + SymbolFile *symfile = module_sp->GetSymbolFile(); + if (symfile) + elapsed += symfile->GetDebugInfoParseTime(); + } ---------------- missing braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112501/new/ https://reviews.llvm.org/D112501 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
