[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:83 +struct Variables { + // Bit mask to tell if a variableReference is inside wallace wrote: > yinghuitan wrote: > > wallace wrote: > > > Move it to a new file and add a global comme

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan added a comment. Debug console and VScode UI synchronization is a much bigger topic than instruction level stepping so I do not plan to fix in this patch. For example, if user change value via lldb comamnd, the watch/locals won't change. If user switch stack frames/threads, it won't

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 360340. yinghuitan added a comment. Last push failed to include the changes due to git issue. Push including the real changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.

[Lldb-commits] [lldb] 0419584 - [intel pt] Add TSC timestamps

Author: Walter Erquinigo Date: 2021-07-20T16:29:17-07:00 New Revision: 04195843ef91d012dbaa1611b348447f8136c271 URL: https://github.com/llvm/llvm-project/commit/04195843ef91d012dbaa1611b348447f8136c271 DIFF: https://github.com/llvm/llvm-project/commit/04195843ef91d012dbaa1611b348447f8136c271.di

[Lldb-commits] [PATCH] D106328: [trace][intel pt] Add TSC timestamps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04195843ef91: [intel pt] Add TSC timestamps (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. There are a lot of comments from your previous diff that were not addressed. I reviewed up to a certain point but fix the remaining ones anyway. About documentation, try to be more

[Lldb-commits] [PATCH] D106328: [trace][intel pt] Add TSC timestamps

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106328/new/ https://reviews.llvm.org/D106328 _

[Lldb-commits] [PATCH] D106328: [trace][intel pt] Add TSC timestamps

wallace added inline comments. Comment at: lldb/source/Commands/Options.td:1071 +Desc<"For each instruction, print the corresponding timestamp counter if available.">; } clayborg wrote: > You mentioned "--psb_period" in your description, but that isn't he

[Lldb-commits] [PATCH] D106348: Write the # of addressable bits into Mach-O corefiles, read it back out again

shafik added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5575-5613 +addr_t ObjectFileMachO::GetAddressMask() { + addr_t mask = 0; + ModuleSP module_sp(GetModule()); + if (module_sp) { +std::lock_guard guard(module_sp->GetMutex());

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione added a comment. @aprantl I renamed `WillPop` to accurately reflect that it's `DidPop`. I also added a comment about the invariant that is broken when `std::move` is used on elements of `m_plans`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione updated this revision to Diff 360290. kastiglione added a comment. Rename WillPop to DidPop, and comment on m_plans invariant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/ https://reviews.llvm.org/D106171 Files: lldb/inc

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py:386-389 +var_ref = permanent_expr_varref_dict[expandable_expression['name']] +response = self.vscode.request_variables(var_ref) +self.verify_va

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 360281. yinghuitan marked 33 inline comments as done. yinghuitan added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/ https://reviews.llvm.org/D105166 Files:

[Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

JDevlieghere added a comment. Fair enough. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106122/new/ https://reviews.llvm.org/D106122 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D106328: [trace][intel pt] Add TSC timestamps

wallace updated this revision to Diff 360265. wallace added a comment. address comments + add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106328/new/ https://reviews.llvm.org/D106328 Files: lldb/docs/lldb-gdb-remote.txt lldb/include/ll

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

rupprecht added a comment. In D106226#2891107 , @teemperor wrote: > Congrats on getting started on your first patch! I improving this error > message really seems like a good idea. > > From what I can see the error message here is identical to GDB's whic

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

teemperor added a comment. Congrats on getting started on your first patch! I improving this error message really seems like a good idea. From what I can see the error message here is identical to GDB's which is a different project with an incompatible license. No idea if this is large enough

[Lldb-commits] [PATCH] D106348: Write the # of addressable bits into Mach-O corefiles, read it back out again

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5575-5613 +addr_t ObjectFileMachO::GetAddressMask() { + addr_t mask = 0; + ModuleSP module_sp(GetModule()); + if (module_sp) { +std::lock_guard guard(module_sp->GetMut

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:125-126 +return Decode(thread)->GetRawTraceSize(); + else +return None; +} No else after return. Seems like a good candidate for a ternary operator. CHA

[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

vsk updated this revision to Diff 360180. vsk added a comment. Drop unneeded braces in switch cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102428/new/ https://reviews.llvm.org/D102428 Files: lldb/include/lldb/Core/Address.h lldb/includ

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh created this revision. Herald added a subscriber: arphaman. kimanh updated this revision to Diff 360084. kimanh added a comment. kimanh retitled this revision from "[Index] Only fallback to manual index if no entry was found" to "[DWARF5] Only fallback to manual index if no entry was found

[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

mib updated this revision to Diff 360074. mib edited the summary of this revision. mib added a comment. Address @jingham feedbacks: - Make `ScriptedProcess` plugin language agnostic - Simplify execution control by removing `Listener-Broadcaster` model - Solve non-deterministic hangs following D10

[Lldb-commits] [PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna added inline comments. Comment at: clang/include/clang/Basic/LangStandards.def:187 Digraphs | HexFloat | OpenCL) +LANGSTANDARD_ALIAS_DEPR(openclcpp10, "clc++") Anastasia wrote: > I am not sure we should move it into the deprecated categor

[Lldb-commits] [PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna updated this revision to Diff 360059. Topotuna added a comment. `clc++` made no longer deprecated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/LangStandards.def clan

[Lldb-commits] [lldb] aa09d1f - [lldb] Remove unused variable. NFCI

Author: Benjamin Kramer Date: 2021-07-20T10:34:05+02:00 New Revision: aa09d1f9c91555b715481defc84cc96d80e52516 URL: https://github.com/llvm/llvm-project/commit/aa09d1f9c91555b715481defc84cc96d80e52516 DIFF: https://github.com/llvm/llvm-project/commit/aa09d1f9c91555b715481defc84cc96d80e52516.dif

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny updated this revision to Diff 360049. mgorny added a comment. Rebased. Switched to watchpoint iterator API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 Files: lldb/include/lldb/Target/Process.h lldb/include/lldb/lldb-private-enu

[Lldb-commits] [PATCH] D100267: [lldb] [gdb-remote client] Remove breakpoints throughout vfork

mgorny updated this revision to Diff 360048. mgorny added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100267/new/ https://reviews.llvm.org/D100267 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/source/Plugins/Process/gdb-remote/Process

[Lldb-commits] [PATCH] D100263: [lldb] [gdb-remote client] Remove breakpoints in forked processes

mgorny updated this revision to Diff 360047. mgorny added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100263/new/ https://reviews.llvm.org/D100263 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/source/Plugins/Process/gdb-remote/Process

[Lldb-commits] [PATCH] D100206: [lldb] [llgs client] Support minimal fork/vfork handling

mgorny updated this revision to Diff 360046. mgorny added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100206/new/ https://reviews.llvm.org/D100206 Files: lldb/include/lldb/Target/Process.h lldb/include/lldb/Target/StopInfo.h lldb/source/Plugins/Process/gdb-r

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

hanbingwang updated this revision to Diff 360044. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105717/new/ https://reviews.llvm.org/D105717 Files: lldb/include/lldb/Target/Trace.h lldb/source/Commands/CommandObjectThread.cpp lldb/source/Commands/Options.td lldb/source/Plugins/Tr

[Lldb-commits] [PATCH] D106348: Write the # of addressable bits into Mach-O corefiles, read it back out again

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. jasonmolenda requested review of this revision. On systems where we have an address mask, add support to process save-core to note the num

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

hanbingwang updated this revision to Diff 360037. hanbingwang added a comment. Create a "thread trace dump info" command CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105717/new/ https://reviews.llvm.org/D105717 Files: lldb/include/lldb/Target/Trace.h lldb/source/Commands/CommandOb

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

hanbingwang updated this revision to Diff 360035. hanbingwang edited the summary of this revision. hanbingwang added a comment. Create a "thread trace dump info" command CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105717/new/ https://reviews.llvm.org/D105717 Files: lldb/include/lld