yinghuitan added inline comments.
================
Comment at: lldb/tools/lldb-vscode/VSCode.h:83
+struct Variables {
+ // Bit mask to tell if a variableReference is inside
----------------
wallace wrote:
> yinghuitan wrote:
> > wallace wrote:
> > > Move it to a new file and add a global comment explaining the different
> > > kinds of variables that exist
> > I can do this in future refactoring. I am doing pragmatic refactoring here
> > without delaying fixing the important bug.
> this bug has been around probably for years, so I think it's reasonable to
> spend a few minutes polishing the code and delivering something nicer.
> Otherwise we might never do any refactor.
>
> Besides, don't forget to add some top-level documentation in this class
> explaining the difference in variables and how they work in lldb-vscode.
> It'll be very useful for future improvements, as it's not intuitive to figure
> out some of the details.
I disagree. The bug is not years but a recent VScode protocol timing/sequence
change caused regression. The point is not about several minutes time but
focusing on big picture -- I am fixing a very important bug in lldb which
prevents users from using watch window in VScode. Everyone has different
opinion about refactoring or make its better. We can keep on iterating but I
think landing the change to unblock users is more important at this point.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105166/new/
https://reviews.llvm.org/D105166
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
