[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace updated this revision to Diff 356875. wallace added a comment. improve documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105531/new/ https://reviews.llvm.org/D105531 Files: lldb/include/lldb/Target/Trace.h lldb/include/lldb/T

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace updated this revision to Diff 356873. wallace added a comment. Herald added a subscriber: JDevlieghere. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105531/new/ https://reviews.llvm.org/D105531 Files: lldb/include/lldb/Target/Trace.

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace created this revision. wallace added a reviewer: clayborg. Herald added subscribers: dang, mgorny. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D104422 added the interface for TraceCurso

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

shafik added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1082 + io_redirect_or_error = ScriptInterpreterIORedirect::Create( + options.GetEnableIO(), m_debugger, nullptr); + `/*result=*/nullp

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1517 + + llvm::Expected> repeated_tags_or_err = + details->manager->RepeatTagsForRange(*unpacked_tags_or_err, range); We unpack, repeat and then repack. Can

[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

omjavaid added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagManager.h:35 + // alignment/expansion over again. + struct TagManagerWithRange { +const MemoryTagManager *manager; I was wondering if you can explain reason for hosting this struc

[Lldb-commits] [PATCH] D105389: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API

jingham added a comment. Could you put a docstring describing the API's in the SBProcess.i file. It is annoying to have to do this in two places but given the way SWIG works we don't have a better alternative. This is where the help in the Python REPL comes from so it's useful to have it ther

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

JDevlieghere accepted this revision. JDevlieghere added a comment. Nice! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105034/new/ https://reviews.llvm.org/D105034 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D105179: [lldb][AArch64] Add tag repeat and unpack to memory tag manager

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good. I just made some cosmetic comments. Comment at: lldb/include/lldb/Target/MemoryTagManager.h:79 + // + // Set granules to 0 to skip checking the number

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1296 +"""Returns true if the architecture is AArch64.""" +return self.getArchitecture().lower() in ["aarch64"] + This can be: ``` return self.getArchi

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

omjavaid created this revision. omjavaid added a reviewer: DavidSpickett. Herald added subscribers: danielkiss, kristof.beyls. omjavaid requested review of this revision. This patch adds a helper function to test target architecture is AArch64 or not. This also tightens isAArch64* helpers by addi

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat updated this revision to Diff 356677. werat added a comment. Use local variables in test Assert for SetValueFromCString Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105470/new/ https://reviews.llvm.org/D105470 Files: lldb/source/Core/Valu

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. So IIUC we can do things here: 1. We disallow giving `ValueObjectConstResult` a new value via `SetData`/`SetValueFromCString`. Both functions have a way of signaling error to the user,

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56 # Run the packet stream context = self.expect_gdbremote_sequence() self.assertIsNotNone(context) This test is s

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat updated this revision to Diff 356663. werat added a comment. Herald added a subscriber: JDevlieghere. Simplify the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105470/new/ https://reviews.llvm.org/D105470 Files: lldb/source/Core

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat created this revision. werat added a reviewer: teemperor. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Children of ValueObject automatically update themselves when they detect the state of the process has changed, which typic

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

teemperor added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103172/new/ https://reviews.llvm.org/D103172 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 51ab17b - [lldb][docs] Fix reference warnings in python-reference.rst

Author: Raphael Isemann Date: 2021-07-06T10:14:33+02:00 New Revision: 51ab17b91d2e3280d08c09648bb4950c0e217d20 URL: https://github.com/llvm/llvm-project/commit/51ab17b91d2e3280d08c09648bb4950c0e217d20 DIFF: https://github.com/llvm/llvm-project/commit/51ab17b91d2e3280d08c09648bb4950c0e217d20.dif