[Lldb-commits] [lldb] 99155e9 - [lldb][NFC] Remove unused header from Target

2021-05-24 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-05-24T15:13:08-07:00 New Revision: 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1 URL: https://github.com/llvm/llvm-project/commit/99155e913e9bad5f7f8a247f8bb3a3ff3da74af1 DIFF: https://github.com/llvm/llvm-project/commit/99155e913e9bad5f7f8a247f8bb3a3ff3da74af1.diff

[Lldb-commits] [PATCH] D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target

2021-05-24 Thread Inactive via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c0b0de904a5: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from… (authored by xiaobai). Repository: rG LLVM Github Mon

[Lldb-commits] [lldb] 4c0b0de - [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target

2021-05-24 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-05-24T13:13:12-07:00 New Revision: 4c0b0de904a5622c33e3ed97e86c6792fbc13feb URL: https://github.com/llvm/llvm-project/commit/4c0b0de904a5622c33e3ed97e86c6792fbc13feb DIFF: https://github.com/llvm/llvm-project/commit/4c0b0de904a5622c33e3ed97e86c6792fbc13feb.diff

[Lldb-commits] [PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

2021-05-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 347478. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp lldb/source/Plugins/Typ

[Lldb-commits] [PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

2021-05-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. cat >1.cpp < struct DWrapper {}; typedef DWrapper DW; struct B { DW spd; } b; struct E { B &b_ref = b; static DW f() { return {}; } } e; EOH $ (set -ex;./bin/clang -c -o 1.o 1.cpp -Wall -g;./bin/lldb -b ./1.o -o 'p E' -o 'p e') (lldb) p

[Lldb-commits] [PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

2021-05-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 347475. jankratochvil added a comment. Update of the testcase but it still does not reproduce the LLDB problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101236/new/ https://reviews.llvm.org/D101236

[Lldb-commits] [PATCH] D103020: [lldb] Add missing mutex guards to TargetList::CreateTarget

2021-05-24 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba51da820e4d: [lldb] Add missing mutex guards to TargetList::CreateTarget (authored by teemperor). Herald added a subscriber: lldb-commits. Reposito

[Lldb-commits] [lldb] ba51da8 - [lldb] Add missing mutex guards to TargetList::CreateTarget

2021-05-24 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-05-24T19:49:57+02:00 New Revision: ba51da820e4dc73153009f8a621ef49711294ae1 URL: https://github.com/llvm/llvm-project/commit/ba51da820e4dc73153009f8a621ef49711294ae1 DIFF: https://github.com/llvm/llvm-project/commit/ba51da820e4dc73153009f8a621ef49711294ae1.dif

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

2021-05-24 Thread Michael Benfield via Phabricator via lldb-commits
mbenfield added a comment. In D102942#2774819 , @dblaikie wrote: > Sure, all sounds good - if you can, please reach out to the authors of any of > the semantics changing changes (the ones related to the `Changed` values in > transformations) to see if t

[Lldb-commits] [PATCH] D103020: [lldb] Add missing mutex guards to TargetList::CreateTarget

2021-05-24 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103020/new/ https://reviews.llvm.org/D103020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D103020: [lldb] Add missing mutex guards to TargetList::CreateTarget

2021-05-24 Thread Vedant Kumar via Phabricator via lldb-commits
vsk accepted this revision as: vsk. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103020/new/ https://reviews.llvm.org/D103020 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] 5d7c1d8 - [lldb] Readd deleted variable in the sample test

2021-05-24 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-05-24T16:29:25+02:00 New Revision: 5d7c1d8f33c305b5113cd1429344524ddc2316d9 URL: https://github.com/llvm/llvm-project/commit/5d7c1d8f33c305b5113cd1429344524ddc2316d9 DIFF: https://github.com/llvm/llvm-project/commit/5d7c1d8f33c305b5113cd1429344524ddc2316d9.dif

[Lldb-commits] [PATCH] D102771: [lldb] Introduce createTestTarget for creating a valid target in API tests

2021-05-24 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54c2687292da: [lldb] Introduce createTestTarget for creating a valid target in API tests (authored by teemperor). Herald added subscribers: lldb-comm

[Lldb-commits] [lldb] 54c2687 - [lldb] Introduce createTestTarget for creating a valid target in API tests

2021-05-24 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-05-24T16:18:44+02:00 New Revision: 54c2687292da54a2d7964a47b0e334155385f084 URL: https://github.com/llvm/llvm-project/commit/54c2687292da54a2d7964a47b0e334155385f084 DIFF: https://github.com/llvm/llvm-project/commit/54c2687292da54a2d7964a47b0e334155385f084.dif

[Lldb-commits] [PATCH] D103020: [lldb] Add missing mutex guards to TargetList::CreateTarget

2021-05-24 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. TestMultipleTargets is randomly failing on the bots. The reason for that is that the test is calling `SBDebugge

[Lldb-commits] [lldb] 42a9c0c - [lldb] Reland "Fix UB in half2float" to fix the ubsan bot.

2021-05-24 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-05-24T15:23:32+02:00 New Revision: 42a9c0c80c23fa0de3e3b00fef0dfa6d85e18e55 URL: https://github.com/llvm/llvm-project/commit/42a9c0c80c23fa0de3e3b00fef0dfa6d85e18e55 DIFF: https://github.com/llvm/llvm-project/commit/42a9c0c80c23fa0de3e3b00fef0dfa6d85e18e55.dif

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

2021-05-24 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. `ABISysV_ppc.cpp` feels a bit like this should be used to calculate some offset, but I don't think that's for this review to figure out what is wrong there. The other LLDB changes LGTM. Comment at: lldb/source/Inter

[Lldb-commits] [PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

2021-05-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3684 + return ToAttrOrErr.takeError(); +#if 0 +RecordType *FromRT = It is still not working. The testcase either PASSes despite this `#if 0` or it FAILs even if it is `#if 1`