[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

2021-03-13 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil updated this revision to Diff 330473. jankratochvil edited the summary of this revision. jankratochvil added a comment. The testcase assumes checked-in D98589 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

2021-03-13 Thread Andy Yankovsky via Phabricator via lldb-commits
werat marked 4 inline comments as done. werat added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2162 void SymbolFileDWARF::FindGlobalVariables(const RegularExpression ®ex, uint32_t max_matches

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

2021-03-13 Thread Andy Yankovsky via Phabricator via lldb-commits
werat updated this revision to Diff 330445. werat added a comment. Address review comments: - Don't create expensive `ConstString` objects - Merge `ParseStaticConstMemberDIE` into `ParseVariableDIE` - Add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

2021-03-13 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 330441. mgorny added a comment. Added support for 0 and -1 values in `ReadTid()` helper, controlled via `allow_any` and `allow_all` parameters. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98482/new/ https://reviews.llvm.org/D98482 Files: lldb/i

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

2021-03-13 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 330435. mgorny added a comment. Add a `GDBRemoteCommunicationServerLLGS::ReadTid()` helper that does appropriate PID verification and constructs error packets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98482/new/ https://reviews.llvm.org/D98482

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

2021-03-13 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. In D98482#2623005 , @labath wrote: > - I wouldn't add `multiprocess` to the qSupported packets just yet. Since > this is accepting the extended syntax regardless of whether the other side > claimed to support it (there's no hard i

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

2021-03-13 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 330432. mgorny marked an inline comment as done. mgorny added a comment. Updated utility function to use `StringRef` and reformatted. Further changes incoming. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98482/new/ https://reviews.llvm.org/D98482