[Lldb-commits] [PATCH] D97249: [lldb] Support debugging utility functions

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a subscriber: pengfei. JDevlieghere requested review of this revision. LLDB uses utility functions to run code in the inferior for its own internal purposes, such as reading classes from the Objective-C runti

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG389955c69a3b: [lldb] add check for libcxx runtime (authored by rmaz, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https:/

[Lldb-commits] [lldb] 389955c - [lldb] add check for libcxx runtime

Author: Richard Howell Date: 2021-02-22T17:53:54-08:00 New Revision: 389955c69a3b9f418e3f39694c94b4519322dd42 URL: https://github.com/llvm/llvm-project/commit/389955c69a3b9f418e3f39694c94b4519322dd42 DIFF: https://github.com/llvm/llvm-project/commit/389955c69a3b9f418e3f39694c94b4519322dd42.diff

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

jingham accepted this revision. jingham added a comment. LGTM at this point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97165/new/ https://reviews.llvm.org/D97165 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D97235: [lldb] Reinstate support for LLDB_VERSION_STRING

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d2850161e8c: [lldb] Reinstate support for LLDB_VERSION_STRING (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] 5d28501 - [lldb] Reinstate support for LLDB_VERSION_STRING

Author: Jonas Devlieghere Date: 2021-02-22T16:56:00-08:00 New Revision: 5d2850161e8cc14254a615911b0277d0050575d6 URL: https://github.com/llvm/llvm-project/commit/5d2850161e8cc14254a615911b0277d0050575d6 DIFF: https://github.com/llvm/llvm-project/commit/5d2850161e8cc14254a615911b0277d0050575d6.d

[Lldb-commits] [PATCH] D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support

jrtc27 added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_mips64.cpp:141 + uint64_t f31; + uint64_t fcsr; + uint64_t fir; MIPS calls it FCSR, FreeBSD's regnum.h calls it FSR. I don't know which is the right thing to

[Lldb-commits] [PATCH] D97235: [lldb] Reinstate support for LLDB_VERSION_STRING

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97235/new/ https://reviews.llvm.org/D97235 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https://reviews.llvm.org/D97227 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

rmaz updated this revision to Diff 325600. rmaz added a comment. update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https://reviews.llvm.org/D97227 Files: lldb/test/CMakeLists.txt Index: lldb/test/CMakeLists.txt ==

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

JDevlieghere added inline comments. Comment at: lldb/test/CMakeLists.txt:121 "LLDB test suite requires libc++, but it is currently disabled. " "Please add `libcxx` to `LLVM_ENABLE_PROJECTS` or disable tests " "via `LLDB_INCLUDE_TESTS=OFF`.")

[Lldb-commits] [PATCH] D97235: [lldb] Reinstate support for LLDB_VERSION_STRING

JDevlieghere created this revision. JDevlieghere added a reviewer: kastiglione. JDevlieghere requested review of this revision. Reinstate support for specifying `-DLLDB_VERSION_STRING` which seems to have gotten accidentally removed in the past. rdar://38983903 (lldb version number requires an i

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https://reviews.llvm.org/D97227 ___

[Lldb-commits] [PATCH] D97205: [lldb][NFC] Don't inherit from UserID in ValueObject

shafik added inline comments. Comment at: lldb/include/lldb/Core/ValueObject.h:888 + /// Unique identifier for every value object. + UserID m_id; + This makes more sense, `ValueObject` is not a `UserID` but contains one. CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D97230: [lldb] [test] Workaround symlink-related create_after_attach test failure

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Use realpath() when spawning the executable create_after_attach to workaround a FreeBSD plugin (and possibly others) problem. If the

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

rmaz added a comment. In D97227#2580049 , @smeenai wrote: > My understanding of the issue is that, with the runtimes build, the `cxx` > target will get created after we process LLDB's build files. The `TARGET cxx` > check here will therefore fail, but th

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

smeenai added a comment. My understanding of the issue is that, with the runtimes build, the `cxx` target will get created after we process LLDB's build files. The `TARGET cxx` check here will therefore fail, but the `cxx` target will end up existing later, and CMake is perfectly fine adding a

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

rmaz created this revision. Herald added a subscriber: mgorny. rmaz requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When enabling LLDB tests with `LLVM_ENABLE_RUNTIMES=libcxx` CMake will fail with: LLDB test suite requires libc++, but i

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

mib added a comment. In D95712#2572343 , @JDevlieghere wrote: > This LGTM. @labath are you fine with landing this and incrementally improving > the interface? @labath Any objection on the patches ? We would like to land these as soon as possible. Rep

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:31 +) +self.assertRegex(valobj.children[0].value, "^0x0{8,}$") + jingham wrote: >

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione updated this revision to Diff 325549. kastiglione added a comment. test for null using SBValue.unsigned Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97165/new/ https://reviews.llvm.org/D97165 Files: lldb/source/Plugins/Language/CPlu

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:75-76 """ -if "LLDB_DEBUGSERVER_PATH" in os.environ: -return os.environ["LLDB_DEBUGSERVER_PATH"] goncharov wrote: > hi @labat

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

jingham added a comment. This looks great. It's a little weird to use "SBValue.value" to get a string version of something that's a pointer and then have to do regex compares. It's more direct to use "unsigned" and compare against 0x0. Comment at: lldb/test/API/functionali

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione updated this revision to Diff 325529. kastiglione added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97165/new/ https://reviews.llvm.org/D97165 Files: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp lldb/sou

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione updated this revision to Diff 325527. kastiglione added a comment. Use expect_var_path and fix other issues with the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97165/new/ https://reviews.llvm.org/D97165 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 325517. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/register/register/aarch64_dynamic_regset/Makefile lldb/test/API/com

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:16 +self.assertTrue(reg_value.IsValid(), +'Verify we have a register named "%s"' % (name)) +self.assertE

[Lldb-commits] [PATCH] D97210: [lldb] Rename NativeRegisterContext{Watchpoint => DBReg}_x86

mgorny updated this revision to Diff 325506. mgorny added a comment. Fixed the top line of header in .cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97210/new/ https://reviews.llvm.org/D97210 Files: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_x86_64.h lldb/

[Lldb-commits] [PATCH] D97210: [lldb] Rename NativeRegisterContext{Watchpoint => DBReg}_x86

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. https://reviews.llvm.org/D97210 Files: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_x86_64.h lldb/source/Plugins/Process/Linux/NativeRegisterContext

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mgorny updated this revision to Diff 325500. mgorny added a comment. Renamed the utility class/file and switched the test to use SBPlatform. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96548/new/ https://reviews.llvm.org/D96548 Files: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 325493. omjavaid added a comment. Ran clang format and fixed typos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/sou

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1128 + if (error.Success()) m_sve_header_is_valid = true; DavidSpickett wrote: > Indent here > > Actually, for these you could just do `m_sv

[Lldb-commits] [PATCH] D48177: Suppress SIGSEGV on Android when the program will recover

jingham added a comment. Another thing that slightly bugs me about this patch is now we have the Architecture with special purpose code to modify the stop reason, and the Platform ditto. I wonder if it wouldn't be better to have a way to register interest in modifying stop infos, and then let

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

mgorny added a comment. In D96548#2577762 , @labath wrote: > In D96548#2574437 , @mgorny wrote: > >> In D96548#2571489 , @mhorne wrote: >> >>> I should also note that it is m

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

teemperor added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:11 + +class LibcxSharedPtrDataFormatterTestCase(TestBase): + kastiglione wrote: > teemperor wrote:

[Lldb-commits] [PATCH] D97205: [lldb][NFC] Don't inherit from UserID in ValueObject

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. ValueObject inherits from UserID which is just a bad idea: - The inheritance gives ValueObject some member func

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

kastiglione added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:11 + +class LibcxSharedPtrDataFormatterTestCase(TestBase): + teemperor wrote: > `Libcx` typo. FWI

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. You can use `expect_var_path` to test `frame var` (LLDB calls the frame var input "expressions paths", hence the `_path` suffix). That way you can test all of these things for

[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic

JDevlieghere added a comment. Looks like a great improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97165/new/ https://reviews.llvm.org/D97165 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1128 + if (error.Success()) m_sve_header_is_valid = true; Indent here Actually, for these you could just do `m_sve_header_is_valid = e

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2038 + return m_aux_vector->GetAuxValue(type); +} Do we not get this from the protected `GetAuxValue` on `NativeProcessELF`? CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

DavidSpickett added a comment. Some python nits otherwise the test looks good. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:16 +self.assertTrue(reg_value.IsValid(), +'Verify we have a reg

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 325441. omjavaid added a comment. Review comments resolved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/register/registe

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 325435. omjavaid added a comment. Rebased after updates to parent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/sour

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

omjavaid updated this revision to Diff 325434. omjavaid added a comment. Rebased after updates to parent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96459/new/ https://reviews.llvm.org/D96459 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp lldb/source/Plugins/Pro

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 325433. omjavaid added a comment. This moves ConfigureRegisterInfos into constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_ar

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2566347 , @labath wrote: > I'm sorry, my response times are pretty slow these days. > > I'm thinking about this `ConfigureRegisterInfos` business. I get that the > vector length is variable, and so we need to refresh it

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

werat updated this revision to Diff 325415. werat added a comment. Added the test cases provided by jankratochvil@ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://reviews.llvm.org/D96778 Files: lldb/source/Plugins/SymbolFile/DWA

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

goncharov added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:75-76 """ -if "LLDB_DEBUGSERVER_PATH" in os.environ: -return os.environ["LLDB_DEBUGSERVER_PATH"] hi @labath ! Sorry for ig