[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Sorry was OOO. The source code is user input, so you can have anything in it. LLDB will happily read and return any file contents as long as it matches the source path. Like, create a t

[Lldb-commits] [PATCH] D85123: Truncate long lines/names if needed in lldb gui

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc0e8fb7874a: [lldb][gui] truncate long lines/names if needed (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] fc0e8fb - [lldb][gui] truncate long lines/names if needed

Author: Luboš Luňák Date: 2020-08-06T08:40:42+02:00 New Revision: fc0e8fb7874a73277b221e3f940b749cdd0a99d7 URL: https://github.com/llvm/llvm-project/commit/fc0e8fb7874a73277b221e3f940b749cdd0a99d7 DIFF: https://github.com/llvm/llvm-project/commit/fc0e8fb7874a73277b221e3f940b749cdd0a99d7.diff L

[Lldb-commits] [lldb] 9097ef8 - [lldb] Remove pointless assign to found_suffix (NFC)

Author: Jonas Devlieghere Date: 2020-08-05T22:54:03-07:00 New Revision: 9097ef84ce590dd002c972522d08c1de1329a7ce URL: https://github.com/llvm/llvm-project/commit/9097ef84ce590dd002c972522d08c1de1329a7ce DIFF: https://github.com/llvm/llvm-project/commit/9097ef84ce590dd002c972522d08c1de1329a7ce.d

[Lldb-commits] [PATCH] D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp

jasonmolenda updated this revision to Diff 283489. jasonmolenda added a comment. Update to std::unique_ptr -- thanks for the reminder! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85396/new/ https://reviews.llvm.org/D85396 Files: lldb/source/Da

[Lldb-commits] [PATCH] D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp

tschuett added a comment. And you can write it as std::unique_ptr synthetic_children = std::make_unique(...); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85396/new/ https://reviews.llvm.org/D85396

[Lldb-commits] [PATCH] D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp

davide added a comment. In D85396#2198668 , @tschuett wrote: > auto_ptr is deprecated since C++11 and will be removed in C++17. @jasonmolenda you might want to use `std::unique_ptr` instead -- probably LLVM won't migrate to 17 for a while, but still. R

[Lldb-commits] [PATCH] D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp

tschuett added a comment. auto_ptr is deprecated since C++11 and will be removed in C++17. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85396/new/ https://reviews.llvm.org/D85396 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This is correct to the best of my understanding. Thank you Jason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85396/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp

jasonmolenda updated this revision to Diff 283484. jasonmolenda added a comment. Made the change in Xcode and the indentation was off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85396/new/ https://reviews.llvm.org/D85396 Files: lldb/source/Da

[Lldb-commits] [PATCH] D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp

jasonmolenda created this revision. jasonmolenda added reviewers: jingham, davide. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. Looking over the clang static analyzer, came across this old memory leak - looks like it'

[Lldb-commits] [PATCH] D85388: [lldb] Fix bug in skipIfRosetta decorator

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fccdd5c85d0: [lldb] Fix bug in skipIfRosetta decorator (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85388/new/ https://reviews

[Lldb-commits] [lldb] 4fccdd5 - [lldb] Fix bug in skipIfRosetta decorator

Author: Jonas Devlieghere Date: 2020-08-05T20:51:07-07:00 New Revision: 4fccdd5c85d05b3b03d029f533762e233259573c URL: https://github.com/llvm/llvm-project/commit/4fccdd5c85d05b3b03d029f533762e233259573c DIFF: https://github.com/llvm/llvm-project/commit/4fccdd5c85d05b3b03d029f533762e233259573c.d

[Lldb-commits] [PATCH] D85388: [lldb] Fix bug in skipIfRosetta decorator

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. yes, this makes sense. We could refine the check in future. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85388/new/ https://reviews.llvm.org/D85388 ___

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

aprantl added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/valueobj-pass-by-reg/Makefile:1 +EXE := a.out +CFLAGS := -O1 I think this is redundant. The default is a.out Comment at: lldb/test/API/functionalities/dat

[Lldb-commits] [lldb] 1c1ffa6 - GetPath() returns a std::string temporary. You can't reference just the c_str.

Author: Jim Ingham Date: 2020-08-05T19:12:15-07:00 New Revision: 1c1ffa6a300a60c81be41a3e08a4e9da7499adc1 URL: https://github.com/llvm/llvm-project/commit/1c1ffa6a300a60c81be41a3e08a4e9da7499adc1 DIFF: https://github.com/llvm/llvm-project/commit/1c1ffa6a300a60c81be41a3e08a4e9da7499adc1.diff LO

[Lldb-commits] [lldb] 08063f8 - "|" used when "||" was meant in SBTarget::FindFunctions

Author: Jim Ingham Date: 2020-08-05T19:02:00-07:00 New Revision: 08063f85a7eadb1e54d0a03e0307bf15319513e8 URL: https://github.com/llvm/llvm-project/commit/08063f85a7eadb1e54d0a03e0307bf15319513e8 DIFF: https://github.com/llvm/llvm-project/commit/08063f85a7eadb1e54d0a03e0307bf15319513e8.diff LO

[Lldb-commits] [PATCH] D85388: [lldb] Fix bug in skipIfRosetta decorator

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:542 -if not lldbplatformutil.getPlatform() in ['darwin', 'macosx']: -return "not on macOS" -if (platform.uname()[5] == "arm") and (self.getArchitecture()

[Lldb-commits] [PATCH] D85388: [lldb] Fix bug in skipIfRosetta decorator

JDevlieghere created this revision. JDevlieghere added reviewers: davide, friss. JDevlieghere added a project: LLDB. JDevlieghere requested review of this revision. Currently, the `skipIfRosetta` decorator will skip tests with the message "not on macOS" on non-macOS platforms. This triggers for e

[Lldb-commits] [lldb] 3a538de - [lldb] Make UBSan tests remote ready

Author: Jonas Devlieghere Date: 2020-08-05T18:31:43-07:00 New Revision: 3a538de653607b7602a870d63b13dd51638c1424 URL: https://github.com/llvm/llvm-project/commit/3a538de653607b7602a870d63b13dd51638c1424 DIFF: https://github.com/llvm/llvm-project/commit/3a538de653607b7602a870d63b13dd51638c1424.d

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

davide added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/valueobj-pass-by-reg/Makefile:2 +EXE := a.out +CFLAGS := -O1 + davide wrote: > This is fundamentally a no-go. Depending on the optimization pipeline passes > this in a regist

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

davide requested changes to this revision. davide added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/functionalities/data-formatter/valueobj-pass-by-reg/Makefile:2 +EXE := a.out +CFLAGS := -O1 + This is fundamentally

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

friss added inline comments. Comment at: lldb/source/Core/ValueObjectChild.cpp:202-205 -if (m_bitfield_bit_size) - scalar.ExtractBitfield(m_bitfield_bit_size, - m_bitfield_bit_offset); -else

[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

aprantl added inline comments. Comment at: lldb/source/Target/TargetList.cpp:162 // Only one arch and none was specified. -prefer_platform_arch = true; -platform_arch = matching_module_spec.GetArchitecture(); +update_platform_arch(

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik added a comment. Note: for the test I did not want to rely on clang choosing to pass the union by register, so I used assembly which ensures I will obtain the behavior I am looking to capture for the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85376/new/ https://reviews

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

shafik created this revision. shafik added reviewers: aprantl, jingham, vsk. shafik requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. When bit-field data was stored in a `Scalar` in `ValueObjectChild` during `UpdateValue()` it was extracti

[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

davide added inline comments. Comment at: lldb/source/Target/TargetList.cpp:110-111 +// architecture so that the platform matching can be more accurate. +if (!platform_arch.TripleOSWasSpecified() || +!platform_arch.TripleVendorWasSpecified()) { + prefer_platf

[Lldb-commits] [lldb] 1adc494 - [CMake] Simplify CMake handling for zlib

Author: Petr Hosek Date: 2020-08-05T16:07:11-07:00 New Revision: 1adc494bce44f6004994deed61b30d4b71fe1d05 URL: https://github.com/llvm/llvm-project/commit/1adc494bce44f6004994deed61b30d4b71fe1d05 DIFF: https://github.com/llvm/llvm-project/commit/1adc494bce44f6004994deed61b30d4b71fe1d05.diff LO

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

max-kudr added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85235/new/ https://reviews.llvm.org/D85235 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

JDevlieghere added a comment. In D85235#2198013 , @max-kudr wrote: > @JDevlieghere This change is is failing LLDB Windows buildbot > since build 18051 >

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

clayborg added a comment. LGTM. Raphael? You have any more comments? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85145/new/ https://reviews.llvm.org/D85145 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

max-kudr added a comment. @JDevlieghere This change is is failing LLDB Windows buildbot since build 18051 . Can you please fix that? Repository: rG LLVM Github Mono

[Lldb-commits] [lldb] 927afdf - [lldb] Skip test_launch_simple on Windows

Author: Jonas Devlieghere Date: 2020-08-05T15:38:07-07:00 New Revision: 927afdffbb1deebd83b86d024b67687d758521d0 URL: https://github.com/llvm/llvm-project/commit/927afdffbb1deebd83b86d024b67687d758521d0 DIFF: https://github.com/llvm/llvm-project/commit/927afdffbb1deebd83b86d024b67687d758521d0.d

[Lldb-commits] [PATCH] D85365: [lldb] Modify the `skipIfRemote` decorator so we can skip all PExpect tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf46f174db5b: [lldb] Modify the `skipIfRemote` decorator so we can skip all PExpect tests. (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D85

[Lldb-commits] [lldb] 31137b8 - [lldb] Skip TestProcessConnect when running remotely

Author: Jonas Devlieghere Date: 2020-08-05T15:27:34-07:00 New Revision: 31137b87efc12b1d8cdd8307bcddb986e5c23c61 URL: https://github.com/llvm/llvm-project/commit/31137b87efc12b1d8cdd8307bcddb986e5c23c61 DIFF: https://github.com/llvm/llvm-project/commit/31137b87efc12b1d8cdd8307bcddb986e5c23c61.d

[Lldb-commits] [lldb] df46f17 - [lldb] Modify the `skipIfRemote` decorator so we can skip all PExpect tests.

Author: Jonas Devlieghere Date: 2020-08-05T15:27:34-07:00 New Revision: df46f174db5bbedb66d77041308d48e701c77e96 URL: https://github.com/llvm/llvm-project/commit/df46f174db5bbedb66d77041308d48e701c77e96 DIFF: https://github.com/llvm/llvm-project/commit/df46f174db5bbedb66d77041308d48e701c77e96.d

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

aprantl updated this revision to Diff 283413. aprantl retitled this revision from "[WIP] Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)" to "Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)". aprantl added a comment

[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

aprantl updated this revision to Diff 283415. aprantl added a comment. Actually update the right patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85243/new/ https://reviews.llvm.org/D85243 Files: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt lldb/source/Plugins/Platform/Ma

[Lldb-commits] [PATCH] D85243: [WIP] Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

aprantl added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:558 + "arm64e-apple-ios-simulator", "arm64-apple-ios-simulator", + "x86_64-apple-ios-simulator", "x86_64h-apple-ios-simulator", +#else

[Lldb-commits] [PATCH] D85365: [lldb] Modify the `skipIfRemote` decorator so we can skip all PExpect tests.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I assume we're still allowing to put the decorator on a test-by-test basis, and that seems the case from what I see. If so, LG. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D85365: [lldb] Modify the `skipIfRemote` decorator so we can skip all PExpect tests.

JDevlieghere added a comment. In D85365#2197948 , @davide wrote: > I assume we're still allowing to put the decorator on a test-by-test basis, > and that seems the case from what I see. > If so, LG. Yup. Thanks! Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [PATCH] D85365: [lldb] Modify the `skipIfRemote` decorator so we can skip all PExpect tests.

JDevlieghere created this revision. JDevlieghere added reviewers: davide, jasonmolenda, friss. JDevlieghere requested review of this revision. This patch modifies the `skipIfRemote` decorator so it can apply to a whole class, which allows us to skip all PExpect tests as a whole. Repository: r

[Lldb-commits] [PATCH] D85358: Correctly detect legacy iOS simulator Mach-O objectfiles

aprantl updated this revision to Diff 283405. aprantl added a comment. Fix a second mistake in the updated test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85358/new/ https://reviews.llvm.org/D85358 Files: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp lldb/source/Uti

[Lldb-commits] [PATCH] D85358: Correctly detect legacy iOS simulator Mach-O objectfiles

aprantl updated this revision to Diff 283404. aprantl added a comment. Fix typo in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85358/new/ https://reviews.llvm.org/D85358 Files: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp lldb/source/Utility/ArchSpec.cpp lldb/

[Lldb-commits] [PATCH] D85358: Correctly detect legacy iOS simulator Mach-O objectfiles

aprantl updated this revision to Diff 283401. aprantl added a comment. Excellent point, Fred! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85358/new/ https://reviews.llvm.org/D85358 Files: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp lldb/source/Utility/ArchSpec.cpp

[Lldb-commits] [PATCH] D85358: Correctly detect legacy iOS simulator Mach-O objectfiles

friss added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5029-5030 + // Disambiguate legacy simulator platforms. + if (base_triple.getArch() == llvm::Triple::x86_64 || + base_triple.getArch() == llvm::Triple::x86) { +

[Lldb-commits] [PATCH] D85358: Correctly detect legacy iOS simulator Mach-O objectfiles

aprantl created this revision. aprantl added reviewers: friss, jasonmolenda. aprantl requested review of this revision. The code in ObjectFileMachO didn't disambiguate between ios and ios-simulator object files for Mach-O objects using the legacy ambiguous LC_VERSION_MIN load commands. This used

[Lldb-commits] [PATCH] D85248: [test] Support git commit version ids for clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1dbac09dd6ec: [lldb/test] Support git commit version ids for clang. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85248/new/ https:

[Lldb-commits] [lldb] 1dbac09 - [lldb/test] Support git commit version ids for clang.

Author: Jordan Rupprecht Date: 2020-08-05T13:16:01-07:00 New Revision: 1dbac09dd6ec8587ae7e16ed669bf73889a21957 URL: https://github.com/llvm/llvm-project/commit/1dbac09dd6ec8587ae7e16ed669bf73889a21957 DIFF: https://github.com/llvm/llvm-project/commit/1dbac09dd6ec8587ae7e16ed669bf73889a21957.di

[Lldb-commits] [PATCH] D85258: [test] Use realpath consistently for test root file paths.

This revision was automatically updated to reflect the committed changes. rupprecht marked an inline comment as done. Closed by commit rGfcb0d8163a4f: [lldb/test] Use realpath consistently for test root file paths. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D8525

[Lldb-commits] [lldb] fcb0d81 - [lldb/test] Use realpath consistently for test root file paths.

Author: Jordan Rupprecht Date: 2020-08-05T11:35:37-07:00 New Revision: fcb0d8163a4f3090cb85d77b459887cf1f84cc7e URL: https://github.com/llvm/llvm-project/commit/fcb0d8163a4f3090cb85d77b459887cf1f84cc7e DIFF: https://github.com/llvm/llvm-project/commit/fcb0d8163a4f3090cb85d77b459887cf1f84cc7e.di

[Lldb-commits] [lldb] f425c04 - [lldb/test] Replace LLDB_TEST_SRC env variable with configuration

Author: Jordan Rupprecht Date: 2020-08-05T10:19:21-07:00 New Revision: f425c0442c3ef137f2c4ab5eebd3d39036b09d70 URL: https://github.com/llvm/llvm-project/commit/f425c0442c3ef137f2c4ab5eebd3d39036b09d70 DIFF: https://github.com/llvm/llvm-project/commit/f425c0442c3ef137f2c4ab5eebd3d39036b09d70.di

[Lldb-commits] [PATCH] D85322: [lldb/test] Replace LLDB_TEST_SRC env variable with configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rGf425c0442c3e: [lldb/test] Replace LLDB_TEST_SRC env variable with configuration (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85322/

[Lldb-commits] [lldb] 249a1d4 - [lldb] Add an option to inherit TCC permissions from parent.

Author: Jonas Devlieghere Date: 2020-08-05T10:08:28-07:00 New Revision: 249a1d4f1bed2f2be5781a90b5d4bce8791d338b URL: https://github.com/llvm/llvm-project/commit/249a1d4f1bed2f2be5781a90b5d4bce8791d338b DIFF: https://github.com/llvm/llvm-project/commit/249a1d4f1bed2f2be5781a90b5d4bce8791d338b.d

[Lldb-commits] [PATCH] D85237: [lldb] Add an option to inherit TCC permissions from parent.

This revision was automatically updated to reflect the committed changes. Closed by commit rG249a1d4f1bed: [lldb] Add an option to inherit TCC permissions from parent. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85237/ne

[Lldb-commits] [PATCH] D85235: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG882d8e60dd40: [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D85235?vs=283136&id=283283#toc Reposito

[Lldb-commits] [lldb] 882d8e6 - [lldb] Make SBTarget::LaunchSimple start form the target's LaunchInfo

Author: Jonas Devlieghere Date: 2020-08-05T10:08:28-07:00 New Revision: 882d8e60dd40c01c74b4e16b02cf7ca02e846434 URL: https://github.com/llvm/llvm-project/commit/882d8e60dd40c01c74b4e16b02cf7ca02e846434 DIFF: https://github.com/llvm/llvm-project/commit/882d8e60dd40c01c74b4e16b02cf7ca02e846434.d

[Lldb-commits] [PATCH] D84966: Remove special Hexagon packet traversal code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3169d920ccd1: Remove special Hexagon packet traversal code (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [lldb] 3169d92 - Remove special Hexagon packet traversal code

Author: Ted Woodward Date: 2020-08-05T12:05:42-05:00 New Revision: 3169d920ccd16ec3c3e1bf5d91595b70a5278045 URL: https://github.com/llvm/llvm-project/commit/3169d920ccd16ec3c3e1bf5d91595b70a5278045 DIFF: https://github.com/llvm/llvm-project/commit/3169d920ccd16ec3c3e1bf5d91595b70a5278045.diff

[Lldb-commits] [PATCH] D85322: [lldb/test] Replace LLDB_TEST_SRC env variable with configuration

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85322/new/ https://reviews.llvm.org/D85322 __

[Lldb-commits] [PATCH] D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733

Meinersbur added a comment. Hasn't this already been done in 80bd6ae13ea23d453a1f45d6ccdbfc7d0c877bb0 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84780/new/ https://reviews.l

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

hans added a comment. In D79219#2153585 , @phosek wrote: > In D79219#2152747 , @labath wrote: > >> I wouldn't mind separate (internal) cache variable, though I am somewhat >> surprised by this problem. A (non-cache

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

hans added a comment. Reverted in 3ab01550b632dad46f9595d74855749557ffd25c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219

[Lldb-commits] [PATCH] D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733

antiagainst accepted this revision. antiagainst added a comment. This revision is now accepted and ready to land. LGTM for SPIR-V side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84780/new/ https://reviews.llvm.org/D84780 __

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2193729 , @simoncook wrote: > As for next steps, if we're happy with the state then I think this should > land (assuming qemu is sufficient given it is public), and then we can flesh > out other bits which give a be

[Lldb-commits] [PATCH] D85258: [test] Use realpath consistently for test root file paths.

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:499 # /abs/path/to/packages/group/subdir/mytest.py -> group/subdir -rel_prefix = test_file[len(os.environ["LLDB_TEST_SRC"]) +

[Lldb-commits] [PATCH] D85322: [lldb/test] Replace LLDB_TEST_SRC env variable with configuration

rupprecht created this revision. rupprecht added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85322 Files: lldb/packages/Python/lldbs

[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

Higuoxing added a comment. In D85289#2196062 , @jhenderson wrote: > I see the point, but we don't do it for all fields in other contexts, and I > have some mild concerns that `DebugAbbrevOffset` is unnecessarily verbose > (I'd think `AbbrevOffset` would

[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

jhenderson added a subscriber: labath. jhenderson added a comment. I see the point, but we don't do it for all fields in other contexts, and I have some mild concerns that `DebugAbbrevOffset` is unnecessarily verbose (I'd think `AbbrevOffset` would be sufficient. Perhaps it would be best to draw

[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

Higuoxing added a comment. In D85289#2195954 , @jhenderson wrote: > What's the motivation for doing this? We should make these mapping keys' name consistent with the spec. The spec uses 'address_size', 'debug_abbrev_offset', 'abbreviation code' to refer

[Lldb-commits] [PATCH] D85290: [lldb][gui] use left/right in the source view to scroll

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. I intentionally decided not to reset the column automatically anywhere, because I don't know where and if at all that should happen. There should be always an indication of being scrolled (

[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

jhenderson added a comment. What's the motivation for doing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85289/new/ https://reviews.llvm.org/D85289 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D85289: [DWARFYAML][debug_info] Rename some mapping keys. NFC.

Higuoxing created this revision. Higuoxing added reviewers: jhenderson, grimar, MaskRay. Herald added subscribers: llvm-commits, lldb-commits, cmtice, hiraditya, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a reviewer: rupprecht. Herald added projects:

[Lldb-commits] [lldb] 3ab0155 - Revert "[CMake] Simplify CMake handling for zlib"

Author: Hans Wennborg Date: 2020-08-05T12:31:44+02:00 New Revision: 3ab01550b632dad46f9595d74855749557ffd25c URL: https://github.com/llvm/llvm-project/commit/3ab01550b632dad46f9595d74855749557ffd25c DIFF: https://github.com/llvm/llvm-project/commit/3ab01550b632dad46f9595d74855749557ffd25c.diff

[Lldb-commits] [lldb] 188187f - [lldb] expect TestGuiBasicDebug.py failure on aarch64

Author: Luboš Luňák Date: 2020-08-05T12:21:05+02:00 New Revision: 188187f062a56604a4339f16f139e3cc720ba2bd URL: https://github.com/llvm/llvm-project/commit/188187f062a56604a4339f16f139e3cc720ba2bd DIFF: https://github.com/llvm/llvm-project/commit/188187f062a56604a4339f16f139e3cc720ba2bd.diff L

[Lldb-commits] [lldb] 1382819 - Revert "[lldb] temporary commit to see why a test is failing only on lldb-aarch64-ubuntu"

Author: Luboš Luňák Date: 2020-08-05T11:55:02+02:00 New Revision: 138281904ba029bc49fca34a8658a8fcd1b843aa URL: https://github.com/llvm/llvm-project/commit/138281904ba029bc49fca34a8658a8fcd1b843aa DIFF: https://github.com/llvm/llvm-project/commit/138281904ba029bc49fca34a8658a8fcd1b843aa.diff L

[Lldb-commits] [lldb] 21f142c - [lldb] temporary commit to see why a test is failing only on lldb-aarch64-ubuntu

Author: Luboš Luňák Date: 2020-08-05T11:54:14+02:00 New Revision: 21f142ce1df10fe6cf5721e263fc6e91aea93938 URL: https://github.com/llvm/llvm-project/commit/21f142ce1df10fe6cf5721e263fc6e91aea93938 DIFF: https://github.com/llvm/llvm-project/commit/21f142ce1df10fe6cf5721e263fc6e91aea93938.diff L

[Lldb-commits] [PATCH] D85286: [lldb][gui] use names for color pairs, instead of magic numbers

llunak updated this revision to Diff 283175. llunak added a comment. Change also SetBackground() calls. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85286/new/ https://reviews.llvm.org/D85286 Files: lldb/source/Core/IOHandlerCursesGUI.cpp Index: lldb/sourc

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:486 + if (!string.consume_front("[")) { +llvm::errs() << "Missing '[' in color escape sequence.\n"; +continue; clayborg wrote: > So what will happen if we actua

[Lldb-commits] [lldb] 75012a8 - [lldb] Use PyUnicode_GetLength instead of PyUnicode_GetSize

Author: Tatyana Krasnukha Date: 2020-08-05T11:59:47+03:00 New Revision: 75012a80440f2302d3dc0e57ea264b9c26c26789 URL: https://github.com/llvm/llvm-project/commit/75012a80440f2302d3dc0e57ea264b9c26c26789 DIFF: https://github.com/llvm/llvm-project/commit/75012a80440f2302d3dc0e57ea264b9c26c26789.d

[Lldb-commits] [lldb] cc68c12 - [lldb/TestingSupport] Manually disable GTEST_HAS_TR1_TUPLE

Author: Tatyana Krasnukha Date: 2020-08-05T11:59:46+03:00 New Revision: cc68c122cd00f99037b8ff7e645e2b387d56da8b URL: https://github.com/llvm/llvm-project/commit/cc68c122cd00f99037b8ff7e645e2b387d56da8b DIFF: https://github.com/llvm/llvm-project/commit/cc68c122cd00f99037b8ff7e645e2b387d56da8b.d

[Lldb-commits] [PATCH] D85286: [lldb][gui] use names for color pairs, instead of magic numbers

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. Repository: rLLDB LLDB https://reviews.llvm.org/D85286 Files: lldb/source/Core/IOHandlerCursesGUI.cpp Index: lldb/source/Core/IOHandlerCursesGUI.cpp ===

[Lldb-commits] [lldb] bc056b3 - [lldb] Suppress MSVC warning C4065

Author: Tatyana Krasnukha Date: 2020-08-05T11:59:48+03:00 New Revision: bc056b3aa7130923ab9ad0505c5a8d65ea721e39 URL: https://github.com/llvm/llvm-project/commit/bc056b3aa7130923ab9ad0505c5a8d65ea721e39 DIFF: https://github.com/llvm/llvm-project/commit/bc056b3aa7130923ab9ad0505c5a8d65ea721e39.d

[Lldb-commits] [PATCH] D85123: Truncate long lines/names if needed in lldb gui

llunak updated this revision to Diff 283155. llunak added a comment. Use SteamString. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85123/new/ https://reviews.llvm.org/D85123 Files: lldb/source/Core/IOHandlerCursesGUI.cpp lldb/test/API/commands/gui/viewlar

[Lldb-commits] [PATCH] D85088: Implement TerminalSizeChanged() for lldb ncurses GUI

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f1b24b70c6c: [lldb][gui] implement TerminalSizeChanged() (authored by llunak). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] d6868d9 - [lldb][gui] implement breakpoint removal on breakpoint toggling

Author: Luboš Luňák Date: 2020-08-05T09:51:12+02:00 New Revision: d6868d9ca1dbdeceaaa1660b6e7b4af0c207fcae URL: https://github.com/llvm/llvm-project/commit/d6868d9ca1dbdeceaaa1660b6e7b4af0c207fcae DIFF: https://github.com/llvm/llvm-project/commit/d6868d9ca1dbdeceaaa1660b6e7b4af0c207fcae.diff L

[Lldb-commits] [PATCH] D85106: Move TestGuiBasicDebug.py to lldb/test and update it

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7be982c836c: [lldb][gui] move TestGuiBasicDebug.py to lldb/test and update it (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D85219: [lldb] fix building with panel.h being in /usr/include/ncurses/

This revision was automatically updated to reflect the committed changes. Closed by commit rGc952ec15d388: [lldb] fix building with panel.h being in /usr/include/ncurses/ (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D85098: Implement breakpoint removal on breakpoint toggling in lldb gui

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6868d9ca1db: [lldb][gui] implement breakpoint removal on breakpoint toggling (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [lldb] c7be982 - [lldb][gui] move TestGuiBasicDebug.py to lldb/test and update it

Author: Luboš Luňák Date: 2020-08-05T09:51:13+02:00 New Revision: c7be982c836cdaf7b1ef303d903e6a3de2eb4a34 URL: https://github.com/llvm/llvm-project/commit/c7be982c836cdaf7b1ef303d903e6a3de2eb4a34 DIFF: https://github.com/llvm/llvm-project/commit/c7be982c836cdaf7b1ef303d903e6a3de2eb4a34.diff L

[Lldb-commits] [PATCH] D85107: Add a test for 'b' (toggle breakpoint)

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb828aba55ac: [lldb][gui] add a test for 'b' (toggle breakpoint) (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D85089: Implement shift+tab for going back in lldb gui views

This revision was automatically updated to reflect the committed changes. llunak marked 2 inline comments as done. Closed by commit rG7a63dc534eb8: [lldb][gui] implement shift+tab for going back in views (authored by llunak). Herald added a subscriber: lldb-commits. Changed prior to commit: htt

[Lldb-commits] [lldb] 2f1b24b - [lldb][gui] implement TerminalSizeChanged()

Author: Luboš Luňák Date: 2020-08-05T09:51:12+02:00 New Revision: 2f1b24b70c6c3ecf3cf5ccd35209d9d7e426be63 URL: https://github.com/llvm/llvm-project/commit/2f1b24b70c6c3ecf3cf5ccd35209d9d7e426be63 DIFF: https://github.com/llvm/llvm-project/commit/2f1b24b70c6c3ecf3cf5ccd35209d9d7e426be63.diff L

[Lldb-commits] [lldb] db828ab - [lldb][gui] add a test for 'b' (toggle breakpoint)

Author: Luboš Luňák Date: 2020-08-05T09:51:13+02:00 New Revision: db828aba55aca0ce977f086dcd449f8fe667f30a URL: https://github.com/llvm/llvm-project/commit/db828aba55aca0ce977f086dcd449f8fe667f30a DIFF: https://github.com/llvm/llvm-project/commit/db828aba55aca0ce977f086dcd449f8fe667f30a.diff L

[Lldb-commits] [lldb] c952ec1 - [lldb] fix building with panel.h being in /usr/include/ncurses/

Author: Luboš Luňák Date: 2020-08-05T09:51:12+02:00 New Revision: c952ec15d38843b69e22dfd7b0665304a0459f9f URL: https://github.com/llvm/llvm-project/commit/c952ec15d38843b69e22dfd7b0665304a0459f9f DIFF: https://github.com/llvm/llvm-project/commit/c952ec15d38843b69e22dfd7b0665304a0459f9f.diff L

[Lldb-commits] [lldb] 7a63dc5 - [lldb][gui] implement shift+tab for going back in views

Author: Luboš Luňák Date: 2020-08-05T09:51:12+02:00 New Revision: 7a63dc534eb8ebdf1b0aa2c0f6d943d0c7adda1d URL: https://github.com/llvm/llvm-project/commit/7a63dc534eb8ebdf1b0aa2c0f6d943d0c7adda1d DIFF: https://github.com/llvm/llvm-project/commit/7a63dc534eb8ebdf1b0aa2c0f6d943d0c7adda1d.diff L

[Lldb-commits] [PATCH] D85106: Move TestGuiBasicDebug.py to lldb/test and update it

llunak added a comment. I personally don't particularly care where the tests are, I just wanted all the gui tests to be together to make it simpler to run them all. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85106/new/ https://reviews.llvm.org/D85106 _