[Lldb-commits] [lldb] fd50e7c - [lldb][NFC] Make some RegularExpression constructor calls less verbose

2020-07-19 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-07-20T07:27:51+02:00 New Revision: fd50e7c06d79e3afe913495eae1759ebf5514ccf URL: https://github.com/llvm/llvm-project/commit/fd50e7c06d79e3afe913495eae1759ebf5514ccf DIFF: https://github.com/llvm/llvm-project/commit/fd50e7c06d79e3afe913495eae1759ebf5514ccf.dif

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

2020-07-19 Thread Benson Li via Phabricator via lldb-commits
bbli added a comment. > Setting this no longer makes sense, as it will always be empty. Please remove > that. Maybe also rename stdout_content to indicate it also contains stderr. > Just plain "output" might suffice? Ok, deleted it and changed "stdout_content" to "combined_content". > this err

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

2020-07-19 Thread Benson Li via Phabricator via lldb-commits
bbli updated this revision to Diff 279122. bbli added a comment. Changed `getCompilerVersion` and a function in `TestDataFormatterSkipSummary` to account for stderr being merged with stdout now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83425/ne

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

2020-07-19 Thread Xing GUO via Phabricator via lldb-commits
Higuoxing added a comment. In D84008#2160426 , @MaskRay wrote: > The number of changed tests is large. Is it worth moving the > `IO.mapOptional("Length", Unit.Length);` change to a separate patch to make > the refactoring more focused? Thanks This patc

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

2020-07-19 Thread Dávid Bolvanský via Phabricator via lldb-commits
xbolva00 added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84126/new/ https://reviews.llvm.org/D84126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg