[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, that's a lot cleaner. A better way to ensure lldb is not accidentally built without xml support is to set LLDB_ENABLE_LIBXML=On in the cmake config/cache file. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

labath added a comment. In D80165#2044509 , @jingham wrote: > We should make sure if we do exit that we don't output any other text that > would obscure the error message. It should be easy to spot the error both so > you can easily fix it and to preven

[Lldb-commits] [PATCH] D80253: [lldb] Cleans up system_libs

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, that's definitely cleaner. Thanks. Some of these could/should probably be moved up to lldbHost, but that's ok if you want to keep this NFC. Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D80226: [lldb/Driver] Error out when encountering unknown arguments

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. yep Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80226/new/ https://reviews.llvm.org/D80226 ___ lldb-commits

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

jarin marked an inline comment as not done. jarin added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:5215 +uint32_t num_pointee_children = 0; +if (pointee_clang_type.IsAggregateType()) + num_pointee_children =

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

jarin updated this revision to Diff 265141. jarin marked 2 inline comments as done. jarin added a comment. Added more assertions, reformatted the test code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80254/new/ https://reviews.llvm.org/D80254 Files: lldb/source/Plugins/TypeSystem/

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f2ce5b915a5: [mlir][SystemZ] Fix incompatible datalayout in SystemZ (authored by imaihal, committed by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This patch breaks lldb unit tests on lldb-arm-ubuntu buildbot. http://lab.llvm.org:8014/builders/lldb-arm-ubuntu/builds/1697 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

imaihal added a comment. @ftynse and @mehdi_amini, Could you help to commit this if this patch ready for commit? I don't have write access to the repository. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80130/new/ https://reviews.llvm.org/D8013

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

imaihal marked 2 inline comments as done. imaihal added inline comments. Comment at: mlir/lib/ExecutionEngine/ExecutionEngine.cpp:123 } - std::unique_ptr machine( - target->createTargetMachine(targetTriple, "generic", "", {}, {})); + std::string cpu = std::string(llvm::

[Lldb-commits] [PATCH] D80130: [mlir][SystemZ] Fix incompatible datalayout in SystemZ

imaihal updated this revision to Diff 265107. imaihal added a comment. Changed getHostCPUName() part to reflect the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80130/new/ https://reviews.llvm.org/D80130 Files: mlir/lib/ExecutionEngine

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3609b0ec685: Add terminateCommands to lldb-vscode protocol (authored by aadsm, committed by António Afonso ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

shafik added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:5215 +uint32_t num_pointee_children = 0; +if (pointee_clang_type.IsAggregateType()) + num_pointee_children = I am curious what cases are pointers aggre

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

hhb updated this revision to Diff 265082. hhb added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80257/new/ https://reviews.llvm.org/D80257 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/source/Host/CMakeLists.txt lldb/so

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

hhb updated this revision to Diff 265080. hhb added a comment. Remove endif() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80257/new/ https://reviews.llvm.org/D80257 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/source/Host/CMakeLists.txt

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

vsk marked 3 inline comments as done. vsk added a comment. @labath Agreed on all points, I've addressed the feedback in 82dbf4aca84 by moving "DataFormatters/Mock.h" to "Plugins/Language/ObjC/Utilities.h", and adding a separa

[Lldb-commits] [PATCH] D80257: [lldb] Allows customizing libxml2 for darwin

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb updated this revision to Diff 265080. hhb added a comment. hhb edited the summary of this revision. hhb updated this revision to Diff 265082. Remove endif() hhb added a comment. rebase

[Lldb-commits] [lldb] a3609b0 - Add terminateCommands to lldb-vscode protocol

Author: António Afonso Date: 2020-05-19T16:18:05-07:00 New Revision: a3609b0ec68522cb417ffe36ce9eb2e25ca61578 URL: https://github.com/llvm/llvm-project/commit/a3609b0ec68522cb417ffe36ce9eb2e25ca61578 DIFF: https://github.com/llvm/llvm-project/commit/a3609b0ec68522cb417ffe36ce9eb2e25ca61578.diff

[Lldb-commits] [lldb] 82dbf4a - [lldb/test] Move "DataFormatters/Mock.h" to "Plugins/Language/ObjC/Utilities.h"

Author: Vedant Kumar Date: 2020-05-19T16:09:42-07:00 New Revision: 82dbf4aca84ec889d0dc390674ff44e30441bcfd URL: https://github.com/llvm/llvm-project/commit/82dbf4aca84ec889d0dc390674ff44e30441bcfd DIFF: https://github.com/llvm/llvm-project/commit/82dbf4aca84ec889d0dc390674ff44e30441bcfd.diff

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

jarin created this revision. jarin added reviewers: teemperor, jingham. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. This is an attempt to fix https://bugs.llvm.org/show_bug.cgi?id=45988, where SBValue::GetNumChildren returns 2, but SBValue::GetChildAtIndex(1) returns an

[Lldb-commits] [PATCH] D80253: [lldb] Cleans up system_libs

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Long long ago system_libs was appended to LLDB_SYSTEM_LIBS in cmake/LLDBDependencies.cmake. After that file was removed, system_libs is orphaned. Currently the only user is source/Utility. Mov

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

jarin added a comment. Pavel, could you possibly land this for us? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] c7dddaa - [lldb/Reproducers] Update GDB remote client tests for passive replay

Author: Jonas Devlieghere Date: 2020-05-19T13:07:50-07:00 New Revision: c7dddaa89ff17d2b191bd70de5a01712590b317d URL: https://github.com/llvm/llvm-project/commit/c7dddaa89ff17d2b191bd70de5a01712590b317d DIFF: https://github.com/llvm/llvm-project/commit/c7dddaa89ff17d2b191bd70de5a01712590b317d.d

[Lldb-commits] [PATCH] D80226: [lldb/Driver] Error out when encountering unknown arguments

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham, clayborg. There appears to be consensus in D80165 that this is the desired behavior and I personally agree. Repository: rLLDB LLDB https://reviews.llvm.org/D80226 Files: ll

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

JDevlieghere abandoned this revision. JDevlieghere added a comment. Abandoning this for the reason mentioned above. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68003/new/ https://reviews.llvm.org/D68003 ___ lldb-

[Lldb-commits] [PATCH] D80159: [lldb/Properties] Move OSPluginReportsAllThreads from Target to Process

This revision was automatically updated to reflect the committed changes. Closed by commit rG018e5a96eebd: [lldb/Properties] Move OSPluginReportsAllThreads from Target to Process (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D80159: [lldb/Properties] Move OSPluginReportsAllThreads from Target to Process

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Excellent! Thanks for doing this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80159/new/ https://reviews.llvm.org/D80159

[Lldb-commits] [lldb] 018e5a9 - [lldb/Properties] Move OSPluginReportsAllThreads from Target to Process

Author: Jonas Devlieghere Date: 2020-05-19T11:26:39-07:00 New Revision: 018e5a96eebd712dd743589327354d528865f9b6 URL: https://github.com/llvm/llvm-project/commit/018e5a96eebd712dd743589327354d528865f9b6 DIFF: https://github.com/llvm/llvm-project/commit/018e5a96eebd712dd743589327354d528865f9b6.d

[Lldb-commits] [lldb] 15ee8a3 - Silence warnings around int/float conversions.

Author: Eric Christopher Date: 2020-05-19T10:56:18-07:00 New Revision: 15ee8a3a58223b48afbe33cb60084f864ef20889 URL: https://github.com/llvm/llvm-project/commit/15ee8a3a58223b48afbe33cb60084f864ef20889 DIFF: https://github.com/llvm/llvm-project/commit/15ee8a3a58223b48afbe33cb60084f864ef20889.di

[Lldb-commits] [PATCH] D80224: [lldb/Reproducers] Support reproducers for PlatformRemoteGDBServer

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor. Add reproducer support to PlatformRemoteGDBServer. The logic is essentially the same as for ProcessGDBRemote. During capture we record the GDB packets and during replay we connect to a replay server. This fixes

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

jingham added a comment. I agree with Pavel, reporting an error and exiting seems like a good behavior. When I mistype a command line option, I generally immediately quit lldb, up-arrow and fix and resubmit, so this would save keystrokes. We should make sure if we do exit that we don't output

[Lldb-commits] [lldb] 225f241 - [lldb/Reproducers] Move connection logic into replay server (NFC)

Author: Jonas Devlieghere Date: 2020-05-19T10:55:35-07:00 New Revision: 225f241c84469d7d29c9ef626558c302134c48ff URL: https://github.com/llvm/llvm-project/commit/225f241c84469d7d29c9ef626558c302134c48ff DIFF: https://github.com/llvm/llvm-project/commit/225f241c84469d7d29c9ef626558c302134c48ff.d

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

labath added inline comments. Comment at: lldb/test/Shell/Driver/TestPositionalArgs.test:27-28 + +UNKNOWN: warning: ignoring unknown option: -baz +UNKNOWN: warning: ignoring unknown option: --quux +UNKNOWN: Current executable set to {{.*}}foo JDevlieghere wrote:

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/test/Shell/Driver/TestPositionalArgs.test:27-28 + +UNKNOWN: warning: ignoring unknown option: -baz +UNKNOWN: warning: ignoring unknown option: --quux +UNKNOWN: Current executable s

[Lldb-commits] [PATCH] D80165: [lldb/Driver] Fix handling on positional arguments

labath added a comment. Thanks for fixing this. I remember running into this a couple of times, but I never got around to do something about it... Comment at: lldb/test/Shell/Driver/TestPositionalArgs.test:27-28 + +UNKNOWN: warning: ignoring unknown option: -baz +UNKNOWN: warn

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

labath added a comment. While I think the idea in this patch is good, the actual implementation seems problematic to me, on several levels. The name `Mock.h` is overly generic, and inappropriate. According to wikipedia , mock (object)s are "simulated

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid added a comment. In D77043#2041844 , @labath wrote: > Sorry, about the delay. I had to find some time to dig into the code again, > to understand all of the interactions. > > It seems that we (lldb) have painted ourselves in the corner somewhat.