labath added inline comments.
================
Comment at: lldb/test/Shell/Driver/TestPositionalArgs.test:27-28
+
+UNKNOWN: warning: ignoring unknown option: -baz
+UNKNOWN: warning: ignoring unknown option: --quux
+UNKNOWN: Current executable set to {{.*}}foo
----------------
JDevlieghere wrote:
> labath wrote:
> > Unrelated to this patch, but.. do we actually want this behavior? I don't
> > think these were just "warnings" before libOption. Given that clang treats
> > (at least some) unknown options as errors, I'm guessing there must be some
> > libOption knob for controlling the behavior of this...
> What behavior do you have in mind? Make these errors and exit early? It's
> just us reporting the warning, we can do anything we want with it.
Yes, I think it would be more reasonable to report an error and exit in case we
encounter an argument we don't recognise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80165/new/
https://reviews.llvm.org/D80165
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
