[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 259126. ctetreau added a comment. split C api stuff into separate commit. Do bare minimum here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Exp

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 259114. ctetreau added a comment. Catch stragglers in C api Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/in

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 259104. ctetreau added a comment. remove unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/inclu

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 259095. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp llvm/include/llvm-c/Core.h

[Lldb-commits] [PATCH] D78489: [lldb/DWARF] Trust CU DW_AT_low/high_pc information when building address tables

clayborg added a comment. Sounds like a win then, as long as we don't get slower I am fine with this. I was guessing that line tables might be faster because it is generally very compressed and compact compared to debug info, but thanks for verifying. Might be worth checking the memory consumpt

[Lldb-commits] [PATCH] D78603: remove unused function LLDBSwigPython_GetIndexOfChildWithName

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jasonmolenda, JDevlieghere. Herald added subscribers: lldb-commits, arphaman. Herald added a project: LLDB. Remove LLDBSwigPython_GetIndexOfChildWithName and associated functions. They are not used. Repository: rG LL

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

This revision was automatically updated to reflect the committed changes. Closed by commit rG737521217295: get rid of PythonInteger::GetInteger() (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D78462?vs=259131&id=259134#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna updated this revision to Diff 259131. lawrence_danna marked 4 inline comments as done. lawrence_danna added a comment. wrap long line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78462/new/ https://reviews.llvm.org/D78462 Files:

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

lawrence_danna added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:585-597 +llvm::Expected result = pfunc.Call(PythonString(child_name)); -if (!result.IsAllocated()) -return UINT32_MAX; +long long retval = unwrapOrSetPythonException(A

[Lldb-commits] [lldb] 7375212 - get rid of PythonInteger::GetInteger()

Author: Lawrence D'Anna Date: 2020-04-21T16:55:51-07:00 New Revision: 7375212172951d2fc283c81d03c1a8588c3280c6 URL: https://github.com/llvm/llvm-project/commit/7375212172951d2fc283c81d03c1a8588c3280c6 DIFF: https://github.com/llvm/llvm-project/commit/7375212172951d2fc283c81d03c1a8588c3280c6.dif

[Lldb-commits] [PATCH] D78588: [lldb/Core] Check that ArchSpec is valid.

clayborg added a comment. None of this is exposed through SBPlatform right? No way to test this? Comment at: lldb/source/Target/Platform.cpp:1825-1826 ArchSpec arch = target.GetArchitecture(); + if (!arch.IsValid()) +return 0; + would be nice to log som

[Lldb-commits] [PATCH] D78588: [lldb/Core] Check that ArchSpec is valid.

davide added a comment. What's exactly the testcase doing? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78588/new/ https://reviews.llvm.org/D78588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

shafik updated this revision to Diff 259110. shafik marked 2 inline comments as done. shafik added a comment. - Simplifying the changes in `ASTImporter::ImportContext` - Removing `DC->setHasExternalLexicalStorage(true);` from unit test since we are checking `getExternalSource()` CHANGES SINCE L

[Lldb-commits] [lldb] b707cf0 - [lldb/Test] Add decorator to the right method

Author: Jonas Devlieghere Date: 2020-04-21T15:05:32-07:00 New Revision: b707cf096dda9592a2ae1d874f4e760e36c6f1e5 URL: https://github.com/llvm/llvm-project/commit/b707cf096dda9592a2ae1d874f4e760e36c6f1e5 DIFF: https://github.com/llvm/llvm-project/commit/b707cf096dda9592a2ae1d874f4e760e36c6f1e5.d

[Lldb-commits] [lldb] 1e566f6 - [lldb/Test] Add skipIfReproducer for tests that diverge during replay

Author: Jonas Devlieghere Date: 2020-04-21T14:42:14-07:00 New Revision: 1e566f6b47fb77812d99c93e0a1b8613d288058c URL: https://github.com/llvm/llvm-project/commit/1e566f6b47fb77812d99c93e0a1b8613d288058c DIFF: https://github.com/llvm/llvm-project/commit/1e566f6b47fb77812d99c93e0a1b8613d288058c.d

[Lldb-commits] [lldb] 400b6f2 - [lldb/Test] Add skipIfReproducer for tests that are not expected to work

Author: Jonas Devlieghere Date: 2020-04-21T14:42:14-07:00 New Revision: 400b6f2bc53915b61f1ed9408819fa898e4c8941 URL: https://github.com/llvm/llvm-project/commit/400b6f2bc53915b61f1ed9408819fa898e4c8941 DIFF: https://github.com/llvm/llvm-project/commit/400b6f2bc53915b61f1ed9408819fa898e4c8941.d

[Lldb-commits] [PATCH] D78588: [lldb/Core] Check that ArchSpec is valid.

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg, labath. A reproducer replay hit an `llvm_unreachable` in Target.cpp because the architecture was not set and therefore the `ArchSpec` was invalid. Unhandled architecture in Platform::GetSoftwareBreakpointTrap

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

mib marked 7 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.cpp:47-62 + DataBufferHeap buffer(size, 0); + m_exe_ctx_ref.GetProcessSP()->ReadMemory(addr, buffer.GetBytes(), size, +

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

mib updated this revision to Diff 259084. mib marked 2 inline comments as done. mib added a comment. Address Pavel's comments: - Fix eventual UB by using the struct type in `sizeof` instead of dereferencing the pointer. - Remove empty destructors. - Fix dangling reference. Repository: rG LLV

[Lldb-commits] [lldb] 116c2da - [lldb/Scripts] proc.returncode is set in proc.communicate

Author: Jonas Devlieghere Date: 2020-04-21T11:30:15-07:00 New Revision: 116c2da4b2505af98c1b9652c8f280ec8147d27e URL: https://github.com/llvm/llvm-project/commit/116c2da4b2505af98c1b9652c8f280ec8147d27e DIFF: https://github.com/llvm/llvm-project/commit/116c2da4b2505af98c1b9652c8f280ec8147d27e.d

[Lldb-commits] [PATCH] D77295: [lldb/Core] Fix a race in the Communication class

JDevlieghere added a comment. Hi Pavel, After this landed I started seeing a bunch of reproducers fail with `SIGPIPE`. I ignored the signal and added a check for `EPIPE` to the `::write` call in `PipePosix.cpp`. Below is the thread state: * thread #1, queue = 'com.apple.main-thread', stop re

Re: [Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

Yes, to do it right you should do that. I think it would still be worthwhile to first check whether the current frame’s source file is the one being asked for, since that is a very common way to get to source files and that would make going from source file -> module very cheap. But otherwise,

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 259044. ctetreau added a comment. Fixup canLosslesslyBitCastTo to use FixedVectorType again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expres

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks for all the changes, this patch LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 _

[Lldb-commits] [PATCH] D76955: [lldb/Test] Decode stdout and stderr in case it contains UTF-8

This revision was automatically updated to reflect the committed changes. Closed by commit rG2de52422acf0: [lldb/Test] Decode stdout and stderr in case it contains Unicode. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D78337: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool

JDevlieghere updated this revision to Diff 259014. JDevlieghere added a comment. Share the thread pool instead of recreating it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78337/new/ https://reviews.llvm.org/D78337 Files: lldb/include/lldb/Host/TaskPool.h lldb/include/lldb/modul

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid marked 4 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1191 + size_t vq = sve_vq_from_vl(m_sve_header.vl); + SetRegisterInfoMode(vq); + m_sve_ptrace_

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid added a comment. @labath I have considered alternatives which can be used to avoid this patch altogether. We are creating dynamic register infos vector for SVE in D77047 . This is needed because we have update register size and offset of SVE registers.

[Lldb-commits] [PATCH] D77759: [lldb/Reproducers] Fix passive replay for functions returning string as (char*, size_t).

labath added a comment. In D77759#1992670 , @JDevlieghere wrote: > In D77759#1992252 , @labath wrote: > > > In D77759#1988419 , @labath wrote: > > > > > Hmm... well, I like

[Lldb-commits] [PATCH] D78462: get rid of PythonInteger::GetInteger()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. I'll leave it up to you to consider whether the `PySys_WriteStderr` thingy is a good idea. Comment at: lldb/bindings/python/python-typemaps.swig:72 + PythonObje

[Lldb-commits] [PATCH] D78489: [lldb/DWARF] Trust CU DW_AT_low/high_pc information when building address tables

labath added a comment. Thanks for the tip about commenting out DW_AT_ranges code. I wanted to do some measurements, but I couldn't find a non-contrived non-trivial code base to try this on (with c++ most compile units always get DW_AT_ranges due to all of the ODR linkage brought in by template

[Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

n1tram1 added a comment. In D78421#1993030 , @jingham wrote: > So you check the currently selected frame's module - which is libbar.dylib > and find that it was built before FileFromNotBar.c and would show me the old > version. > > Showing me the latest

[Lldb-commits] [PATCH] D76955: [lldb/Test] Decode stdout and stderr in case it contains UTF-8

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems like the simplest thing to do while we wait for py2 to die. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76955/new/ https://reviews.llvm.org/D76955

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

labath added a comment. I don't have a vested interested here (the main reason I looked at this was the template discussion), but I have made a cursory pass over the patch. I didn't check the high level functionality, but it seems like the implementation details can be improved upon. ===

[Lldb-commits] [PATCH] D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE

jankratochvil marked 4 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.h:82 + /// The object will remain valid during the whole call statement: + /// Function(name, DIERefCallback({callback, name})); + s

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

jankratochvil added a comment. In D75750#1991873 , @labath wrote: > In D75750#1988694 , @jankratochvil > wrote: > > > The current plan discussed with @kwk is to create the new `SymbolServer` > > abstract superclas

[Lldb-commits] [PATCH] D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE

jankratochvil updated this revision to Diff 258921. jankratochvil marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77970/new/ https://reviews.llvm.org/D77970 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFInde

[Lldb-commits] [PATCH] D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE

jankratochvil updated this revision to Diff 258920. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77970/new/ https://reviews.llvm.org/D77970 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp lldb/source/Plugins/SymbolFile/DWARF/App

[Lldb-commits] [PATCH] D78337: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool

labath added a comment. Thanks. The observed difference appears to be (borderline) statistically significant, but the difference (~1%) is not very big, so I think that's worth reusing the llvm class (and any future performance improvements). I think the difference will go down even more if you