mib marked 7 inline comments as done.
mib added inline comments.
================
Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.cpp:47-62
+ DataBufferHeap buffer(size, 0);
+ m_exe_ctx_ref.GetProcessSP()->ReadMemory(addr, buffer.GetBytes(), size,
+ error);
+ if (error.Fail())
+ return false;
+
+ DataExtractor data_extractor = DataExtractor(
----------------
labath wrote:
> Why don't you just pass `m_ht.get()` to `ReadMemory` ?
IIUC, `ReadMemory` will read memory matching the inferior endianness. That's
why, I'm using a `DataExtractor`, to translate, the copied bytes to the host
endianness.
================
Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.cpp:71-82
+ m_exe_ctx_ref.GetProcessSP()->ReadMemory(ptr_offset, buffer.GetBytes(), size,
+ error);
+
+ if (error.Fail()) {
+ m_ht = nullptr;
+ return false;
+ }
----------------
labath wrote:
> `ReadMemory(ptr_offset, m_ht->pointers, ...)` ?
Same answer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78396/new/
https://reviews.llvm.org/D78396
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
