[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

teemperor added inline comments. Comment at: lldb/include/lldb/Target/AbortRecognizer.h:29 + GetAbortLocation(Process *process_sp); + static llvm::Optional> + GetAssertLocation(Process *process_sp); This function (especially the return types) deserve some docu

Re: [Lldb-commits] [lldb] d8acf88 - [lldb/Test] Disable command-breakpoint-col.test on Windows

On 23/01/2020 23:18, Jonas Devlieghere via lldb-commits wrote: > > Author: Jonas Devlieghere > Date: 2020-01-23T14:17:50-08:00 > New Revision: d8acf8852dbfbe2d6f2e2fdb4fa0ec18a4194da3 > > URL: > https://github.com/llvm/llvm-project/commit/d8acf8852dbfbe2d6f2e2fdb4fa0ec18a4194da3 > DIFF: > https

[Lldb-commits] [lldb] be2bc6b - [lldb/Util] Remove reproducers after replay

Author: Jonas Devlieghere Date: 2020-01-23T21:46:50-08:00 New Revision: be2bc6b1d0f60b45e3fb40c14ee7bd1b4f2fa88c URL: https://github.com/llvm/llvm-project/commit/be2bc6b1d0f60b45e3fb40c14ee7bd1b4f2fa88c DIFF: https://github.com/llvm/llvm-project/commit/be2bc6b1d0f60b45e3fb40c14ee7bd1b4f2fa88c.d

[Lldb-commits] [lldb] d92f776 - [lldb/Util] Fix Python 3 incompatibility in lldb-repro

Author: Jonas Devlieghere Date: 2020-01-23T21:41:49-08:00 New Revision: d92f77606aa6cfcb1e3e792a880b290d77f1c8fd URL: https://github.com/llvm/llvm-project/commit/d92f77606aa6cfcb1e3e792a880b290d77f1c8fd DIFF: https://github.com/llvm/llvm-project/commit/d92f77606aa6cfcb1e3e792a880b290d77f1c8fd.d

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

aadsm added a comment. Yeah, I'm not sure why the LoadModules function is calling target.SetExecutableModule. It is true that the libraries-svr4 will not include the main executable in its list. This code was added in the context of providing qXfer:libraries support here: https://reviews.llvm.o

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

friss added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:126-127 + // Fetch abort location + auto abort_location = + AbortRecognizerHandler::GetAbortLocation(process_sp.get()); + Why do you even check the abort location? The recogniz

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/AbortRecognizer.h:27 + + static llvm::Optional> + GetAbortLocation(Process *process_sp); This doesn't really look much like a class with just two static member functions. Assuming that th

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev updated this revision to Diff 240077. paolosev added a comment. Thanks for the explanation! I wasn't quite clear on "executable module" here, but after your comments I realized that `Target::SetExecutableModule()` should not probably be called also for Wasm modules. The point is that `O

[Lldb-commits] [PATCH] D73314: [lldb/Commands] Make column available through _regexp-break

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a subscriber: teemperor. Herald added a project: LLDB. Update `_regexp-break` to interpret `main.c:8:21` as `breakpoint set --line 8 --column 21`. Repository: rLLDB LLDB https://reviews.llvm.org/D73314

[Lldb-commits] [PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk added a comment. I think I can land this version, but I'll wait until tomorrow so I'll be around to debug fallout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71313/new/ https://reviews.llvm.org/D71313

[Lldb-commits] [PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk updated this revision to Diff 240050. rnk added a comment. This revision is now accepted and ready to land. - Move things around while retaining API compatibility for getParents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71313/new/ https://r

[Lldb-commits] [lldb] 47d7a81 - [lldb/Util] Use md5 instead of python's hash function.

Author: Jonas Devlieghere Date: 2020-01-23T16:37:03-08:00 New Revision: 47d7a81ba4bb4be2e6027fb44aa4cbfaffe9c3f2 URL: https://github.com/llvm/llvm-project/commit/47d7a81ba4bb4be2e6027fb44aa4cbfaffe9c3f2 DIFF: https://github.com/llvm/llvm-project/commit/47d7a81ba4bb4be2e6027fb44aa4cbfaffe9c3f2.d

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Target/AbortRecognizer.cpp:109 + + // FIXME: This breaks several tests. + // m_stop_info_sp = StopInfo::CreateStopReasonForRecognizedFrame( The tests failures happen becau

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib added a comment. I'm sending this first implementation looking for feedbacks, it is not passing all the tests and will probably change in the near future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/ https://reviews.llvm.org/D73303

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

mib created this revision. mib added reviewers: jingham, friss, LLDB. mib added a project: LLDB. Herald added subscribers: lldb-commits, jfb, mgorny. When a thread stops on an abort frame, the recognizer will unwind the stack to look for the frame from which the assert was triggered. Once located,

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

aprantl added a comment. @shafik: FYI If it isn't obvious, you can try building -DLLVM_ENABLE_REVERSE_ITERATION 1 to track it down. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68961/new/ https://reviews.llvm.org/D68961 ___

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/TestCppBitfields.py:15 +# Call super's setUp(). +TestBase.setUp(self) +# Find the line number to break inside main(). Is this needed?

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcaf5f6c01a0: [LLDB] Fix the handling of unnamed bit-fields when parsing DWARF (authored by shafik). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D72953?vs=239995&id=2

[Lldb-commits] [PATCH] D73206: `DWARFASTParserClang::m_decl_ctx_to_die` `DWARFDIE`->`DIERef` for DWZ

jankratochvil added a comment. In D73206#1837138 , @clayborg wrote: > Is this something we can store in the DWARFUnit? Seems like it would be nice > to be able to ask the DWARFUnit for its DWZ Unit? Then no changes are needed > to DWARFDie since it could

[Lldb-commits] [lldb] fcaf5f6 - [LLDB] Fix the handling of unnamed bit-fields when parsing DWARF

Author: shafik Date: 2020-01-23T14:46:24-08:00 New Revision: fcaf5f6c01a09f23b948afb8c91c4dd951d4525e URL: https://github.com/llvm/llvm-project/commit/fcaf5f6c01a09f23b948afb8c91c4dd951d4525e DIFF: https://github.com/llvm/llvm-project/commit/fcaf5f6c01a09f23b948afb8c91c4dd951d4525e.diff LOG: [

[Lldb-commits] [PATCH] D73289: [lldb/Test] Disallow using substituted binaries in shell test.

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG8d508c597aaf: [lldb/Test] Disallow using substituted binaries in shell test. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 8d508c5 - [lldb/Test] Disallow using substituted binaries in shell test.

Author: Jonas Devlieghere Date: 2020-01-23T14:39:27-08:00 New Revision: 8d508c597aaf5b483f4430300eda22f4d235f2ba URL: https://github.com/llvm/llvm-project/commit/8d508c597aaf5b483f4430300eda22f4d235f2ba DIFF: https://github.com/llvm/llvm-project/commit/8d508c597aaf5b483f4430300eda22f4d235f2ba.d

[Lldb-commits] [PATCH] D73289: [lldb/Test] Disallow using substituted binaries in shell test.

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/test/Shell/helper/toolchain.py:24 + warning.format(execName))) + + compnerd wrote: > Wow, that took a couple of reads to figure out w

[Lldb-commits] [PATCH] D73289: [lldb/Test] Disallow using substituted binaries in shell test.

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/Shell/helper/toolchain.py:24 + warning.format(execName))) + + Wow, that took a couple of reads to

[Lldb-commits] [lldb] d8acf88 - [lldb/Test] Disable command-breakpoint-col.test on Windows

Author: Jonas Devlieghere Date: 2020-01-23T14:17:50-08:00 New Revision: d8acf8852dbfbe2d6f2e2fdb4fa0ec18a4194da3 URL: https://github.com/llvm/llvm-project/commit/d8acf8852dbfbe2d6f2e2fdb4fa0ec18a4194da3 DIFF: https://github.com/llvm/llvm-project/commit/d8acf8852dbfbe2d6f2e2fdb4fa0ec18a4194da3.d

[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

xiaobai updated this revision to Diff 240001. xiaobai added a comment. Implement @teemperor's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72946/new/ https://reviews.llvm.org/D72946 Files: lldb/include/lldb/Symbol/TypeSystemClang.h

[Lldb-commits] [PATCH] D73206: `DWARFASTParserClang::m_decl_ctx_to_die` `DWARFDIE`->`DIERef` for DWZ

clayborg added a comment. Is this something we can store in the DWARFUnit? Seems like it would be nice to be able to ask the DWARFUnit for its DWZ Unit? Then no changes are needed to DWARFDie since it could get the language by checking the DWARFUnit first and then fall back to the DWZ DwarfUnit

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

shafik updated this revision to Diff 239995. shafik marked an inline comment as done. shafik added a comment. - Addressing minor comments - Adding fix for TestObjCIvarOffsets.py we need to guard `last_field_info.NextBitfieldOffsetIsValid(...)` with a check to make sure we have a bit-field. Objec

[Lldb-commits] [PATCH] D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods

friss added inline comments. Comment at: lldb/include/lldb/Target/ThreadPlan.h:464-469 + // Also sets the plans to private and not master plans. A plan pushed by + // another thread plan is never either of the above. void PushPlan(lldb::ThreadPlanSP &thread_plan_sp) {

[Lldb-commits] [PATCH] D73289: [lldb/Test] Disallow using substituted binaries in shell test.

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath. Herald added a subscriber: teemperor. Herald added a project: LLDB. Explicitly disallow using `lldb` instead of `%lldb` in the shell tests. This is a clever trick that is used by Swift to achieve the same results. R

[Lldb-commits] [PATCH] D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG29c7e6c8c97f: Clang added a new feature to the ObjC compiler that will translate method calls… (authored by jingham). Rep

[Lldb-commits] [PATCH] D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods

jingham marked 2 inline comments as done. jingham added a comment. Addressed remaining review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73225/new/ https://reviews.llvm.org/D73225 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D73225: Handle the new objc direct dispatch accelerator functions for uncommonly overridden methods

jingham updated this revision to Diff 239981. jingham added a comment. Addresses the rest of Jonas' comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73225/new/ https://reviews.llvm.org/D73225 Files: lldb/include/lldb/Target/ThreadPlan.h lldb/include/lldb/Target/ThreadPlanSte

[Lldb-commits] [lldb] 29c7e6c - Clang added a new feature to the ObjC compiler that will translate method

Author: Jim Ingham Date: 2020-01-23T12:41:14-08:00 New Revision: 29c7e6c8c97f6b1186f012d614e9a1100e8c06cb URL: https://github.com/llvm/llvm-project/commit/29c7e6c8c97f6b1186f012d614e9a1100e8c06cb DIFF: https://github.com/llvm/llvm-project/commit/29c7e6c8c97f6b1186f012d614e9a1100e8c06cb.diff LO

[Lldb-commits] [PATCH] D73284: [lldb/Commands] Fix, rename and document column number argument to breakpoint set.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6672a4f5b64f: [lldb/Commands] Fix, rename and document column number arg to breakpoint set. (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D73284?vs=239949&id=239980#toc

[Lldb-commits] [lldb] 6672a4f - [lldb/Commands] Fix, rename and document column number arg to breakpoint set.

Author: Jonas Devlieghere Date: 2020-01-23T12:34:24-08:00 New Revision: 6672a4f5b64f6b5a17cba63b421fcf313003b5b8 URL: https://github.com/llvm/llvm-project/commit/6672a4f5b64f6b5a17cba63b421fcf313003b5b8 DIFF: https://github.com/llvm/llvm-project/commit/6672a4f5b64f6b5a17cba63b421fcf313003b5b8.d

[Lldb-commits] [PATCH] D73284: [lldb/Commands] Fix, rename and document column number argument to breakpoint set.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM. This is my bad. I put in the parsing for -C in CommandObjectBreakpointSet in an (apparently futile) attempt to remind myself to reserve -C for column number... Repository: rLLDB

[Lldb-commits] [lldb] 794b8a0 - [lldb] s/lldb/%lldb in another test

Author: Jonas Devlieghere Date: 2020-01-23T11:17:24-08:00 New Revision: 794b8a0329d1356455970fe1ae26f5d3b38e7906 URL: https://github.com/llvm/llvm-project/commit/794b8a0329d1356455970fe1ae26f5d3b38e7906 DIFF: https://github.com/llvm/llvm-project/commit/794b8a0329d1356455970fe1ae26f5d3b38e7906.d

[Lldb-commits] [PATCH] D73284: [lldb/Commands] Fix, rename and document column number argument to breakpoint set.

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added subscribers: teemperor, abidh. Herald added a project: LLDB. We were incorrectly parsing the `-C` argument to `breakpoint set` as the column breakpoint, even though according to the help this should be the br

[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. In D73206 @labath said: //The test changes are cool, and I'd encourage you to split them off into a separate patch. // Repository: rG LLVM Github

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

teemperor added a comment. LGTM modulo some minor points regarding the test. The refactoring of the parsing code and using `expect_expr` can be done as NFC follow-ups. Thanks for the patch, great work! Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/TestCp

Re: [Lldb-commits] [lldb] 9be5c13 - [lldb/Test] Add check-lldb-repro target

Thanks Martin! I'll see if I can change the temp path to whatever lit uses. On Thu, Jan 23, 2020 at 12:05 AM Martin Storsjö wrote: > > On Wed, 22 Jan 2020, Jonas Devlieghere via lldb-commits wrote: > > > > > Author: Jonas Devlieghere > > Date: 2020-01-22T17:35:45-08:00 > > New Revision: 9be5c1353

[Lldb-commits] [PATCH] D73206: `DWARFASTParserClang::m_decl_ctx_to_die` `DWARFDIE`->`DIERef` for DWZ

labath added a comment. It's been a while since we had that discussion, but the way I'm remembering it, sizeof(DWARFDIE) was not my biggest concern with this stuff (though I may have been echoing the concerns of some other people). What I was trying to prevent is diverging even more from the ll

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

labath added a comment. This doesn't sound right. Will that mean we won't be able to find a method even if we search for it by its proper full mangled name (e.g. `_ZZ5ffbarvEN4sbaz3fooEv` in this case)? A better heuristic might be to check for DW_AT_linkage_name, and if the DIE has it, then on

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

jarin added a comment. > FWIW, the Sony debugger throws away the `` part of the DW_AT_name and > reconstructs it from the template_parameter children. The presence of > typedefs and/or enums can make the `` text inconsistent, especially > across enums. Our debugger reconstructs the type-param

[Lldb-commits] [lldb] a1e0b53 - [lldb][NFC] Delete empty file source/Host/linux/ProcessLauncherLinux.cpp

Author: Raphael Isemann Date: 2020-01-23T10:37:59+01:00 New Revision: a1e0b53490af15633e44170cdf5c0bfc0aac4ba0 URL: https://github.com/llvm/llvm-project/commit/a1e0b53490af15633e44170cdf5c0bfc0aac4ba0 DIFF: https://github.com/llvm/llvm-project/commit/a1e0b53490af15633e44170cdf5c0bfc0aac4ba0.dif

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a subscriber: aadsm. labath added a comment. [ looping in @aadsm for the svr4 stuff ] Thanks for adding the test, and for the detailed writeup. Please find my comments inline. In D72751#1835502 , @paolosev wrote: > The first is that we need

Re: [Lldb-commits] [lldb] 9be5c13 - [lldb/Test] Add check-lldb-repro target

On Wed, 22 Jan 2020, Jonas Devlieghere via lldb-commits wrote: Author: Jonas Devlieghere Date: 2020-01-22T17:35:45-08:00 New Revision: 9be5c13538898c7632c2de7300de9479688a2460 URL: https://github.com/llvm/llvm-project/commit/9be5c13538898c7632c2de7300de9479688a2460 DIFF: https://github.com/l