friss added inline comments.
================ Comment at: lldb/include/lldb/Target/ThreadPlan.h:464-469 + // Also sets the plans to private and not master plans. A plan pushed by + // another thread plan is never either of the above. void PushPlan(lldb::ThreadPlanSP &thread_plan_sp) { m_thread.PushPlan(thread_plan_sp); + thread_plan_sp->SetPrivate(false); + thread_plan_sp->SetIsMasterPlan(false); ---------------- The comment is somewhat ambiguous about whether the pushed plan is private or not. The first sentence says yes and the second no. Given the code seems to say no, I suppose the first sentence is wrong? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73225/new/ https://reviews.llvm.org/D73225 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits