kwk added a comment.
Why don't we always print the target index? Wouldn't that be much simpler?
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:76
- strm.Printf("%starget #%u: %s", prefix_cstr ? prefix_cstr : "", target_idx,
- exe_path);
+ if (prefix_c
paolosev added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:46-63
+llvm::Optional GetVaruint7(DataExtractor §ion_header_data,
+lldb::offset_t *offset_ptr) {
+ lldb::offset_t initial_offset = *offset_ptr;
paolosev updated this revision to Diff 236237.
paolosev marked 8 inline comments as done.
paolosev added a comment.
Addressed more review comments:
- removed code to manage "external_debug_info" sections; logic for this will be
implemented in the symbol vendor code.
- modified test code, from un
