kwk added a comment.
Why don't we always print the target index? Wouldn't that be much simpler?
================
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:76
- strm.Printf("%starget #%u: %s", prefix_cstr ? prefix_cstr : "", target_idx,
- exe_path);
+ if (prefix_cstr)
+ strm << prefix_cstr;
----------------
Happy New Years! For the rest of file and in particular for the target
properties (e.g. `arch`, `platform`), we use a one line `strm.Printf`. But I
can understand that you don't want to introduce a `?:` for every argument of
the `Printf`. However why don't we always print the target index? Wouldn't that
be much simpler?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67906/new/
https://reviews.llvm.org/D67906
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
