[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. WFM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 ___

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

mgorny added a comment. Diff 4, I think. Lemme do a quick test with 5. Hopefully it won't request me to rebuild everything again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 _

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

compnerd added a comment. The reason for bringing this back up as a Windows specific thing is that currently, there is no good way to build LLDB with python support without having to specify additional details on *just* windows because the windows path is doing something special. This is tryin

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG99046b873f7f: [lldb] move package generation from python to cmake (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://review

[Lldb-commits] [PATCH] D69453: Modernize TestThreadStepOut.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG651b5e725ee6: Modernize TestThreadStepOut.py (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69453/new/ https://reviews.llvm.org/D69453

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

jasonmolenda added a comment. In D62931#1724433 , @guiandrade wrote: > Yeah, more tests would be useful. They made me notice an issue btw. I was > simply sending a 'g' packet and checking if the server replied back nicely; > however, IIUC with 'G' packet

[Lldb-commits] [PATCH] D69523: [debugserver] Detect arch from LLVM_DEFAULT_TARGET_TRIPLE

vsk closed this revision. vsk added a comment. Landed in 82d3ba. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69523/new/ https://reviews.llvm.org/D69523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb updated this revision to Diff 226781. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py lldb/scripts/Py

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade marked an inline comment as done. guiandrade added a comment. In D62931#1719948 , @labath wrote: > I'm sorry, this dropped off my radar. The code looks fine, but it could use > some more tests. For instance, one test when you set the setting va

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade updated this revision to Diff 226779. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm.org/D62931 Files: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py lldb/

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade updated this revision to Diff 226778. guiandrade added a comment. Adding tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm.org/D62931 Files: lldb/packages/Python/lldbsuite/test/commands/register/regi

[Lldb-commits] [lldb] 651b5e7 - Modernize TestThreadStepOut.py

Author: Jim Ingham Date: 2019-10-28T16:15:09-07:00 New Revision: 651b5e725ee6812fdabb369ed2ecd4740106a82c URL: https://github.com/llvm/llvm-project/commit/651b5e725ee6812fdabb369ed2ecd4740106a82c DIFF: https://github.com/llvm/llvm-project/commit/651b5e725ee6812fdabb369ed2ecd4740106a82c.diff LO

[Lldb-commits] [PATCH] D69453: Modernize TestThreadStepOut.py

jingham marked 4 inline comments as done. jingham added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/thread/step_out/TestThreadStepOut.py:136 +(self.inferior_target, self.inferior_process, thread, bkpt) = lldbutil.run_to_source_breakp

[Lldb-commits] [PATCH] D69453: Modernize TestThreadStepOut.py

jingham updated this revision to Diff 226772. jingham added a comment. Addressed review comments. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69453/new/ https://reviews.llvm.org/D69453 Files: lldb/packages/Python/lldbsuite/test/functionalities/thread/step

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

JDevlieghere added a comment. I proposed this in https://reviews.llvm.org/D64881 and the consensus was that we didn't want to do this. Also I don't think this should be a Windows-only thing. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69535/new/ https://rev

[Lldb-commits] [lldb] 82d3ba8 - [debugserver] Detect arch from LLVM_DEFAULT_TARGET_TRIPLE

Author: Vedant Kumar Date: 2019-10-28T15:34:39-07:00 New Revision: 82d3ba87d06f9e2abc6e27d8799587d433c56630 URL: https://github.com/llvm/llvm-project/commit/82d3ba87d06f9e2abc6e27d8799587d433c56630 DIFF: https://github.com/llvm/llvm-project/commit/82d3ba87d06f9e2abc6e27d8799587d433c56630.diff

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

This revision was automatically updated to reflect the committed changes. Closed by commit rGde2c7cab715e: Add support for DW_AT_export_symbols for anonymous structs (authored by shafik). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D68961?vs=226450&id=226764#

[Lldb-commits] [PATCH] D69523: [debugserver] Detect arch from LLVM_DEFAULT_TARGET_TRIPLE

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69523/new/ https://reviews.llvm.org/D69523 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] 5ae881f - [Docs] Repurpose 'sources' page as 'contributing'.

Author: Jonas Devlieghere Date: 2019-10-28T15:03:05-07:00 New Revision: 5ae881f96f999aaca98d8f83d3f00e037c783647 URL: https://github.com/llvm/llvm-project/commit/5ae881f96f999aaca98d8f83d3f00e037c783647 DIFF: https://github.com/llvm/llvm-project/commit/5ae881f96f999aaca98d8f83d3f00e037c783647.d

[Lldb-commits] [PATCH] D69535: build: improve python check for Windows

compnerd created this revision. compnerd added reviewers: xiaobai, stella.stamenova. Herald added subscribers: JDevlieghere, mgorny. Herald added a project: LLDB. If we have a new enough CMake, use `find_package(Python3)`. This version is able to check both 32-bit and 64-bit versions and will se

[Lldb-commits] [lldb] de2c7ca - Add support for DW_AT_export_symbols for anonymous structs

Author: shafik Date: 2019-10-28T14:26:54-07:00 New Revision: de2c7cab715e195c9d559d317beb760cf0b95262 URL: https://github.com/llvm/llvm-project/commit/de2c7cab715e195c9d559d317beb760cf0b95262 DIFF: https://github.com/llvm/llvm-project/commit/de2c7cab715e195c9d559d317beb760cf0b95262.diff LOG: A

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

lawrence_danna created this revision. lawrence_danna added reviewers: labath, mgorny. Herald added a project: LLDB. It is, I think, inherently unsafe to hand a borrowed native file object to a python program on python 2. This is because the python file object must be created with a FILE*, not

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226747. lawrence_danna added a comment. revert to previous version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files: lldb/packages/Python/lldbsuite/test/p

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna added a comment. In D69488#1724178 , @mgorny wrote: > I have confirmed that your previous revision fixed the problem in question. > The newer one would probably require full test suite run which I can't do > right now. As I said, I would p

Re: [Lldb-commits] [lldb] f8a92af - [LLDB] Remove incorrect dotest.py invocation

It looks like this was the only call to getRerunArgs, so why not delete it? On Mon, Oct 28, 2019 at 1:24 PM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Jonas Devlieghere > Date: 2019-10-28T13:24:07-07:00 > New Revision: f8a92af893eee7ac7ffda93c24b9e69df506

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

mgorny added a comment. I have confirmed that your previous revision fixed the problem in question. The newer one would probably require full test suite run which I can't do right now. As I said, I would prefer those two changes to be committed separately, preferably with a few hours delay so t

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce display_name

wallace updated this revision to Diff 226744. wallace added a comment. now reading from comm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 Files: lldb/docs/lldb-gdb-remote.txt lldb/include/lldb/Utilit

[Lldb-commits] [lldb] f8a92af - [LLDB] Remove incorrect dotest.py invocation

Author: Jonas Devlieghere Date: 2019-10-28T13:24:07-07:00 New Revision: f8a92af893eee7ac7ffda93c24b9e69df506148f URL: https://github.com/llvm/llvm-project/commit/f8a92af893eee7ac7ffda93c24b9e69df506148f DIFF: https://github.com/llvm/llvm-project/commit/f8a92af893eee7ac7ffda93c24b9e69df506148f.d

[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

lawrence_danna updated this revision to Diff 226737. lawrence_danna added a comment. improved error handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69468/new/ https://reviews.llvm.org/D69468 Files: lldb/include/lldb/Interpreter/ScriptInte

[Lldb-commits] [PATCH] D69453: Modernize TestThreadStepOut.py

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:781 -test.assertTrue(len(threads) == 1, "Expected 1 thread to stop at breakpoint, %d did."%(len(threads))) +num_threads = len(threads) +if only_one_thread: t

[Lldb-commits] [PATCH] D69453: Modernize TestThreadStepOut.py

aprantl added a comment. Thanks! Nitpicking inside. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/thread/step_out/TestThreadStepOut.py:136 +(self.inferior_target, self.inferior_process, thread, bkpt) = lldbutil.run_to_source_breakpoint( +

[Lldb-commits] [PATCH] D69524: [debugserver] Delete macOS/PPC debug server implementation

vsk created this revision. vsk added reviewers: clayborg, jasonmolenda. Herald added subscribers: kbarton, mgorny, nemanjai. macOS/PPC support was dropped in 10.6 (Snow Leopard). https://reviews.llvm.org/D69524 Files: lldb/tools/debugserver/source/MacOSX/CMakeLists.txt lldb/tools/debugserve

[Lldb-commits] [PATCH] D69523: [debugserver] Detect arch from LLVM_DEFAULT_TARGET_TRIPLE

vsk created this revision. vsk added reviewers: davide, JDevlieghere, xiaobai. Herald added a subscriber: mgorny. The debugserver build needs to conditionally include files depending on the target architecture. Switch on the architecture specified by LLVM_DEFAULT_TARGET_TRIPLE, as the llvm and sw

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna added a comment. In D69488#1723481 , @labath wrote: > I am not thrilled by all of that duping going around. Having multiple FILE > objects means that you have multiple independent file caches too. That can > cause different kinds of strang

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce display_name

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/source/Host/linux/Host.cpp:205-222 +static bool GetProcessNameFromStat(::pid_t pid, std::string& name) { + auto BufferOrError = getProcFile(pid, "stat"); + if (!BufferOrError) +return

[Lldb-commits] [lldb] da2a4c2 - [Docs] Update source code link to Github

Author: Jonas Devlieghere Date: 2019-10-28T11:14:59-07:00 New Revision: da2a4c234dcda0677d89051408b38d50d44991fe URL: https://github.com/llvm/llvm-project/commit/da2a4c234dcda0677d89051408b38d50d44991fe DIFF: https://github.com/llvm/llvm-project/commit/da2a4c234dcda0677d89051408b38d50d44991fe.d

Re: [Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

In the work I was doing with the scripted ThreadPlans & Breakpoint Callbacks, I've been introducing Status objects into these calls in python-wrapper.swig (usually you have to start from the ScriptInterpreter API's, so we can report errors. That way I could catch errors with wrong number of arg

Re: [Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

May be the test for PECallFrameInfo will be helpful? Martin Storsjö via Phabricator schrieb am Mo., 28. Okt. 2019, 19:43: > mstorsjo added a comment. > > In D69502#1723549 , @labath > wrote: > > > Any way to get a test for this? Maybe creating a object fi

[Lldb-commits] [lldb] 6336317 - [Docs] Disable Python docs when LLDB_DISABLE_PYTHON is set

Author: Jonas Devlieghere Date: 2019-10-28T09:53:58-07:00 New Revision: 6336317e0a37c246b7aea29a178c0d6fd3d12454 URL: https://github.com/llvm/llvm-project/commit/6336317e0a37c246b7aea29a178c0d6fd3d12454 DIFF: https://github.com/llvm/llvm-project/commit/6336317e0a37c246b7aea29a178c0d6fd3d12454.d

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

mstorsjo added a comment. In D69502#1723549 , @labath wrote: > Any way to get a test for this? Maybe creating a object file with a bogus > unwind RVA via yaml2obj ? Do we have a suitable test as basis for it? I'm not quite sure which way is the most co

Re: [Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

On 28/10/2019 11:57, Omair Javaid wrote: On Fri, 25 Oct 2019 at 17:53, Pavel Labath via Phabricator wrote: labath added a comment. In D69371#1721077 , @omjavaid wrote: We ll be dealing with Linux user mode and mostly aarch64 data registers except fo

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

labath added a comment. Any way to get a test for this? Maybe creating a object file with a bogus unwind RVA via yaml2obj ? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69502/new/ https://reviews.llvm.org/D69502

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

labath added a comment. I don't know whether this is the right way to check for this, but at the very least is seems suspicious, as this function is called from LaunchProcess, which initializes m_session_data. This means that someone else needs to clear it in the mean time, and he probably does

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

teemperor added a comment. Will properly review this later, but this seems like a patch that might be related to the performance issue here: https://reviews.llvm.org/D41416 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69309/new/ https://reviews.l

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

labath added a comment. I am not thrilled by all of that duping going around. Having multiple FILE objects means that you have multiple independent file caches too. That can cause different kinds of strange behavior if multiple things start reading/writing to the different FILE objects simultan

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

mstorsjo added a comment. In D69502#1723385 , @aleksandr.urakov wrote: > LGTM, thank you! Can you send me an example of binary on which unwinding > fails with a crash, please? It is a very interesting case... It is on arm64, so it's not something that

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

aleksandr.urakov added a comment. Sorry, I'm OOO today, so I can't take a precise look on this now. But I'm not sure, isn't race condition possible here on the m_session_data reset? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69503/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok. sounds good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://reviews.llvm.org/D69019 ___

[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

labath added inline comments. Comment at: lldb/scripts/Python/python-wrapper.swig:64 +unsigned max_positional_args = PythonCallable::ArgInfo::UNBOUNDED; +if (auto arg_info = pfunc.GetArgInfo()) { lawrence_danna wrote: > labath wrote: > > Is there any ca

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thank you! Can you send me an example of binary on which unwinding fails with a crash, please? It is a very interesting case... Repository: rLLDB LLDB CHANGES SIN

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce display_name

labath added a comment. This looks pretty good. I just have one quick question about the /comm file. Comment at: lldb/source/Host/linux/Host.cpp:205-222 +static bool GetProcessNameFromStat(::pid_t pid, std::string& name) { + auto BufferOrError = getProcFile(pid, "stat"); + if

[Lldb-commits] [PATCH] D69503: [LLDB] [Windows] Don't crash if the debugged process is unable to start up

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, aleksandr.urakov. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. This can e.g. happen if the debugged executable depends on unavailable DLLs. One could also return e.g. Status(ERROR_DLL_NOT_FOUND,

[Lldb-commits] [PATCH] D69502: [LLDB] [PECOFF] Don't crash in ReadImageDataByRVA for addresses out of range

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, aleksandr.urakov. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This can happen e.g. when unwinding doesn't work perfectly. Repository: rLLDB LLDB https://reviews.llvm.org/D69502

Re: [Lldb-commits] [PATCH] D69371: [ARM64] Cleanup and speedup NativeRegisterContextLinux_arm64

On Fri, 25 Oct 2019 at 17:53, Pavel Labath via Phabricator wrote: > > labath added a comment. > > In D69371#1721077 , @omjavaid wrote: > > > We ll be dealing with Linux user mode and mostly aarch64 data registers > > except for cpsr, fpsr and fpcr. I think

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

mgorny added a comment. Thanks but I'd personally prefer splitting this into a future commit, in case it introduced unrelated issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 _

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna added a comment. There, I think that fixes the issue with borrow semantics and the NetBSD issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 ___

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226618. lawrence_danna added a comment. protect python from being exposed to C++ reference borrowing semantics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Fi