[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224722. wallace added a comment. i think i finally wrote something that works python 2 and 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files: lldb/packages/Pyt

[Lldb-commits] [lldb] r374631 - [platform process list] add a flag for showing the processes of all users

Author: wallace Date: Fri Oct 11 19:36:16 2019 New Revision: 374631 URL: http://llvm.org/viewvc/llvm-project?rev=374631&view=rev Log: [platform process list] add a flag for showing the processes of all users Summary: For context: https://reviews.llvm.org/D68293 We need a way to show all the proc

[Lldb-commits] [lldb] r374630 - Revert "[platform process list] add a flag for showing the processes of all users"

Author: wallace Date: Fri Oct 11 19:31:22 2019 New Revision: 374630 URL: http://llvm.org/viewvc/llvm-project?rev=374630&view=rev Log: Revert "[platform process list] add a flag for showing the processes of all users" This reverts commit f670a5edfc70066872e1795d650ed6e1ac62b6a8. Removed: ll

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224721. wallace added a comment. after the logging finally found the bug, it's was an encoding issue due to a different python version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.l

[Lldb-commits] [lldb] r374626 - [platform process list] add a flag for showing the processes of all users

Author: wallace Date: Fri Oct 11 19:08:35 2019 New Revision: 374626 URL: http://llvm.org/viewvc/llvm-project?rev=374626&view=rev Log: [platform process list] add a flag for showing the processes of all users Summary: For context: https://reviews.llvm.org/D68293 We need a way to show all the proc

[Lldb-commits] [lldb] r374625 - Revert "[platform process list] add a flag for showing the processes of all users"

Author: wallace Date: Fri Oct 11 19:01:33 2019 New Revision: 374625 URL: http://llvm.org/viewvc/llvm-project?rev=374625&view=rev Log: Revert "[platform process list] add a flag for showing the processes of all users" This reverts commit 90d0de4999354a5223f08ad714222b0a5dca3cad. Removed: ll

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

jingham updated this revision to Diff 224719. jingham added a comment. I added ScriptInterpreter::GetNumArgumentsForCallable, so I can base all the decisions on how to call the function on whether I was passed a function with 3 or 4 arguments. That's cleaner. I also plumbed an error through th

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224717. wallace added a comment. adding some logging for exceptions in the mock server Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files: lldb/packages/Python/ll

[Lldb-commits] [lldb] r374622 - [platform process list] add a flag for showing the processes of all users

Author: wallace Date: Fri Oct 11 18:33:21 2019 New Revision: 374622 URL: http://llvm.org/viewvc/llvm-project?rev=374622&view=rev Log: [platform process list] add a flag for showing the processes of all users Summary: For context: https://reviews.llvm.org/D68293 We need a way to show all the proc

[Lldb-commits] [lldb] r374621 - Revert "[platform process list] add a flag for showing the processes of all users"

Author: wallace Date: Fri Oct 11 18:08:50 2019 New Revision: 374621 URL: http://llvm.org/viewvc/llvm-project?rev=374621&view=rev Log: Revert "[platform process list] add a flag for showing the processes of all users" This reverts commit 08781f4c53a177662c029d3da9c407ba65ae6747. Removed: ll

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224716. wallace added a comment. another try Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_cl

[Lldb-commits] [lldb] r374620 - [platform process list] add a flag for showing the processes of all users

Author: wallace Date: Fri Oct 11 17:44:50 2019 New Revision: 374620 URL: http://llvm.org/viewvc/llvm-project?rev=374620&view=rev Log: [platform process list] add a flag for showing the processes of all users Summary: For context: https://reviews.llvm.org/D68293 We need a way to show all the proc

[Lldb-commits] [lldb] r374616 - Temporarily Revert [platform process list] add a flag for showing the processes of all users

Author: adrian Date: Fri Oct 11 17:03:40 2019 New Revision: 374616 URL: http://llvm.org/viewvc/llvm-project?rev=374616&view=rev Log: Temporarily Revert [platform process list] add a flag for showing the processes of all users as it breaks the bots. This reverts r374609 (git commit 696d3cf8ad6f3

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

aprantl added a comment. The re-committed variant still doesn't work :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224707. hhb added a comment. Adds VERBATIM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224703. wallace added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_clien

[Lldb-commits] [lldb] r374609 - [platform process list] add a flag for showing the processes of all users

Author: wallace Date: Fri Oct 11 16:10:34 2019 New Revision: 374609 URL: http://llvm.org/viewvc/llvm-project?rev=374609&view=rev Log: [platform process list] add a flag for showing the processes of all users Summary: For context: https://reviews.llvm.org/D68293 We need a way to show all the proc

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace added a comment. i'm reverting it, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] r374603 - Revert "[platform process list] add a flag for showing the processes of all users"

Author: wallace Date: Fri Oct 11 14:58:49 2019 New Revision: 374603 URL: http://llvm.org/viewvc/llvm-project?rev=374603&view=rev Log: Revert "[platform process list] add a flag for showing the processes of all users" Summary: This reverts commit e4ac611cd787f3f0e727a394e96fb1a5c3b19ccb. There's

Re: [Lldb-commits] [lldb] r374584 - [platform process list] add a flag for showing the processes of all users

This test fails on green dragon: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2538/changes#detail0 http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2538/testReport/junit/lldb-api/functionalities_gd

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

aprantl added a comment. This test fails on green dragon: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2538/changes#detail0 http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2538/testReport/junit/lldb-api/functionalities_gdb_remote_client/TestPlatformClient_py/ lldb-api.func

[Lldb-commits] [PATCH] D68890: remove FILE* bindings from SBInstruction.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. This patch replaces the FILE* python bindings for SBInstruction and SBInstructionList and replaces them with the new, safe SBFile and FileSP bindings. I also re-

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

dblaikie added inline comments. Comment at: lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:291-295 + EntryIterator Absolute = + getAbsoluteLocations( + SectionedAddress{BaseAddr, SectionedAddress::UndefSection}, + LookupPooledAddress) + .begin(); -

[Lldb-commits] [lldb] r374591 - Set GNUC version in the LLDB expression parser.

Author: adrian Date: Fri Oct 11 13:27:51 2019 New Revision: 374591 URL: http://llvm.org/viewvc/llvm-project?rev=374591&view=rev Log: Set GNUC version in the LLDB expression parser. This adapts LLDB for https://reviews.llvm.org/D68055. Darwin's libC headers expect the GNUC macro to be set. Modif

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna updated this revision to Diff 224666. lawrence_danna added a comment. use stream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68546/new/ https://reviews.llvm.org/D68546 Files: lldb/include/lldb/API/SBDebugger.h lldb/include/lld

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna updated this revision to Diff 224668. lawrence_danna added a comment. swig 3 fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68546/new/ https://reviews.llvm.org/D68546 Files: lldb/include/lldb/API/SBDebugger.h lldb/include/lld

[Lldb-commits] [PATCH] D68883: Revert "[platform process list] add a flag for showing the processes of all users"

wallace created this revision. wallace added reviewers: labath, aadsm, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This reverts commit e4ac611cd787f3f0e727a394e96fb1a5c3b19ccb. There's a failure according to http://lab.llvm.org:8080/green/view/LLDB/job/lldb-c

[Lldb-commits] [lldb] r374587 - [NativePDB] Remove unused references to ClangASTImporter

Author: xiaobai Date: Fri Oct 11 13:12:29 2019 New Revision: 374587 URL: http://llvm.org/viewvc/llvm-project?rev=374587&view=rev Log: [NativePDB] Remove unused references to ClangASTImporter Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp lldb/trunk/source

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna added a comment. In D68546#1705684 , @labath wrote: > Well... if we agree that SBStream is the future for APIs like this, then I > don't think that would be too strange. The FileSP and FILE* variants would > both be "legacy/deprecated" and

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:776 @add_test_categories(['pyapi']) -@expectedFailure # FIXME implement SBFile::GetFile @skipIf(py_version=['<', (3,)]) l

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna updated this revision to Diff 224659. lawrence_danna marked 8 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68737/new/ https://reviews.llvm.org/D68737 Files: ll

[Lldb-commits] [PATCH] D68853: uint32_t options -> File::OpenOptions options

lawrence_danna updated this revision to Diff 224658. lawrence_danna added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68853/new/ https://reviews.llvm.org/D68853 Files: lldb/include/lldb/Core/StreamFile.h lldb/include/lldb/Host

[Lldb-commits] [lldb] r374585 - Add -fgnuc-version to ClangModuleCompilationOptions on Darwin.

Author: adrian Date: Fri Oct 11 12:54:09 2019 New Revision: 374585 URL: http://llvm.org/viewvc/llvm-project?rev=374585&view=rev Log: Add -fgnuc-version to ClangModuleCompilationOptions on Darwin. This adapts LLDB for https://reviews.llvm.org/D68055. Darwin's libC headers expect the GNUC macro to

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

stella.stamenova added a comment. It looks like this changed fixed at least one of the XFAILed tests on Windows: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9751 So now the test results would be red because of the unexpectedly passing test (if there wasn't another failure).

[Lldb-commits] [lldb] r374584 - [platform process list] add a flag for showing the processes of all users

Author: wallace Date: Fri Oct 11 12:41:12 2019 New Revision: 374584 URL: http://llvm.org/viewvc/llvm-project?rev=374584&view=rev Log: [platform process list] add a flag for showing the processes of all users Summary: For context: https://reviews.llvm.org/D68293 We need a way to show all the proc

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224656. wallace added a comment. now it should work, the test pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files: lldb/packages/Python/lldbsuite/test/functio

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2ca7cb504a8: make ConstString allocate memory in non-tiny chunks (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68549/new/ https://rev

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224648. hhb added a comment. Fix file copy path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224649. hhb added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py Index: lld

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224647. hhb added a comment. Fix file copy path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D68662: Redo D68354 - [platform process list] add a flag for showing the processes of all users

wallace closed this revision. wallace added a comment. will update the previous diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68662/new/ https://reviews.llvm.org/D68662 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

hhb added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) tatyana-krasnukha wrote: > tatyana-krasnukha wrote: > >

[Lldb-commits] [PATCH] D68096: ProcessMinidump: Suppress reporting stop for signal '0'

JosephTremoulet added a comment. In D68096#1706258 , @clayborg wrote: > If this patch is solely meant to fix this issue, then I remove my "Requires > Changes" and this patch is good to go if it no longer hangs LLDB. Great, thanks. And just to confirm o

[Lldb-commits] [PATCH] D68662: Redo D68354 - [platform process list] add a flag for showing the processes of all users

wallace added a comment. Good suggestion! I'll do that next time Thank you so much. I'm getting more used to all the llvm infrastructure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68662/new/ https://reviews.llvm.org/D68662 __

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

clayborg added a comment. > The only place where I treat the extra_args as a Dictionary is when I use as > a way to tell whether the extra_args is empty, which I need to write the > right wrapper function in GenerateBreakpointCommandCallbackData. That > function is little annoying because it do

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

lawrence_danna updated this revision to Diff 224638. lawrence_danna added a comment. fix for swig 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68856/new/ https://reviews.llvm.org/D68856 Files: lldb/packages/Python/lldbsuite/test/python_api/fi

[Lldb-commits] [PATCH] D68096: ProcessMinidump: Suppress reporting stop for signal '0'

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. In D68096#1706076 , @JosephTremoulet wrote: > Just to make sure I'm understanding the feedback correctly, I'll try to > summarize. Please let me

[Lldb-commits] [PATCH] D68878: [lldb] Fix python packages install path

This revision was automatically updated to reflect the committed changes. Closed by commit rG6aacd9687543: [lldb] Fix python packages install path (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68878/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3faa01ff962: IOHandler: fall back on File::Read if a FILE* isn't available. (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6862

[Lldb-commits] [PATCH] D68853: uint32_t options -> File::OpenOptions options

lawrence_danna added inline comments. Comment at: lldb/source/Host/common/File.cpp:42 -static const char *GetStreamOpenModeFromOptions(uint32_t options) { +static Expected GetStreamOpenModeFromOptions(uint32_t options) { if (options & File::eOpenOptionAppend) { -

[Lldb-commits] [lldb] r374577 - [lldb] Fix python packages install path

Author: hhb Date: Fri Oct 11 10:44:14 2019 New Revision: 374577 URL: http://llvm.org/viewvc/llvm-project?rev=374577&view=rev Log: [lldb] Fix python packages install path Reviewers: mgorny Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D68878 Modified:

[Lldb-commits] [lldb] r374576 - IOHandler: fall back on File::Read if a FILE* isn't available.

Author: lawrence_danna Date: Fri Oct 11 10:43:32 2019 New Revision: 374576 URL: http://llvm.org/viewvc/llvm-project?rev=374576&view=rev Log: IOHandler: fall back on File::Read if a FILE* isn't available. Summary: IOHandler needs to read lines of input from a lldb::File. The way it currently does

[Lldb-commits] [PATCH] D68853: uint32_t options -> File::OpenOptions options

lawrence_danna updated this revision to Diff 224631. lawrence_danna marked 5 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68853/new/ https://reviews.llvm.org/D68853 Files: ll

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna updated this revision to Diff 224630. lawrence_danna added a comment. move using declarations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 Files: lldb/include/lldb/Core/IOHandler.h lld

[Lldb-commits] [PATCH] D68878: [lldb] Fix python packages install path

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68878/new/ https://reviews.llvm.org/D68878 __

[Lldb-commits] [lldb] r374574 - [lldb] Mark import-std-module/empty-module as libc++ test

Author: teemperor Date: Fri Oct 11 10:34:44 2019 New Revision: 374574 URL: http://llvm.org/viewvc/llvm-project?rev=374574&view=rev Log: [lldb] Mark import-std-module/empty-module as libc++ test Same as with the import-std-module/sysroot test before. Modified: lldb/trunk/packages/Python/lldb

[Lldb-commits] [lldb] r374572 - [lldb] Add import-std-module/sysroot to the libc++ test category.

Author: teemperor Date: Fri Oct 11 10:17:58 2019 New Revision: 374572 URL: http://llvm.org/viewvc/llvm-project?rev=374572&view=rev Log: [lldb] Add import-std-module/sysroot to the libc++ test category. We essentially test libc++ in a sysroot here so let's make sure that we actually only run this

[Lldb-commits] [PATCH] D68878: [lldb] Fix python packages install path

hhb created this revision. hhb added a reviewer: mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68878 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade updated this revision to Diff 224626. guiandrade added a comment. Properly separating MPX fix from this change (I guess) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm.org/D62931 Files: lldb/packages/Py

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade updated this revision to Diff 224615. guiandrade edited the summary of this revision. guiandrade added a comment. Moving MPX fix to a parent change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm.org/D62931

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f46982b452b: [lldb-test] Modify lldb-test to print out ASTs from symbol file (authored by shafik). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D67994?vs=224479&id=22

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

stella.stamenova added a comment. This is failing on the windows bot. There was already another failure, so you probably didn't get an email: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9727 http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9760 Repository:

[Lldb-commits] [lldb] r374570 - [lldb-test] Modify lldb-test to print out ASTs from symbol file

Author: shafik Date: Fri Oct 11 09:36:20 2019 New Revision: 374570 URL: http://llvm.org/viewvc/llvm-project?rev=374570&view=rev Log: [lldb-test] Modify lldb-test to print out ASTs from symbol file Summary: Currently when invoking lldb-test symbols -dump-ast it parses all the debug symbols and ca

[Lldb-commits] [PATCH] D68874: [lldb] Fix offset intersection bug between MPX and AVX registers

guiandrade created this revision. guiandrade added a reviewer: labath. guiandrade added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. This change increases the offset of MPX registers (by 128) so they do not overlap with the offset associated with AVX registers. That was c

[Lldb-commits] [PATCH] D68096: ProcessMinidump: Suppress reporting stop for signal '0'

JosephTremoulet added a comment. Just to make sure I'm understanding the feedback correctly, I'll try to summarize. Please let me know if this is off track: - When one uses breakpad to generate a minidump for a process that *hasn't* crashed, depending which of its methods one calls to write th

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 224603. mbrkusanin added a comment. - Rebase - Ping @echristo @craig.topper @tstellar @dylanmckay @petecoup If there are no objections then I'll split this into llvm, clang and lldb patches and commit them next week. CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

JosephTremoulet updated this revision to Diff 224607. JosephTremoulet added a comment. Address review feedback - Add Exception stream to minidump-basic.yaml to test obj2yaml direction - Reorder ExceptionStream definition and constructors - Use the mapOptional helper - Re

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

JosephTremoulet marked 4 inline comments as done. JosephTremoulet added a comment. Added Exception stream to minidump-basic.yaml as suggested. Comment at: llvm/lib/ObjectYAML/MinidumpYAML.cpp:394 + mapOptionalHex(IO, "Exception Address", Exception.ExceptionAddress, 0); + IO.m

Re: [Lldb-commits] LLDB finish_swig and Python module installation broken for multi-configuration generators

I had that issue since r373668 and the commit was already reverted today (r374226). Now finish_swig works for me. Cannot say anything about installation steps. From: lldb-dev On Behalf Of Ted Woodward via lldb-dev Sent: Friday, October 11, 2019 2:11 AM To: LLDB ; h...@google.com; antonio.afo..

[Lldb-commits] [PATCH] D68868: Fix build under musl

markand added a comment. In fact, in musl, the content of the structure FILE isn't exposed. But anyway, I don't understand why the code tries to write the content of the structure directly. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68868/new/ https://revi

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

tatyana-krasnukha added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) tatyana-krasnukha wrote: > hhb wrote: > >

[Lldb-commits] [PATCH] D68868: Fix build under musl

markand added a comment. Wait, actually the patch isn't working entirely. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68868/new/ https://reviews.llvm.org/D68868 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D68868: Fix build under musl

markand created this revision. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. This fixes the build under musl because of missing definitions. In file included from /src/vanilla/dev/lldb/lldb-9.0.0.src/source/API/SBReproducerPrivate.h:18: /src/vani

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

labath marked an inline comment as done. labath added inline comments. Comment at: lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:291-295 + EntryIterator Absolute = + getAbsoluteLocations( + SectionedAddress{BaseAddr, SectionedAddress::UndefSection}, + LookupPooled

[Lldb-commits] [lldb] r374545 - [lldb] Insert break to avoid unannotated fall-through

Author: kadircet Date: Fri Oct 11 05:33:47 2019 New Revision: 374545 URL: http://llvm.org/viewvc/llvm-project?rev=374545&view=rev Log: [lldb] Insert break to avoid unannotated fall-through Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/PECallFrameInfo.cpp Modified: lldb/trunk/source/P

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

tatyana-krasnukha abandoned this revision. tatyana-krasnukha added a comment. Fixed by reverting the initial commit. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.d

[Lldb-commits] [PATCH] D68864: [LLDB] [lldb-server] Use llvm::InitLLVM for doing unicode conversion of arguments for windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG807dbee36679: [LLDB] [lldb-server] Use llvm::InitLLVM for doing unicode conversion of… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] r374537 - [LLDB] [lldb-server] Use llvm::InitLLVM for doing unicode conversion of arguments for windows

Author: mstorsjo Date: Fri Oct 11 04:47:07 2019 New Revision: 374537 URL: http://llvm.org/viewvc/llvm-project?rev=374537&view=rev Log: [LLDB] [lldb-server] Use llvm::InitLLVM for doing unicode conversion of arguments for windows This should allow lldb-server to operate on files with non-ascii pa

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

labath added a comment. I've committed my ProcessInstanceInfoMatch fix now. Feel free to recommit when you're able to check the bots for failure. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 _

[Lldb-commits] [PATCH] D68662: Redo D68354 - [platform process list] add a flag for showing the processes of all users

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sorry for taking a while, this got burried in my stack. Still looks good, but please do keep an eye out on the bots. BTW, it would make it easier to figure out what changed if you just re-open

[Lldb-commits] [lldb] r374532 - minidump: Use llvm memory info list parser

Author: labath Date: Fri Oct 11 04:23:40 2019 New Revision: 374532 URL: http://llvm.org/viewvc/llvm-project?rev=374532&view=rev Log: minidump: Use llvm memory info list parser Modified: lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp lldb/trunk/source/Plugins/Process/minidum

[Lldb-commits] [PATCH] D68631: ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested, take 2

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8b18baa0f9e: ProcessInstanceInfoMatch: Don't match processes with no name if a name match… (authored by labath). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D68631?v

[Lldb-commits] [lldb] r374529 - ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested, take 2

Author: labath Date: Fri Oct 11 03:56:54 2019 New Revision: 374529 URL: http://llvm.org/viewvc/llvm-project?rev=374529&view=rev Log: ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested, take 2 Summary: The previous attempt at making nameless process not mat

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

labath added a comment. In D68546#1700273 , @lawrence_danna wrote: > So what's the conclusion here? Should `HandleProcessEvent` get a SBStream > variant as well? I say "as well", because the `FileSP` variant is > required in order to remove the

[Lldb-commits] [PATCH] D68864: [LLDB] [lldb-server] Use llvm::InitLLVM for doing unicode conversion of arguments for windows

mstorsjo created this revision. mstorsjo added reviewers: amccarth, labath, aleksandr.urakov. Herald added a project: LLDB. This should allow lldb-server to operate on files with non-ascii pathnames. I tried looking around in lldb/tools, and this seemed like the only other tool (other than the m

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

mstorsjo added a comment. In D67347#1705611 , @labath wrote: > In D67347#1705563 , @mstorsjo wrote: > > > Quick question here; will unwinding using DWARF debug info still work like > > before after this, for binari

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath added a comment. Yeah, I think that's the best we can do right now. Could you just drop the gdb_remote_offset from the `GetPtraceOffset`. It can be recovered from the `index` argument, and I don't want people to think that they _have to_ implement the ptrace offset computation via the gd

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

labath added a comment. In D67347#1705563 , @mstorsjo wrote: > Quick question here; will unwinding using DWARF debug info still work like > before after this, for binaries that don't use SEH for exception unwinding? Do you mean debug_frame or eh_frame?

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

labath added a comment. Thanks. IIUC, all the existing tests just cover the yaml2obj direction. Could you add something for the other direction too? Maybe add an exception stream to `test/tools/obj2yaml/basic-minidump.yaml`? Comment at: llvm/include/llvm/ObjectYAML/MinidumpYA

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

aleksandr.urakov added a comment. In D67347#1705563 , @mstorsjo wrote: > Quick question here; will unwinding using DWARF debug info still work like > before after this, for binaries that don't use SEH for exception unwinding? Hi Martin! Do I understand

[Lldb-commits] [PATCH] D68096: ProcessMinidump: Suppress reporting stop for signal '0'

labath added a comment. What lldb does not like the most is a stop info with a signal "0" -- that causes a resume. Having no stop info whatsoever seems to work just fine -- and this is already what happens when there is no exception record around. I was surprised by that distinction, but we alr

[Lldb-commits] [PATCH] D68853: uint32_t options -> File::OpenOptions options

labath added a comment. I originally thought you would do something local, but changing this across the board is definitely better, and it doesn't seem the patch is that big. LLVM already has a utility to work out the kinks in the bitmask enum use case. Please take a look at `llvm/ADT/BitmaskEn

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

mstorsjo added a comment. Quick question here; will unwinding using DWARF debug info still work like before after this, for binaries that don't use SEH for exception unwinding? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67347/new/ https://revie

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

This revision was automatically updated to reflect the committed changes. Closed by commit rG30c2441a3262: [Windows] Use information from the PE32 exceptions directory to construct… (authored by aleksandr.urakov). Changed prior to commit: https://reviews.llvm.org/D67347?vs=220144&id=224554#toc

[Lldb-commits] [lldb] r374528 - [Windows] Use information from the PE32 exceptions directory to construct unwind plans

Author: aleksandr.urakov Date: Fri Oct 11 02:03:29 2019 New Revision: 374528 URL: http://llvm.org/viewvc/llvm-project?rev=374528&view=rev Log: [Windows] Use information from the PE32 exceptions directory to construct unwind plans This patch adds an implementation of unwinding using PE EH info. I

[Lldb-commits] [PATCH] D68770: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG4778f40f782f: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

labath added inline comments. Comment at: lldb/include/lldb/Host/File.h:56 static bool DescriptorIsValid(int descriptor) { return descriptor >= 0; }; + static const char *GetStreamOpenModeFromOptions(uint32_t options); lawrence_danna wrote: > labath wrote:

[Lldb-commits] [lldb] r374526 - [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows

Author: mstorsjo Date: Fri Oct 11 01:44:51 2019 New Revision: 374526 URL: http://llvm.org/viewvc/llvm-project?rev=374526&view=rev Log: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows This avoids the currently MSVC specific codepath of using the wchar entry point an

[Lldb-commits] [lldb] r374525 - [lldb] Fix crash in CxxModuleHandler when std module is empty

Author: teemperor Date: Fri Oct 11 01:42:22 2019 New Revision: 374525 URL: http://llvm.org/viewvc/llvm-project?rev=374525&view=rev Log: [lldb] Fix crash in CxxModuleHandler when std module is empty We currently don't handle the error in the Expected we get when searching for an equal local DeclCo

[Lldb-commits] [PATCH] D68856: convert SBDebugger::***FileHandle() wrappers to native files.

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:827-835 +self.assertRaises(TypeError, self.debugger.SetOutputFile, None) +self.assertRaises(TypeError, self.debugger.SetOutputFile, "ham sandwi

  1   2   >