[Lldb-commits] [PATCH] D63380: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled

labath added a comment. This definitely aren't all of our watchpoint tests. What's the reason for picking this particular bunch? Are they the only ones enabled on NetBSD right now? Anyway, given that all of the watchpoint tests are already annotated with the "watchpoint" category, I think it w

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

labath added a comment. Although this is technically correct and pretty consistent with our other "plugins", I can't help but feel that it's incredibly wasteful. Each of the XXXSignals.cpp files is less than a 100 lines long (with the licence header and all bolierplate) and it's unlikely to eve

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm updated this revision to Diff 204979. aadsm added a comment. - Address missing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62503/new/ https://reviews.llvm.org/D62503 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm updated this revision to Diff 204977. aadsm added a comment. Herald added a subscriber: emaste. - Make ReadCStringFromMemory return llvm::Expected> - Add documentation - Address other comments - Created `static const size_t g_cache_line_size` to avoid calling llvm::sys::Process::getPageSize

[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

hintonda added inline comments. Comment at: lldb/trunk/unittests/tools/lldb-mi/utils/CMakeLists.txt:12 + +target_sources(LLDBMiUtilTests PRIVATE $) Just wanted to let you know that using `$` in anything other than `add_library` and `add_executable` wasn't added